net/qede/base: refactor some code bits
[dpdk.git] / drivers / net / qede / base / ecore_int.c
index c70e404..96f283b 100644 (file)
@@ -60,8 +60,6 @@ struct aeu_invert_reg_bit {
 #define ATTENTION_OFFSET_SHIFT         (12)
 
 #define        ATTENTION_CLEAR_ENABLE          (1 << 28)
-#define        ATTENTION_FW_DUMP               (1 << 29)
-#define        ATTENTION_PANIC_DUMP            (1 << 30)
        unsigned int flags;
 
        /* Callback to call if attention will be triggered */
@@ -74,8 +72,568 @@ struct aeu_invert_reg {
        struct aeu_invert_reg_bit bits[32];
 };
 
+#define MAX_ATTN_GRPS          (8)
 #define NUM_ATTN_REGS          (9)
 
+static enum _ecore_status_t ecore_mcp_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+       u32 tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, MCP_REG_CPU_STATE);
+
+       DP_INFO(p_hwfn->p_dev, "MCP_REG_CPU_STATE: %08x - Masking...\n", tmp);
+       ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, MCP_REG_CPU_EVENT_MASK, 0xffffffff);
+
+       return ECORE_SUCCESS;
+}
+
+#define ECORE_PSWHST_ATTENTION_DISABLED_PF_MASK                (0x3c000)
+#define ECORE_PSWHST_ATTENTION_DISABLED_PF_SHIFT       (14)
+#define ECORE_PSWHST_ATTENTION_DISABLED_VF_MASK                (0x03fc0)
+#define ECORE_PSWHST_ATTENTION_DISABLED_VF_SHIFT       (6)
+#define ECORE_PSWHST_ATTENTION_DISABLED_VALID_MASK     (0x00020)
+#define ECORE_PSWHST_ATTENTION_DISABLED_VALID_SHIFT    (5)
+#define ECORE_PSWHST_ATTENTION_DISABLED_CLIENT_MASK    (0x0001e)
+#define ECORE_PSWHST_ATTENTION_DISABLED_CLIENT_SHIFT   (1)
+#define ECORE_PSWHST_ATTENTION_DISABLED_WRITE_MASK     (0x1)
+#define ECORE_PSWHST_ATTNETION_DISABLED_WRITE_SHIFT    (0)
+#define ECORE_PSWHST_ATTENTION_VF_DISABLED             (0x1)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS                (0x1)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_WR_MASK                (0x1)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_WR_SHIFT       (0)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_CLIENT_MASK    (0x1e)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_CLIENT_SHIFT   (1)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_VALID_MASK  (0x20)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_VALID_SHIFT (5)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_ID_MASK     (0x3fc0)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_ID_SHIFT    (6)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_PF_ID_MASK     (0x3c000)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_PF_ID_SHIFT    (14)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_BYTE_EN_MASK   (0x3fc0000)
+#define ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_BYTE_EN_SHIFT  (18)
+static enum _ecore_status_t ecore_pswhst_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+       u32 tmp =
+           ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                    PSWHST_REG_VF_DISABLED_ERROR_VALID);
+
+       /* Disabled VF access */
+       if (tmp & ECORE_PSWHST_ATTENTION_VF_DISABLED) {
+               u32 addr, data;
+
+               addr = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                               PSWHST_REG_VF_DISABLED_ERROR_ADDRESS);
+               data = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                               PSWHST_REG_VF_DISABLED_ERROR_DATA);
+               DP_INFO(p_hwfn->p_dev,
+                       "PF[0x%02x] VF [0x%02x] [Valid 0x%02x] Client [0x%02x]"
+                       " Write [0x%02x] Addr [0x%08x]\n",
+                       (u8)((data & ECORE_PSWHST_ATTENTION_DISABLED_PF_MASK)
+                            >> ECORE_PSWHST_ATTENTION_DISABLED_PF_SHIFT),
+                       (u8)((data & ECORE_PSWHST_ATTENTION_DISABLED_VF_MASK)
+                            >> ECORE_PSWHST_ATTENTION_DISABLED_VF_SHIFT),
+                       (u8)((data &
+                             ECORE_PSWHST_ATTENTION_DISABLED_VALID_MASK) >>
+                             ECORE_PSWHST_ATTENTION_DISABLED_VALID_SHIFT),
+                       (u8)((data &
+                             ECORE_PSWHST_ATTENTION_DISABLED_CLIENT_MASK) >>
+                             ECORE_PSWHST_ATTENTION_DISABLED_CLIENT_SHIFT),
+                       (u8)((data &
+                             ECORE_PSWHST_ATTENTION_DISABLED_WRITE_MASK) >>
+                             ECORE_PSWHST_ATTNETION_DISABLED_WRITE_SHIFT),
+                       addr);
+       }
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PSWHST_REG_INCORRECT_ACCESS_VALID);
+       if (tmp & ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS) {
+               u32 addr, data, length;
+
+               addr = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                               PSWHST_REG_INCORRECT_ACCESS_ADDRESS);
+               data = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                               PSWHST_REG_INCORRECT_ACCESS_DATA);
+               length = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                 PSWHST_REG_INCORRECT_ACCESS_LENGTH);
+
+               DP_INFO(p_hwfn->p_dev,
+                       "Incorrect access to %08x of length %08x - PF [%02x]"
+                       " VF [%04x] [valid %02x] client [%02x] write [%02x]"
+                       " Byte-Enable [%04x] [%08x]\n",
+                       addr, length,
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_PF_ID_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_PF_ID_SHIFT),
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_ID_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_ID_SHIFT),
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_VALID_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_VF_VALID_SHIFT),
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_CLIENT_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_CLIENT_SHIFT),
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_WR_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_WR_SHIFT),
+                       (u8)((data &
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_BYTE_EN_MASK) >>
+                     ECORE_PSWHST_ATTENTION_INCORRECT_ACCESS_BYTE_EN_SHIFT),
+                       data);
+       }
+
+       /* TODO - We know 'some' of these are legal due to virtualization,
+        * but is it true for all of them?
+        */
+       return ECORE_SUCCESS;
+}
+
+#define ECORE_GRC_ATTENTION_VALID_BIT          (1 << 0)
+#define ECORE_GRC_ATTENTION_ADDRESS_MASK       (0x7fffff << 0)
+#define ECORE_GRC_ATTENTION_RDWR_BIT           (1 << 23)
+#define ECORE_GRC_ATTENTION_MASTER_MASK                (0xf << 24)
+#define ECORE_GRC_ATTENTION_MASTER_SHIFT       (24)
+#define ECORE_GRC_ATTENTION_PF_MASK            (0xf)
+#define ECORE_GRC_ATTENTION_VF_MASK            (0xff << 4)
+#define ECORE_GRC_ATTENTION_VF_SHIFT           (4)
+#define ECORE_GRC_ATTENTION_PRIV_MASK          (0x3 << 14)
+#define ECORE_GRC_ATTENTION_PRIV_SHIFT         (14)
+#define ECORE_GRC_ATTENTION_PRIV_VF            (0)
+static const char *grc_timeout_attn_master_to_str(u8 master)
+{
+       switch (master) {
+       case 1:
+               return "PXP";
+       case 2:
+               return "MCP";
+       case 3:
+               return "MSDM";
+       case 4:
+               return "PSDM";
+       case 5:
+               return "YSDM";
+       case 6:
+               return "USDM";
+       case 7:
+               return "TSDM";
+       case 8:
+               return "XSDM";
+       case 9:
+               return "DBU";
+       case 10:
+               return "DMAE";
+       default:
+               return "Unknown";
+       }
+}
+
+static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+       u32 tmp, tmp2;
+
+       /* We've already cleared the timeout interrupt register, so we learn
+        * of interrupts via the validity register
+        */
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      GRC_REG_TIMEOUT_ATTN_ACCESS_VALID);
+       if (!(tmp & ECORE_GRC_ATTENTION_VALID_BIT))
+               goto out;
+
+       /* Read the GRC timeout information */
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      GRC_REG_TIMEOUT_ATTN_ACCESS_DATA_0);
+       tmp2 = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                       GRC_REG_TIMEOUT_ATTN_ACCESS_DATA_1);
+
+       DP_INFO(p_hwfn->p_dev,
+               "GRC timeout [%08x:%08x] - %s Address [%08x] [Master %s]"
+               " [PF: %02x %s %02x]\n",
+               tmp2, tmp,
+               (tmp & ECORE_GRC_ATTENTION_RDWR_BIT) ? "Write to" : "Read from",
+               (tmp & ECORE_GRC_ATTENTION_ADDRESS_MASK) << 2,
+               grc_timeout_attn_master_to_str((tmp &
+                                       ECORE_GRC_ATTENTION_MASTER_MASK) >>
+                                      ECORE_GRC_ATTENTION_MASTER_SHIFT),
+               (tmp2 & ECORE_GRC_ATTENTION_PF_MASK),
+               (((tmp2 & ECORE_GRC_ATTENTION_PRIV_MASK) >>
+                 ECORE_GRC_ATTENTION_PRIV_SHIFT) ==
+                ECORE_GRC_ATTENTION_PRIV_VF) ? "VF" : "(Irrelevant:)",
+               (tmp2 & ECORE_GRC_ATTENTION_VF_MASK) >>
+               ECORE_GRC_ATTENTION_VF_SHIFT);
+
+out:
+       /* Regardles of anything else, clean the validity bit */
+       ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt,
+                GRC_REG_TIMEOUT_ATTN_ACCESS_VALID, 0);
+       return ECORE_SUCCESS;
+}
+
+#define ECORE_PGLUE_ATTENTION_VALID (1 << 29)
+#define ECORE_PGLUE_ATTENTION_RD_VALID (1 << 26)
+#define ECORE_PGLUE_ATTENTION_DETAILS_PFID_MASK (0xf << 20)
+#define ECORE_PGLUE_ATTENTION_DETAILS_PFID_SHIFT (20)
+#define ECORE_PGLUE_ATTENTION_DETAILS_VF_VALID (1 << 19)
+#define ECORE_PGLUE_ATTENTION_DETAILS_VFID_MASK (0xff << 24)
+#define ECORE_PGLUE_ATTENTION_DETAILS_VFID_SHIFT (24)
+#define ECORE_PGLUE_ATTENTION_DETAILS2_WAS_ERR (1 << 21)
+#define ECORE_PGLUE_ATTENTION_DETAILS2_BME     (1 << 22)
+#define ECORE_PGLUE_ATTENTION_DETAILS2_FID_EN (1 << 23)
+#define ECORE_PGLUE_ATTENTION_ICPL_VALID (1 << 23)
+#define ECORE_PGLUE_ATTENTION_ZLR_VALID (1 << 25)
+#define ECORE_PGLUE_ATTENTION_ILT_VALID (1 << 23)
+static enum _ecore_status_t ecore_pglub_rbc_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+       u32 tmp;
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PGLUE_B_REG_TX_ERR_WR_DETAILS2);
+       if (tmp & ECORE_PGLUE_ATTENTION_VALID) {
+               u32 addr_lo, addr_hi, details;
+
+               addr_lo = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_WR_ADD_31_0);
+               addr_hi = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_WR_ADD_63_32);
+               details = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_WR_DETAILS);
+
+               DP_INFO(p_hwfn,
+                       "Illegal write by chip to [%08x:%08x] blocked."
+                       "Details: %08x [PFID %02x, VFID %02x, VF_VALID %02x]"
+                       " Details2 %08x [Was_error %02x BME deassert %02x"
+                       " FID_enable deassert %02x]\n",
+                       addr_hi, addr_lo, details,
+                       (u8)((details &
+                             ECORE_PGLUE_ATTENTION_DETAILS_PFID_MASK) >>
+                            ECORE_PGLUE_ATTENTION_DETAILS_PFID_SHIFT),
+                       (u8)((details &
+                             ECORE_PGLUE_ATTENTION_DETAILS_VFID_MASK) >>
+                            ECORE_PGLUE_ATTENTION_DETAILS_VFID_SHIFT),
+                       (u8)((details & ECORE_PGLUE_ATTENTION_DETAILS_VF_VALID)
+                            ? 1 : 0), tmp,
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_WAS_ERR) ? 1
+                            : 0),
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_BME) ? 1 :
+                            0),
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_FID_EN) ? 1
+                            : 0));
+       }
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PGLUE_B_REG_TX_ERR_RD_DETAILS2);
+       if (tmp & ECORE_PGLUE_ATTENTION_RD_VALID) {
+               u32 addr_lo, addr_hi, details;
+
+               addr_lo = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_RD_ADD_31_0);
+               addr_hi = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_RD_ADD_63_32);
+               details = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_TX_ERR_RD_DETAILS);
+
+               DP_INFO(p_hwfn,
+                       "Illegal read by chip from [%08x:%08x] blocked."
+                       " Details: %08x [PFID %02x, VFID %02x, VF_VALID %02x]"
+                       " Details2 %08x [Was_error %02x BME deassert %02x"
+                       " FID_enable deassert %02x]\n",
+                       addr_hi, addr_lo, details,
+                       (u8)((details &
+                             ECORE_PGLUE_ATTENTION_DETAILS_PFID_MASK) >>
+                            ECORE_PGLUE_ATTENTION_DETAILS_PFID_SHIFT),
+                       (u8)((details &
+                             ECORE_PGLUE_ATTENTION_DETAILS_VFID_MASK) >>
+                            ECORE_PGLUE_ATTENTION_DETAILS_VFID_SHIFT),
+                       (u8)((details & ECORE_PGLUE_ATTENTION_DETAILS_VF_VALID)
+                            ? 1 : 0), tmp,
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_WAS_ERR) ? 1
+                            : 0),
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_BME) ? 1 :
+                            0),
+                       (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_FID_EN) ? 1
+                            : 0));
+       }
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PGLUE_B_REG_TX_ERR_WR_DETAILS_ICPL);
+       if (tmp & ECORE_PGLUE_ATTENTION_ICPL_VALID)
+               DP_INFO(p_hwfn, "ICPL error - %08x\n", tmp);
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PGLUE_B_REG_MASTER_ZLR_ERR_DETAILS);
+       if (tmp & ECORE_PGLUE_ATTENTION_ZLR_VALID) {
+               u32 addr_hi, addr_lo;
+
+               addr_lo = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_MASTER_ZLR_ERR_ADD_31_0);
+               addr_hi = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_MASTER_ZLR_ERR_ADD_63_32);
+
+               DP_INFO(p_hwfn, "ICPL error - %08x [Address %08x:%08x]\n",
+                       tmp, addr_hi, addr_lo);
+       }
+
+       tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                      PGLUE_B_REG_VF_ILT_ERR_DETAILS2);
+       if (tmp & ECORE_PGLUE_ATTENTION_ILT_VALID) {
+               u32 addr_hi, addr_lo, details;
+
+               addr_lo = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_VF_ILT_ERR_ADD_31_0);
+               addr_hi = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_VF_ILT_ERR_ADD_63_32);
+               details = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  PGLUE_B_REG_VF_ILT_ERR_DETAILS);
+
+               DP_INFO(p_hwfn,
+                       "ILT error - Details %08x Details2 %08x"
+                       " [Address %08x:%08x]\n",
+                       details, tmp, addr_hi, addr_lo);
+       }
+
+       /* Clear the indications */
+       ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt,
+                PGLUE_B_REG_LATCHED_ERRORS_CLR, (1 << 2));
+
+       return ECORE_SUCCESS;
+}
+
+static enum _ecore_status_t ecore_fw_assertion(struct ecore_hwfn *p_hwfn)
+{
+       DP_NOTICE(p_hwfn, false, "FW assertion!\n");
+
+       ecore_hw_err_notify(p_hwfn, ECORE_HW_ERR_FW_ASSERT);
+
+       return ECORE_INVAL;
+}
+
+static enum _ecore_status_t
+ecore_general_attention_35(struct ecore_hwfn *p_hwfn)
+{
+       DP_INFO(p_hwfn, "General attention 35!\n");
+
+       return ECORE_SUCCESS;
+}
+
+#define ECORE_DORQ_ATTENTION_REASON_MASK (0xfffff)
+#define ECORE_DORQ_ATTENTION_OPAQUE_MASK (0xffff)
+#define ECORE_DORQ_ATTENTION_SIZE_MASK  (0x7f)
+#define ECORE_DORQ_ATTENTION_SIZE_SHIFT         (16)
+
+static enum _ecore_status_t ecore_dorq_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+       u32 reason;
+
+       reason = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, DORQ_REG_DB_DROP_REASON) &
+           ECORE_DORQ_ATTENTION_REASON_MASK;
+       if (reason) {
+               u32 details = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                      DORQ_REG_DB_DROP_DETAILS);
+
+               DP_INFO(p_hwfn->p_dev,
+                       "DORQ db_drop: address 0x%08x Opaque FID 0x%04x"
+                       " Size [bytes] 0x%08x Reason: 0x%08x\n",
+                       ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                DORQ_REG_DB_DROP_DETAILS_ADDRESS),
+                       (u16)(details & ECORE_DORQ_ATTENTION_OPAQUE_MASK),
+                       ((details & ECORE_DORQ_ATTENTION_SIZE_MASK) >>
+                        ECORE_DORQ_ATTENTION_SIZE_SHIFT) * 4, reason);
+       }
+
+       return ECORE_INVAL;
+}
+
+static enum _ecore_status_t ecore_tm_attn_cb(struct ecore_hwfn *p_hwfn)
+{
+#ifndef ASIC_ONLY
+       if (CHIP_REV_IS_EMUL_B0(p_hwfn->p_dev)) {
+               u32 val = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                  TM_REG_INT_STS_1);
+
+               if (val & ~(TM_REG_INT_STS_1_PEND_TASK_SCAN |
+                           TM_REG_INT_STS_1_PEND_CONN_SCAN))
+                       return ECORE_INVAL;
+
+               if (val & (TM_REG_INT_STS_1_PEND_TASK_SCAN |
+                          TM_REG_INT_STS_1_PEND_CONN_SCAN))
+                       DP_INFO(p_hwfn,
+                               "TM attention on emulation - most likely"
+                               " results of clock-ratios\n");
+               val = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, TM_REG_INT_MASK_1);
+               val |= TM_REG_INT_MASK_1_PEND_CONN_SCAN |
+                   TM_REG_INT_MASK_1_PEND_TASK_SCAN;
+               ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, TM_REG_INT_MASK_1, val);
+
+               return ECORE_SUCCESS;
+       }
+#endif
+
+       return ECORE_INVAL;
+}
+
+/* Notice aeu_invert_reg must be defined in the same order of bits as HW;  */
+static struct aeu_invert_reg aeu_descs[NUM_ATTN_REGS] = {
+       {
+        {                      /* After Invert 1 */
+         {"GPIO0 function%d", (32 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          MAX_BLOCK_ID},
+         }
+        },
+
+       {
+        {                      /* After Invert 2 */
+         {"PGLUE config_space", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"PGLUE misc_flr", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"PGLUE B RBC", ATTENTION_PAR_INT, ecore_pglub_rbc_attn_cb,
+          BLOCK_PGLUE_B},
+         {"PGLUE misc_mctp", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"Flash event", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"SMB event", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"Main Power", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"SW timers #%d",
+          (8 << ATTENTION_LENGTH_SHIFT) | (1 << ATTENTION_OFFSET_SHIFT),
+          OSAL_NULL, MAX_BLOCK_ID},
+         {"PCIE glue/PXP VPD %d", (16 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          BLOCK_PGLCS},
+         }
+        },
+
+       {
+        {                      /* After Invert 3 */
+         {"General Attention %d", (32 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          MAX_BLOCK_ID},
+         }
+        },
+
+       {
+        {                      /* After Invert 4 */
+         {"General Attention 32", ATTENTION_SINGLE | ATTENTION_CLEAR_ENABLE,
+          ecore_fw_assertion, MAX_BLOCK_ID},
+         {"General Attention %d",
+          (2 << ATTENTION_LENGTH_SHIFT) | (33 << ATTENTION_OFFSET_SHIFT),
+          OSAL_NULL, MAX_BLOCK_ID},
+         {"General Attention 35", ATTENTION_SINGLE | ATTENTION_CLEAR_ENABLE,
+          ecore_general_attention_35, MAX_BLOCK_ID},
+         {"CNIG port %d", (4 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          BLOCK_CNIG},
+         {"MCP CPU", ATTENTION_SINGLE, ecore_mcp_attn_cb, MAX_BLOCK_ID},
+         {"MCP Watchdog timer", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"MCP M2P", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"AVS stop status ready", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"MSTAT", ATTENTION_PAR_INT, OSAL_NULL, MAX_BLOCK_ID},
+         {"MSTAT per-path", ATTENTION_PAR_INT, OSAL_NULL, MAX_BLOCK_ID},
+         {"Reserved %d", (6 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          MAX_BLOCK_ID},
+         {"NIG", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_NIG},
+         {"BMB/OPTE/MCP", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_BMB},
+         {"BTB", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_BTB},
+         {"BRB", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_BRB},
+         {"PRS", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PRS},
+         }
+        },
+
+       {
+        {                      /* After Invert 5 */
+         {"SRC", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_SRC},
+         {"PB Client1", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PBF_PB1},
+         {"PB Client2", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PBF_PB2},
+         {"RPB", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_RPB},
+         {"PBF", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PBF},
+         {"QM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_QM},
+         {"TM", ATTENTION_PAR_INT, ecore_tm_attn_cb, BLOCK_TM},
+         {"MCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MCM},
+         {"MSDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MSDM},
+         {"MSEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MSEM},
+         {"PCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PCM},
+         {"PSDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSDM},
+         {"PSEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSEM},
+         {"TCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TCM},
+         {"TSDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TSDM},
+         {"TSEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TSEM},
+         }
+        },
+
+       {
+        {                      /* After Invert 6 */
+         {"UCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_UCM},
+         {"USDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_USDM},
+         {"USEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_USEM},
+         {"XCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_XCM},
+         {"XSDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_XSDM},
+         {"XSEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_XSEM},
+         {"YCM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_YCM},
+         {"YSDM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_YSDM},
+         {"YSEM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_YSEM},
+         {"XYLD", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_XYLD},
+         {"TMLD", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TMLD},
+         {"MYLD", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MULD},
+         {"YULD", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_YULD},
+         {"DORQ", ATTENTION_PAR_INT, ecore_dorq_attn_cb, BLOCK_DORQ},
+         {"DBG", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_DBG},
+         {"IPC", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_IPC},
+         }
+        },
+
+       {
+        {                      /* After Invert 7 */
+         {"CCFC", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_CCFC},
+         {"CDU", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_CDU},
+         {"DMAE", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_DMAE},
+         {"IGU", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_IGU},
+         {"ATC", ATTENTION_PAR_INT, OSAL_NULL, MAX_BLOCK_ID},
+         {"CAU", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_CAU},
+         {"PTU", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PTU},
+         {"PRM", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PRM},
+         {"TCFC", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TCFC},
+         {"RDIF", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_RDIF},
+         {"TDIF", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_TDIF},
+         {"RSS", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_RSS},
+         {"MISC", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MISC},
+         {"MISCS", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_MISCS},
+         {"PCIE", ATTENTION_PAR, OSAL_NULL, BLOCK_PCIE},
+         {"Vaux PCI core", ATTENTION_SINGLE, OSAL_NULL, BLOCK_PGLCS},
+         {"PSWRQ", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWRQ},
+         }
+        },
+
+       {
+        {                      /* After Invert 8 */
+         {"PSWRQ (pci_clk)", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWRQ2},
+         {"PSWWR", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWWR},
+         {"PSWWR (pci_clk)", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWWR2},
+         {"PSWRD", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWRD},
+         {"PSWRD (pci_clk)", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWRD2},
+         {"PSWHST", ATTENTION_PAR_INT, ecore_pswhst_attn_cb, BLOCK_PSWHST},
+         {"PSWHST (pci_clk)", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_PSWHST2},
+         {"GRC", ATTENTION_PAR_INT, ecore_grc_attn_cb, BLOCK_GRC},
+         {"CPMU", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_CPMU},
+         {"NCSI", ATTENTION_PAR_INT, OSAL_NULL, BLOCK_NCSI},
+         {"MSEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"PSEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"TSEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"USEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"XSEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"YSEM PRAM", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"pxp_misc_mps", ATTENTION_PAR, OSAL_NULL, BLOCK_PGLCS},
+         {"PCIE glue/PXP Exp. ROM", ATTENTION_SINGLE, OSAL_NULL, BLOCK_PGLCS},
+         {"PERST_B assertion", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"PERST_B deassertion", ATTENTION_SINGLE, OSAL_NULL, MAX_BLOCK_ID},
+         {"Reserved %d", (2 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          MAX_BLOCK_ID},
+         }
+        },
+
+       {
+        {                      /* After Invert 9 */
+         {"MCP Latched memory", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"MCP Latched scratchpad cache", ATTENTION_SINGLE, OSAL_NULL,
+          MAX_BLOCK_ID},
+         {"MCP Latched ump_tx", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"MCP Latched scratchpad", ATTENTION_PAR, OSAL_NULL, MAX_BLOCK_ID},
+         {"Reserved %d", (28 << ATTENTION_LENGTH_SHIFT), OSAL_NULL,
+          MAX_BLOCK_ID},
+         }
+        },
+
+};
+
 #define ATTN_STATE_BITS                (0xfff)
 #define ATTN_BITS_MASKABLE     (0x3ff)
 struct ecore_sb_attn_info {
@@ -117,6 +675,356 @@ static u16 ecore_attn_update_idx(struct ecore_hwfn *p_hwfn,
        return rc;
 }
 
+/**
+ * @brief ecore_int_assertion - handles asserted attention bits
+ *
+ * @param p_hwfn
+ * @param asserted_bits newly asserted bits
+ * @return enum _ecore_status_t
+ */
+static enum _ecore_status_t ecore_int_assertion(struct ecore_hwfn *p_hwfn,
+                                               u16 asserted_bits)
+{
+       struct ecore_sb_attn_info *sb_attn_sw = p_hwfn->p_sb_attn;
+       u32 igu_mask;
+
+       /* Mask the source of the attention in the IGU */
+       igu_mask = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                           IGU_REG_ATTENTION_ENABLE);
+       DP_VERBOSE(p_hwfn, ECORE_MSG_INTR, "IGU mask: 0x%08x --> 0x%08x\n",
+                  igu_mask, igu_mask & ~(asserted_bits & ATTN_BITS_MASKABLE));
+       igu_mask &= ~(asserted_bits & ATTN_BITS_MASKABLE);
+       ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, IGU_REG_ATTENTION_ENABLE, igu_mask);
+
+       DP_VERBOSE(p_hwfn, ECORE_MSG_INTR,
+                  "inner known ATTN state: 0x%04x --> 0x%04x\n",
+                  sb_attn_sw->known_attn,
+                  sb_attn_sw->known_attn | asserted_bits);
+       sb_attn_sw->known_attn |= asserted_bits;
+
+       /* Handle MCP events */
+       if (asserted_bits & 0x100) {
+               ecore_mcp_handle_events(p_hwfn, p_hwfn->p_dpc_ptt);
+               /* Clean the MCP attention */
+               ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt,
+                        sb_attn_sw->mfw_attn_addr, 0);
+       }
+
+       /* FIXME - this will change once we'll have GOOD gtt definitions */
+       DIRECT_REG_WR(p_hwfn,
+                     (u8 OSAL_IOMEM *) p_hwfn->regview +
+                     GTT_BAR0_MAP_REG_IGU_CMD +
+                     ((IGU_CMD_ATTN_BIT_SET_UPPER -
+                       IGU_CMD_INT_ACK_BASE) << 3), (u32)asserted_bits);
+
+       DP_VERBOSE(p_hwfn, ECORE_MSG_INTR, "set cmd IGU: 0x%04x\n",
+                  asserted_bits);
+
+       return ECORE_SUCCESS;
+}
+
+static void ecore_int_attn_print(struct ecore_hwfn *p_hwfn,
+                                enum block_id id, enum dbg_attn_type type,
+                                bool b_clear)
+{
+       /* @DPDK */
+       DP_NOTICE(p_hwfn->p_dev, false, "[block_id %d type %d]\n", id, type);
+}
+
+/**
+ * @brief ecore_int_deassertion_aeu_bit - handles the effects of a single
+ * cause of the attention
+ *
+ * @param p_hwfn
+ * @param p_aeu - descriptor of an AEU bit which caused the attention
+ * @param aeu_en_reg - register offset of the AEU enable reg. which configured
+ *  this bit to this group.
+ * @param bit_index - index of this bit in the aeu_en_reg
+ *
+ * @return enum _ecore_status_t
+ */
+static enum _ecore_status_t
+ecore_int_deassertion_aeu_bit(struct ecore_hwfn *p_hwfn,
+                             struct aeu_invert_reg_bit *p_aeu,
+                             u32 aeu_en_reg,
+                             const char *p_bit_name,
+                             u32 bitmask)
+{
+       enum _ecore_status_t rc = ECORE_INVAL;
+       bool b_fatal = false;
+
+       DP_INFO(p_hwfn, "Deasserted attention `%s'[%08x]\n",
+               p_bit_name, bitmask);
+
+       /* Call callback before clearing the interrupt status */
+       if (p_aeu->cb) {
+               DP_INFO(p_hwfn, "`%s (attention)': Calling Callback function\n",
+                       p_bit_name);
+               rc = p_aeu->cb(p_hwfn);
+       }
+
+       if (rc != ECORE_SUCCESS)
+               b_fatal = true;
+
+       /* Print HW block interrupt registers */
+       if (p_aeu->block_index != MAX_BLOCK_ID) {
+               ecore_int_attn_print(p_hwfn, p_aeu->block_index,
+                                    ATTN_TYPE_INTERRUPT, !b_fatal);
+}
+
+       /* Reach assertion if attention is fatal */
+       if (b_fatal) {
+               DP_NOTICE(p_hwfn, true, "`%s': Fatal attention\n",
+                         p_bit_name);
+
+               ecore_hw_err_notify(p_hwfn, ECORE_HW_ERR_HW_ATTN);
+       }
+
+       /* Prevent this Attention from being asserted in the future */
+       if (p_aeu->flags & ATTENTION_CLEAR_ENABLE ||
+           p_hwfn->p_dev->attn_clr_en) {
+               u32 val;
+               u32 mask = ~bitmask;
+               val = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, aeu_en_reg);
+               ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, aeu_en_reg, (val & mask));
+               DP_INFO(p_hwfn, "`%s' - Disabled future attentions\n",
+                       p_bit_name);
+       }
+
+       return rc;
+}
+
+/**
+ * @brief ecore_int_deassertion_parity - handle a single parity AEU source
+ *
+ * @param p_hwfn
+ * @param p_aeu - descriptor of an AEU bit which caused the
+ *              parity
+ * @param bit_index
+ */
+static void ecore_int_deassertion_parity(struct ecore_hwfn *p_hwfn,
+                                        struct aeu_invert_reg_bit *p_aeu,
+                                        u8 bit_index)
+{
+       u32 block_id = p_aeu->block_index;
+
+       DP_INFO(p_hwfn->p_dev, "%s[%d] parity attention is set\n",
+               p_aeu->bit_name, bit_index);
+
+       if (block_id == MAX_BLOCK_ID)
+               return;
+
+       ecore_int_attn_print(p_hwfn, block_id,
+                            ATTN_TYPE_PARITY, false);
+
+       /* In A0, there's a single parity bit for several blocks */
+       if (block_id == BLOCK_BTB) {
+               ecore_int_attn_print(p_hwfn, BLOCK_OPTE,
+                                    ATTN_TYPE_PARITY, false);
+               ecore_int_attn_print(p_hwfn, BLOCK_MCP,
+                                    ATTN_TYPE_PARITY, false);
+       }
+}
+
+/**
+ * @brief - handles deassertion of previously asserted attentions.
+ *
+ * @param p_hwfn
+ * @param deasserted_bits - newly deasserted bits
+ * @return enum _ecore_status_t
+ *
+ */
+static enum _ecore_status_t ecore_int_deassertion(struct ecore_hwfn *p_hwfn,
+                                                 u16 deasserted_bits)
+{
+       struct ecore_sb_attn_info *sb_attn_sw = p_hwfn->p_sb_attn;
+       u32 aeu_inv_arr[NUM_ATTN_REGS], aeu_mask;
+       bool b_parity = false;
+       u8 i, j, k, bit_idx;
+       enum _ecore_status_t rc = ECORE_SUCCESS;
+
+       /* Read the attention registers in the AEU */
+       for (i = 0; i < NUM_ATTN_REGS; i++) {
+               aeu_inv_arr[i] = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                         MISC_REG_AEU_AFTER_INVERT_1_IGU +
+                                         i * 0x4);
+               DP_VERBOSE(p_hwfn, ECORE_MSG_INTR,
+                          "Deasserted bits [%d]: %08x\n", i, aeu_inv_arr[i]);
+       }
+
+       /* Handle parity attentions first */
+       for (i = 0; i < NUM_ATTN_REGS; i++) {
+               struct aeu_invert_reg *p_aeu = &sb_attn_sw->p_aeu_desc[i];
+               u32 en = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                                 MISC_REG_AEU_ENABLE1_IGU_OUT_0 +
+                                 i * sizeof(u32));
+
+               u32 parities = sb_attn_sw->parity_mask[i] & aeu_inv_arr[i] & en;
+
+               /* Skip register in which no parity bit is currently set */
+               if (!parities)
+                       continue;
+
+               for (j = 0, bit_idx = 0; bit_idx < 32; j++) {
+                       struct aeu_invert_reg_bit *p_bit = &p_aeu->bits[j];
+
+                       if ((p_bit->flags & ATTENTION_PARITY) &&
+                           !!(parities & (1 << bit_idx))) {
+                               ecore_int_deassertion_parity(p_hwfn, p_bit,
+                                                            bit_idx);
+                               b_parity = true;
+                       }
+
+                       bit_idx += ATTENTION_LENGTH(p_bit->flags);
+               }
+       }
+
+       /* Find non-parity cause for attention and act */
+       for (k = 0; k < MAX_ATTN_GRPS; k++) {
+               struct aeu_invert_reg_bit *p_aeu;
+
+               /* Handle only groups whose attention is currently deasserted */
+               if (!(deasserted_bits & (1 << k)))
+                       continue;
+
+               for (i = 0; i < NUM_ATTN_REGS; i++) {
+                       u32 aeu_en = MISC_REG_AEU_ENABLE1_IGU_OUT_0 +
+                           i * sizeof(u32) + k * sizeof(u32) * NUM_ATTN_REGS;
+                       u32 en = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, aeu_en);
+                       u32 bits = aeu_inv_arr[i] & en;
+
+                       /* Skip if no bit from this group is currently set */
+                       if (!bits)
+                               continue;
+
+                       /* Find all set bits from current register which belong
+                        * to current group, making them responsible for the
+                        * previous assertion.
+                        */
+                       for (j = 0, bit_idx = 0; bit_idx < 32; j++) {
+                               unsigned long int bitmask;
+                               u8 bit, bit_len;
+
+                               p_aeu = &sb_attn_sw->p_aeu_desc[i].bits[j];
+
+                               /* No need to handle attention-only bits */
+                               if (p_aeu->flags == ATTENTION_PAR)
+                                       continue;
+
+                               bit = bit_idx;
+                               bit_len = ATTENTION_LENGTH(p_aeu->flags);
+                               if (p_aeu->flags & ATTENTION_PAR_INT) {
+                                       /* Skip Parity */
+                                       bit++;
+                                       bit_len--;
+                               }
+
+                               bitmask = bits & (((1 << bit_len) - 1) << bit);
+                               if (bitmask) {
+                                       u32 flags = p_aeu->flags;
+                                       char bit_name[30];
+
+                                       bit = (u8)OSAL_FIND_FIRST_BIT(&bitmask,
+                                                               bit_len);
+
+                                       /* Some bits represent more than a
+                                        * a single interrupt. Correctly print
+                                        * their name.
+                                        */
+                                       if (ATTENTION_LENGTH(flags) > 2 ||
+                                           ((flags & ATTENTION_PAR_INT) &&
+                                           ATTENTION_LENGTH(flags) > 1))
+                                               OSAL_SNPRINTF(bit_name, 30,
+                                                             p_aeu->bit_name,
+                                                             bit);
+                                       else
+                                               OSAL_STRNCPY(bit_name,
+                                                            p_aeu->bit_name,
+                                                            30);
+                                       /* Handle source of the attention */
+                                       ecore_int_deassertion_aeu_bit(p_hwfn,
+                                                                     p_aeu,
+                                                                     aeu_en,
+                                                                     bit_name,
+                                                                     bitmask);
+                               }
+
+                               bit_idx += ATTENTION_LENGTH(p_aeu->flags);
+                       }
+               }
+       }
+
+       /* Clear IGU indication for the deasserted bits */
+       /* FIXME - this will change once we'll have GOOD gtt definitions */
+       DIRECT_REG_WR(p_hwfn,
+                     (u8 OSAL_IOMEM *) p_hwfn->regview +
+                     GTT_BAR0_MAP_REG_IGU_CMD +
+                     ((IGU_CMD_ATTN_BIT_CLR_UPPER -
+                       IGU_CMD_INT_ACK_BASE) << 3), ~((u32)deasserted_bits));
+
+       /* Unmask deasserted attentions in IGU */
+       aeu_mask = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt,
+                           IGU_REG_ATTENTION_ENABLE);
+       aeu_mask |= (deasserted_bits & ATTN_BITS_MASKABLE);
+       ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, IGU_REG_ATTENTION_ENABLE, aeu_mask);
+
+       /* Clear deassertion from inner state */
+       sb_attn_sw->known_attn &= ~deasserted_bits;
+
+       return rc;
+}
+
+static enum _ecore_status_t ecore_int_attentions(struct ecore_hwfn *p_hwfn)
+{
+       struct ecore_sb_attn_info *p_sb_attn_sw = p_hwfn->p_sb_attn;
+       struct atten_status_block *p_sb_attn = p_sb_attn_sw->sb_attn;
+       u16 index = 0, asserted_bits, deasserted_bits;
+       u32 attn_bits = 0, attn_acks = 0;
+       enum _ecore_status_t rc = ECORE_SUCCESS;
+
+       /* Read current attention bits/acks - safeguard against attentions
+        * by guaranting work on a synchronized timeframe
+        */
+       do {
+               index = OSAL_LE16_TO_CPU(p_sb_attn->sb_index);
+               attn_bits = OSAL_LE32_TO_CPU(p_sb_attn->atten_bits);
+               attn_acks = OSAL_LE32_TO_CPU(p_sb_attn->atten_ack);
+       } while (index != OSAL_LE16_TO_CPU(p_sb_attn->sb_index));
+       p_sb_attn->sb_index = index;
+
+       /* Attention / Deassertion are meaningful (and in correct state)
+        * only when they differ and consistent with known state - deassertion
+        * when previous attention & current ack, and assertion when current
+        * attention with no previous attention
+        */
+       asserted_bits = (attn_bits & ~attn_acks & ATTN_STATE_BITS) &
+           ~p_sb_attn_sw->known_attn;
+       deasserted_bits = (~attn_bits & attn_acks & ATTN_STATE_BITS) &
+           p_sb_attn_sw->known_attn;
+
+       if ((asserted_bits & ~0x100) || (deasserted_bits & ~0x100))
+               DP_INFO(p_hwfn,
+                       "Attention: Index: 0x%04x, Bits: 0x%08x, Acks: 0x%08x, asserted: 0x%04x, De-asserted 0x%04x [Prev. known: 0x%04x]\n",
+                       index, attn_bits, attn_acks, asserted_bits,
+                       deasserted_bits, p_sb_attn_sw->known_attn);
+       else if (asserted_bits == 0x100)
+               DP_INFO(p_hwfn, "MFW indication via attention\n");
+       else
+               DP_VERBOSE(p_hwfn, ECORE_MSG_INTR,
+                          "MFW indication [deassertion]\n");
+
+       if (asserted_bits) {
+               rc = ecore_int_assertion(p_hwfn, asserted_bits);
+               if (rc)
+                       return rc;
+       }
+
+       if (deasserted_bits)
+               rc = ecore_int_deassertion(p_hwfn, deasserted_bits);
+
+       return rc;
+}
+
 static void ecore_sb_ack_attn(struct ecore_hwfn *p_hwfn,
                              void OSAL_IOMEM *igu_addr, u32 ack_cons)
 {
@@ -144,13 +1052,11 @@ void ecore_int_sp_dpc(osal_int_ptr_t hwfn_cookie)
        struct ecore_pi_info *pi_info = OSAL_NULL;
        struct ecore_sb_attn_info *sb_attn;
        struct ecore_sb_info *sb_info;
-       static int arr_size;
+       int arr_size;
        u16 rc = 0;
 
-       if (!p_hwfn) {
-               DP_ERR(p_hwfn->p_dev, "DPC called - no hwfn!\n");
+       if (!p_hwfn)
                return;
-       }
 
        if (!p_hwfn->p_sp_sb) {
                DP_ERR(p_hwfn->p_dev, "DPC called - no p_sp_sb\n");
@@ -211,13 +1117,17 @@ void ecore_int_sp_dpc(osal_int_ptr_t hwfn_cookie)
                return;
        }
 
-       /* Check the validity of the DPC ptt. If not ack interrupts and fail */
+/* Check the validity of the DPC ptt. If not ack interrupts and fail */
+
        if (!p_hwfn->p_dpc_ptt) {
                DP_NOTICE(p_hwfn->p_dev, true, "Failed to allocate PTT\n");
                ecore_sb_ack(sb_info, IGU_INT_ENABLE, 1);
                return;
        }
 
+       if (rc & ECORE_SB_ATT_IDX)
+               ecore_int_attentions(p_hwfn);
+
        if (rc & ECORE_SB_IDX) {
                int pi;
 
@@ -258,18 +1168,96 @@ static void ecore_int_sb_attn_free(struct ecore_hwfn *p_hwfn)
        OSAL_FREE(p_hwfn->p_dev, p_sb);
 }
 
+static void ecore_int_sb_attn_setup(struct ecore_hwfn *p_hwfn,
+                                   struct ecore_ptt *p_ptt)
+{
+       struct ecore_sb_attn_info *sb_info = p_hwfn->p_sb_attn;
+
+       OSAL_MEMSET(sb_info->sb_attn, 0, sizeof(*sb_info->sb_attn));
+
+       sb_info->index = 0;
+       sb_info->known_attn = 0;
+
+       /* Configure Attention Status Block in IGU */
+       ecore_wr(p_hwfn, p_ptt, IGU_REG_ATTN_MSG_ADDR_L,
+                DMA_LO(p_hwfn->p_sb_attn->sb_phys));
+       ecore_wr(p_hwfn, p_ptt, IGU_REG_ATTN_MSG_ADDR_H,
+                DMA_HI(p_hwfn->p_sb_attn->sb_phys));
+}
+
+static void ecore_int_sb_attn_init(struct ecore_hwfn *p_hwfn,
+                                  struct ecore_ptt *p_ptt,
+                                  void *sb_virt_addr, dma_addr_t sb_phy_addr)
+{
+       struct ecore_sb_attn_info *sb_info = p_hwfn->p_sb_attn;
+       int i, j, k;
+
+       sb_info->sb_attn = sb_virt_addr;
+       sb_info->sb_phys = sb_phy_addr;
+
+       /* Set the pointer to the AEU descriptors */
+       sb_info->p_aeu_desc = aeu_descs;
+
+       /* Calculate Parity Masks */
+       OSAL_MEMSET(sb_info->parity_mask, 0, sizeof(u32) * NUM_ATTN_REGS);
+       for (i = 0; i < NUM_ATTN_REGS; i++) {
+               /* j is array index, k is bit index */
+               for (j = 0, k = 0; k < 32; j++) {
+                       unsigned int flags = aeu_descs[i].bits[j].flags;
+
+                       if (flags & ATTENTION_PARITY)
+                               sb_info->parity_mask[i] |= 1 << k;
+
+                       k += ATTENTION_LENGTH(flags);
+               }
+               DP_VERBOSE(p_hwfn, ECORE_MSG_INTR,
+                          "Attn Mask [Reg %d]: 0x%08x\n",
+                          i, sb_info->parity_mask[i]);
+       }
+
+       /* Set the address of cleanup for the mcp attention */
+       sb_info->mfw_attn_addr = (p_hwfn->rel_pf_id << 3) +
+           MISC_REG_AEU_GENERAL_ATTN_0;
+
+       ecore_int_sb_attn_setup(p_hwfn, p_ptt);
+}
+
+static enum _ecore_status_t ecore_int_sb_attn_alloc(struct ecore_hwfn *p_hwfn,
+                                                   struct ecore_ptt *p_ptt)
+{
+       struct ecore_dev *p_dev = p_hwfn->p_dev;
+       struct ecore_sb_attn_info *p_sb;
+       dma_addr_t p_phys = 0;
+       void *p_virt;
+
+       /* SB struct */
+       p_sb = OSAL_ALLOC(p_dev, GFP_KERNEL, sizeof(*p_sb));
+       if (!p_sb) {
+               DP_NOTICE(p_dev, true,
+                         "Failed to allocate `struct ecore_sb_attn_info'\n");
+               return ECORE_NOMEM;
+       }
+
+       /* SB ring  */
+       p_virt = OSAL_DMA_ALLOC_COHERENT(p_dev, &p_phys,
+                                        SB_ATTN_ALIGNED_SIZE(p_hwfn));
+       if (!p_virt) {
+               DP_NOTICE(p_dev, true,
+                         "Failed to allocate status block (attentions)\n");
+               OSAL_FREE(p_dev, p_sb);
+               return ECORE_NOMEM;
+       }
+
+       /* Attention setup */
+       p_hwfn->p_sb_attn = p_sb;
+       ecore_int_sb_attn_init(p_hwfn, p_ptt, p_virt, p_phys);
+
+       return ECORE_SUCCESS;
+}
+
 /* coalescing timeout = timeset << (timer_res + 1) */
-#ifdef RTE_LIBRTE_QEDE_RX_COAL_US
-#define ECORE_CAU_DEF_RX_USECS RTE_LIBRTE_QEDE_RX_COAL_US
-#else
 #define ECORE_CAU_DEF_RX_USECS 24
-#endif
-
-#ifdef RTE_LIBRTE_QEDE_TX_COAL_US
-#define ECORE_CAU_DEF_TX_USECS RTE_LIBRTE_QEDE_TX_COAL_US
-#else
 #define ECORE_CAU_DEF_TX_USECS 48
-#endif
 
 void ecore_init_cau_sb_entry(struct ecore_hwfn *p_hwfn,
                             struct cau_sb_entry *p_sb_entry,
@@ -277,6 +1265,7 @@ void ecore_init_cau_sb_entry(struct ecore_hwfn *p_hwfn,
 {
        struct ecore_dev *p_dev = p_hwfn->p_dev;
        u32 cau_state;
+       u8 timer_res;
 
        OSAL_MEMSET(p_sb_entry, 0, sizeof(*p_sb_entry));
 
@@ -286,28 +1275,33 @@ void ecore_init_cau_sb_entry(struct ecore_hwfn *p_hwfn,
        SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_SB_TIMESET0, 0x7F);
        SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_SB_TIMESET1, 0x7F);
 
-       /* setting the time resultion to a fixed value ( = 1) */
-       SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_TIMER_RES0,
-                 ECORE_CAU_DEF_RX_TIMER_RES);
-       SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_TIMER_RES1,
-                 ECORE_CAU_DEF_TX_TIMER_RES);
-
        cau_state = CAU_HC_DISABLE_STATE;
 
        if (p_dev->int_coalescing_mode == ECORE_COAL_MODE_ENABLE) {
                cau_state = CAU_HC_ENABLE_STATE;
-               if (!p_dev->rx_coalesce_usecs) {
+               if (!p_dev->rx_coalesce_usecs)
                        p_dev->rx_coalesce_usecs = ECORE_CAU_DEF_RX_USECS;
-                       DP_INFO(p_dev, "Coalesce params rx-usecs=%u\n",
-                               p_dev->rx_coalesce_usecs);
-               }
-               if (!p_dev->tx_coalesce_usecs) {
+               if (!p_dev->tx_coalesce_usecs)
                        p_dev->tx_coalesce_usecs = ECORE_CAU_DEF_TX_USECS;
-                       DP_INFO(p_dev, "Coalesce params tx-usecs=%u\n",
-                               p_dev->tx_coalesce_usecs);
-               }
        }
 
+       /* Coalesce = (timeset << timer-res), timeset is 7bit wide */
+       if (p_dev->rx_coalesce_usecs <= 0x7F)
+               timer_res = 0;
+       else if (p_dev->rx_coalesce_usecs <= 0xFF)
+               timer_res = 1;
+       else
+               timer_res = 2;
+       SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_TIMER_RES0, timer_res);
+
+       if (p_dev->tx_coalesce_usecs <= 0x7F)
+               timer_res = 0;
+       else if (p_dev->tx_coalesce_usecs <= 0xFF)
+               timer_res = 1;
+       else
+               timer_res = 2;
+       SET_FIELD(p_sb_entry->params, CAU_SB_ENTRY_TIMER_RES1, timer_res);
+
        SET_FIELD(p_sb_entry->data, CAU_SB_ENTRY_STATE0, cau_state);
        SET_FIELD(p_sb_entry->data, CAU_SB_ENTRY_STATE1, cau_state);
 }
@@ -347,17 +1341,32 @@ void ecore_int_cau_conf_sb(struct ecore_hwfn *p_hwfn,
 
        /* Configure pi coalescing if set */
        if (p_hwfn->p_dev->int_coalescing_mode == ECORE_COAL_MODE_ENABLE) {
-               u8 num_tc = 1;  /* @@@TBD aelior ECORE_MULTI_COS */
-               u8 timeset = p_hwfn->p_dev->rx_coalesce_usecs >>
-                   (ECORE_CAU_DEF_RX_TIMER_RES + 1);
+               /* eth will open queues for all tcs, so configure all of them
+                * properly, rather than just the active ones
+                */
+               u8 num_tc = p_hwfn->hw_info.num_hw_tc;
+
+               u8 timeset, timer_res;
                u8 i;
 
+               /* timeset = (coalesce >> timer-res), timeset is 7bit wide */
+               if (p_hwfn->p_dev->rx_coalesce_usecs <= 0x7F)
+                       timer_res = 0;
+               else if (p_hwfn->p_dev->rx_coalesce_usecs <= 0xFF)
+                       timer_res = 1;
+               else
+                       timer_res = 2;
+               timeset = (u8)(p_hwfn->p_dev->rx_coalesce_usecs >> timer_res);
                ecore_int_cau_conf_pi(p_hwfn, p_ptt, igu_sb_id, RX_PI,
                                      ECORE_COAL_RX_STATE_MACHINE, timeset);
 
-               timeset = p_hwfn->p_dev->tx_coalesce_usecs >>
-                   (ECORE_CAU_DEF_TX_TIMER_RES + 1);
-
+               if (p_hwfn->p_dev->tx_coalesce_usecs <= 0x7F)
+                       timer_res = 0;
+               else if (p_hwfn->p_dev->tx_coalesce_usecs <= 0xFF)
+                       timer_res = 1;
+               else
+                       timer_res = 2;
+               timeset = (u8)(p_hwfn->p_dev->tx_coalesce_usecs >> timer_res);
                for (i = 0; i < num_tc; i++) {
                        ecore_int_cau_conf_pi(p_hwfn, p_ptt,
                                              igu_sb_id, TX_PI(i),
@@ -531,10 +1540,10 @@ static enum _ecore_status_t ecore_int_sp_sb_alloc(struct ecore_hwfn *p_hwfn,
        /* SB struct */
        p_sb =
            OSAL_ALLOC(p_hwfn->p_dev, GFP_KERNEL,
-                      sizeof(struct ecore_sb_sp_info));
+                      sizeof(*p_sb));
        if (!p_sb) {
                DP_NOTICE(p_hwfn, true,
-                         "Failed to allocate `struct ecore_sb_info'");
+                         "Failed to allocate `struct ecore_sb_info'\n");
                return ECORE_NOMEM;
        }
 
@@ -542,7 +1551,7 @@ static enum _ecore_status_t ecore_int_sp_sb_alloc(struct ecore_hwfn *p_hwfn,
        p_virt = OSAL_DMA_ALLOC_COHERENT(p_hwfn->p_dev,
                                         &p_phys, SB_ALIGNED_SIZE(p_hwfn));
        if (!p_virt) {
-               DP_NOTICE(p_hwfn, true, "Failed to allocate status block");
+               DP_NOTICE(p_hwfn, true, "Failed to allocate status block\n");
                OSAL_FREE(p_hwfn->p_dev, p_sb);
                return ECORE_NOMEM;
        }
@@ -603,14 +1612,14 @@ void ecore_int_igu_enable_int(struct ecore_hwfn *p_hwfn,
                              struct ecore_ptt *p_ptt,
                              enum ecore_int_mode int_mode)
 {
-       u32 igu_pf_conf = IGU_PF_CONF_FUNC_EN;
+       u32 igu_pf_conf = IGU_PF_CONF_FUNC_EN | IGU_PF_CONF_ATTN_BIT_EN;
 
 #ifndef ASIC_ONLY
-       if (CHIP_REV_IS_FPGA(p_hwfn->p_dev))
+       if (CHIP_REV_IS_FPGA(p_hwfn->p_dev)) {
                DP_INFO(p_hwfn, "FPGA - don't enable ATTN generation in IGU\n");
-       else
+               igu_pf_conf &= ~IGU_PF_CONF_ATTN_BIT_EN;
+       }
 #endif
-               igu_pf_conf |= IGU_PF_CONF_ATTN_BIT_EN;
 
        p_hwfn->p_dev->int_mode = int_mode;
        switch (p_hwfn->p_dev->int_mode) {
@@ -651,6 +1660,7 @@ static void ecore_int_igu_enable_attn(struct ecore_hwfn *p_hwfn,
        ecore_wr(p_hwfn, p_ptt, IGU_REG_TRAILING_EDGE_LATCH, 0xfff);
        ecore_wr(p_hwfn, p_ptt, IGU_REG_ATTENTION_ENABLE, 0xfff);
 
+       /* Flush the writes to IGU */
        OSAL_MMIOWB(p_hwfn->p_dev);
 
        /* Unmask AEU signals toward IGU */
@@ -659,16 +1669,10 @@ static void ecore_int_igu_enable_attn(struct ecore_hwfn *p_hwfn,
 
 enum _ecore_status_t
 ecore_int_igu_enable(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt,
-                    enum ecore_int_mode int_mode)
+                         enum ecore_int_mode int_mode)
 {
        enum _ecore_status_t rc = ECORE_SUCCESS;
-       u32 tmp, reg_addr;
-
-       /* @@@tmp - Mask General HW attentions 0-31, Enable 32-36 */
-       tmp = ecore_rd(p_hwfn, p_ptt, MISC_REG_AEU_ENABLE4_IGU_OUT_0);
-       tmp |= 0xf;
-       ecore_wr(p_hwfn, p_ptt, MISC_REG_AEU_ENABLE3_IGU_OUT_0, 0);
-       ecore_wr(p_hwfn, p_ptt, MISC_REG_AEU_ENABLE4_IGU_OUT_0, tmp);
+       u32 tmp;
 
        /* @@@tmp - Starting with MFW 8.2.1.0 we've started hitting AVS stop
         * attentions. Since we're waiting for BRCM answer regarding this
@@ -710,7 +1714,7 @@ void ecore_int_igu_disable_int(struct ecore_hwfn *p_hwfn,
 }
 
 #define IGU_CLEANUP_SLEEP_LENGTH               (1000)
-void ecore_int_igu_cleanup_sb(struct ecore_hwfn *p_hwfn,
+static void ecore_int_igu_cleanup_sb(struct ecore_hwfn *p_hwfn,
                              struct ecore_ptt *p_ptt,
                              u32 sb_id, bool cleanup_set, u16 opaque_fid)
 {
@@ -742,6 +1746,7 @@ void ecore_int_igu_cleanup_sb(struct ecore_hwfn *p_hwfn,
 
        ecore_wr(p_hwfn, p_ptt, IGU_REG_COMMAND_REG_CTRL, cmd_ctrl);
 
+       /* Flush the write to IGU */
        OSAL_MMIOWB(p_hwfn->p_dev);
 
        /* calculate where to read the status bit from */
@@ -768,7 +1773,7 @@ void ecore_int_igu_init_pure_rt_single(struct ecore_hwfn *p_hwfn,
                                       struct ecore_ptt *p_ptt,
                                       u32 sb_id, u16 opaque, bool b_set)
 {
-       int pi;
+       int pi, i;
 
        /* Set */
        if (b_set)
@@ -777,6 +1782,23 @@ void ecore_int_igu_init_pure_rt_single(struct ecore_hwfn *p_hwfn,
        /* Clear */
        ecore_int_igu_cleanup_sb(p_hwfn, p_ptt, sb_id, 0, opaque);
 
+       /* Wait for the IGU SB to cleanup */
+       for (i = 0; i < IGU_CLEANUP_SLEEP_LENGTH; i++) {
+               u32 val;
+
+               val = ecore_rd(p_hwfn, p_ptt,
+                              IGU_REG_WRITE_DONE_PENDING +
+                              ((sb_id / 32) * 4));
+               if (val & (1 << (sb_id % 32)))
+                       OSAL_UDELAY(10);
+               else
+                       break;
+       }
+       if (i == IGU_CLEANUP_SLEEP_LENGTH)
+               DP_NOTICE(p_hwfn, true,
+                         "Failed SB[0x%08x] still appearing in WRITE_DONE_PENDING\n",
+                         sb_id);
+
        /* Clear the CAU for the SB */
        for (pi = 0; pi < 12; pi++)
                ecore_wr(p_hwfn, p_ptt,
@@ -852,8 +1874,8 @@ enum _ecore_status_t ecore_int_igu_read_cam(struct ecore_hwfn *p_hwfn,
 {
        struct ecore_igu_info *p_igu_info;
        struct ecore_igu_block *p_block;
+       u32 min_vf = 0, max_vf = 0, val;
        u16 sb_id, last_iov_sb_id = 0;
-       u32 min_vf, max_vf, val;
        u16 prev_sb_id = 0xFF;
 
        p_hwfn->hw_info.p_igu_info = OSAL_ALLOC(p_hwfn->p_dev,
@@ -872,16 +1894,14 @@ enum _ecore_status_t ecore_int_igu_read_cam(struct ecore_hwfn *p_hwfn,
        p_igu_info->igu_dsb_id = 0xffff;
        p_igu_info->igu_base_sb_iov = 0xffff;
 
-#ifdef CONFIG_ECORE_SRIOV
-       min_vf = p_hwfn->hw_info.first_vf_in_pf;
-       max_vf = p_hwfn->hw_info.first_vf_in_pf +
-           p_hwfn->p_dev->sriov_info.total_vfs;
-#else
-       min_vf = 0;
-       max_vf = 0;
-#endif
+       if (p_hwfn->p_dev->p_iov_info) {
+               struct ecore_hw_sriov_info *p_iov = p_hwfn->p_dev->p_iov_info;
 
-       for (sb_id = 0; sb_id < ECORE_MAPPING_MEMORY_SIZE(p_hwfn->p_dev);
+               min_vf = p_iov->first_vf_in_pf;
+               max_vf = p_iov->first_vf_in_pf + p_iov->total_vfs;
+       }
+       for (sb_id = 0;
+            sb_id < ECORE_MAPPING_MEMORY_SIZE(p_hwfn->p_dev);
             sb_id++) {
                p_block = &p_igu_info->igu_map.igu_blocks[sb_id];
                val = ecore_int_igu_read_cam_block(p_hwfn, p_ptt, sb_id);
@@ -1035,6 +2055,10 @@ enum _ecore_status_t ecore_int_alloc(struct ecore_hwfn *p_hwfn,
                return rc;
        }
 
+       rc = ecore_int_sb_attn_alloc(p_hwfn, p_ptt);
+       if (rc != ECORE_SUCCESS)
+               DP_ERR(p_hwfn->p_dev, "Failed to allocate sb attn mem\n");
+
        return rc;
 }
 
@@ -1051,6 +2075,7 @@ void ecore_int_setup(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt)
                return;
 
        ecore_int_sb_setup(p_hwfn, p_ptt, &p_hwfn->p_sp_sb->sb_info);
+       ecore_int_sb_attn_setup(p_hwfn, p_ptt);
        ecore_int_sp_dpc_setup(p_hwfn);
 }
 
@@ -1078,11 +2103,11 @@ u16 ecore_int_queue_id_from_sb_id(struct ecore_hwfn *p_hwfn, u16 sb_id)
        } else if ((sb_id >= p_info->igu_base_sb_iov) &&
                   (sb_id < p_info->igu_base_sb_iov + p_info->igu_sb_cnt_iov)) {
                return sb_id - p_info->igu_base_sb_iov + p_info->igu_sb_cnt;
+       } else {
+               DP_NOTICE(p_hwfn, true, "SB %d not in range for function\n",
+                         sb_id);
+               return 0;
        }
-
-       DP_NOTICE(p_hwfn, true, "SB %d not in range for function\n",
-                 sb_id);
-       return 0;
 }
 
 void ecore_int_disable_post_isr_release(struct ecore_dev *p_dev)
@@ -1092,3 +2117,45 @@ void ecore_int_disable_post_isr_release(struct ecore_dev *p_dev)
        for_each_hwfn(p_dev, i)
                p_dev->hwfns[i].b_int_requested = false;
 }
+
+void ecore_int_attn_clr_enable(struct ecore_dev *p_dev, bool clr_enable)
+{
+       p_dev->attn_clr_en = clr_enable;
+}
+
+enum _ecore_status_t ecore_int_set_timer_res(struct ecore_hwfn *p_hwfn,
+                                            struct ecore_ptt *p_ptt,
+                                            u8 timer_res, u16 sb_id, bool tx)
+{
+       struct cau_sb_entry sb_entry;
+       enum _ecore_status_t rc;
+
+       if (!p_hwfn->hw_init_done) {
+               DP_ERR(p_hwfn, "hardware not initialized yet\n");
+               return ECORE_INVAL;
+       }
+
+       rc = ecore_dmae_grc2host(p_hwfn, p_ptt, CAU_REG_SB_VAR_MEMORY +
+                                sb_id * sizeof(u64),
+                                (u64)(osal_uintptr_t)&sb_entry, 2, 0);
+       if (rc != ECORE_SUCCESS) {
+               DP_ERR(p_hwfn, "dmae_grc2host failed %d\n", rc);
+               return rc;
+       }
+
+       if (tx)
+               SET_FIELD(sb_entry.params, CAU_SB_ENTRY_TIMER_RES1, timer_res);
+       else
+               SET_FIELD(sb_entry.params, CAU_SB_ENTRY_TIMER_RES0, timer_res);
+
+       rc = ecore_dmae_host2grc(p_hwfn, p_ptt,
+                                (u64)(osal_uintptr_t)&sb_entry,
+                                CAU_REG_SB_VAR_MEMORY +
+                                sb_id * sizeof(u64), 2, 0);
+       if (rc != ECORE_SUCCESS) {
+               DP_ERR(p_hwfn, "dmae_host2grc failed %d\n", rc);
+               return rc;
+       }
+
+       return rc;
+}