fix typos using codespell utility
[dpdk.git] / drivers / net / qede / qede_rxtx.c
index 8e634d4..f65c833 100644 (file)
@@ -37,64 +37,20 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq)
        return 0;
 }
 
-static void qede_rx_queue_release_mbufs(struct qede_rx_queue *rxq)
-{
-       uint16_t i;
-
-       if (rxq->sw_rx_ring != NULL) {
-               for (i = 0; i < rxq->nb_rx_desc; i++) {
-                       if (rxq->sw_rx_ring[i].mbuf != NULL) {
-                               rte_pktmbuf_free(rxq->sw_rx_ring[i].mbuf);
-                               rxq->sw_rx_ring[i].mbuf = NULL;
-                       }
-               }
-       }
-}
-
-void qede_rx_queue_release(void *rx_queue)
-{
-       struct qede_rx_queue *rxq = rx_queue;
-
-       if (rxq != NULL) {
-               qede_rx_queue_release_mbufs(rxq);
-               rte_free(rxq->sw_rx_ring);
-               rxq->sw_rx_ring = NULL;
-               rte_free(rxq);
-               rxq = NULL;
-       }
-}
-
-static void qede_tx_queue_release_mbufs(struct qede_tx_queue *txq)
-{
-       unsigned int i;
-
-       PMD_TX_LOG(DEBUG, txq, "releasing %u mbufs", txq->nb_tx_desc);
-
-       if (txq->sw_tx_ring) {
-               for (i = 0; i < txq->nb_tx_desc; i++) {
-                       if (txq->sw_tx_ring[i].mbuf) {
-                               rte_pktmbuf_free(txq->sw_tx_ring[i].mbuf);
-                               txq->sw_tx_ring[i].mbuf = NULL;
-                       }
-               }
-       }
-}
-
 int
 qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                    uint16_t nb_desc, unsigned int socket_id,
-                   const struct rte_eth_rxconf *rx_conf,
+                   __rte_unused const struct rte_eth_rxconf *rx_conf,
                    struct rte_mempool *mp)
 {
-       struct qede_dev *qdev = dev->data->dev_private;
-       struct ecore_dev *edev = &qdev->edev;
+       struct qede_dev *qdev = QEDE_INIT_QDEV(dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
        struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
        struct qede_rx_queue *rxq;
        uint16_t max_rx_pkt_len;
        uint16_t bufsz;
        size_t size;
        int rc;
-       int i;
 
        PMD_INIT_FUNC_TRACE(edev);
 
@@ -157,7 +113,6 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                          "Unable to alloc memory for sw_rx_ring on socket %u\n",
                          socket_id);
                rte_free(rxq);
-               rxq = NULL;
                return -ENOMEM;
        }
 
@@ -176,9 +131,7 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                          "Unable to alloc memory for rxbd ring on socket %u\n",
                          socket_id);
                rte_free(rxq->sw_rx_ring);
-               rxq->sw_rx_ring = NULL;
                rte_free(rxq);
-               rxq = NULL;
                return -ENOMEM;
        }
 
@@ -198,45 +151,87 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                          socket_id);
                /* TBD: Freeing RX BD ring */
                rte_free(rxq->sw_rx_ring);
-               rxq->sw_rx_ring = NULL;
                rte_free(rxq);
                return -ENOMEM;
        }
 
-       /* Allocate buffers for the Rx ring */
-       for (i = 0; i < rxq->nb_rx_desc; i++) {
-               rc = qede_alloc_rx_buffer(rxq);
-               if (rc) {
-                       DP_NOTICE(edev, false,
-                                 "RX buffer allocation failed at idx=%d\n", i);
-                       goto err4;
-               }
-       }
-
        dev->data->rx_queues[queue_idx] = rxq;
+       qdev->fp_array[queue_idx].rxq = rxq;
 
        DP_INFO(edev, "rxq %d num_desc %u rx_buf_size=%u socket %u\n",
                  queue_idx, nb_desc, qdev->mtu, socket_id);
 
        return 0;
-err4:
-       qede_rx_queue_release(rxq);
-       return -ENOMEM;
 }
 
-void qede_tx_queue_release(void *tx_queue)
+static void
+qede_rx_queue_reset(__rte_unused struct qede_dev *qdev,
+                   struct qede_rx_queue *rxq)
 {
-       struct qede_tx_queue *txq = tx_queue;
+       DP_INFO(&qdev->edev, "Reset RX queue %u\n", rxq->queue_id);
+       ecore_chain_reset(&rxq->rx_bd_ring);
+       ecore_chain_reset(&rxq->rx_comp_ring);
+       rxq->sw_rx_prod = 0;
+       rxq->sw_rx_cons = 0;
+       *rxq->hw_cons_ptr = 0;
+}
 
-       if (txq != NULL) {
-               qede_tx_queue_release_mbufs(txq);
-               if (txq->sw_tx_ring) {
-                       rte_free(txq->sw_tx_ring);
-                       txq->sw_tx_ring = NULL;
+static void qede_rx_queue_release_mbufs(struct qede_rx_queue *rxq)
+{
+       uint16_t i;
+
+       if (rxq->sw_rx_ring) {
+               for (i = 0; i < rxq->nb_rx_desc; i++) {
+                       if (rxq->sw_rx_ring[i].mbuf) {
+                               rte_pktmbuf_free(rxq->sw_rx_ring[i].mbuf);
+                               rxq->sw_rx_ring[i].mbuf = NULL;
+                       }
                }
-               rte_free(txq);
        }
-       txq = NULL;
+}
+
+void qede_rx_queue_release(void *rx_queue)
+{
+       struct qede_rx_queue *rxq = rx_queue;
+
+       if (rxq) {
+               qede_rx_queue_release_mbufs(rxq);
+               rte_free(rxq->sw_rx_ring);
+               rte_free(rxq);
+       }
+}
+
+/* Stops a given RX queue in the HW */
+static int qede_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)
+{
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct ecore_hwfn *p_hwfn;
+       struct qede_rx_queue *rxq;
+       int hwfn_index;
+       int rc;
+
+       if (rx_queue_id < eth_dev->data->nb_rx_queues) {
+               rxq = eth_dev->data->rx_queues[rx_queue_id];
+               hwfn_index = rx_queue_id % edev->num_hwfns;
+               p_hwfn = &edev->hwfns[hwfn_index];
+               rc = ecore_eth_rx_queue_stop(p_hwfn, rxq->handle,
+                               true, false);
+               if (rc != ECORE_SUCCESS) {
+                       DP_ERR(edev, "RX queue %u stop fails\n", rx_queue_id);
+                       return -1;
+               }
+               qede_rx_queue_release_mbufs(rxq);
+               qede_rx_queue_reset(qdev, rxq);
+               eth_dev->data->rx_queue_state[rx_queue_id] =
+                       RTE_ETH_QUEUE_STATE_STOPPED;
+               DP_INFO(edev, "RX queue %u stopped\n", rx_queue_id);
+       } else {
+               DP_ERR(edev, "RX queue %u is not in range\n", rx_queue_id);
+               rc = -EINVAL;
+       }
+
+       return rc;
 }
 
 int
@@ -318,6 +313,7 @@ qede_tx_queue_setup(struct rte_eth_dev *dev,
            (txq->nb_tx_desc - QEDE_DEFAULT_TX_FREE_THRESH);
 
        dev->data->tx_queues[queue_idx] = txq;
+       qdev->fp_array[queue_idx].txq = txq;
 
        DP_INFO(edev,
                  "txq %u num_desc %u tx_free_thresh %u socket %u\n",
@@ -326,73 +322,40 @@ qede_tx_queue_setup(struct rte_eth_dev *dev,
        return 0;
 }
 
-/* This function inits fp content and resets the SB, RXQ and TXQ arrays */
-static void qede_init_fp(struct qede_dev *qdev)
+static void
+qede_tx_queue_reset(__rte_unused struct qede_dev *qdev,
+                   struct qede_tx_queue *txq)
 {
-       struct qede_fastpath *fp;
-       uint8_t i, rss_id, tc;
-       int fp_rx = qdev->fp_num_rx, rxq = 0, txq = 0;
-
-       memset((void *)qdev->fp_array, 0, (QEDE_QUEUE_CNT(qdev) *
-                                          sizeof(*qdev->fp_array)));
-       memset((void *)qdev->sb_array, 0, (QEDE_QUEUE_CNT(qdev) *
-                                          sizeof(*qdev->sb_array)));
-       for_each_queue(i) {
-               fp = &qdev->fp_array[i];
-               if (fp_rx) {
-                       fp->type = QEDE_FASTPATH_RX;
-                       fp_rx--;
-               } else{
-                       fp->type = QEDE_FASTPATH_TX;
-               }
-               fp->qdev = qdev;
-               fp->id = i;
-               fp->sb_info = &qdev->sb_array[i];
-               snprintf(fp->name, sizeof(fp->name), "%s-fp-%d", "qdev", i);
-       }
-
+       DP_INFO(&qdev->edev, "Reset TX queue %u\n", txq->queue_id);
+       ecore_chain_reset(&txq->tx_pbl);
+       txq->sw_tx_cons = 0;
+       txq->sw_tx_prod = 0;
+       *txq->hw_cons_ptr = 0;
 }
 
-void qede_free_fp_arrays(struct qede_dev *qdev)
+static void qede_tx_queue_release_mbufs(struct qede_tx_queue *txq)
 {
-       /* It asseumes qede_free_mem_load() is called before */
-       if (qdev->fp_array != NULL) {
-               rte_free(qdev->fp_array);
-               qdev->fp_array = NULL;
-       }
+       uint16_t i;
 
-       if (qdev->sb_array != NULL) {
-               rte_free(qdev->sb_array);
-               qdev->sb_array = NULL;
+       if (txq->sw_tx_ring) {
+               for (i = 0; i < txq->nb_tx_desc; i++) {
+                       if (txq->sw_tx_ring[i].mbuf) {
+                               rte_pktmbuf_free(txq->sw_tx_ring[i].mbuf);
+                               txq->sw_tx_ring[i].mbuf = NULL;
+                       }
+               }
        }
 }
 
-int qede_alloc_fp_array(struct qede_dev *qdev)
+void qede_tx_queue_release(void *tx_queue)
 {
-       struct qede_fastpath *fp;
-       struct ecore_dev *edev = &qdev->edev;
-       int i;
-
-       qdev->fp_array = rte_calloc("fp", QEDE_QUEUE_CNT(qdev),
-                                   sizeof(*qdev->fp_array),
-                                   RTE_CACHE_LINE_SIZE);
-
-       if (!qdev->fp_array) {
-               DP_ERR(edev, "fp array allocation failed\n");
-               return -ENOMEM;
-       }
-
-       qdev->sb_array = rte_calloc("sb", QEDE_QUEUE_CNT(qdev),
-                                   sizeof(*qdev->sb_array),
-                                   RTE_CACHE_LINE_SIZE);
+       struct qede_tx_queue *txq = tx_queue;
 
-       if (!qdev->sb_array) {
-               DP_ERR(edev, "sb array allocation failed\n");
-               rte_free(qdev->fp_array);
-               return -ENOMEM;
+       if (txq) {
+               qede_tx_queue_release_mbufs(txq);
+               rte_free(txq->sw_tx_ring);
+               rte_free(txq);
        }
-
-       return 0;
 }
 
 /* This function allocates fast-path status block memory */
@@ -412,9 +375,8 @@ qede_alloc_mem_sb(struct qede_dev *qdev, struct ecore_sb_info *sb_info,
                return -ENOMEM;
        }
 
-       rc = qdev->ops->common->sb_init(edev, sb_info,
-                                       sb_virt, sb_phys, sb_id,
-                                       QED_SB_TYPE_L2_QUEUE);
+       rc = qdev->ops->common->sb_init(edev, sb_info, sb_virt,
+                                       sb_phys, sb_id);
        if (rc) {
                DP_ERR(edev, "Status block initialization failed\n");
                /* TBD: No dma_free_coherent possible */
@@ -429,9 +391,7 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
        struct ecore_dev *edev = &qdev->edev;
        struct qede_fastpath *fp;
        uint32_t num_sbs;
-       uint16_t i;
        uint16_t sb_idx;
-       int rc;
 
        if (IS_VF(edev))
                ecore_vf_get_num_sbs(ECORE_LEADING_HWFN(edev), &num_sbs);
@@ -444,25 +404,31 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
                return -EINVAL;
        }
 
-       if (qdev->fp_array)
-               qede_free_fp_arrays(qdev);
+       qdev->fp_array = rte_calloc("fp", QEDE_RXTX_MAX(qdev),
+                               sizeof(*qdev->fp_array), RTE_CACHE_LINE_SIZE);
 
-       rc = qede_alloc_fp_array(qdev);
-       if (rc != 0)
-               return rc;
+       if (!qdev->fp_array) {
+               DP_ERR(edev, "fp array allocation failed\n");
+               return -ENOMEM;
+       }
 
-       qede_init_fp(qdev);
+       memset((void *)qdev->fp_array, 0, QEDE_RXTX_MAX(qdev) *
+                       sizeof(*qdev->fp_array));
 
-       for (i = 0; i < QEDE_QUEUE_CNT(qdev); i++) {
-               fp = &qdev->fp_array[i];
-               if (IS_VF(edev))
-                       sb_idx = i % num_sbs;
-               else
-                       sb_idx = i;
+       for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
+               fp = &qdev->fp_array[sb_idx];
+               fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info),
+                               RTE_CACHE_LINE_SIZE);
+               if (!fp->sb_info) {
+                       DP_ERR(edev, "FP sb_info allocation fails\n");
+                       return -1;
+               }
                if (qede_alloc_mem_sb(qdev, fp->sb_info, sb_idx)) {
-                       qede_free_fp_arrays(qdev);
-                       return -ENOMEM;
+                       DP_ERR(edev, "FP status block allocation fails\n");
+                       return -1;
                }
+               DP_INFO(edev, "sb_info idx 0x%x initialized\n",
+                               fp->sb_info->igu_sb_id);
        }
 
        return 0;
@@ -471,13 +437,28 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
 void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
 {
        struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       __rte_unused struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct qede_fastpath *fp;
+       uint16_t sb_idx;
+
+       PMD_INIT_FUNC_TRACE(edev);
 
-       qede_free_mem_load(eth_dev);
-       qede_free_fp_arrays(qdev);
+       for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
+               fp = &qdev->fp_array[sb_idx];
+               DP_INFO(edev, "Free sb_info index 0x%x\n",
+                               fp->sb_info->igu_sb_id);
+               if (fp->sb_info)
+                       rte_free(fp->sb_info);
+               fp->sb_info = NULL;
+       }
+       if (qdev->fp_array)
+               rte_free(qdev->fp_array);
+       qdev->fp_array = NULL;
 }
 
 static inline void
-qede_update_rx_prod(struct qede_dev *edev, struct qede_rx_queue *rxq)
+qede_update_rx_prod(__rte_unused struct qede_dev *edev,
+                   struct qede_rx_queue *rxq)
 {
        uint16_t bd_prod = ecore_chain_get_prod_idx(&rxq->rx_bd_ring);
        uint16_t cqe_prod = ecore_chain_get_prod_idx(&rxq->rx_comp_ring);
@@ -507,168 +488,303 @@ qede_update_rx_prod(struct qede_dev *edev, struct qede_rx_queue *rxq)
        PMD_RX_LOG(DEBUG, rxq, "bd_prod %u  cqe_prod %u", bd_prod, cqe_prod);
 }
 
-static void
-qede_update_sge_tpa_params(struct ecore_sge_tpa_params *sge_tpa_params,
-                          uint16_t mtu, bool enable)
-{
-       /* Enable LRO in split mode */
-       sge_tpa_params->tpa_ipv4_en_flg = enable;
-       sge_tpa_params->tpa_ipv6_en_flg = enable;
-       sge_tpa_params->tpa_ipv4_tunn_en_flg = enable;
-       sge_tpa_params->tpa_ipv6_tunn_en_flg = enable;
-       /* set if tpa enable changes */
-       sge_tpa_params->update_tpa_en_flg = 1;
-       /* set if tpa parameters should be handled */
-       sge_tpa_params->update_tpa_param_flg = enable;
-
-       sge_tpa_params->max_buffers_per_cqe = 20;
-       sge_tpa_params->tpa_pkt_split_flg = 1;
-       sge_tpa_params->tpa_hdr_data_split_flg = 0;
-       sge_tpa_params->tpa_gro_consistent_flg = 0;
-       sge_tpa_params->tpa_max_aggs_num = ETH_TPA_MAX_AGGS_NUM;
-       sge_tpa_params->tpa_max_size = 0x7FFF;
-       sge_tpa_params->tpa_min_size_to_start = mtu / 2;
-       sge_tpa_params->tpa_min_size_to_cont = mtu / 2;
-}
-
-static int qede_start_queues(struct rte_eth_dev *eth_dev, bool clear_stats)
+/* Starts a given RX queue in HW */
+static int
+qede_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)
 {
-       struct qede_dev *qdev = eth_dev->data->dev_private;
-       struct ecore_dev *edev = &qdev->edev;
-       struct ecore_queue_start_common_params q_params;
-       struct qed_dev_info *qed_info = &qdev->dev_info.common;
-       struct qed_update_vport_params vport_update_params;
-       struct ecore_sge_tpa_params tpa_params;
-       struct qede_tx_queue *txq;
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct ecore_queue_start_common_params params;
+       struct ecore_rxq_start_ret_params ret_params;
+       struct qede_rx_queue *rxq;
        struct qede_fastpath *fp;
+       struct ecore_hwfn *p_hwfn;
        dma_addr_t p_phys_table;
-       int txq_index;
        uint16_t page_cnt;
-       int vlan_removal_en = 1;
-       int rc, tc, i;
-
-       for_each_queue(i) {
-               fp = &qdev->fp_array[i];
-               if (fp->type & QEDE_FASTPATH_RX) {
-                       struct ecore_rxq_start_ret_params ret_params;
-
-                       p_phys_table =
-                           ecore_chain_get_pbl_phys(&fp->rxq->rx_comp_ring);
-                       page_cnt =
-                           ecore_chain_get_page_cnt(&fp->rxq->rx_comp_ring);
-
-                       memset(&ret_params, 0, sizeof(ret_params));
-                       memset(&q_params, 0, sizeof(q_params));
-                       q_params.queue_id = i;
-                       q_params.vport_id = 0;
-                       q_params.sb = fp->sb_info->igu_sb_id;
-                       q_params.sb_idx = RX_PI;
-
-                       ecore_sb_ack(fp->sb_info, IGU_INT_DISABLE, 0);
-
-                       rc = qdev->ops->q_rx_start(edev, i, &q_params,
-                                          fp->rxq->rx_buf_size,
-                                          fp->rxq->rx_bd_ring.p_phys_addr,
-                                          p_phys_table,
-                                          page_cnt,
-                                          &ret_params);
+       uint16_t j;
+       int hwfn_index;
+       int rc;
+
+       if (rx_queue_id < eth_dev->data->nb_rx_queues) {
+               fp = &qdev->fp_array[rx_queue_id];
+               rxq = eth_dev->data->rx_queues[rx_queue_id];
+               /* Allocate buffers for the Rx ring */
+               for (j = 0; j < rxq->nb_rx_desc; j++) {
+                       rc = qede_alloc_rx_buffer(rxq);
                        if (rc) {
-                               DP_ERR(edev, "Start rxq #%d failed %d\n",
-                                      fp->rxq->queue_id, rc);
-                               return rc;
+                               DP_ERR(edev, "RX buffer allocation failed"
+                                               " for rxq = %u\n", rx_queue_id);
+                               return -ENOMEM;
                        }
+               }
+               /* disable interrupts */
+               ecore_sb_ack(fp->sb_info, IGU_INT_DISABLE, 0);
+               /* Prepare ramrod */
+               memset(&params, 0, sizeof(params));
+               params.queue_id = rx_queue_id;
+               params.vport_id = 0;
+               params.sb = fp->sb_info->igu_sb_id;
+               DP_INFO(edev, "rxq %u igu_sb_id 0x%x\n",
+                               fp->rxq->queue_id, fp->sb_info->igu_sb_id);
+               params.sb_idx = RX_PI;
+               hwfn_index = rx_queue_id % edev->num_hwfns;
+               p_hwfn = &edev->hwfns[hwfn_index];
+               p_phys_table = ecore_chain_get_pbl_phys(&fp->rxq->rx_comp_ring);
+               page_cnt = ecore_chain_get_page_cnt(&fp->rxq->rx_comp_ring);
+               memset(&ret_params, 0, sizeof(ret_params));
+               rc = ecore_eth_rx_queue_start(p_hwfn,
+                               p_hwfn->hw_info.opaque_fid,
+                               &params, fp->rxq->rx_buf_size,
+                               fp->rxq->rx_bd_ring.p_phys_addr,
+                               p_phys_table, page_cnt,
+                               &ret_params);
+               if (rc) {
+                       DP_ERR(edev, "RX queue %u could not be started, rc = %d\n",
+                                       rx_queue_id, rc);
+                       return -1;
+               }
+               /* Update with the returned parameters */
+               fp->rxq->hw_rxq_prod_addr = ret_params.p_prod;
+               fp->rxq->handle = ret_params.p_handle;
+
+               fp->rxq->hw_cons_ptr = &fp->sb_info->sb_virt->pi_array[RX_PI];
+               qede_update_rx_prod(qdev, fp->rxq);
+               eth_dev->data->rx_queue_state[rx_queue_id] =
+                       RTE_ETH_QUEUE_STATE_STARTED;
+               DP_INFO(edev, "RX queue %u started\n", rx_queue_id);
+       } else {
+               DP_ERR(edev, "RX queue %u is not in range\n", rx_queue_id);
+               rc = -EINVAL;
+       }
 
-                       /* Use the return parameters */
-                       fp->rxq->hw_rxq_prod_addr = ret_params.p_prod;
-                       fp->rxq->handle = ret_params.p_handle;
+       return rc;
+}
 
-                       fp->rxq->hw_cons_ptr =
-                                       &fp->sb_info->sb_virt->pi_array[RX_PI];
+static int
+qede_tx_queue_start(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)
+{
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct ecore_queue_start_common_params params;
+       struct ecore_txq_start_ret_params ret_params;
+       struct ecore_hwfn *p_hwfn;
+       dma_addr_t p_phys_table;
+       struct qede_tx_queue *txq;
+       struct qede_fastpath *fp;
+       uint16_t page_cnt;
+       int hwfn_index;
+       int rc;
 
-                       qede_update_rx_prod(qdev, fp->rxq);
+       if (tx_queue_id < eth_dev->data->nb_tx_queues) {
+               txq = eth_dev->data->tx_queues[tx_queue_id];
+               fp = &qdev->fp_array[tx_queue_id];
+               memset(&params, 0, sizeof(params));
+               params.queue_id = tx_queue_id;
+               params.vport_id = 0;
+               params.sb = fp->sb_info->igu_sb_id;
+               DP_INFO(edev, "txq %u igu_sb_id 0x%x\n",
+                               fp->txq->queue_id, fp->sb_info->igu_sb_id);
+               params.sb_idx = TX_PI(0); /* tc = 0 */
+               p_phys_table = ecore_chain_get_pbl_phys(&txq->tx_pbl);
+               page_cnt = ecore_chain_get_page_cnt(&txq->tx_pbl);
+               hwfn_index = tx_queue_id % edev->num_hwfns;
+               p_hwfn = &edev->hwfns[hwfn_index];
+               if (qdev->dev_info.is_legacy)
+                       fp->txq->is_legacy = true;
+               rc = ecore_eth_tx_queue_start(p_hwfn,
+                               p_hwfn->hw_info.opaque_fid,
+                               &params, 0 /* tc */,
+                               p_phys_table, page_cnt,
+                               &ret_params);
+               if (rc != ECORE_SUCCESS) {
+                       DP_ERR(edev, "TX queue %u couldn't be started, rc=%d\n",
+                                       tx_queue_id, rc);
+                       return -1;
                }
+               txq->doorbell_addr = ret_params.p_doorbell;
+               txq->handle = ret_params.p_handle;
+
+               txq->hw_cons_ptr = &fp->sb_info->sb_virt->pi_array[TX_PI(0)];
+               SET_FIELD(txq->tx_db.data.params, ETH_DB_DATA_DEST,
+                               DB_DEST_XCM);
+               SET_FIELD(txq->tx_db.data.params, ETH_DB_DATA_AGG_CMD,
+                               DB_AGG_CMD_SET);
+               SET_FIELD(txq->tx_db.data.params,
+                               ETH_DB_DATA_AGG_VAL_SEL,
+                               DQ_XCM_ETH_TX_BD_PROD_CMD);
+               txq->tx_db.data.agg_flags = DQ_XCM_ETH_DQ_CF_CMD;
+               eth_dev->data->tx_queue_state[tx_queue_id] =
+                       RTE_ETH_QUEUE_STATE_STARTED;
+               DP_INFO(edev, "TX queue %u started\n", tx_queue_id);
+       } else {
+               DP_ERR(edev, "TX queue %u is not in range\n", tx_queue_id);
+               rc = -EINVAL;
+       }
 
-               if (!(fp->type & QEDE_FASTPATH_TX))
-                       continue;
-               for (tc = 0; tc < qdev->num_tc; tc++) {
-                       struct ecore_txq_start_ret_params ret_params;
+       return rc;
+}
 
-                       txq = fp->txqs[tc];
-                       txq_index = tc * QEDE_RSS_COUNT(qdev) + i;
+static inline void
+qede_free_tx_pkt(struct qede_tx_queue *txq)
+{
+       struct rte_mbuf *mbuf;
+       uint16_t nb_segs;
+       uint16_t idx;
 
-                       p_phys_table = ecore_chain_get_pbl_phys(&txq->tx_pbl);
-                       page_cnt = ecore_chain_get_page_cnt(&txq->tx_pbl);
+       idx = TX_CONS(txq);
+       mbuf = txq->sw_tx_ring[idx].mbuf;
+       if (mbuf) {
+               nb_segs = mbuf->nb_segs;
+               PMD_TX_LOG(DEBUG, txq, "nb_segs to free %u\n", nb_segs);
+               while (nb_segs) {
+                       /* It's like consuming rxbuf in recv() */
+                       ecore_chain_consume(&txq->tx_pbl);
+                       txq->nb_tx_avail++;
+                       nb_segs--;
+               }
+               rte_pktmbuf_free(mbuf);
+               txq->sw_tx_ring[idx].mbuf = NULL;
+               txq->sw_tx_cons++;
+               PMD_TX_LOG(DEBUG, txq, "Freed tx packet\n");
+       } else {
+               ecore_chain_consume(&txq->tx_pbl);
+               txq->nb_tx_avail++;
+       }
+}
 
-                       memset(&q_params, 0, sizeof(q_params));
-                       memset(&ret_params, 0, sizeof(ret_params));
-                       q_params.queue_id = txq->queue_id;
-                       q_params.vport_id = 0;
-                       q_params.sb = fp->sb_info->igu_sb_id;
-                       q_params.sb_idx = TX_PI(tc);
+static inline void
+qede_process_tx_compl(__rte_unused struct ecore_dev *edev,
+                     struct qede_tx_queue *txq)
+{
+       uint16_t hw_bd_cons;
+#ifdef RTE_LIBRTE_QEDE_DEBUG_TX
+       uint16_t sw_tx_cons;
+#endif
 
-                       rc = qdev->ops->q_tx_start(edev, i, &q_params,
-                                                  p_phys_table,
-                                                  page_cnt, /* **pp_doorbell */
-                                                  &ret_params);
-                       if (rc) {
-                               DP_ERR(edev, "Start txq %u failed %d\n",
-                                      txq_index, rc);
-                               return rc;
-                       }
+       rte_compiler_barrier();
+       hw_bd_cons = rte_le_to_cpu_16(*txq->hw_cons_ptr);
+#ifdef RTE_LIBRTE_QEDE_DEBUG_TX
+       sw_tx_cons = ecore_chain_get_cons_idx(&txq->tx_pbl);
+       PMD_TX_LOG(DEBUG, txq, "Tx Completions = %u\n",
+                  abs(hw_bd_cons - sw_tx_cons));
+#endif
+       while (hw_bd_cons !=  ecore_chain_get_cons_idx(&txq->tx_pbl))
+               qede_free_tx_pkt(txq);
+}
 
-                       txq->doorbell_addr = ret_params.p_doorbell;
-                       txq->handle = ret_params.p_handle;
 
-                       txq->hw_cons_ptr =
-                           &fp->sb_info->sb_virt->pi_array[TX_PI(tc)];
-                       SET_FIELD(txq->tx_db.data.params,
-                                 ETH_DB_DATA_DEST, DB_DEST_XCM);
-                       SET_FIELD(txq->tx_db.data.params, ETH_DB_DATA_AGG_CMD,
-                                 DB_AGG_CMD_SET);
-                       SET_FIELD(txq->tx_db.data.params,
-                                 ETH_DB_DATA_AGG_VAL_SEL,
-                                 DQ_XCM_ETH_TX_BD_PROD_CMD);
+static int qede_drain_txq(struct qede_dev *qdev,
+                         struct qede_tx_queue *txq, bool allow_drain)
+{
+       struct ecore_dev *edev = &qdev->edev;
+       int rc, cnt = 1000;
 
-                       txq->tx_db.data.agg_flags = DQ_XCM_ETH_DQ_CF_CMD;
+       while (txq->sw_tx_cons != txq->sw_tx_prod) {
+               qede_process_tx_compl(edev, txq);
+               if (!cnt) {
+                       if (allow_drain) {
+                               DP_ERR(edev, "Tx queue[%u] is stuck,"
+                                         "requesting MCP to drain\n",
+                                         txq->queue_id);
+                               rc = qdev->ops->common->drain(edev);
+                               if (rc)
+                                       return rc;
+                               return qede_drain_txq(qdev, txq, false);
+                       }
+                       DP_ERR(edev, "Timeout waiting for tx queue[%d]:"
+                                 "PROD=%d, CONS=%d\n",
+                                 txq->queue_id, txq->sw_tx_prod,
+                                 txq->sw_tx_cons);
+                       return -1;
                }
+               cnt--;
+               DELAY(1000);
+               rte_compiler_barrier();
        }
 
-       /* Prepare and send the vport enable */
-       memset(&vport_update_params, 0, sizeof(vport_update_params));
-       /* Update MTU via vport update */
-       vport_update_params.mtu = qdev->mtu;
-       vport_update_params.vport_id = 0;
-       vport_update_params.update_vport_active_flg = 1;
-       vport_update_params.vport_active_flg = 1;
-
-       /* @DPDK */
-       if (qed_info->mf_mode == MF_NPAR && qed_info->tx_switching) {
-               /* TBD: Check SRIOV enabled for VF */
-               vport_update_params.update_tx_switching_flg = 1;
-               vport_update_params.tx_switching_flg = 1;
-       }
+       /* FW finished processing, wait for HW to transmit all tx packets */
+       DELAY(2000);
 
-       /* TPA */
-       if (qdev->enable_lro) {
-               DP_INFO(edev, "Enabling LRO\n");
-               memset(&tpa_params, 0, sizeof(struct ecore_sge_tpa_params));
-               qede_update_sge_tpa_params(&tpa_params, qdev->mtu, true);
-               vport_update_params.sge_tpa_params = &tpa_params;
-       }
+       return 0;
+}
 
-       rc = qdev->ops->vport_update(edev, &vport_update_params);
-       if (rc) {
-               DP_ERR(edev, "Update V-PORT failed %d\n", rc);
-               return rc;
+
+/* Stops a given TX queue in the HW */
+static int qede_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)
+{
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct ecore_hwfn *p_hwfn;
+       struct qede_tx_queue *txq;
+       int hwfn_index;
+       int rc;
+
+       if (tx_queue_id < eth_dev->data->nb_tx_queues) {
+               txq = eth_dev->data->tx_queues[tx_queue_id];
+               /* Drain txq */
+               if (qede_drain_txq(qdev, txq, true))
+                       return -1; /* For the lack of retcodes */
+               /* Stop txq */
+               hwfn_index = tx_queue_id % edev->num_hwfns;
+               p_hwfn = &edev->hwfns[hwfn_index];
+               rc = ecore_eth_tx_queue_stop(p_hwfn, txq->handle);
+               if (rc != ECORE_SUCCESS) {
+                       DP_ERR(edev, "TX queue %u stop fails\n", tx_queue_id);
+                       return -1;
+               }
+               qede_tx_queue_release_mbufs(txq);
+               qede_tx_queue_reset(qdev, txq);
+               eth_dev->data->tx_queue_state[tx_queue_id] =
+                       RTE_ETH_QUEUE_STATE_STOPPED;
+               DP_INFO(edev, "TX queue %u stopped\n", tx_queue_id);
+       } else {
+               DP_ERR(edev, "TX queue %u is not in range\n", tx_queue_id);
+               rc = -EINVAL;
        }
 
-       return 0;
+       return rc;
 }
 
-static bool qede_tunn_exist(uint16_t flag)
+int qede_start_queues(struct rte_eth_dev *eth_dev)
 {
-       return !!((PARSING_AND_ERR_FLAGS_TUNNELEXIST_MASK <<
-                   PARSING_AND_ERR_FLAGS_TUNNELEXIST_SHIFT) & flag);
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       uint8_t id;
+       int rc;
+
+       for_each_rss(id) {
+               rc = qede_rx_queue_start(eth_dev, id);
+               if (rc != ECORE_SUCCESS)
+                       return -1;
+       }
+
+       for_each_tss(id) {
+               rc = qede_tx_queue_start(eth_dev, id);
+               if (rc != ECORE_SUCCESS)
+                       return -1;
+       }
+
+       return rc;
+}
+
+void qede_stop_queues(struct rte_eth_dev *eth_dev)
+{
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       uint8_t id;
+
+       /* Stopping RX/TX queues */
+       for_each_tss(id) {
+               qede_tx_queue_stop(eth_dev, id);
+       }
+
+       for_each_rss(id) {
+               qede_rx_queue_stop(eth_dev, id);
+       }
+}
+
+static bool qede_tunn_exist(uint16_t flag)
+{
+       return !!((PARSING_AND_ERR_FLAGS_TUNNELEXIST_MASK <<
+                   PARSING_AND_ERR_FLAGS_TUNNELEXIST_SHIFT) & flag);
 }
 
 /*
@@ -697,6 +813,33 @@ static inline uint8_t qede_check_notunn_csum_l4(uint16_t flag)
        return 0;
 }
 
+static inline uint32_t qede_rx_cqe_to_pkt_type(uint16_t flags)
+{
+       uint16_t val;
+
+       /* Lookup table */
+       static const uint32_t
+       ptype_lkup_tbl[QEDE_PKT_TYPE_MAX] __rte_cache_aligned = {
+               [QEDE_PKT_TYPE_IPV4] = RTE_PTYPE_L3_IPV4,
+               [QEDE_PKT_TYPE_IPV6] = RTE_PTYPE_L3_IPV6,
+               [QEDE_PKT_TYPE_IPV4_TCP] = RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_TCP,
+               [QEDE_PKT_TYPE_IPV6_TCP] = RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_TCP,
+               [QEDE_PKT_TYPE_IPV4_UDP] = RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_UDP,
+               [QEDE_PKT_TYPE_IPV6_UDP] = RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_UDP,
+       };
+
+       /* Bits (0..3) provides L3/L4 protocol type */
+       val = ((PARSING_AND_ERR_FLAGS_L3TYPE_MASK <<
+              PARSING_AND_ERR_FLAGS_L3TYPE_SHIFT) |
+              (PARSING_AND_ERR_FLAGS_L4PROTOCOL_MASK <<
+               PARSING_AND_ERR_FLAGS_L4PROTOCOL_SHIFT)) & flags;
+
+       if (val < QEDE_PKT_TYPE_MAX)
+               return ptype_lkup_tbl[val] | RTE_PTYPE_L2_ETHER;
+       else
+               return RTE_PTYPE_UNKNOWN;
+}
+
 static inline uint8_t
 qede_check_notunn_csum_l3(struct rte_mbuf *m, uint16_t flag)
 {
@@ -732,7 +875,7 @@ static inline void qede_rx_bd_ring_consume(struct qede_rx_queue *rxq)
 }
 
 static inline void
-qede_reuse_page(struct qede_dev *qdev,
+qede_reuse_page(__rte_unused struct qede_dev *qdev,
                struct qede_rx_queue *rxq, struct qede_rx_entry *curr_cons)
 {
        struct eth_rx_bd *rx_bd_prod = ecore_chain_produce(&rxq->rx_bd_ring);
@@ -765,119 +908,69 @@ qede_recycle_rx_bd_ring(struct qede_rx_queue *rxq,
        }
 }
 
-static inline uint32_t qede_rx_cqe_to_pkt_type(uint16_t flags)
-{
-       uint16_t val;
-
-       /* Lookup table */
-       static const uint32_t
-       ptype_lkup_tbl[QEDE_PKT_TYPE_MAX] __rte_cache_aligned = {
-               [QEDE_PKT_TYPE_IPV4] = RTE_PTYPE_L3_IPV4,
-               [QEDE_PKT_TYPE_IPV6] = RTE_PTYPE_L3_IPV6,
-               [QEDE_PKT_TYPE_IPV4_TCP] = RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_TCP,
-               [QEDE_PKT_TYPE_IPV6_TCP] = RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_TCP,
-               [QEDE_PKT_TYPE_IPV4_UDP] = RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_UDP,
-               [QEDE_PKT_TYPE_IPV6_UDP] = RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_UDP,
-       };
-
-       /* Bits (0..3) provides L3/L4 protocol type */
-       val = ((PARSING_AND_ERR_FLAGS_L3TYPE_MASK <<
-              PARSING_AND_ERR_FLAGS_L3TYPE_SHIFT) |
-              (PARSING_AND_ERR_FLAGS_L4PROTOCOL_MASK <<
-               PARSING_AND_ERR_FLAGS_L4PROTOCOL_SHIFT)) & flags;
-
-       if (val < QEDE_PKT_TYPE_MAX)
-               return ptype_lkup_tbl[val] | RTE_PTYPE_L2_ETHER;
-       else
-               return RTE_PTYPE_UNKNOWN;
-}
-
 static inline void
-qede_rx_process_tpa_cont_cqe(struct qede_dev *qdev,
-                            struct qede_rx_queue *rxq,
-                            struct eth_fast_path_rx_tpa_cont_cqe *cqe)
+qede_rx_process_tpa_cmn_cont_end_cqe(__rte_unused struct qede_dev *qdev,
+                                    struct qede_rx_queue *rxq,
+                                    uint8_t agg_index, uint16_t len)
 {
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
        struct qede_agg_info *tpa_info;
-       struct rte_mbuf *temp_frag; /* Pointer to mbuf chain head */
-       struct rte_mbuf *curr_frag;
-       uint8_t list_count = 0;
+       struct rte_mbuf *curr_frag; /* Pointer to currently filled TPA seg */
        uint16_t cons_idx;
-       uint8_t i;
-
-       PMD_RX_LOG(INFO, rxq, "TPA cont[%02x] - len_list [%04x %04x]\n",
-                  cqe->tpa_agg_index, rte_le_to_cpu_16(cqe->len_list[0]),
-                  rte_le_to_cpu_16(cqe->len_list[1]));
 
-       tpa_info = &rxq->tpa_info[cqe->tpa_agg_index];
-       temp_frag = tpa_info->mbuf;
-       assert(temp_frag);
-
-       for (i = 0; cqe->len_list[i]; i++) {
+       /* Under certain conditions it is possible that FW may not consume
+        * additional or new BD. So decision to consume the BD must be made
+        * based on len_list[0].
+        */
+       if (rte_le_to_cpu_16(len)) {
+               tpa_info = &rxq->tpa_info[agg_index];
                cons_idx = rxq->sw_rx_cons & NUM_RX_BDS(rxq);
                curr_frag = rxq->sw_rx_ring[cons_idx].mbuf;
+               assert(curr_frag);
+               curr_frag->nb_segs = 1;
+               curr_frag->pkt_len = rte_le_to_cpu_16(len);
+               curr_frag->data_len = curr_frag->pkt_len;
+               tpa_info->tpa_tail->next = curr_frag;
+               tpa_info->tpa_tail = curr_frag;
                qede_rx_bd_ring_consume(rxq);
-               curr_frag->data_len = rte_le_to_cpu_16(cqe->len_list[i]);
-               temp_frag->next = curr_frag;
-               temp_frag = curr_frag;
-               list_count++;
-       }
-
-       /* Allocate RX mbuf on the RX BD ring for those many consumed  */
-       for (i = 0 ; i < list_count ; i++) {
                if (unlikely(qede_alloc_rx_buffer(rxq) != 0)) {
-                       DP_ERR(edev, "Failed to allocate mbuf for LRO cont\n");
-                       tpa_info->state = QEDE_AGG_STATE_ERROR;
+                       PMD_RX_LOG(ERR, rxq, "mbuf allocation fails\n");
+                       rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;
+                       rxq->rx_alloc_errors++;
                }
        }
 }
 
+static inline void
+qede_rx_process_tpa_cont_cqe(struct qede_dev *qdev,
+                            struct qede_rx_queue *rxq,
+                            struct eth_fast_path_rx_tpa_cont_cqe *cqe)
+{
+       PMD_RX_LOG(INFO, rxq, "TPA cont[%d] - len [%d]\n",
+                  cqe->tpa_agg_index, rte_le_to_cpu_16(cqe->len_list[0]));
+       /* only len_list[0] will have value */
+       qede_rx_process_tpa_cmn_cont_end_cqe(qdev, rxq, cqe->tpa_agg_index,
+                                            cqe->len_list[0]);
+}
+
 static inline void
 qede_rx_process_tpa_end_cqe(struct qede_dev *qdev,
                            struct qede_rx_queue *rxq,
                            struct eth_fast_path_rx_tpa_end_cqe *cqe)
 {
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct qede_agg_info *tpa_info;
-       struct rte_mbuf *temp_frag; /* Pointer to mbuf chain head */
-       struct rte_mbuf *curr_frag;
-       struct rte_mbuf *rx_mb;
-       uint8_t list_count = 0;
-       uint16_t cons_idx;
-       uint8_t i;
-
-       PMD_RX_LOG(INFO, rxq, "TPA End[%02x] - len_list [%04x %04x]\n",
-                  cqe->tpa_agg_index, rte_le_to_cpu_16(cqe->len_list[0]),
-                  rte_le_to_cpu_16(cqe->len_list[1]));
-
-       tpa_info = &rxq->tpa_info[cqe->tpa_agg_index];
-       temp_frag = tpa_info->mbuf;
-       assert(temp_frag);
-
-       for (i = 0; cqe->len_list[i]; i++) {
-               cons_idx = rxq->sw_rx_cons & NUM_RX_BDS(rxq);
-               curr_frag = rxq->sw_rx_ring[cons_idx].mbuf;
-               qede_rx_bd_ring_consume(rxq);
-               curr_frag->data_len = rte_le_to_cpu_16(cqe->len_list[i]);
-               temp_frag->next = curr_frag;
-               temp_frag = curr_frag;
-               list_count++;
-       }
-
-       /* Allocate RX mbuf on the RX BD ring for those many consumed */
-       for (i = 0 ; i < list_count ; i++) {
-               if (unlikely(qede_alloc_rx_buffer(rxq) != 0)) {
-                       DP_ERR(edev, "Failed to allocate mbuf for lro end\n");
-                       tpa_info->state = QEDE_AGG_STATE_ERROR;
-               }
-       }
+       struct rte_mbuf *rx_mb; /* Pointer to head of the chained agg */
 
+       qede_rx_process_tpa_cmn_cont_end_cqe(qdev, rxq, cqe->tpa_agg_index,
+                                            cqe->len_list[0]);
        /* Update total length and frags based on end TPA */
-       rx_mb = rxq->tpa_info[cqe->tpa_agg_index].mbuf;
-       /* TBD: Add sanity checks here */
+       rx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head;
+       /* TODO:  Add Sanity Checks */
        rx_mb->nb_segs = cqe->num_of_bds;
        rx_mb->pkt_len = cqe->total_packet_len;
-       tpa_info->state = QEDE_AGG_STATE_NONE;
+
+       PMD_RX_LOG(INFO, rxq, "TPA End[%d] reason %d cqe_len %d nb_segs %d"
+                  " pkt_len %d\n", cqe->tpa_agg_index, cqe->end_reason,
+                  rte_le_to_cpu_16(cqe->len_list[0]), rx_mb->nb_segs,
+                  rx_mb->pkt_len);
 }
 
 static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags)
@@ -947,7 +1040,6 @@ qede_process_sg_pkts(void *p_rxq,  struct rte_mbuf *rx_mb,
 {
        struct qede_rx_queue *rxq = p_rxq;
        struct qede_dev *qdev = rxq->qdev;
-       struct ecore_dev *edev = &qdev->edev;
        register struct rte_mbuf *seg1 = NULL;
        register struct rte_mbuf *seg2 = NULL;
        uint16_t sw_rx_index;
@@ -983,21 +1075,22 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
        struct qede_rx_queue *rxq = p_rxq;
        struct qede_dev *qdev = rxq->qdev;
        struct ecore_dev *edev = &qdev->edev;
-       struct qede_fastpath *fp = &qdev->fp_array[rxq->queue_id];
        uint16_t hw_comp_cons, sw_comp_cons, sw_rx_index;
        uint16_t rx_pkt = 0;
        union eth_rx_cqe *cqe;
-       struct eth_fast_path_rx_reg_cqe *fp_cqe;
+       struct eth_fast_path_rx_reg_cqe *fp_cqe = NULL;
        register struct rte_mbuf *rx_mb = NULL;
        register struct rte_mbuf *seg1 = NULL;
        enum eth_rx_cqe_type cqe_type;
-       uint16_t pkt_len; /* Sum of all BD segments */
+       uint16_t pkt_len = 0; /* Sum of all BD segments */
        uint16_t len; /* Length of first BD */
        uint8_t num_segs = 1;
        uint16_t preload_idx;
-       uint8_t csum_flag;
        uint16_t parse_flag;
+#ifdef RTE_LIBRTE_QEDE_DEBUG_RX
+       uint8_t bitfield_val;
        enum rss_hash_type htype;
+#endif
        uint8_t tunn_parse_flag;
        uint8_t j;
        struct eth_fast_path_rx_tpa_start_cqe *cqe_start_tpa;
@@ -1005,9 +1098,9 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
        uint32_t packet_type;
        uint16_t vlan_tci;
        bool tpa_start_flg;
-       uint8_t bitfield_val;
        uint8_t offset, tpa_agg_idx, flags;
-       struct qede_agg_info *tpa_info;
+       struct qede_agg_info *tpa_info = NULL;
+       uint32_t rss_hash;
 
        hw_comp_cons = rte_le_to_cpu_16(*rxq->hw_cons_ptr);
        sw_comp_cons = ecore_chain_get_cons_idx(&rxq->rx_comp_ring);
@@ -1022,6 +1115,7 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                packet_type = RTE_PTYPE_UNKNOWN;
                vlan_tci = 0;
                tpa_start_flg = false;
+               rss_hash = 0;
 
                /* Get the CQE from the completion ring */
                cqe =
@@ -1037,9 +1131,15 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                        cqe_start_tpa = &cqe->fast_path_tpa_start;
                        tpa_info = &rxq->tpa_info[cqe_start_tpa->tpa_agg_index];
                        tpa_start_flg = true;
+                       /* Mark it as LRO packet */
+                       ol_flags |= PKT_RX_LRO;
+                       /* In split mode,  seg_len is same as len_on_first_bd
+                        * and ext_bd_len_list will be empty since there are
+                        * no additional buffers
+                        */
                        PMD_RX_LOG(INFO, rxq,
-                           "TPA start[%u] - len %04x [header %02x]"
-                           " [bd_list[0] %04x], [seg_len %04x]\n",
+                           "TPA start[%d] - len_on_first_bd %d header %d"
+                           " [bd_list[0] %d], [seg_len %d]\n",
                            cqe_start_tpa->tpa_agg_index,
                            rte_le_to_cpu_16(cqe_start_tpa->len_on_first_bd),
                            cqe_start_tpa->header_len,
@@ -1050,18 +1150,18 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                case ETH_RX_CQE_TYPE_TPA_CONT:
                        qede_rx_process_tpa_cont_cqe(qdev, rxq,
                                                     &cqe->fast_path_tpa_cont);
-                       continue;
+                       goto next_cqe;
                case ETH_RX_CQE_TYPE_TPA_END:
                        qede_rx_process_tpa_end_cqe(qdev, rxq,
                                                    &cqe->fast_path_tpa_end);
                        tpa_agg_idx = cqe->fast_path_tpa_end.tpa_agg_index;
-                       rx_mb = rxq->tpa_info[tpa_agg_idx].mbuf;
-                       PMD_RX_LOG(INFO, rxq, "TPA end reason %d\n",
-                                  cqe->fast_path_tpa_end.end_reason);
+                       tpa_info = &rxq->tpa_info[tpa_agg_idx];
+                       rx_mb = rxq->tpa_info[tpa_agg_idx].tpa_head;
                        goto tpa_end;
                case ETH_RX_CQE_TYPE_SLOW_PATH:
                        PMD_RX_LOG(INFO, rxq, "Got unexpected slowpath CQE\n");
-                       qdev->ops->eth_cqe_completion(edev, fp->id,
+                       ecore_eth_cqe_completion(
+                               &edev->hwfns[rxq->queue_id % edev->num_hwfns],
                                (struct eth_slow_path_rx_cqe *)cqe);
                        /* fall-thru */
                default:
@@ -1076,20 +1176,29 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                /* Handle regular CQE or TPA start CQE */
                if (!tpa_start_flg) {
                        parse_flag = rte_le_to_cpu_16(fp_cqe->pars_flags.flags);
-                       bitfield_val = fp_cqe->bitfields;
                        offset = fp_cqe->placement_offset;
                        len = rte_le_to_cpu_16(fp_cqe->len_on_first_bd);
                        pkt_len = rte_le_to_cpu_16(fp_cqe->pkt_len);
+                       vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag);
+                       rss_hash = rte_le_to_cpu_32(fp_cqe->rss_hash);
+#ifdef RTE_LIBRTE_QEDE_DEBUG_RX
+                       bitfield_val = fp_cqe->bitfields;
+                       htype = (uint8_t)GET_FIELD(bitfield_val,
+                                       ETH_FAST_PATH_RX_REG_CQE_RSS_HASH_TYPE);
+#endif
                } else {
                        parse_flag =
                            rte_le_to_cpu_16(cqe_start_tpa->pars_flags.flags);
-                       bitfield_val = cqe_start_tpa->bitfields;
                        offset = cqe_start_tpa->placement_offset;
                        /* seg_len = len_on_first_bd */
                        len = rte_le_to_cpu_16(cqe_start_tpa->len_on_first_bd);
-                       tpa_info->start_cqe_bd_len = len +
-                                               cqe_start_tpa->header_len;
-                       tpa_info->mbuf = rx_mb;
+                       vlan_tci = rte_le_to_cpu_16(cqe_start_tpa->vlan_tag);
+#ifdef RTE_LIBRTE_QEDE_DEBUG_RX
+                       bitfield_val = cqe_start_tpa->bitfields;
+                       htype = (uint8_t)GET_FIELD(bitfield_val,
+                               ETH_FAST_PATH_RX_TPA_START_CQE_RSS_HASH_TYPE);
+#endif
+                       rss_hash = rte_le_to_cpu_32(cqe_start_tpa->rss_hash);
                }
                if (qede_tunn_exist(parse_flag)) {
                        PMD_RX_LOG(INFO, rxq, "Rx tunneled packet\n");
@@ -1136,24 +1245,24 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                }
 
                if (CQE_HAS_VLAN(parse_flag)) {
-                       vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag);
                        ol_flags |= PKT_RX_VLAN_PKT;
+                       if (qdev->vlan_strip_flg) {
+                               ol_flags |= PKT_RX_VLAN_STRIPPED;
+                               rx_mb->vlan_tci = vlan_tci;
+                       }
                }
-
                if (CQE_HAS_OUTER_VLAN(parse_flag)) {
-                       vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag);
                        ol_flags |= PKT_RX_QINQ_PKT;
+                       if (qdev->vlan_strip_flg) {
+                               rx_mb->vlan_tci = vlan_tci;
+                               ol_flags |= PKT_RX_QINQ_STRIPPED;
+                       }
                        rx_mb->vlan_tci_outer = 0;
                }
-
                /* RSS Hash */
-               htype = (uint8_t)GET_FIELD(bitfield_val,
-                                       ETH_FAST_PATH_RX_REG_CQE_RSS_HASH_TYPE);
-               if (qdev->rss_enable && htype) {
+               if (qdev->rss_enable) {
                        ol_flags |= PKT_RX_RSS_HASH;
-                       rx_mb->hash.rss = rte_le_to_cpu_32(fp_cqe->rss_hash);
-                       PMD_RX_LOG(INFO, rxq, "Hash result 0x%x\n",
-                                  rx_mb->hash.rss);
+                       rx_mb->hash.rss = rss_hash;
                }
 
                if (unlikely(qede_alloc_rx_buffer(rxq) != 0)) {
@@ -1200,13 +1309,19 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                rx_mb->port = rxq->port_id;
                rx_mb->ol_flags = ol_flags;
                rx_mb->data_len = len;
-               rx_mb->vlan_tci = vlan_tci;
                rx_mb->packet_type = packet_type;
-               PMD_RX_LOG(INFO, rxq, "pkt_type %04x len %04x flags %04lx\n",
-                          packet_type, len, (unsigned long)ol_flags);
+               PMD_RX_LOG(INFO, rxq,
+                          "pkt_type 0x%04x len %u hash_type %d hash_val 0x%x"
+                          " ol_flags 0x%04lx\n",
+                          packet_type, len, htype, rx_mb->hash.rss,
+                          (unsigned long)ol_flags);
                if (!tpa_start_flg) {
                        rx_mb->nb_segs = fp_cqe->bd_num;
                        rx_mb->pkt_len = pkt_len;
+               } else {
+                       /* store ref to the updated mbuf */
+                       tpa_info->tpa_head = rx_mb;
+                       tpa_info->tpa_tail = tpa_info->tpa_head;
                }
                rte_prefetch1(rte_pktmbuf_mtod(rx_mb, void *));
 tpa_end:
@@ -1234,49 +1349,6 @@ next_cqe:
        return rx_pkt;
 }
 
-static inline void
-qede_free_tx_pkt(struct qede_tx_queue *txq)
-{
-       struct rte_mbuf *mbuf;
-       uint16_t nb_segs;
-       uint16_t idx;
-       uint8_t nbds;
-
-       idx = TX_CONS(txq);
-       mbuf = txq->sw_tx_ring[idx].mbuf;
-       if (mbuf) {
-               nb_segs = mbuf->nb_segs;
-               PMD_TX_LOG(DEBUG, txq, "nb_segs to free %u\n", nb_segs);
-               while (nb_segs) {
-                       /* It's like consuming rxbuf in recv() */
-                       ecore_chain_consume(&txq->tx_pbl);
-                       txq->nb_tx_avail++;
-                       nb_segs--;
-               }
-               rte_pktmbuf_free(mbuf);
-               txq->sw_tx_ring[idx].mbuf = NULL;
-               txq->sw_tx_cons++;
-               PMD_TX_LOG(DEBUG, txq, "Freed tx packet\n");
-       } else {
-               ecore_chain_consume(&txq->tx_pbl);
-               txq->nb_tx_avail++;
-       }
-}
-
-static inline void
-qede_process_tx_compl(struct ecore_dev *edev, struct qede_tx_queue *txq)
-{
-       uint16_t hw_bd_cons;
-       uint16_t sw_tx_cons;
-
-       rte_compiler_barrier();
-       hw_bd_cons = rte_le_to_cpu_16(*txq->hw_cons_ptr);
-       sw_tx_cons = ecore_chain_get_cons_idx(&txq->tx_pbl);
-       PMD_TX_LOG(DEBUG, txq, "Tx Completions = %u\n",
-                  abs(hw_bd_cons - sw_tx_cons));
-       while (hw_bd_cons !=  ecore_chain_get_cons_idx(&txq->tx_pbl))
-               qede_free_tx_pkt(txq);
-}
 
 /* Populate scatter gather buffer descriptor fields */
 static inline uint8_t
@@ -1338,7 +1410,7 @@ print_tx_bd_info(struct qede_tx_queue *txq,
 
        if (bd1)
                PMD_TX_LOG(INFO, txq,
-                          "BD1: nbytes=%u nbds=%u bd_flags=04%x bf=%04x",
+                          "BD1: nbytes=%u nbds=%u bd_flags=%04x bf=%04x",
                           rte_cpu_to_le_16(bd1->nbytes), bd1->data.nbds,
                           bd1->data.bd_flags.bitfields,
                           rte_cpu_to_le_16(bd1->data.bitfields));
@@ -1360,10 +1432,16 @@ print_tx_bd_info(struct qede_tx_queue *txq,
 
 /* TX prepare to check packets meets TX conditions */
 uint16_t
+#ifdef RTE_LIBRTE_QEDE_DEBUG_TX
 qede_xmit_prep_pkts(void *p_txq, struct rte_mbuf **tx_pkts,
                    uint16_t nb_pkts)
 {
        struct qede_tx_queue *txq = p_txq;
+#else
+qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,
+                   uint16_t nb_pkts)
+{
+#endif
        uint64_t ol_flags;
        struct rte_mbuf *m;
        uint16_t i;
@@ -1400,7 +1478,7 @@ qede_xmit_prep_pkts(void *p_txq, struct rte_mbuf **tx_pkts,
                        break;
                }
 #endif
-               /* TBD: pseudo csum calcuation required iff
+               /* TBD: pseudo csum calcuation required if
                 * ETH_TX_DATA_2ND_BD_L4_PSEUDO_CSUM_MODE not set?
                 */
                ret = rte_net_intel_cksum_prepare(m);
@@ -1410,9 +1488,11 @@ qede_xmit_prep_pkts(void *p_txq, struct rte_mbuf **tx_pkts,
                }
        }
 
+#ifdef RTE_LIBRTE_QEDE_DEBUG_TX
        if (unlikely(i != nb_pkts))
                PMD_TX_LOG(ERR, txq, "TX prepare failed for %u\n",
                           nb_pkts - i);
+#endif
        return i;
 }
 
@@ -1432,12 +1512,23 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
        uint8_t nbds;
        bool ipv6_ext_flg;
        bool lso_flg;
-       bool tunn_flg;
+       __rte_unused bool tunn_flg;
        struct eth_tx_1st_bd *bd1;
        struct eth_tx_2nd_bd *bd2;
        struct eth_tx_3rd_bd *bd3;
        uint64_t tx_ol_flags;
        uint16_t hdr_size;
+       /* BD1 */
+       uint16_t bd1_bf;
+       uint8_t bd1_bd_flags_bf;
+       uint16_t vlan;
+       /* BD2 */
+       uint16_t bd2_bf1;
+       uint16_t bd2_bf2;
+       /* BD3 */
+       uint16_t mss;
+       uint16_t bd3_bf;
+
 
        if (unlikely(txq->nb_tx_avail < txq->tx_free_thresh)) {
                PMD_TX_LOG(DEBUG, txq, "send=%u avail=%u free_thresh=%u",
@@ -1453,12 +1544,19 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
                tunn_flg = false;
                lso_flg = false;
                nbds = 0;
+               vlan = 0;
                bd1 = NULL;
                bd2 = NULL;
                bd3 = NULL;
                hdr_size = 0;
-
-               mbuf = *tx_pkts;
+               bd1_bf = 0;
+               bd1_bd_flags_bf = 0;
+               bd2_bf1 = 0;
+               bd2_bf2 = 0;
+               mss = 0;
+               bd3_bf = 0;
+
+               mbuf = *tx_pkts++;
                assert(mbuf);
 
                /* Check minimum TX BDS availability against available BDs */
@@ -1466,150 +1564,137 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
                        break;
 
                tx_ol_flags = mbuf->ol_flags;
+               bd1_bd_flags_bf |= 1 << ETH_TX_1ST_BD_FLAGS_START_BD_SHIFT;
 
 #define RTE_ETH_IS_IPV6_HDR_EXT(ptype) ((ptype) & RTE_PTYPE_L3_IPV6_EXT)
-               if (RTE_ETH_IS_IPV6_HDR_EXT(mbuf->packet_type))
+               if (RTE_ETH_IS_IPV6_HDR_EXT(mbuf->packet_type)) {
                        ipv6_ext_flg = true;
-
-               if (RTE_ETH_IS_TUNNEL_PKT(mbuf->packet_type))
-                       tunn_flg = true;
-
-               if (tx_ol_flags & PKT_TX_TCP_SEG)
-                       lso_flg = true;
-
-               if (lso_flg) {
-                       if (unlikely(txq->nb_tx_avail <
-                                               ETH_TX_MIN_BDS_PER_LSO_PKT))
-                               break;
-               } else {
-                       if (unlikely(txq->nb_tx_avail <
-                                       ETH_TX_MIN_BDS_PER_NON_LSO_PKT))
-                               break;
-               }
-
-               if (tunn_flg && ipv6_ext_flg) {
-                       if (unlikely(txq->nb_tx_avail <
-                               ETH_TX_MIN_BDS_PER_TUNN_IPV6_WITH_EXT_PKT))
-                               break;
-               }
-               if (ipv6_ext_flg) {
                        if (unlikely(txq->nb_tx_avail <
                                        ETH_TX_MIN_BDS_PER_IPV6_WITH_EXT_PKT))
                                break;
                }
 
-               /* Fill the entry in the SW ring and the BDs in the FW ring */
-               idx = TX_PROD(txq);
-               *tx_pkts++;
-               txq->sw_tx_ring[idx].mbuf = mbuf;
-
-               /* BD1 */
-               bd1 = (struct eth_tx_1st_bd *)ecore_chain_produce(&txq->tx_pbl);
-               memset(bd1, 0, sizeof(struct eth_tx_1st_bd));
-               nbds++;
-
-               bd1->data.bd_flags.bitfields |=
-                       1 << ETH_TX_1ST_BD_FLAGS_START_BD_SHIFT;
-               /* FW 8.10.x specific change */
-               if (!lso_flg) {
-                       bd1->data.bitfields |=
-                       (mbuf->pkt_len & ETH_TX_DATA_1ST_BD_PKT_LEN_MASK)
-                               << ETH_TX_DATA_1ST_BD_PKT_LEN_SHIFT;
-                       /* Map MBUF linear data for DMA and set in the BD1 */
-                       QEDE_BD_SET_ADDR_LEN(bd1, rte_mbuf_data_dma_addr(mbuf),
-                                            mbuf->data_len);
-               } else {
-                       /* For LSO, packet header and payload must reside on
-                        * buffers pointed by different BDs. Using BD1 for HDR
-                        * and BD2 onwards for data.
-                        */
-                       hdr_size = mbuf->l2_len + mbuf->l3_len + mbuf->l4_len;
-                       QEDE_BD_SET_ADDR_LEN(bd1, rte_mbuf_data_dma_addr(mbuf),
-                                            hdr_size);
-               }
-
-               if (tunn_flg) {
+               if (RTE_ETH_IS_TUNNEL_PKT(mbuf->packet_type)) {
+                       if (ipv6_ext_flg) {
+                               if (unlikely(txq->nb_tx_avail <
+                                   ETH_TX_MIN_BDS_PER_TUNN_IPV6_WITH_EXT_PKT))
+                                       break;
+                       }
+                       tunn_flg = true;
                        /* First indicate its a tunnel pkt */
-                       bd1->data.bd_flags.bitfields |=
-                               ETH_TX_DATA_1ST_BD_TUNN_FLAG_MASK <<
-                               ETH_TX_DATA_1ST_BD_TUNN_FLAG_SHIFT;
-
+                       bd1_bf |= ETH_TX_DATA_1ST_BD_TUNN_FLAG_MASK <<
+                                 ETH_TX_DATA_1ST_BD_TUNN_FLAG_SHIFT;
                        /* Legacy FW had flipped behavior in regard to this bit
                         * i.e. it needed to set to prevent FW from touching
                         * encapsulated packets when it didn't need to.
                         */
-                       if (unlikely(txq->is_legacy))
-                               bd1->data.bitfields ^=
-                                       1 << ETH_TX_DATA_1ST_BD_TUNN_FLAG_SHIFT;
-
+                       if (unlikely(txq->is_legacy)) {
+                               bd1_bf ^= 1 <<
+                                       ETH_TX_DATA_1ST_BD_TUNN_FLAG_SHIFT;
+                       }
                        /* Outer IP checksum offload */
                        if (tx_ol_flags & PKT_TX_OUTER_IP_CKSUM) {
-                               bd1->data.bd_flags.bitfields |=
+                               bd1_bd_flags_bf |=
                                        ETH_TX_1ST_BD_FLAGS_TUNN_IP_CSUM_MASK <<
                                        ETH_TX_1ST_BD_FLAGS_TUNN_IP_CSUM_SHIFT;
                        }
-
                        /* Outer UDP checksum offload */
-                       bd1->data.bd_flags.bitfields |=
+                       bd1_bd_flags_bf |=
                                ETH_TX_1ST_BD_FLAGS_TUNN_L4_CSUM_MASK <<
                                ETH_TX_1ST_BD_FLAGS_TUNN_L4_CSUM_SHIFT;
                }
 
+               if (tx_ol_flags & PKT_TX_TCP_SEG) {
+                       lso_flg = true;
+                       if (unlikely(txq->nb_tx_avail <
+                                               ETH_TX_MIN_BDS_PER_LSO_PKT))
+                               break;
+                       /* For LSO, packet header and payload must reside on
+                        * buffers pointed by different BDs. Using BD1 for HDR
+                        * and BD2 onwards for data.
+                        */
+                       hdr_size = mbuf->l2_len + mbuf->l3_len + mbuf->l4_len;
+                       bd1_bd_flags_bf |= 1 << ETH_TX_1ST_BD_FLAGS_LSO_SHIFT;
+                       bd1_bd_flags_bf |=
+                                       1 << ETH_TX_1ST_BD_FLAGS_IP_CSUM_SHIFT;
+                       /* PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM */
+                       bd1_bd_flags_bf |=
+                                       1 << ETH_TX_1ST_BD_FLAGS_L4_CSUM_SHIFT;
+                       mss = rte_cpu_to_le_16(mbuf->tso_segsz);
+                       /* Using one header BD */
+                       bd3_bf |= rte_cpu_to_le_16(1 <<
+                                       ETH_TX_DATA_3RD_BD_HDR_NBD_SHIFT);
+               } else {
+                       if (unlikely(txq->nb_tx_avail <
+                                       ETH_TX_MIN_BDS_PER_NON_LSO_PKT))
+                               break;
+                       bd1_bf |=
+                              (mbuf->pkt_len & ETH_TX_DATA_1ST_BD_PKT_LEN_MASK)
+                               << ETH_TX_DATA_1ST_BD_PKT_LEN_SHIFT;
+               }
+
                /* Descriptor based VLAN insertion */
                if (tx_ol_flags & (PKT_TX_VLAN_PKT | PKT_TX_QINQ_PKT)) {
-                       bd1->data.vlan = rte_cpu_to_le_16(mbuf->vlan_tci);
-                       bd1->data.bd_flags.bitfields |=
+                       vlan = rte_cpu_to_le_16(mbuf->vlan_tci);
+                       bd1_bd_flags_bf |=
                            1 << ETH_TX_1ST_BD_FLAGS_VLAN_INSERTION_SHIFT;
                }
 
-               if (lso_flg)
-                       bd1->data.bd_flags.bitfields |=
-                               1 << ETH_TX_1ST_BD_FLAGS_LSO_SHIFT;
-
                /* Offload the IP checksum in the hardware */
-               if ((lso_flg) || (tx_ol_flags & PKT_TX_IP_CKSUM))
-                       bd1->data.bd_flags.bitfields |=
-                           1 << ETH_TX_1ST_BD_FLAGS_IP_CSUM_SHIFT;
+               if (tx_ol_flags & PKT_TX_IP_CKSUM)
+                       bd1_bd_flags_bf |=
+                               1 << ETH_TX_1ST_BD_FLAGS_IP_CSUM_SHIFT;
 
                /* L4 checksum offload (tcp or udp) */
-               if ((lso_flg) || (tx_ol_flags & (PKT_TX_TCP_CKSUM |
-                                               PKT_TX_UDP_CKSUM)))
-                       /* PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM */
-                       bd1->data.bd_flags.bitfields |=
-                           1 << ETH_TX_1ST_BD_FLAGS_L4_CSUM_SHIFT;
+               if (tx_ol_flags & (PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM))
+                       bd1_bd_flags_bf |=
+                               1 << ETH_TX_1ST_BD_FLAGS_L4_CSUM_SHIFT;
+
+               if (ipv6_ext_flg) {
+                       /* TBD: check pseudo csum if tx_prepare not called? */
+                       bd2_bf1 |= ETH_L4_PSEUDO_CSUM_ZERO_LENGTH <<
+                               ETH_TX_DATA_2ND_BD_L4_PSEUDO_CSUM_MODE_SHIFT;
+               }
+
+               /* Fill the entry in the SW ring and the BDs in the FW ring */
+               idx = TX_PROD(txq);
+               txq->sw_tx_ring[idx].mbuf = mbuf;
+
+               /* BD1 */
+               bd1 = (struct eth_tx_1st_bd *)ecore_chain_produce(&txq->tx_pbl);
+               memset(bd1, 0, sizeof(struct eth_tx_1st_bd));
+               nbds++;
+
+               /* Map MBUF linear data for DMA and set in the BD1 */
+               QEDE_BD_SET_ADDR_LEN(bd1, rte_mbuf_data_dma_addr(mbuf),
+                                       mbuf->data_len);
+               bd1->data.bitfields = bd1_bf;
+               bd1->data.bd_flags.bitfields = bd1_bd_flags_bf;
+               bd1->data.vlan = vlan;
 
-               /* BD2 */
                if (lso_flg || ipv6_ext_flg) {
                        bd2 = (struct eth_tx_2nd_bd *)ecore_chain_produce
                                                        (&txq->tx_pbl);
                        memset(bd2, 0, sizeof(struct eth_tx_2nd_bd));
                        nbds++;
-                       QEDE_BD_SET_ADDR_LEN(bd2,
-                                           (hdr_size +
-                                           rte_mbuf_data_dma_addr(mbuf)),
-                                           mbuf->data_len - hdr_size);
-                       /* TBD: check pseudo csum iff tx_prepare not called? */
-                       if (ipv6_ext_flg) {
-                               bd2->data.bitfields1 |=
-                               ETH_L4_PSEUDO_CSUM_ZERO_LENGTH <<
-                               ETH_TX_DATA_2ND_BD_L4_PSEUDO_CSUM_MODE_SHIFT;
-                       }
-               }
 
-               /* BD3 */
-               if (lso_flg || ipv6_ext_flg) {
+                       /* BD1 */
+                       QEDE_BD_SET_ADDR_LEN(bd1, rte_mbuf_data_dma_addr(mbuf),
+                                            hdr_size);
+                       /* BD2 */
+                       QEDE_BD_SET_ADDR_LEN(bd2, (hdr_size +
+                                            rte_mbuf_data_dma_addr(mbuf)),
+                                            mbuf->data_len - hdr_size);
+                       bd2->data.bitfields1 = bd2_bf1;
+                       bd2->data.bitfields2 = bd2_bf2;
+
+                       /* BD3 */
                        bd3 = (struct eth_tx_3rd_bd *)ecore_chain_produce
                                                        (&txq->tx_pbl);
                        memset(bd3, 0, sizeof(struct eth_tx_3rd_bd));
                        nbds++;
-                       if (lso_flg) {
-                               bd3->data.lso_mss =
-                                       rte_cpu_to_le_16(mbuf->tso_segsz);
-                               /* Using one header BD */
-                               bd3->data.bitfields |=
-                                       rte_cpu_to_le_16(1 <<
-                                       ETH_TX_DATA_3RD_BD_HDR_NBD_SHIFT);
-                       }
+                       bd3->data.bitfields = bd3_bf;
+                       bd3->data.lso_mss = mss;
                }
 
                /* Handle fragmented MBUF */
@@ -1647,291 +1732,10 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
        return nb_pkt_sent;
 }
 
-static void qede_init_fp_queue(struct rte_eth_dev *eth_dev)
-{
-       struct qede_dev *qdev = eth_dev->data->dev_private;
-       struct qede_fastpath *fp;
-       uint8_t i, rss_id, txq_index, tc;
-       int rxq = 0, txq = 0;
-
-       for_each_queue(i) {
-               fp = &qdev->fp_array[i];
-               if (fp->type & QEDE_FASTPATH_RX) {
-                       fp->rxq = eth_dev->data->rx_queues[i];
-                       fp->rxq->queue_id = rxq++;
-               }
-
-               if (fp->type & QEDE_FASTPATH_TX) {
-                       for (tc = 0; tc < qdev->num_tc; tc++) {
-                               txq_index = tc * QEDE_TSS_COUNT(qdev) + txq;
-                               fp->txqs[tc] =
-                                       eth_dev->data->tx_queues[txq_index];
-                               fp->txqs[tc]->queue_id = txq_index;
-                               if (qdev->dev_info.is_legacy)
-                                       fp->txqs[tc]->is_legacy = true;
-                       }
-                       txq++;
-               }
-       }
-}
-
-int qede_dev_start(struct rte_eth_dev *eth_dev)
-{
-       struct qede_dev *qdev = eth_dev->data->dev_private;
-       struct ecore_dev *edev = &qdev->edev;
-       struct qed_link_output link_output;
-       struct qede_fastpath *fp;
-       int rc;
-
-       DP_INFO(edev, "Device state is %d\n", qdev->state);
-
-       if (qdev->state == QEDE_DEV_START) {
-               DP_INFO(edev, "Port is already started\n");
-               return 0;
-       }
-
-       if (qdev->state == QEDE_DEV_CONFIG)
-               qede_init_fp_queue(eth_dev);
-
-       rc = qede_start_queues(eth_dev, true);
-       if (rc) {
-               DP_ERR(edev, "Failed to start queues\n");
-               /* TBD: free */
-               return rc;
-       }
-
-       /* Newer SR-IOV PF driver expects RX/TX queues to be started before
-        * enabling RSS. Hence RSS configuration is deferred upto this point.
-        * Also, we would like to retain similar behavior in PF case, so we
-        * don't do PF/VF specific check here.
-        */
-       if (eth_dev->data->dev_conf.rxmode.mq_mode  == ETH_MQ_RX_RSS)
-               if (qede_config_rss(eth_dev))
-                       return -1;
-
-       /* Bring-up the link */
-       qede_dev_set_link_state(eth_dev, true);
-
-       /* Reset ring */
-       if (qede_reset_fp_rings(qdev))
-               return -ENOMEM;
-
-       /* Start/resume traffic */
-       qdev->ops->fastpath_start(edev);
-
-       qdev->state = QEDE_DEV_START;
-
-       DP_INFO(edev, "dev_state is QEDE_DEV_START\n");
-
-       return 0;
-}
-
-static int qede_drain_txq(struct qede_dev *qdev,
-                         struct qede_tx_queue *txq, bool allow_drain)
-{
-       struct ecore_dev *edev = &qdev->edev;
-       int rc, cnt = 1000;
-
-       while (txq->sw_tx_cons != txq->sw_tx_prod) {
-               qede_process_tx_compl(edev, txq);
-               if (!cnt) {
-                       if (allow_drain) {
-                               DP_ERR(edev, "Tx queue[%u] is stuck,"
-                                         "requesting MCP to drain\n",
-                                         txq->queue_id);
-                               rc = qdev->ops->common->drain(edev);
-                               if (rc)
-                                       return rc;
-                               return qede_drain_txq(qdev, txq, false);
-                       }
-                       DP_ERR(edev, "Timeout waiting for tx queue[%d]:"
-                                 "PROD=%d, CONS=%d\n",
-                                 txq->queue_id, txq->sw_tx_prod,
-                                 txq->sw_tx_cons);
-                       return -1;
-               }
-               cnt--;
-               DELAY(1000);
-               rte_compiler_barrier();
-       }
-
-       /* FW finished processing, wait for HW to transmit all tx packets */
-       DELAY(2000);
-
-       return 0;
-}
-
-static int qede_stop_queues(struct qede_dev *qdev)
-{
-       struct qed_update_vport_params vport_update_params;
-       struct ecore_dev *edev = &qdev->edev;
-       struct ecore_sge_tpa_params tpa_params;
-       struct qede_fastpath *fp;
-       int rc, tc, i;
-
-       /* Disable the vport */
-       memset(&vport_update_params, 0, sizeof(vport_update_params));
-       vport_update_params.vport_id = 0;
-       vport_update_params.update_vport_active_flg = 1;
-       vport_update_params.vport_active_flg = 0;
-       vport_update_params.update_rss_flg = 0;
-       /* Disable TPA */
-       if (qdev->enable_lro) {
-               DP_INFO(edev, "Disabling LRO\n");
-               memset(&tpa_params, 0, sizeof(struct ecore_sge_tpa_params));
-               qede_update_sge_tpa_params(&tpa_params, qdev->mtu, false);
-               vport_update_params.sge_tpa_params = &tpa_params;
-       }
-
-       DP_INFO(edev, "Deactivate vport\n");
-       rc = qdev->ops->vport_update(edev, &vport_update_params);
-       if (rc) {
-               DP_ERR(edev, "Failed to update vport\n");
-               return rc;
-       }
-
-       DP_INFO(edev, "Flushing tx queues\n");
-
-       /* Flush Tx queues. If needed, request drain from MCP */
-       for_each_queue(i) {
-               fp = &qdev->fp_array[i];
-
-               if (fp->type & QEDE_FASTPATH_TX) {
-                       for (tc = 0; tc < qdev->num_tc; tc++) {
-                               struct qede_tx_queue *txq = fp->txqs[tc];
-
-                               rc = qede_drain_txq(qdev, txq, true);
-                               if (rc)
-                                       return rc;
-                       }
-               }
-       }
-
-       /* Stop all Queues in reverse order */
-       for (i = QEDE_QUEUE_CNT(qdev) - 1; i >= 0; i--) {
-               fp = &qdev->fp_array[i];
-
-               /* Stop the Tx Queue(s) */
-               if (qdev->fp_array[i].type & QEDE_FASTPATH_TX) {
-                       for (tc = 0; tc < qdev->num_tc; tc++) {
-                               struct qede_tx_queue *txq = fp->txqs[tc];
-                               DP_INFO(edev, "Stopping tx queues\n");
-                               rc = qdev->ops->q_tx_stop(edev, i, txq->handle);
-                               if (rc) {
-                                       DP_ERR(edev, "Failed to stop TXQ #%d\n",
-                                              i);
-                                       return rc;
-                               }
-                       }
-               }
-
-               /* Stop the Rx Queue */
-               if (qdev->fp_array[i].type & QEDE_FASTPATH_RX) {
-                       DP_INFO(edev, "Stopping rx queues\n");
-                       rc = qdev->ops->q_rx_stop(edev, i, fp->rxq->handle);
-                       if (rc) {
-                               DP_ERR(edev, "Failed to stop RXQ #%d\n", i);
-                               return rc;
-                       }
-               }
-       }
-
-       return 0;
-}
-
-int qede_reset_fp_rings(struct qede_dev *qdev)
+uint16_t
+qede_rxtx_pkts_dummy(__rte_unused void *p_rxq,
+                    __rte_unused struct rte_mbuf **pkts,
+                    __rte_unused uint16_t nb_pkts)
 {
-       struct qede_fastpath *fp;
-       struct qede_tx_queue *txq;
-       uint8_t tc;
-       uint16_t id, i;
-
-       for_each_queue(id) {
-               fp = &qdev->fp_array[id];
-
-               if (fp->type & QEDE_FASTPATH_RX) {
-                       DP_INFO(&qdev->edev,
-                               "Reset FP chain for RSS %u\n", id);
-                       qede_rx_queue_release_mbufs(fp->rxq);
-                       ecore_chain_reset(&fp->rxq->rx_bd_ring);
-                       ecore_chain_reset(&fp->rxq->rx_comp_ring);
-                       fp->rxq->sw_rx_prod = 0;
-                       fp->rxq->sw_rx_cons = 0;
-                       *fp->rxq->hw_cons_ptr = 0;
-                       for (i = 0; i < fp->rxq->nb_rx_desc; i++) {
-                               if (qede_alloc_rx_buffer(fp->rxq)) {
-                                       DP_ERR(&qdev->edev,
-                                              "RX buffer allocation failed\n");
-                                       return -ENOMEM;
-                               }
-                       }
-               }
-               if (fp->type & QEDE_FASTPATH_TX) {
-                       for (tc = 0; tc < qdev->num_tc; tc++) {
-                               txq = fp->txqs[tc];
-                               qede_tx_queue_release_mbufs(txq);
-                               ecore_chain_reset(&txq->tx_pbl);
-                               txq->sw_tx_cons = 0;
-                               txq->sw_tx_prod = 0;
-                               *txq->hw_cons_ptr = 0;
-                       }
-               }
-       }
-
        return 0;
 }
-
-/* This function frees all memory of a single fp */
-void qede_free_mem_load(struct rte_eth_dev *eth_dev)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct qede_fastpath *fp;
-       uint16_t txq_idx;
-       uint8_t id;
-       uint8_t tc;
-
-       for_each_queue(id) {
-               fp = &qdev->fp_array[id];
-               if (fp->type & QEDE_FASTPATH_RX) {
-                       if (!fp->rxq)
-                               continue;
-                       qede_rx_queue_release(fp->rxq);
-                       eth_dev->data->rx_queues[id] = NULL;
-               } else {
-                       for (tc = 0; tc < qdev->num_tc; tc++) {
-                               if (!fp->txqs[tc])
-                                       continue;
-                               txq_idx = fp->txqs[tc]->queue_id;
-                               qede_tx_queue_release(fp->txqs[tc]);
-                               eth_dev->data->tx_queues[txq_idx] = NULL;
-                       }
-               }
-       }
-}
-
-void qede_dev_stop(struct rte_eth_dev *eth_dev)
-{
-       struct qede_dev *qdev = eth_dev->data->dev_private;
-       struct ecore_dev *edev = &qdev->edev;
-
-       DP_INFO(edev, "port %u\n", eth_dev->data->port_id);
-
-       if (qdev->state != QEDE_DEV_START) {
-               DP_INFO(edev, "Device not yet started\n");
-               return;
-       }
-
-       if (qede_stop_queues(qdev))
-               DP_ERR(edev, "Didn't succeed to close queues\n");
-
-       DP_INFO(edev, "Stopped queues\n");
-
-       qdev->ops->fastpath_stop(edev);
-
-       /* Bring the link down */
-       qede_dev_set_link_state(eth_dev, false);
-
-       qdev->state = QEDE_DEV_STOP;
-
-       DP_INFO(edev, "dev_state is QEDE_DEV_STOP\n");
-}