drivers/net: do not use private ethdev data
[dpdk.git] / drivers / net / ring / rte_eth_ring.c
index ada025f..e53823a 100644 (file)
@@ -1,56 +1,42 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2015 Intel Corporation
  */
 
 #include "rte_eth_ring.h"
 #include <rte_mbuf.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
 #include <rte_string_fns.h>
-#include <rte_dev.h>
+#include <rte_bus_vdev.h>
 #include <rte_kvargs.h>
+#include <rte_errno.h>
 
 #define ETH_RING_NUMA_NODE_ACTION_ARG  "nodeaction"
 #define ETH_RING_ACTION_CREATE         "CREATE"
 #define ETH_RING_ACTION_ATTACH         "ATTACH"
-
-static const char *ring_ethdev_driver_name = "Ring PMD";
+#define ETH_RING_INTERNAL_ARG          "internal"
 
 static const char *valid_arguments[] = {
        ETH_RING_NUMA_NODE_ACTION_ARG,
+       ETH_RING_INTERNAL_ARG,
        NULL
 };
 
+struct ring_internal_args {
+       struct rte_ring * const *rx_queues;
+       const unsigned int nb_rx_queues;
+       struct rte_ring * const *tx_queues;
+       const unsigned int nb_tx_queues;
+       const unsigned int numa_node;
+       void *addr; /* self addr for sanity check */
+};
+
+enum dev_action {
+       DEV_CREATE,
+       DEV_ATTACH
+};
+
 struct ring_queue {
        struct rte_ring *rng;
        rte_atomic64_t rx_pkts;
@@ -59,21 +45,22 @@ struct ring_queue {
 };
 
 struct pmd_internals {
-       unsigned nb_rx_queues;
-       unsigned nb_tx_queues;
+       unsigned max_rx_queues;
+       unsigned max_tx_queues;
 
        struct ring_queue rx_ring_queues[RTE_PMD_RING_MAX_RX_RINGS];
        struct ring_queue tx_ring_queues[RTE_PMD_RING_MAX_TX_RINGS];
 
        struct ether_addr address;
+       enum dev_action action;
 };
 
 
-static const char *drivername = "Rings PMD";
 static struct rte_eth_link pmd_link = {
-               .link_speed = 10000,
+               .link_speed = ETH_SPEED_NUM_10G,
                .link_duplex = ETH_LINK_FULL_DUPLEX,
-               .link_status = 0
+               .link_status = ETH_LINK_DOWN,
+               .link_autoneg = ETH_LINK_AUTONEG
 };
 
 static uint16_t
@@ -82,7 +69,7 @@ eth_ring_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
        void **ptrs = (void *)&bufs[0];
        struct ring_queue *r = q;
        const uint16_t nb_rx = (uint16_t)rte_ring_dequeue_burst(r->rng,
-                       ptrs, nb_bufs);
+                       ptrs, nb_bufs, NULL);
        if (r->rng->flags & RING_F_SC_DEQ)
                r->rx_pkts.cnt += nb_rx;
        else
@@ -96,7 +83,7 @@ eth_ring_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
        void **ptrs = (void *)&bufs[0];
        struct ring_queue *r = q;
        const uint16_t nb_tx = (uint16_t)rte_ring_enqueue_burst(r->rng,
-                       ptrs, nb_bufs);
+                       ptrs, nb_bufs, NULL);
        if (r->rng->flags & RING_F_SP_ENQ) {
                r->tx_pkts.cnt += nb_tx;
                r->err_pkts.cnt += nb_bufs - nb_tx;
@@ -113,32 +100,32 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) { return 0; }
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = 1;
+       dev->data->dev_link.link_status = ETH_LINK_UP;
        return 0;
 }
 
 static void
 eth_dev_stop(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = 0;
+       dev->data->dev_link.link_status = ETH_LINK_DOWN;
 }
 
 static int
 eth_dev_set_link_down(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = 0;
+       dev->data->dev_link.link_status = ETH_LINK_DOWN;
        return 0;
 }
 
 static int
 eth_dev_set_link_up(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = 1;
+       dev->data->dev_link.link_status = ETH_LINK_UP;
        return 0;
 }
 
 static int
-eth_rx_queue_setup(struct rte_eth_dev *dev,uint16_t rx_queue_id,
+eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
                                    uint16_t nb_rx_desc __rte_unused,
                                    unsigned int socket_id __rte_unused,
                                    const struct rte_eth_rxconf *rx_conf __rte_unused,
@@ -166,39 +153,39 @@ eth_dev_info(struct rte_eth_dev *dev,
                struct rte_eth_dev_info *dev_info)
 {
        struct pmd_internals *internals = dev->data->dev_private;
-       dev_info->driver_name = drivername;
        dev_info->max_mac_addrs = 1;
        dev_info->max_rx_pktlen = (uint32_t)-1;
-       dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues;
-       dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues;
+       dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;
+       dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues;
        dev_info->min_rx_bufsize = 0;
-       dev_info->pci_dev = NULL;
 }
 
-static void
-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
+static int
+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
        unsigned i;
        unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
        const struct pmd_internals *internal = dev->data->dev_private;
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
-                       i < internal->nb_rx_queues; i++) {
-               igb_stats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts.cnt;
-               rx_total += igb_stats->q_ipackets[i];
+                       i < dev->data->nb_rx_queues; i++) {
+               stats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts.cnt;
+               rx_total += stats->q_ipackets[i];
        }
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
-                       i < internal->nb_tx_queues; i++) {
-               igb_stats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;
-               igb_stats->q_errors[i] = internal->tx_ring_queues[i].err_pkts.cnt;
-               tx_total += igb_stats->q_opackets[i];
-               tx_err_total += igb_stats->q_errors[i];
+                       i < dev->data->nb_tx_queues; i++) {
+               stats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;
+               stats->q_errors[i] = internal->tx_ring_queues[i].err_pkts.cnt;
+               tx_total += stats->q_opackets[i];
+               tx_err_total += stats->q_errors[i];
        }
 
-       igb_stats->ipackets = rx_total;
-       igb_stats->opackets = tx_total;
-       igb_stats->oerrors = tx_err_total;
+       stats->ipackets = rx_total;
+       stats->opackets = tx_total;
+       stats->oerrors = tx_err_total;
+
+       return 0;
 }
 
 static void
@@ -206,9 +193,9 @@ eth_stats_reset(struct rte_eth_dev *dev)
 {
        unsigned i;
        struct pmd_internals *internal = dev->data->dev_private;
-       for (i = 0; i < internal->nb_rx_queues; i++)
+       for (i = 0; i < dev->data->nb_rx_queues; i++)
                internal->rx_ring_queues[i].rx_pkts.cnt = 0;
-       for (i = 0; i < internal->nb_tx_queues; i++) {
+       for (i = 0; i < dev->data->nb_tx_queues; i++) {
                internal->tx_ring_queues[i].tx_pkts.cnt = 0;
                internal->tx_ring_queues[i].err_pkts.cnt = 0;
        }
@@ -220,12 +207,13 @@ eth_mac_addr_remove(struct rte_eth_dev *dev __rte_unused,
 {
 }
 
-static void
+static int
 eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused,
        struct ether_addr *mac_addr __rte_unused,
        uint32_t index __rte_unused,
        uint32_t vmdq __rte_unused)
 {
+       return 0;
 }
 
 static void
@@ -252,200 +240,186 @@ static const struct eth_dev_ops ops = {
        .mac_addr_add = eth_mac_addr_add,
 };
 
-int
-rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
-               const unsigned nb_rx_queues,
-               struct rte_ring *const tx_queues[],
-               const unsigned nb_tx_queues,
-               const unsigned numa_node)
+static struct rte_vdev_driver pmd_ring_drv;
+
+static int
+do_eth_dev_ring_create(const char *name,
+               struct rte_ring * const rx_queues[], const unsigned nb_rx_queues,
+               struct rte_ring *const tx_queues[], const unsigned nb_tx_queues,
+               const unsigned int numa_node, enum dev_action action,
+               struct rte_eth_dev **eth_dev_p)
 {
        struct rte_eth_dev_data *data = NULL;
-       struct rte_pci_device *pci_dev = NULL;
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
-       struct eth_driver *eth_drv = NULL;
-       struct rte_pci_id *id_table = NULL;
-
+       void **rx_queues_local = NULL;
+       void **tx_queues_local = NULL;
        unsigned i;
 
-       /* do some parameter checking */
-       if (rx_queues == NULL && nb_rx_queues > 0)
-               goto error;
-       if (tx_queues == NULL && nb_tx_queues > 0)
-               goto error;
-
        RTE_LOG(INFO, PMD, "Creating rings-backed ethdev on numa socket %u\n",
                        numa_node);
 
-       /* now do all data allocation - for eth_dev structure, dummy pci driver
-        * and internal (private) data
-        */
-       data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);
-       if (data == NULL)
-               goto error;
-
-       pci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);
-       if (pci_dev == NULL)
+       rx_queues_local = rte_zmalloc_socket(name,
+                       sizeof(void *) * nb_rx_queues, 0, numa_node);
+       if (rx_queues_local == NULL) {
+               rte_errno = ENOMEM;
                goto error;
+       }
 
-       id_table = rte_zmalloc_socket(name, sizeof(*id_table), 0, numa_node);
-       if (id_table == NULL)
+       tx_queues_local = rte_zmalloc_socket(name,
+                       sizeof(void *) * nb_tx_queues, 0, numa_node);
+       if (tx_queues_local == NULL) {
+               rte_errno = ENOMEM;
                goto error;
+       }
 
        internals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);
-       if (internals == NULL)
+       if (internals == NULL) {
+               rte_errno = ENOMEM;
                goto error;
+       }
 
        /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocate(name, RTE_ETH_DEV_VIRTUAL);
-       if (eth_dev == NULL)
-               goto error;
-
-       eth_drv = rte_zmalloc_socket(name, sizeof(*eth_drv), 0, numa_node);
-       if (eth_drv == NULL)
+       eth_dev = rte_eth_dev_allocate(name);
+       if (eth_dev == NULL) {
+               rte_errno = ENOSPC;
                goto error;
+       }
 
        /* now put it all together
         * - store queue data in internals,
-        * - store numa_node info in pci_driver
-        * - point eth_dev_data to internals and pci_driver
+        * - store numa_node info in eth_dev_data
+        * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
-       /* NOTE: we'll replace the data element, of originally allocated eth_dev
-        * so the rings are local per-process */
 
-       internals->nb_rx_queues = nb_rx_queues;
-       internals->nb_tx_queues = nb_tx_queues;
+       data = eth_dev->data;
+       data->rx_queues = rx_queues_local;
+       data->tx_queues = tx_queues_local;
+
+       internals->action = action;
+       internals->max_rx_queues = nb_rx_queues;
+       internals->max_tx_queues = nb_tx_queues;
        for (i = 0; i < nb_rx_queues; i++) {
                internals->rx_ring_queues[i].rng = rx_queues[i];
+               data->rx_queues[i] = &internals->rx_ring_queues[i];
        }
        for (i = 0; i < nb_tx_queues; i++) {
                internals->tx_ring_queues[i].rng = tx_queues[i];
+               data->tx_queues[i] = &internals->tx_ring_queues[i];
        }
 
-       eth_drv->pci_drv.name = ring_ethdev_driver_name;
-       eth_drv->pci_drv.id_table = id_table;
-
-       pci_dev->numa_node = numa_node;
-       pci_dev->driver = &eth_drv->pci_drv;
-
        data->dev_private = internals;
-       data->port_id = eth_dev->data->port_id;
        data->nb_rx_queues = (uint16_t)nb_rx_queues;
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
        data->mac_addrs = &internals->address;
 
-       eth_dev->data = data;
-       eth_dev->driver = eth_drv;
        eth_dev->dev_ops = &ops;
-       eth_dev->pci_dev = pci_dev;
-       TAILQ_INIT(&(eth_dev->link_intr_cbs));
+       data->kdrv = RTE_KDRV_NONE;
+       data->numa_node = numa_node;
 
        /* finally assign rx and tx ops */
        eth_dev->rx_pkt_burst = eth_ring_rx;
        eth_dev->tx_pkt_burst = eth_ring_tx;
 
+       *eth_dev_p = eth_dev;
+
        return data->port_id;
 
 error:
-       rte_free(data);
-       rte_free(pci_dev);
+       rte_free(rx_queues_local);
+       rte_free(tx_queues_local);
        rte_free(internals);
 
        return -1;
 }
 
-enum dev_action{
-       DEV_CREATE,
-       DEV_ATTACH
-};
-
-static int
-eth_dev_ring_create(const char *name, const unsigned numa_node,
-               enum dev_action action)
+int
+rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
+               const unsigned nb_rx_queues,
+               struct rte_ring *const tx_queues[],
+               const unsigned nb_tx_queues,
+               const unsigned numa_node)
 {
-       /* rx and tx are so-called from point of view of first port.
-        * They are inverted from the point of view of second port
-        */
-       struct rte_ring *rxtx[RTE_PMD_RING_MAX_RX_RINGS];
-       unsigned i;
-       char rng_name[RTE_RING_NAMESIZE];
-       unsigned num_rings = RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS,
-                       RTE_PMD_RING_MAX_TX_RINGS);
+       struct ring_internal_args args = {
+               .rx_queues = rx_queues,
+               .nb_rx_queues = nb_rx_queues,
+               .tx_queues = tx_queues,
+               .nb_tx_queues = nb_tx_queues,
+               .numa_node = numa_node,
+               .addr = &args,
+       };
+       char args_str[32] = { 0 };
+       char ring_name[32] = { 0 };
+       uint16_t port_id = RTE_MAX_ETHPORTS;
+       int ret;
 
-       for (i = 0; i < num_rings; i++) {
-               snprintf(rng_name, sizeof(rng_name), "ETH_RXTX%u_%s", i, name);
-               rxtx[i] = (action == DEV_CREATE) ?
-                               rte_ring_create(rng_name, 1024, numa_node,
-                                               RING_F_SP_ENQ|RING_F_SC_DEQ) :
-                               rte_ring_lookup(rng_name);
-               if (rxtx[i] == NULL)
-                       return -1;
+       /* do some parameter checking */
+       if (rx_queues == NULL && nb_rx_queues > 0) {
+               rte_errno = EINVAL;
+               return -1;
+       }
+       if (tx_queues == NULL && nb_tx_queues > 0) {
+               rte_errno = EINVAL;
+               return -1;
+       }
+       if (nb_rx_queues > RTE_PMD_RING_MAX_RX_RINGS) {
+               rte_errno = EINVAL;
+               return -1;
        }
 
-       if (rte_eth_from_rings(name, rxtx, num_rings, rxtx, num_rings, numa_node) < 0)
+       snprintf(args_str, 32, "%s=%p", ETH_RING_INTERNAL_ARG, &args);
+       snprintf(ring_name, 32, "net_ring_%s", name);
+
+       ret = rte_vdev_init(ring_name, args_str);
+       if (ret) {
+               rte_errno = EINVAL;
                return -1;
+       }
 
-       return 0;
+       rte_eth_dev_get_port_by_name(ring_name, &port_id);
+
+       return port_id;
 }
 
+int
+rte_eth_from_ring(struct rte_ring *r)
+{
+       return rte_eth_from_rings(r->name, &r, 1, &r, 1,
+                       r->memzone ? r->memzone->socket_id : SOCKET_ID_ANY);
+}
 
 static int
-eth_dev_ring_pair_create(const char *name, const unsigned numa_node,
-               enum dev_action action)
+eth_dev_ring_create(const char *name, const unsigned numa_node,
+               enum dev_action action, struct rte_eth_dev **eth_dev)
 {
        /* rx and tx are so-called from point of view of first port.
         * They are inverted from the point of view of second port
         */
-       struct rte_ring *rx[RTE_PMD_RING_MAX_RX_RINGS];
-       struct rte_ring *tx[RTE_PMD_RING_MAX_TX_RINGS];
+       struct rte_ring *rxtx[RTE_PMD_RING_MAX_RX_RINGS];
        unsigned i;
-       char rx_rng_name[RTE_RING_NAMESIZE];
-       char tx_rng_name[RTE_RING_NAMESIZE];
+       char rng_name[RTE_RING_NAMESIZE];
        unsigned num_rings = RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS,
                        RTE_PMD_RING_MAX_TX_RINGS);
 
        for (i = 0; i < num_rings; i++) {
-               snprintf(rx_rng_name, sizeof(rx_rng_name), "ETH_RX%u_%s", i, name);
-               rx[i] = (action == DEV_CREATE) ?
-                               rte_ring_create(rx_rng_name, 1024, numa_node,
+               snprintf(rng_name, sizeof(rng_name), "ETH_RXTX%u_%s", i, name);
+               rxtx[i] = (action == DEV_CREATE) ?
+                               rte_ring_create(rng_name, 1024, numa_node,
                                                RING_F_SP_ENQ|RING_F_SC_DEQ) :
-                               rte_ring_lookup(rx_rng_name);
-               if (rx[i] == NULL)
-                       return -1;
-               snprintf(tx_rng_name, sizeof(tx_rng_name), "ETH_TX%u_%s", i, name);
-               tx[i] = (action == DEV_CREATE) ?
-                               rte_ring_create(tx_rng_name, 1024, numa_node,
-                                               RING_F_SP_ENQ|RING_F_SC_DEQ):
-                               rte_ring_lookup(tx_rng_name);
-               if (tx[i] == NULL)
+                               rte_ring_lookup(rng_name);
+               if (rxtx[i] == NULL)
                        return -1;
        }
 
-       if (rte_eth_from_rings(rx_rng_name, rx, num_rings, tx, num_rings,
-                               numa_node) < 0 ||
-                       rte_eth_from_rings(tx_rng_name, tx, num_rings, rx,
-                               num_rings, numa_node) < 0)
+       if (do_eth_dev_ring_create(name, rxtx, num_rings, rxtx, num_rings,
+               numa_node, action, eth_dev) < 0)
                return -1;
 
        return 0;
 }
 
-int
-rte_eth_ring_pair_create(const char *name, const unsigned numa_node)
-{
-       RTE_LOG(WARNING, PMD, "rte_eth_ring_pair_create is deprecated\n");
-       return eth_dev_ring_pair_create(name, numa_node, DEV_CREATE);
-}
-
-int
-rte_eth_ring_pair_attach(const char *name, const unsigned numa_node)
-{
-       RTE_LOG(WARNING, PMD, "rte_eth_ring_pair_attach is deprecated\n");
-       return eth_dev_ring_pair_create(name, numa_node, DEV_ATTACH);
-}
-
 struct node_action_pair {
        char name[PATH_MAX];
        unsigned node;
@@ -472,13 +446,14 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
        ret = -EINVAL;
 
        if (!name) {
-               RTE_LOG(WARNING, PMD, "command line paramter is empty for ring pmd!\n");
+               RTE_LOG(WARNING, PMD, "command line parameter is empty for ring pmd!\n");
                goto out;
        }
 
        node = strchr(name, ':');
        if (!node) {
-               RTE_LOG(WARNING, PMD, "could not parse node value from %s", name);
+               RTE_LOG(WARNING, PMD, "could not parse node value from %s\n",
+                       name);
                goto out;
        }
 
@@ -487,7 +462,8 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
 
        action = strchr(node, ':');
        if (!action) {
-               RTE_LOG(WARNING, PMD, "could not action value from %s", node);
+               RTE_LOG(WARNING, PMD, "could not parse action value from %s\n",
+                       node);
                goto out;
        }
 
@@ -524,28 +500,91 @@ out:
 }
 
 static int
-rte_pmd_ring_devinit(const char *name, const char *params)
+parse_internal_args(const char *key __rte_unused, const char *value,
+               void *data)
 {
+       struct ring_internal_args **internal_args = data;
+       void *args;
+
+       sscanf(value, "%p", &args);
+
+       *internal_args = args;
+
+       if ((*internal_args)->addr != args)
+               return -1;
+
+       return 0;
+}
+
+static int
+rte_pmd_ring_probe(struct rte_vdev_device *dev)
+{
+       const char *name, *params;
        struct rte_kvargs *kvlist = NULL;
        int ret = 0;
        struct node_action_list *info = NULL;
+       struct rte_eth_dev *eth_dev = NULL;
+       struct ring_internal_args *internal_args;
+
+       name = rte_vdev_device_name(dev);
+       params = rte_vdev_device_args(dev);
 
        RTE_LOG(INFO, PMD, "Initializing pmd_ring for %s\n", name);
 
-       if (params == NULL || params[0] == '\0')
-               eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE);
-       else {
+       if (params == NULL || params[0] == '\0') {
+               ret = eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE,
+                               &eth_dev);
+               if (ret == -1) {
+                       RTE_LOG(INFO, PMD,
+                               "Attach to pmd_ring for %s\n", name);
+                       ret = eth_dev_ring_create(name, rte_socket_id(),
+                                                 DEV_ATTACH, &eth_dev);
+               }
+       } else {
                kvlist = rte_kvargs_parse(params, valid_arguments);
 
                if (!kvlist) {
                        RTE_LOG(INFO, PMD, "Ignoring unsupported parameters when creating"
                                        " rings-backed ethernet device\n");
-                       eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE);
-                       return 0;
+                       ret = eth_dev_ring_create(name, rte_socket_id(),
+                                                 DEV_CREATE, &eth_dev);
+                       if (ret == -1) {
+                               RTE_LOG(INFO, PMD,
+                                       "Attach to pmd_ring for %s\n",
+                                       name);
+                               ret = eth_dev_ring_create(name, rte_socket_id(),
+                                                         DEV_ATTACH, &eth_dev);
+                       }
+
+                       if (eth_dev)
+                               eth_dev->device = &dev->device;
+
+                       return ret;
+               }
+
+               if (rte_kvargs_count(kvlist, ETH_RING_INTERNAL_ARG) == 1) {
+                       ret = rte_kvargs_process(kvlist, ETH_RING_INTERNAL_ARG,
+                                                parse_internal_args,
+                                                &internal_args);
+                       if (ret < 0)
+                               goto out_free;
+
+                       ret = do_eth_dev_ring_create(name,
+                               internal_args->rx_queues,
+                               internal_args->nb_rx_queues,
+                               internal_args->tx_queues,
+                               internal_args->nb_tx_queues,
+                               internal_args->numa_node,
+                               DEV_ATTACH,
+                               &eth_dev);
+                       if (ret >= 0)
+                               ret = 0;
                } else {
                        ret = rte_kvargs_count(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG);
-                       info = rte_zmalloc("struct node_action_list", sizeof(struct node_action_list) +
-                                          (sizeof(struct node_action_pair) * ret), 0);
+                       info = rte_zmalloc("struct node_action_list",
+                                          sizeof(struct node_action_list) +
+                                          (sizeof(struct node_action_pair) * ret),
+                                          0);
                        if (!info)
                                goto out_free;
 
@@ -559,22 +598,80 @@ rte_pmd_ring_devinit(const char *name, const char *params)
                                goto out_free;
 
                        for (info->count = 0; info->count < info->total; info->count++) {
-                               eth_dev_ring_create(name, info->list[info->count].node,
-                                                   info->list[info->count].action);
+                               ret = eth_dev_ring_create(info->list[info->count].name,
+                                                         info->list[info->count].node,
+                                                         info->list[info->count].action,
+                                                         &eth_dev);
+                               if ((ret == -1) &&
+                                   (info->list[info->count].action == DEV_CREATE)) {
+                                       RTE_LOG(INFO, PMD,
+                                               "Attach to pmd_ring for %s\n",
+                                               name);
+                                       ret = eth_dev_ring_create(name,
+                                                       info->list[info->count].node,
+                                                       DEV_ATTACH,
+                                                       &eth_dev);
+                               }
                        }
                }
        }
 
+       if (eth_dev)
+               eth_dev->device = &dev->device;
+
 out_free:
        rte_kvargs_free(kvlist);
        rte_free(info);
        return ret;
 }
 
-static struct rte_driver pmd_ring_drv = {
-       .name = "eth_ring",
-       .type = PMD_VDEV,
-       .init = rte_pmd_ring_devinit,
+static int
+rte_pmd_ring_remove(struct rte_vdev_device *dev)
+{
+       const char *name = rte_vdev_device_name(dev);
+       struct rte_eth_dev *eth_dev = NULL;
+       struct pmd_internals *internals = NULL;
+       struct ring_queue *r = NULL;
+       uint16_t i;
+
+       RTE_LOG(INFO, PMD, "Un-Initializing pmd_ring for %s\n", name);
+
+       if (name == NULL)
+               return -EINVAL;
+
+       /* find an ethdev entry */
+       eth_dev = rte_eth_dev_allocated(name);
+       if (eth_dev == NULL)
+               return -ENODEV;
+
+       eth_dev_stop(eth_dev);
+
+       internals = eth_dev->data->dev_private;
+       if (internals->action == DEV_CREATE) {
+               /*
+                * it is only necessary to delete the rings in rx_queues because
+                * they are the same used in tx_queues
+                */
+               for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
+                       r = eth_dev->data->rx_queues[i];
+                       rte_ring_free(r->rng);
+               }
+       }
+
+       rte_free(eth_dev->data->rx_queues);
+       rte_free(eth_dev->data->tx_queues);
+       rte_free(eth_dev->data->dev_private);
+
+       rte_eth_dev_release_port(eth_dev);
+       return 0;
+}
+
+static struct rte_vdev_driver pmd_ring_drv = {
+       .probe = rte_pmd_ring_probe,
+       .remove = rte_pmd_ring_remove,
 };
 
-PMD_REGISTER_DRIVER(pmd_ring_drv);
+RTE_PMD_REGISTER_VDEV(net_ring, pmd_ring_drv);
+RTE_PMD_REGISTER_ALIAS(net_ring, eth_ring);
+RTE_PMD_REGISTER_PARAM_STRING(net_ring,
+       ETH_RING_NUMA_NODE_ACTION_ARG "=name:node:action(ATTACH|CREATE)");