net/ngbe: support flow control
[dpdk.git] / drivers / net / sfc / sfc_repr_proxy.c
index a5be8fa..535b07e 100644 (file)
@@ -18,6 +18,7 @@
 #include "sfc_ev.h"
 #include "sfc_rx.h"
 #include "sfc_tx.h"
+#include "sfc_dp_rx.h"
 
 /**
  * Amount of time to wait for the representor proxy routine (which is
  */
 #define SFC_REPR_PROXY_MBOX_POLL_TIMEOUT_MS    1000
 
+/**
+ * Amount of time to wait for the representor proxy routine (which is
+ * running on a service core) to terminate after service core is stopped.
+ */
+#define SFC_REPR_PROXY_ROUTINE_TERMINATE_TIMEOUT_MS    10000
+
+#define SFC_REPR_INVALID_ROUTE_PORT_ID  (UINT16_MAX)
+
 static struct sfc_repr_proxy *
 sfc_repr_proxy_by_adapter(struct sfc_adapter *sa)
 {
@@ -53,6 +62,19 @@ sfc_put_adapter(struct sfc_adapter *sa)
        sfc_adapter_unlock(sa);
 }
 
+static struct sfc_repr_proxy_port *
+sfc_repr_proxy_find_port(struct sfc_repr_proxy *rp, uint16_t repr_id)
+{
+       struct sfc_repr_proxy_port *port;
+
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (port->repr_id == repr_id)
+                       return port;
+       }
+
+       return NULL;
+}
+
 static int
 sfc_repr_proxy_mbox_send(struct sfc_repr_proxy_mbox *mbox,
                         struct sfc_repr_proxy_port *port,
@@ -117,6 +139,12 @@ sfc_repr_proxy_mbox_handle(struct sfc_repr_proxy *rp)
        case SFC_REPR_PROXY_MBOX_DEL_PORT:
                TAILQ_REMOVE(&rp->ports, mbox->port, entries);
                break;
+       case SFC_REPR_PROXY_MBOX_START_PORT:
+               mbox->port->started = true;
+               break;
+       case SFC_REPR_PROXY_MBOX_STOP_PORT:
+               mbox->port->started = false;
+               break;
        default:
                SFC_ASSERT(0);
                return;
@@ -129,16 +157,181 @@ sfc_repr_proxy_mbox_handle(struct sfc_repr_proxy *rp)
        __atomic_store_n(&mbox->ack, true, __ATOMIC_RELEASE);
 }
 
+static void
+sfc_repr_proxy_handle_tx(struct sfc_repr_proxy_dp_txq *rp_txq,
+                        struct sfc_repr_proxy_txq *repr_txq)
+{
+       /*
+        * With multiple representor proxy queues configured it is
+        * possible that not all of the corresponding representor
+        * queues were created. Skip the queues that do not exist.
+        */
+       if (repr_txq->ring == NULL)
+               return;
+
+       if (rp_txq->available < RTE_DIM(rp_txq->tx_pkts)) {
+               rp_txq->available +=
+                       rte_ring_sc_dequeue_burst(repr_txq->ring,
+                               (void **)(&rp_txq->tx_pkts[rp_txq->available]),
+                               RTE_DIM(rp_txq->tx_pkts) - rp_txq->available,
+                               NULL);
+
+               if (rp_txq->available == rp_txq->transmitted)
+                       return;
+       }
+
+       rp_txq->transmitted += rp_txq->pkt_burst(rp_txq->dp,
+                               &rp_txq->tx_pkts[rp_txq->transmitted],
+                               rp_txq->available - rp_txq->transmitted);
+
+       if (rp_txq->available == rp_txq->transmitted) {
+               rp_txq->available = 0;
+               rp_txq->transmitted = 0;
+       }
+}
+
+static struct sfc_repr_proxy_port *
+sfc_repr_proxy_rx_route_mbuf(struct sfc_repr_proxy *rp, struct rte_mbuf *m)
+{
+       struct sfc_repr_proxy_port *port;
+       efx_mport_id_t mport_id;
+
+       mport_id.id = *RTE_MBUF_DYNFIELD(m, sfc_dp_mport_offset,
+                                        typeof(&((efx_mport_id_t *)0)->id));
+
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (port->egress_mport.id == mport_id.id) {
+                       m->port = port->rte_port_id;
+                       m->ol_flags &= ~sfc_dp_mport_override;
+                       return port;
+               }
+       }
+
+       return NULL;
+}
+
+/*
+ * Returns true if a packet is encountered which should be forwarded to a
+ * port which is different from the one that is currently routed.
+ */
+static bool
+sfc_repr_proxy_rx_route(struct sfc_repr_proxy *rp,
+                       struct sfc_repr_proxy_dp_rxq *rp_rxq)
+{
+       unsigned int i;
+
+       for (i = rp_rxq->routed;
+            i < rp_rxq->available && !rp_rxq->stop_route;
+            i++, rp_rxq->routed++) {
+               struct sfc_repr_proxy_port *port;
+               struct rte_mbuf *m = rp_rxq->pkts[i];
+
+               port = sfc_repr_proxy_rx_route_mbuf(rp, m);
+               /* Cannot find destination representor */
+               if (port == NULL) {
+                       /* Effectively drop the packet */
+                       rp_rxq->forwarded++;
+                       continue;
+               }
+
+               /* Currently routed packets are mapped to a different port */
+               if (port->repr_id != rp_rxq->route_port_id &&
+                   rp_rxq->route_port_id != SFC_REPR_INVALID_ROUTE_PORT_ID)
+                       return true;
+
+               rp_rxq->route_port_id = port->repr_id;
+       }
+
+       return false;
+}
+
+static void
+sfc_repr_proxy_rx_forward(struct sfc_repr_proxy *rp,
+                         struct sfc_repr_proxy_dp_rxq *rp_rxq)
+{
+       struct sfc_repr_proxy_port *port;
+
+       if (rp_rxq->route_port_id != SFC_REPR_INVALID_ROUTE_PORT_ID) {
+               port = sfc_repr_proxy_find_port(rp, rp_rxq->route_port_id);
+
+               if (port != NULL && port->started) {
+                       rp_rxq->forwarded +=
+                           rte_ring_sp_enqueue_burst(port->rxq[0].ring,
+                               (void **)(&rp_rxq->pkts[rp_rxq->forwarded]),
+                               rp_rxq->routed - rp_rxq->forwarded, NULL);
+               } else {
+                       /* Drop all routed packets if the port is not started */
+                       rp_rxq->forwarded = rp_rxq->routed;
+               }
+       }
+
+       if (rp_rxq->forwarded == rp_rxq->routed) {
+               rp_rxq->route_port_id = SFC_REPR_INVALID_ROUTE_PORT_ID;
+               rp_rxq->stop_route = false;
+       } else {
+               /* Stall packet routing if not all packets were forwarded */
+               rp_rxq->stop_route = true;
+       }
+
+       if (rp_rxq->available == rp_rxq->forwarded)
+               rp_rxq->available = rp_rxq->forwarded = rp_rxq->routed = 0;
+}
+
+static void
+sfc_repr_proxy_handle_rx(struct sfc_repr_proxy *rp,
+                        struct sfc_repr_proxy_dp_rxq *rp_rxq)
+{
+       bool route_again;
+
+       if (rp_rxq->available < RTE_DIM(rp_rxq->pkts)) {
+               rp_rxq->available += rp_rxq->pkt_burst(rp_rxq->dp,
+                               &rp_rxq->pkts[rp_rxq->available],
+                               RTE_DIM(rp_rxq->pkts) - rp_rxq->available);
+               if (rp_rxq->available == rp_rxq->forwarded)
+                       return;
+       }
+
+       do {
+               route_again = sfc_repr_proxy_rx_route(rp, rp_rxq);
+               sfc_repr_proxy_rx_forward(rp, rp_rxq);
+       } while (route_again && !rp_rxq->stop_route);
+}
+
 static int32_t
 sfc_repr_proxy_routine(void *arg)
 {
+       struct sfc_repr_proxy_port *port;
        struct sfc_repr_proxy *rp = arg;
+       unsigned int i;
 
        sfc_repr_proxy_mbox_handle(rp);
 
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (!port->started)
+                       continue;
+
+               for (i = 0; i < rp->nb_txq; i++)
+                       sfc_repr_proxy_handle_tx(&rp->dp_txq[i], &port->txq[i]);
+       }
+
+       for (i = 0; i < rp->nb_rxq; i++)
+               sfc_repr_proxy_handle_rx(rp, &rp->dp_rxq[i]);
+
        return 0;
 }
 
+static struct sfc_txq_info *
+sfc_repr_proxy_txq_info_get(struct sfc_adapter *sa, unsigned int repr_queue_id)
+{
+       struct sfc_adapter_shared *sas = sfc_sa2shared(sa);
+       struct sfc_repr_proxy_dp_txq *dp_txq;
+
+       SFC_ASSERT(repr_queue_id < sfc_repr_nb_txq(sas));
+       dp_txq = &sa->repr_proxy.dp_txq[repr_queue_id];
+
+       return &sas->txq_info[dp_txq->sw_index];
+}
+
 static int
 sfc_repr_proxy_txq_attach(struct sfc_adapter *sa)
 {
@@ -270,11 +463,20 @@ sfc_repr_proxy_txq_fini(struct sfc_adapter *sa)
 static int
 sfc_repr_proxy_txq_start(struct sfc_adapter *sa)
 {
+       struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
        struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       unsigned int i;
 
        sfc_log_init(sa, "entry");
 
-       RTE_SET_USED(rp);
+       for (i = 0; i < sfc_repr_nb_txq(sas); i++) {
+               struct sfc_repr_proxy_dp_txq *txq = &rp->dp_txq[i];
+
+               txq->dp = sfc_repr_proxy_txq_info_get(sa, i)->dp;
+               txq->pkt_burst = sa->eth_dev->tx_pkt_burst;
+               txq->available = 0;
+               txq->transmitted = 0;
+       }
 
        sfc_log_init(sa, "done");
 
@@ -323,6 +525,18 @@ sfc_repr_proxy_rxq_detach(struct sfc_adapter *sa)
        sfc_log_init(sa, "done");
 }
 
+static struct sfc_rxq_info *
+sfc_repr_proxy_rxq_info_get(struct sfc_adapter *sa, unsigned int repr_queue_id)
+{
+       struct sfc_adapter_shared *sas = sfc_sa2shared(sa);
+       struct sfc_repr_proxy_dp_rxq *dp_rxq;
+
+       SFC_ASSERT(repr_queue_id < sfc_repr_nb_rxq(sas));
+       dp_rxq = &sa->repr_proxy.dp_rxq[repr_queue_id];
+
+       return &sas->rxq_info[dp_rxq->sw_index];
+}
+
 static int
 sfc_repr_proxy_rxq_init(struct sfc_adapter *sa,
                        struct sfc_repr_proxy_dp_rxq *rxq)
@@ -450,6 +664,14 @@ sfc_repr_proxy_rxq_start(struct sfc_adapter *sa)
                                i);
                        goto fail_start;
                }
+
+               rxq->dp = sfc_repr_proxy_rxq_info_get(sa, i)->dp;
+               rxq->pkt_burst = sa->eth_dev->rx_pkt_burst;
+               rxq->available = 0;
+               rxq->routed = 0;
+               rxq->forwarded = 0;
+               rxq->stop_route = false;
+               rxq->route_port_id = SFC_REPR_INVALID_ROUTE_PORT_ID;
        }
 
        sfc_log_init(sa, "done");
@@ -463,6 +685,158 @@ fail_init:
        return rc;
 }
 
+static int
+sfc_repr_proxy_mae_rule_insert(struct sfc_adapter *sa,
+                              struct sfc_repr_proxy_port *port)
+{
+       struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       efx_mport_sel_t mport_alias_selector;
+       efx_mport_sel_t mport_vf_selector;
+       struct sfc_mae_rule *mae_rule;
+       int rc;
+
+       sfc_log_init(sa, "entry");
+
+       rc = efx_mae_mport_by_id(&port->egress_mport,
+                                &mport_vf_selector);
+       if (rc != 0) {
+               sfc_err(sa, "failed to get VF mport for repr %u",
+                       port->repr_id);
+               goto fail_get_vf;
+       }
+
+       rc = efx_mae_mport_by_id(&rp->mport_alias, &mport_alias_selector);
+       if (rc != 0) {
+               sfc_err(sa, "failed to get mport selector for repr %u",
+                       port->repr_id);
+               goto fail_get_alias;
+       }
+
+       rc = sfc_mae_rule_add_mport_match_deliver(sa, &mport_vf_selector,
+                                                 &mport_alias_selector, -1,
+                                                 &mae_rule);
+       if (rc != 0) {
+               sfc_err(sa, "failed to insert MAE rule for repr %u",
+                       port->repr_id);
+               goto fail_rule_add;
+       }
+
+       port->mae_rule = mae_rule;
+
+       sfc_log_init(sa, "done");
+
+       return 0;
+
+fail_rule_add:
+fail_get_alias:
+fail_get_vf:
+       sfc_log_init(sa, "failed: %s", rte_strerror(rc));
+       return rc;
+}
+
+static void
+sfc_repr_proxy_mae_rule_remove(struct sfc_adapter *sa,
+                              struct sfc_repr_proxy_port *port)
+{
+       struct sfc_mae_rule *mae_rule = port->mae_rule;
+
+       sfc_mae_rule_del(sa, mae_rule);
+}
+
+static int
+sfc_repr_proxy_mport_filter_insert(struct sfc_adapter *sa)
+{
+       struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
+       struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       struct sfc_rxq *rxq_ctrl;
+       struct sfc_repr_proxy_filter *filter = &rp->mport_filter;
+       efx_mport_sel_t mport_alias_selector;
+       static const efx_filter_match_flags_t flags[RTE_DIM(filter->specs)] = {
+               EFX_FILTER_MATCH_UNKNOWN_UCAST_DST,
+               EFX_FILTER_MATCH_UNKNOWN_MCAST_DST };
+       unsigned int i;
+       int rc;
+
+       sfc_log_init(sa, "entry");
+
+       if (sfc_repr_nb_rxq(sas) == 1) {
+               rxq_ctrl = &sa->rxq_ctrl[rp->dp_rxq[0].sw_index];
+       } else {
+               sfc_err(sa, "multiple representor proxy RxQs not supported");
+               rc = ENOTSUP;
+               goto fail_multiple_queues;
+       }
+
+       rc = efx_mae_mport_by_id(&rp->mport_alias, &mport_alias_selector);
+       if (rc != 0) {
+               sfc_err(sa, "failed to get repr proxy mport by ID");
+               goto fail_get_selector;
+       }
+
+       memset(filter->specs, 0, sizeof(filter->specs));
+       for (i = 0; i < RTE_DIM(filter->specs); i++) {
+               filter->specs[i].efs_priority = EFX_FILTER_PRI_MANUAL;
+               filter->specs[i].efs_flags = EFX_FILTER_FLAG_RX;
+               filter->specs[i].efs_dmaq_id = rxq_ctrl->hw_index;
+               filter->specs[i].efs_match_flags = flags[i] |
+                               EFX_FILTER_MATCH_MPORT;
+               filter->specs[i].efs_ingress_mport = mport_alias_selector.sel;
+
+               rc = efx_filter_insert(sa->nic, &filter->specs[i]);
+               if (rc != 0) {
+                       sfc_err(sa, "failed to insert repr proxy filter");
+                       goto fail_insert;
+               }
+       }
+
+       sfc_log_init(sa, "done");
+
+       return 0;
+
+fail_insert:
+       while (i-- > 0)
+               efx_filter_remove(sa->nic, &filter->specs[i]);
+
+fail_get_selector:
+fail_multiple_queues:
+       sfc_log_init(sa, "failed: %s", rte_strerror(rc));
+       return rc;
+}
+
+static void
+sfc_repr_proxy_mport_filter_remove(struct sfc_adapter *sa)
+{
+       struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       struct sfc_repr_proxy_filter *filter = &rp->mport_filter;
+       unsigned int i;
+
+       for (i = 0; i < RTE_DIM(filter->specs); i++)
+               efx_filter_remove(sa->nic, &filter->specs[i]);
+}
+
+static int
+sfc_repr_proxy_port_rule_insert(struct sfc_adapter *sa,
+                               struct sfc_repr_proxy_port *port)
+{
+       int rc;
+
+       rc = sfc_repr_proxy_mae_rule_insert(sa, port);
+       if (rc != 0)
+               goto fail_mae_rule_insert;
+
+       return 0;
+
+fail_mae_rule_insert:
+       return rc;
+}
+
+static void
+sfc_repr_proxy_port_rule_remove(struct sfc_adapter *sa,
+                               struct sfc_repr_proxy_port *port)
+{
+       sfc_repr_proxy_mae_rule_remove(sa, port);
+}
+
 static int
 sfc_repr_proxy_ports_init(struct sfc_adapter *sa)
 {
@@ -644,24 +1018,105 @@ sfc_repr_proxy_detach(struct sfc_adapter *sa)
        sfc_log_init(sa, "done");
 }
 
+static int
+sfc_repr_proxy_do_start_port(struct sfc_adapter *sa,
+                          struct sfc_repr_proxy_port *port)
+{
+       struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       int rc;
+
+       rc = sfc_repr_proxy_port_rule_insert(sa, port);
+       if (rc != 0)
+               goto fail_filter_insert;
+
+       if (rp->started) {
+               rc = sfc_repr_proxy_mbox_send(&rp->mbox, port,
+                                             SFC_REPR_PROXY_MBOX_START_PORT);
+               if (rc != 0) {
+                       sfc_err(sa, "failed to start proxy port %u",
+                               port->repr_id);
+                       goto fail_port_start;
+               }
+       } else {
+               port->started = true;
+       }
+
+       return 0;
+
+fail_port_start:
+       sfc_repr_proxy_port_rule_remove(sa, port);
+fail_filter_insert:
+       sfc_err(sa, "%s() failed %s", __func__, rte_strerror(rc));
+
+       return rc;
+}
+
+static int
+sfc_repr_proxy_do_stop_port(struct sfc_adapter *sa,
+                         struct sfc_repr_proxy_port *port)
+
+{
+       struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       int rc;
+
+       if (rp->started) {
+               rc = sfc_repr_proxy_mbox_send(&rp->mbox, port,
+                                             SFC_REPR_PROXY_MBOX_STOP_PORT);
+               if (rc != 0) {
+                       sfc_err(sa, "failed to stop proxy port %u: %s",
+                               port->repr_id, rte_strerror(rc));
+                       return rc;
+               }
+       } else {
+               port->started = false;
+       }
+
+       sfc_repr_proxy_port_rule_remove(sa, port);
+
+       return 0;
+}
+
+static bool
+sfc_repr_proxy_port_enabled(struct sfc_repr_proxy_port *port)
+{
+       return port->rte_port_id != RTE_MAX_ETHPORTS && port->enabled;
+}
+
+static bool
+sfc_repr_proxy_ports_disabled(struct sfc_repr_proxy *rp)
+{
+       struct sfc_repr_proxy_port *port;
+
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (sfc_repr_proxy_port_enabled(port))
+                       return false;
+       }
+
+       return true;
+}
+
 int
 sfc_repr_proxy_start(struct sfc_adapter *sa)
 {
        struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
        struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       struct sfc_repr_proxy_port *last_port = NULL;
+       struct sfc_repr_proxy_port *port;
        int rc;
 
        sfc_log_init(sa, "entry");
 
-       /*
-        * The condition to start the proxy is insufficient. It will be
-        * complemented with representor port start/stop support.
-        */
+       /* Representor proxy is not started when no representors are started */
        if (!sfc_repr_available(sas)) {
                sfc_log_init(sa, "representors not supported - skip");
                return 0;
        }
 
+       if (sfc_repr_proxy_ports_disabled(rp)) {
+               sfc_log_init(sa, "no started representor ports - skip");
+               return 0;
+       }
+
        rc = sfc_repr_proxy_rxq_start(sa);
        if (rc != 0)
                goto fail_rxq_start;
@@ -670,6 +1125,9 @@ sfc_repr_proxy_start(struct sfc_adapter *sa)
        if (rc != 0)
                goto fail_txq_start;
 
+       rp->nb_txq = sfc_repr_nb_txq(sas);
+       rp->nb_rxq = sfc_repr_nb_rxq(sas);
+
        /* Service core may be in "stopped" state, start it */
        rc = rte_service_lcore_start(rp->service_core_id);
        if (rc != 0 && rc != -EALREADY) {
@@ -698,12 +1156,40 @@ sfc_repr_proxy_start(struct sfc_adapter *sa)
                goto fail_runstate_set;
        }
 
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (sfc_repr_proxy_port_enabled(port)) {
+                       rc = sfc_repr_proxy_do_start_port(sa, port);
+                       if (rc != 0)
+                               goto fail_start_id;
+
+                       last_port = port;
+               }
+       }
+
+       rc = sfc_repr_proxy_mport_filter_insert(sa);
+       if (rc != 0)
+               goto fail_mport_filter_insert;
+
        rp->started = true;
 
        sfc_log_init(sa, "done");
 
        return 0;
 
+fail_mport_filter_insert:
+fail_start_id:
+       if (last_port != NULL) {
+               TAILQ_FOREACH(port, &rp->ports, entries) {
+                       if (sfc_repr_proxy_port_enabled(port)) {
+                               (void)sfc_repr_proxy_do_stop_port(sa, port);
+                               if (port == last_port)
+                                       break;
+                       }
+               }
+       }
+
+       rte_service_runstate_set(rp->service_id, 0);
+
 fail_runstate_set:
        rte_service_component_runstate_set(rp->service_id, 0);
 
@@ -726,6 +1212,10 @@ sfc_repr_proxy_stop(struct sfc_adapter *sa)
 {
        struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
        struct sfc_repr_proxy *rp = &sa->repr_proxy;
+       struct sfc_repr_proxy_port *port;
+       const unsigned int wait_ms_total =
+               SFC_REPR_PROXY_ROUTINE_TERMINATE_TIMEOUT_MS;
+       unsigned int i;
        int rc;
 
        sfc_log_init(sa, "entry");
@@ -735,6 +1225,24 @@ sfc_repr_proxy_stop(struct sfc_adapter *sa)
                return;
        }
 
+       if (sfc_repr_proxy_ports_disabled(rp)) {
+               sfc_log_init(sa, "no started representor ports - skip");
+               return;
+       }
+
+       TAILQ_FOREACH(port, &rp->ports, entries) {
+               if (sfc_repr_proxy_port_enabled(port)) {
+                       rc = sfc_repr_proxy_do_stop_port(sa, port);
+                       if (rc != 0) {
+                               sfc_err(sa,
+                                       "failed to stop representor proxy port %u: %s",
+                                       port->repr_id, rte_strerror(rc));
+                       }
+               }
+       }
+
+       sfc_repr_proxy_mport_filter_remove(sa);
+
        rc = rte_service_runstate_set(rp->service_id, 0);
        if (rc < 0) {
                sfc_err(sa, "failed to stop %s: %s",
@@ -751,6 +1259,17 @@ sfc_repr_proxy_stop(struct sfc_adapter *sa)
 
        /* Service lcore may be shared and we never stop it */
 
+       /*
+        * Wait for the representor proxy routine to finish the last iteration.
+        * Give up on timeout.
+        */
+       for (i = 0; i < wait_ms_total; i++) {
+               if (rte_service_may_be_active(rp->service_id) == 0)
+                       break;
+
+               rte_delay_ms(1);
+       }
+
        sfc_repr_proxy_rxq_stop(sa);
        sfc_repr_proxy_txq_stop(sa);
 
@@ -759,19 +1278,6 @@ sfc_repr_proxy_stop(struct sfc_adapter *sa)
        sfc_log_init(sa, "done");
 }
 
-static struct sfc_repr_proxy_port *
-sfc_repr_proxy_find_port(struct sfc_repr_proxy *rp, uint16_t repr_id)
-{
-       struct sfc_repr_proxy_port *port;
-
-       TAILQ_FOREACH(port, &rp->ports, entries) {
-               if (port->repr_id == repr_id)
-                       return port;
-       }
-
-       return NULL;
-}
-
 int
 sfc_repr_proxy_add_port(uint16_t pf_port_id, uint16_t repr_id,
                        uint16_t rte_port_id, const efx_mport_sel_t *mport_sel)
@@ -1020,3 +1526,136 @@ sfc_repr_proxy_del_txq(uint16_t pf_port_id, uint16_t repr_id,
        sfc_log_init(sa, "done");
        sfc_put_adapter(sa);
 }
+
+int
+sfc_repr_proxy_start_repr(uint16_t pf_port_id, uint16_t repr_id)
+{
+       bool proxy_start_required = false;
+       struct sfc_repr_proxy_port *port;
+       struct sfc_repr_proxy *rp;
+       struct sfc_adapter *sa;
+       int rc;
+
+       sa = sfc_get_adapter_by_pf_port_id(pf_port_id);
+       rp = sfc_repr_proxy_by_adapter(sa);
+
+       sfc_log_init(sa, "entry");
+
+       port = sfc_repr_proxy_find_port(rp, repr_id);
+       if (port == NULL) {
+               sfc_err(sa, "%s() failed: no such port", __func__);
+               rc = ENOENT;
+               goto fail_not_found;
+       }
+
+       if (port->enabled) {
+               rc = EALREADY;
+               sfc_err(sa, "failed: repr %u proxy port already started",
+                       repr_id);
+               goto fail_already_started;
+       }
+
+       if (sa->state == SFC_ETHDEV_STARTED) {
+               if (sfc_repr_proxy_ports_disabled(rp)) {
+                       proxy_start_required = true;
+               } else {
+                       rc = sfc_repr_proxy_do_start_port(sa, port);
+                       if (rc != 0) {
+                               sfc_err(sa,
+                                       "failed to start repr %u proxy port",
+                                       repr_id);
+                               goto fail_start_id;
+                       }
+               }
+       }
+
+       port->enabled = true;
+
+       if (proxy_start_required) {
+               rc = sfc_repr_proxy_start(sa);
+               if (rc != 0) {
+                       sfc_err(sa, "failed to start proxy");
+                       goto fail_proxy_start;
+               }
+       }
+
+       sfc_log_init(sa, "done");
+       sfc_put_adapter(sa);
+
+       return 0;
+
+fail_proxy_start:
+       port->enabled = false;
+
+fail_start_id:
+fail_already_started:
+fail_not_found:
+       sfc_err(sa, "failed to start repr %u proxy port: %s", repr_id,
+               rte_strerror(rc));
+       sfc_put_adapter(sa);
+
+       return rc;
+}
+
+int
+sfc_repr_proxy_stop_repr(uint16_t pf_port_id, uint16_t repr_id)
+{
+       struct sfc_repr_proxy_port *port;
+       struct sfc_repr_proxy_port *p;
+       struct sfc_repr_proxy *rp;
+       struct sfc_adapter *sa;
+       int rc;
+
+       sa = sfc_get_adapter_by_pf_port_id(pf_port_id);
+       rp = sfc_repr_proxy_by_adapter(sa);
+
+       sfc_log_init(sa, "entry");
+
+       port = sfc_repr_proxy_find_port(rp, repr_id);
+       if (port == NULL) {
+               sfc_err(sa, "%s() failed: no such port", __func__);
+               return ENOENT;
+       }
+
+       if (!port->enabled) {
+               sfc_log_init(sa, "repr %u proxy port is not started - skip",
+                            repr_id);
+               sfc_put_adapter(sa);
+               return 0;
+       }
+
+       if (sa->state == SFC_ETHDEV_STARTED) {
+               bool last_enabled = true;
+
+               TAILQ_FOREACH(p, &rp->ports, entries) {
+                       if (p == port)
+                               continue;
+
+                       if (sfc_repr_proxy_port_enabled(p)) {
+                               last_enabled = false;
+                               break;
+                       }
+               }
+
+               rc = 0;
+               if (last_enabled)
+                       sfc_repr_proxy_stop(sa);
+               else
+                       rc = sfc_repr_proxy_do_stop_port(sa, port);
+
+               if (rc != 0) {
+                       sfc_err(sa,
+                               "failed to stop representor proxy TxQ %u: %s",
+                               repr_id, rte_strerror(rc));
+                       sfc_put_adapter(sa);
+                       return rc;
+               }
+       }
+
+       port->enabled = false;
+
+       sfc_log_init(sa, "done");
+       sfc_put_adapter(sa);
+
+       return 0;
+}