net/tap: add link status notification
[dpdk.git] / drivers / net / tap / rte_eth_tap.c
index 3345c1a..6567bba 100644 (file)
@@ -32,6 +32,7 @@
  */
 
 #include <rte_atomic.h>
+#include <rte_branch_prediction.h>
 #include <rte_common.h>
 #include <rte_mbuf.h>
 #include <rte_ethdev.h>
@@ -49,6 +50,7 @@
 #include <errno.h>
 #include <signal.h>
 #include <stdint.h>
+#include <sys/uio.h>
 #include <unistd.h>
 #include <arpa/inet.h>
 #include <net/if.h>
@@ -59,6 +61,7 @@
 
 #include <rte_eth_tap.h>
 #include <tap_flow.h>
+#include <tap_netlink.h>
 #include <tap_tcmsgs.h>
 
 /* Linux based path to the TUN device */
@@ -67,6 +70,7 @@
 
 #define ETH_TAP_IFACE_ARG       "iface"
 #define ETH_TAP_SPEED_ARG       "speed"
+#define ETH_TAP_REMOTE_ARG      "remote"
 
 #ifdef IFF_MULTI_QUEUE
 #define RTE_PMD_TAP_MAX_QUEUES 16
@@ -82,6 +86,7 @@ static struct rte_vdev_driver pmd_tap_drv;
 static const char *valid_arguments[] = {
        ETH_TAP_IFACE_ARG,
        ETH_TAP_SPEED_ARG,
+       ETH_TAP_REMOTE_ARG,
        NULL
 };
 
@@ -107,6 +112,8 @@ static int
 tap_ioctl(struct pmd_internals *pmd, unsigned long request,
          struct ifreq *ifr, int set);
 
+static int tap_intr_handle_set(struct rte_eth_dev *dev, int set);
+
 /* Tun/Tap allocation routine
  *
  * name is the number of the interface to use, unless NULL to take the host
@@ -123,7 +130,11 @@ tun_alloc(struct pmd_internals *pmd, uint16_t qid)
 
        memset(&ifr, 0, sizeof(struct ifreq));
 
-       ifr.ifr_flags = IFF_TAP | IFF_NO_PI;
+       /*
+        * Do not set IFF_NO_PI as packet information header will be needed
+        * to check if a received packet has been truncated.
+        */
+       ifr.ifr_flags = IFF_TAP;
        snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name);
 
        RTE_LOG(DEBUG, PMD, "ifr_name '%s'\n", ifr.ifr_name);
@@ -237,10 +248,43 @@ tun_alloc(struct pmd_internals *pmd, uint16_t qid)
                                pmd->name);
                        return fd;
                }
+               if (pmd->remote_if_index) {
+                       /*
+                        * Flush usually returns negative value because it tries
+                        * to delete every QDISC (and on a running device, one
+                        * QDISC at least is needed). Ignore negative return
+                        * value.
+                        */
+                       qdisc_flush(pmd->nlsk_fd, pmd->remote_if_index);
+                       if (qdisc_create_ingress(pmd->nlsk_fd,
+                                                pmd->remote_if_index) < 0)
+                               goto remote_fail;
+                       LIST_INIT(&pmd->implicit_flows);
+                       if (tap_flow_implicit_create(
+                                   pmd, TAP_REMOTE_LOCAL_MAC) < 0)
+                               goto remote_fail;
+                       if (tap_flow_implicit_create(
+                                   pmd, TAP_REMOTE_BROADCAST) < 0)
+                               goto remote_fail;
+                       if (tap_flow_implicit_create(
+                                   pmd, TAP_REMOTE_BROADCASTV6) < 0)
+                               goto remote_fail;
+                       if (tap_flow_implicit_create(
+                                   pmd, TAP_REMOTE_TX) < 0)
+                               goto remote_fail;
+               }
        }
 
        return fd;
 
+remote_fail:
+       RTE_LOG(ERR, PMD,
+               "Could not set up remote flow rules for %s: remote disabled.\n",
+               pmd->name);
+       pmd->remote_if_index = 0;
+       tap_flow_implicit_flush(pmd, NULL);
+       return fd;
+
 error:
        if (fd > 0)
                close(fd);
@@ -253,8 +297,6 @@ error:
 static uint16_t
 pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       int len;
-       struct rte_mbuf *mbuf;
        struct rx_queue *rxq = queue;
        uint16_t num_rx;
        unsigned long num_rx_bytes = 0;
@@ -266,23 +308,67 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                rxq->trigger_seen = trigger;
        rte_compiler_barrier();
        for (num_rx = 0; num_rx < nb_pkts; ) {
-               /* allocate the next mbuf */
-               mbuf = rte_pktmbuf_alloc(rxq->mp);
-               if (unlikely(!mbuf)) {
-                       RTE_LOG(WARNING, PMD, "TAP unable to allocate mbuf\n");
+               struct rte_mbuf *mbuf = rxq->pool;
+               struct rte_mbuf *seg = NULL;
+               struct rte_mbuf *new_tail = NULL;
+               uint16_t data_off = rte_pktmbuf_headroom(mbuf);
+               int len;
+
+               len = readv(rxq->fd, *rxq->iovecs,
+                           1 + (rxq->rxmode->enable_scatter ?
+                                rxq->nb_rx_desc : 1));
+               if (len < (int)sizeof(struct tun_pi))
                        break;
-               }
 
-               len = read(rxq->fd, rte_pktmbuf_mtod(mbuf, char *),
-                          rte_pktmbuf_tailroom(mbuf));
-               if (len <= 0) {
-                       rte_pktmbuf_free(mbuf);
-                       break;
+               /* Packet couldn't fit in the provided mbuf */
+               if (unlikely(rxq->pi.flags & TUN_PKT_STRIP)) {
+                       rxq->stats.ierrors++;
+                       continue;
                }
 
-               mbuf->data_len = len;
+               len -= sizeof(struct tun_pi);
+
                mbuf->pkt_len = len;
                mbuf->port = rxq->in_port;
+               while (1) {
+                       struct rte_mbuf *buf = rte_pktmbuf_alloc(rxq->mp);
+
+                       if (unlikely(!buf)) {
+                               rxq->stats.rx_nombuf++;
+                               /* No new buf has been allocated: do nothing */
+                               if (!new_tail || !seg)
+                                       goto end;
+
+                               seg->next = NULL;
+                               rte_pktmbuf_free(mbuf);
+
+                               goto end;
+                       }
+                       seg = seg ? seg->next : mbuf;
+                       if (rxq->pool == mbuf)
+                               rxq->pool = buf;
+                       if (new_tail)
+                               new_tail->next = buf;
+                       new_tail = buf;
+                       new_tail->next = seg->next;
+
+                       /* iovecs[0] is reserved for packet info (pi) */
+                       (*rxq->iovecs)[mbuf->nb_segs].iov_len =
+                               buf->buf_len - data_off;
+                       (*rxq->iovecs)[mbuf->nb_segs].iov_base =
+                               (char *)buf->buf_addr + data_off;
+
+                       seg->data_len = RTE_MIN(seg->buf_len - data_off, len);
+                       seg->data_off = data_off;
+
+                       len -= seg->data_len;
+                       if (len <= 0)
+                               break;
+                       mbuf->nb_segs++;
+                       /* First segment has headroom, not the others */
+                       data_off = 0;
+               }
+               seg->next = NULL;
                mbuf->packet_type = rte_net_get_ptype(mbuf, NULL,
                                                      RTE_PTYPE_ALL_MASK);
 
@@ -290,6 +376,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                bufs[num_rx++] = mbuf;
                num_rx_bytes += mbuf->pkt_len;
        }
+end:
        rxq->stats.ipackets += num_rx;
        rxq->stats.ibytes += num_rx_bytes;
 
@@ -301,26 +388,38 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 static uint16_t
 pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       struct rte_mbuf *mbuf;
        struct tx_queue *txq = queue;
        uint16_t num_tx = 0;
        unsigned long num_tx_bytes = 0;
        uint32_t max_size;
-       int i, n;
+       int i;
 
        if (unlikely(nb_pkts == 0))
                return 0;
 
        max_size = *txq->mtu + (ETHER_HDR_LEN + ETHER_CRC_LEN + 4);
        for (i = 0; i < nb_pkts; i++) {
-               /* copy the tx frame data */
-               mbuf = bufs[num_tx];
+               struct rte_mbuf *mbuf = bufs[num_tx];
+               struct iovec iovecs[mbuf->nb_segs + 1];
+               struct tun_pi pi = { .flags = 0 };
+               struct rte_mbuf *seg = mbuf;
+               int n;
+               int j;
+
                /* stats.errs will be incremented */
                if (rte_pktmbuf_pkt_len(mbuf) > max_size)
                        break;
-               n = write(txq->fd,
-                         rte_pktmbuf_mtod(mbuf, void *),
-                         rte_pktmbuf_pkt_len(mbuf));
+
+               iovecs[0].iov_base = &pi;
+               iovecs[0].iov_len = sizeof(pi);
+               for (j = 1; j <= mbuf->nb_segs; j++) {
+                       iovecs[j].iov_len = rte_pktmbuf_data_len(seg);
+                       iovecs[j].iov_base =
+                               rte_pktmbuf_mtod(seg, void *);
+                       seg = seg->next;
+               }
+               /* copy the tx frame data */
+               n = writev(txq->fd, iovecs, mbuf->nb_segs + 1);
                if (n <= 0)
                        break;
 
@@ -341,8 +440,25 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,
          struct ifreq *ifr, int set)
 {
        short req_flags = ifr->ifr_flags;
+       int remote = !!pmd->remote_if_index;
 
-       snprintf(ifr->ifr_name, IFNAMSIZ, "%s", pmd->name);
+       /*
+        * If there is a remote netdevice, apply ioctl on it, then apply it on
+        * the tap netdevice.
+        */
+       if (request == SIOCGIFFLAGS && !set) {
+               /*
+                * Special case for getting flags. If set is given,
+                * then return the flags from the remote netdevice only.
+                * Otherwise return the flags from the tap netdevice.
+                */
+               remote = 0;
+       }
+apply:
+       if (remote)
+               snprintf(ifr->ifr_name, IFNAMSIZ, "%s", pmd->remote_iface);
+       else
+               snprintf(ifr->ifr_name, IFNAMSIZ, "%s", pmd->name);
        switch (request) {
        case SIOCSIFFLAGS:
                /* fetch current flags to leave other flags untouched */
@@ -353,7 +469,17 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,
                else
                        ifr->ifr_flags &= ~req_flags;
                break;
+       case SIOCGIFFLAGS:
+               if (remote && set)
+                       remote = 0; /* don't loop */
+               break;
        case SIOCGIFHWADDR:
+               /* Set remote MAC on the tap netdevice */
+               if (!remote && pmd->remote_if_index) {
+                       request = SIOCSIFHWADDR;
+                       goto apply;
+               }
+               break;
        case SIOCSIFHWADDR:
        case SIOCSIFMTU:
                break;
@@ -364,6 +490,8 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,
        }
        if (ioctl(pmd->ioctl_sock, request, ifr) < 0)
                goto error;
+       if (remote--)
+               goto apply;
        return 0;
 
 error:
@@ -395,6 +523,11 @@ tap_link_set_up(struct rte_eth_dev *dev)
 static int
 tap_dev_start(struct rte_eth_dev *dev)
 {
+       int err;
+
+       err = tap_intr_handle_set(dev, 1);
+       if (err)
+               return err;
        return tap_link_set_up(dev);
 }
 
@@ -403,6 +536,7 @@ tap_dev_start(struct rte_eth_dev *dev)
 static void
 tap_dev_stop(struct rte_eth_dev *dev)
 {
+       tap_intr_handle_set(dev, 0);
        tap_link_set_down(dev);
 }
 
@@ -467,6 +601,7 @@ tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)
        unsigned int i, imax;
        unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
        unsigned long rx_bytes_total = 0, tx_bytes_total = 0;
+       unsigned long rx_nombuf = 0, ierrors = 0;
        const struct pmd_internals *pmd = dev->data->dev_private;
 
        imax = (pmd->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS) ?
@@ -477,6 +612,8 @@ tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)
                tap_stats->q_ibytes[i] = pmd->rxq[i].stats.ibytes;
                rx_total += tap_stats->q_ipackets[i];
                rx_bytes_total += tap_stats->q_ibytes[i];
+               rx_nombuf += pmd->rxq[i].stats.rx_nombuf;
+               ierrors += pmd->rxq[i].stats.ierrors;
 
                tap_stats->q_opackets[i] = pmd->txq[i].stats.opackets;
                tap_stats->q_errors[i] = pmd->txq[i].stats.errs;
@@ -488,6 +625,8 @@ tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)
 
        tap_stats->ipackets = rx_total;
        tap_stats->ibytes = rx_bytes_total;
+       tap_stats->ierrors = ierrors;
+       tap_stats->rx_nombuf = rx_nombuf;
        tap_stats->opackets = tx_total;
        tap_stats->oerrors = tx_err_total;
        tap_stats->obytes = tx_bytes_total;
@@ -502,6 +641,8 @@ tap_stats_reset(struct rte_eth_dev *dev)
        for (i = 0; i < pmd->nb_queues; i++) {
                pmd->rxq[i].stats.ipackets = 0;
                pmd->rxq[i].stats.ibytes = 0;
+               pmd->rxq[i].stats.ierrors = 0;
+               pmd->rxq[i].stats.rx_nombuf = 0;
 
                pmd->txq[i].stats.opackets = 0;
                pmd->txq[i].stats.errs = 0;
@@ -517,6 +658,7 @@ tap_dev_close(struct rte_eth_dev *dev __rte_unused)
 
        tap_link_set_down(dev);
        tap_flow_flush(dev, NULL);
+       tap_flow_implicit_flush(internals, NULL);
 
        for (i = 0; i < internals->nb_queues; i++) {
                if (internals->rxq[i].fd != -1)
@@ -534,6 +676,10 @@ tap_rx_queue_release(void *queue)
        if (rxq && (rxq->fd > 0)) {
                close(rxq->fd);
                rxq->fd = -1;
+               rte_pktmbuf_free(rxq->pool);
+               rte_free(rxq->iovecs);
+               rxq->pool = NULL;
+               rxq->iovecs = NULL;
        }
 }
 
@@ -549,9 +695,25 @@ tap_tx_queue_release(void *queue)
 }
 
 static int
-tap_link_update(struct rte_eth_dev *dev __rte_unused,
-               int wait_to_complete __rte_unused)
+tap_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
 {
+       struct rte_eth_link *dev_link = &dev->data->dev_link;
+       struct pmd_internals *pmd = dev->data->dev_private;
+       struct ifreq ifr = { .ifr_flags = 0 };
+
+       if (pmd->remote_if_index) {
+               tap_ioctl(pmd, SIOCGIFFLAGS, &ifr, 1);
+               if (!(ifr.ifr_flags & IFF_UP) ||
+                   !(ifr.ifr_flags & IFF_RUNNING)) {
+                       dev_link->link_status = ETH_LINK_DOWN;
+                       return 0;
+               }
+       }
+       tap_ioctl(pmd, SIOCGIFFLAGS, &ifr, 0);
+       dev_link->link_status =
+               ((ifr.ifr_flags & IFF_UP) && (ifr.ifr_flags & IFF_RUNNING) ?
+                ETH_LINK_UP :
+                ETH_LINK_DOWN);
        return 0;
 }
 
@@ -563,6 +725,8 @@ tap_promisc_enable(struct rte_eth_dev *dev)
 
        dev->data->promiscuous = 1;
        tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 1);
+       if (pmd->remote_if_index)
+               tap_flow_implicit_create(pmd, TAP_REMOTE_PROMISC);
 }
 
 static void
@@ -573,6 +737,8 @@ tap_promisc_disable(struct rte_eth_dev *dev)
 
        dev->data->promiscuous = 0;
        tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 0);
+       if (pmd->remote_if_index)
+               tap_flow_implicit_destroy(pmd, TAP_REMOTE_PROMISC);
 }
 
 static void
@@ -583,6 +749,8 @@ tap_allmulti_enable(struct rte_eth_dev *dev)
 
        dev->data->all_multicast = 1;
        tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 1);
+       if (pmd->remote_if_index)
+               tap_flow_implicit_create(pmd, TAP_REMOTE_ALLMULTI);
 }
 
 static void
@@ -593,6 +761,8 @@ tap_allmulti_disable(struct rte_eth_dev *dev)
 
        dev->data->all_multicast = 0;
        tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 0);
+       if (pmd->remote_if_index)
+               tap_flow_implicit_destroy(pmd, TAP_REMOTE_ALLMULTI);
 }
 
 
@@ -652,6 +822,7 @@ tap_setup_queue(struct rte_eth_dev *dev,
        rx->fd = fd;
        tx->fd = fd;
        tx->mtu = &dev->data->mtu;
+       rx->rxmode = &dev->data->dev_conf.rxmode;
 
        return fd;
 }
@@ -679,14 +850,20 @@ tx_setup_queue(struct rte_eth_dev *dev,
 static int
 tap_rx_queue_setup(struct rte_eth_dev *dev,
                   uint16_t rx_queue_id,
-                  uint16_t nb_rx_desc __rte_unused,
-                  unsigned int socket_id __rte_unused,
+                  uint16_t nb_rx_desc,
+                  unsigned int socket_id,
                   const struct rte_eth_rxconf *rx_conf __rte_unused,
                   struct rte_mempool *mp)
 {
        struct pmd_internals *internals = dev->data->dev_private;
+       struct rx_queue *rxq = &internals->rxq[rx_queue_id];
+       struct rte_mbuf **tmp = &rxq->pool;
+       struct iovec (*iovecs)[nb_rx_desc + 1];
+       int data_off = RTE_PKTMBUF_HEADROOM;
        uint16_t buf_size;
+       int ret = 0;
        int fd;
+       int i;
 
        if ((rx_queue_id >= internals->nb_queues) || !mp) {
                RTE_LOG(WARNING, PMD,
@@ -695,9 +872,19 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
                return -1;
        }
 
-       internals->rxq[rx_queue_id].mp = mp;
-       internals->rxq[rx_queue_id].trigger_seen = 1; /* force initial burst */
-       internals->rxq[rx_queue_id].in_port = dev->data->port_id;
+       rxq->mp = mp;
+       rxq->trigger_seen = 1; /* force initial burst */
+       rxq->in_port = dev->data->port_id;
+       rxq->nb_rx_desc = nb_rx_desc;
+       iovecs = rte_zmalloc_socket(dev->data->name, sizeof(*iovecs), 0,
+                                   socket_id);
+       if (!iovecs) {
+               RTE_LOG(WARNING, PMD,
+                       "%s: Couldn't allocate %d RX descriptors\n",
+                       dev->data->name, nb_rx_desc);
+               return -ENOMEM;
+       }
+       rxq->iovecs = iovecs;
 
        /* Now get the space available for data in the mbuf */
        buf_size = (uint16_t)(rte_pktmbuf_data_room_size(mp) -
@@ -707,17 +894,46 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
                RTE_LOG(WARNING, PMD,
                        "%s: %d bytes will not fit in mbuf (%d bytes)\n",
                        dev->data->name, ETH_FRAME_LEN, buf_size);
-               return -ENOMEM;
+               ret = -ENOMEM;
+               goto error;
        }
 
        fd = rx_setup_queue(dev, internals, rx_queue_id);
-       if (fd == -1)
-               return -1;
+       if (fd == -1) {
+               ret = fd;
+               goto error;
+       }
+
+       (*rxq->iovecs)[0].iov_len = sizeof(struct tun_pi);
+       (*rxq->iovecs)[0].iov_base = &rxq->pi;
+
+       for (i = 1; i <= nb_rx_desc; i++) {
+               *tmp = rte_pktmbuf_alloc(rxq->mp);
+               if (!*tmp) {
+                       RTE_LOG(WARNING, PMD,
+                               "%s: couldn't allocate memory for queue %d\n",
+                               dev->data->name, rx_queue_id);
+                       ret = -ENOMEM;
+                       goto error;
+               }
+               (*rxq->iovecs)[i].iov_len = (*tmp)->buf_len - data_off;
+               (*rxq->iovecs)[i].iov_base =
+                       (char *)(*tmp)->buf_addr + data_off;
+               data_off = 0;
+               tmp = &(*tmp)->next;
+       }
 
        RTE_LOG(DEBUG, PMD, "  RX TAP device name %s, qid %d on fd %d\n",
                internals->name, rx_queue_id, internals->rxq[rx_queue_id].fd);
 
        return 0;
+
+error:
+       rte_pktmbuf_free(rxq->pool);
+       rxq->pool = NULL;
+       rte_free(rxq->iovecs);
+       rxq->iovecs = NULL;
+       return ret;
 }
 
 static int
@@ -769,6 +985,55 @@ tap_set_mc_addr_list(struct rte_eth_dev *dev __rte_unused,
        return 0;
 }
 
+static int
+tap_nl_msg_handler(struct nlmsghdr *nh, void *arg)
+{
+       struct rte_eth_dev *dev = arg;
+       struct pmd_internals *pmd = dev->data->dev_private;
+       struct ifinfomsg *info = NLMSG_DATA(nh);
+
+       if (nh->nlmsg_type != RTM_NEWLINK ||
+           (info->ifi_index != pmd->if_index &&
+            info->ifi_index != pmd->remote_if_index))
+               return 0;
+       return tap_link_update(dev, 0);
+}
+
+static void
+tap_dev_intr_handler(struct rte_intr_handle *intr_handle __rte_unused,
+                    void *cb_arg)
+{
+       struct rte_eth_dev *dev = cb_arg;
+       struct pmd_internals *pmd = dev->data->dev_private;
+
+       nl_recv(pmd->intr_handle.fd, tap_nl_msg_handler, dev);
+}
+
+static int
+tap_intr_handle_set(struct rte_eth_dev *dev, int set)
+{
+       struct pmd_internals *pmd = dev->data->dev_private;
+
+       /* In any case, disable interrupt if the conf is no longer there. */
+       if (!dev->data->dev_conf.intr_conf.lsc) {
+               if (pmd->intr_handle.fd != -1)
+                       nl_final(pmd->intr_handle.fd);
+               rte_intr_callback_unregister(
+                       &pmd->intr_handle, tap_dev_intr_handler, dev);
+               return 0;
+       }
+       if (set) {
+               pmd->intr_handle.fd = nl_init(RTMGRP_LINK);
+               if (unlikely(pmd->intr_handle.fd == -1))
+                       return -EBADF;
+               return rte_intr_callback_register(
+                       &pmd->intr_handle, tap_dev_intr_handler, dev);
+       }
+       nl_final(pmd->intr_handle.fd);
+       return rte_intr_callback_unregister(&pmd->intr_handle,
+                                           tap_dev_intr_handler, dev);
+}
+
 static const uint32_t*
 tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)
 {
@@ -864,7 +1129,7 @@ tap_kernel_support(struct pmd_internals *pmd)
 }
 
 static int
-eth_dev_tap_create(const char *name, char *tap_name)
+eth_dev_tap_create(const char *name, char *tap_name, char *remote_iface)
 {
        int numa_node = rte_socket_id();
        struct rte_eth_dev *dev = NULL;
@@ -910,7 +1175,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
        data->dev_private = pmd;
        data->port_id = dev->data->port_id;
        data->mtu = dev->data->mtu;
-       data->dev_flags = RTE_ETH_DEV_DETACHABLE;
+       data->dev_flags = RTE_ETH_DEV_DETACHABLE | RTE_ETH_DEV_INTR_LSC;
        data->kdrv = RTE_KDRV_NONE;
        data->drv_name = pmd_tap_drv.driver.name;
        data->numa_node = numa_node;
@@ -926,6 +1191,9 @@ eth_dev_tap_create(const char *name, char *tap_name)
        dev->rx_pkt_burst = pmd_rx_burst;
        dev->tx_pkt_burst = pmd_tx_burst;
 
+       pmd->intr_handle.type = RTE_INTR_HANDLE_EXT;
+       pmd->intr_handle.fd = -1;
+
        /* Presetup the fds to -1 as being not valid */
        for (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) {
                pmd->rxq[i].fd = -1;
@@ -940,7 +1208,16 @@ eth_dev_tap_create(const char *name, char *tap_name)
         * If no netlink socket can be created, then it will fail when
         * creating/destroying flow rules.
         */
-       pmd->nlsk_fd = nl_init();
+       pmd->nlsk_fd = nl_init(0);
+       if (strlen(remote_iface)) {
+               pmd->remote_if_index = if_nametoindex(remote_iface);
+               snprintf(pmd->remote_iface, RTE_ETH_NAME_MAX_LEN,
+                        "%s", remote_iface);
+               if (!pmd->remote_if_index)
+                       RTE_LOG(ERR, PMD, "Could not find %s ifindex: "
+                               "remote interface will remain unconfigured\n",
+                               remote_iface);
+       }
 
        return 0;
 
@@ -981,6 +1258,19 @@ set_interface_speed(const char *key __rte_unused,
        return 0;
 }
 
+static int
+set_remote_iface(const char *key __rte_unused,
+                const char *value,
+                void *extra_args)
+{
+       char *name = (char *)extra_args;
+
+       if (value)
+               snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s", value);
+
+       return 0;
+}
+
 /* Open a TAP interface device.
  */
 static int
@@ -990,10 +1280,12 @@ rte_pmd_tap_probe(const char *name, const char *params)
        struct rte_kvargs *kvlist = NULL;
        int speed;
        char tap_name[RTE_ETH_NAME_MAX_LEN];
+       char remote_iface[RTE_ETH_NAME_MAX_LEN];
 
        speed = ETH_SPEED_NUM_10G;
        snprintf(tap_name, sizeof(tap_name), "%s%d",
                 DEFAULT_TAP_NAME, tap_unit++);
+       memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
 
        if (params && (params[0] != '\0')) {
                RTE_LOG(DEBUG, PMD, "paramaters (%s)\n", params);
@@ -1017,6 +1309,15 @@ rte_pmd_tap_probe(const char *name, const char *params)
                                if (ret == -1)
                                        goto leave;
                        }
+
+                       if (rte_kvargs_count(kvlist, ETH_TAP_REMOTE_ARG) == 1) {
+                               ret = rte_kvargs_process(kvlist,
+                                                        ETH_TAP_REMOTE_ARG,
+                                                        &set_remote_iface,
+                                                        remote_iface);
+                               if (ret == -1)
+                                       goto leave;
+                       }
                }
        }
        pmd_link.link_speed = speed;
@@ -1024,7 +1325,7 @@ rte_pmd_tap_probe(const char *name, const char *params)
        RTE_LOG(NOTICE, PMD, "Initializing pmd_tap for %s as %s\n",
                name, tap_name);
 
-       ret = eth_dev_tap_create(name, tap_name);
+       ret = eth_dev_tap_create(name, tap_name, remote_iface);
 
 leave:
        if (ret == -1) {
@@ -1057,6 +1358,7 @@ rte_pmd_tap_remove(const char *name)
        internals = eth_dev->data->dev_private;
        if (internals->flower_support && internals->nlsk_fd) {
                tap_flow_flush(eth_dev, NULL);
+               tap_flow_implicit_flush(internals, NULL);
                nl_final(internals->nlsk_fd);
        }
        for (i = 0; i < internals->nb_queues; i++)