net/vhost: merge stats loop in datapath
[dpdk.git] / drivers / net / vhost / rte_eth_vhost.c
index ce32be9..8649836 100644 (file)
@@ -8,8 +8,8 @@
 #include <sys/epoll.h>
 
 #include <rte_mbuf.h>
-#include <rte_ethdev_driver.h>
-#include <rte_ethdev_vdev.h>
+#include <ethdev_driver.h>
+#include <ethdev_vdev.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
 #include <rte_bus_vdev.h>
@@ -19,7 +19,7 @@
 
 #include "rte_eth_vhost.h"
 
-RTE_LOG_REGISTER(vhost_logtype, pmd.net.vhost, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vhost_logtype, NOTICE);
 
 #define VHOST_LOG(level, ...) \
        rte_log(RTE_LOG_ ## level, vhost_logtype, __VA_ARGS__)
@@ -29,7 +29,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
 #define ETH_VHOST_IFACE_ARG            "iface"
 #define ETH_VHOST_QUEUES_ARG           "queues"
 #define ETH_VHOST_CLIENT_ARG           "client"
-#define ETH_VHOST_DEQUEUE_ZERO_COPY    "dequeue-zero-copy"
 #define ETH_VHOST_IOMMU_SUPPORT                "iommu-support"
 #define ETH_VHOST_POSTCOPY_SUPPORT     "postcopy-support"
 #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso"
@@ -41,7 +40,6 @@ static const char *valid_arguments[] = {
        ETH_VHOST_IFACE_ARG,
        ETH_VHOST_QUEUES_ARG,
        ETH_VHOST_CLIENT_ARG,
-       ETH_VHOST_DEQUEUE_ZERO_COPY,
        ETH_VHOST_IOMMU_SUPPORT,
        ETH_VHOST_POSTCOPY_SUPPORT,
        ETH_VHOST_VIRTIO_NET_F_HOST_TSO,
@@ -73,6 +71,9 @@ enum vhost_xstats_pkts {
        VHOST_BROADCAST_PKT,
        VHOST_MULTICAST_PKT,
        VHOST_UNICAST_PKT,
+       VHOST_PKT,
+       VHOST_BYTE,
+       VHOST_MISSED_PKT,
        VHOST_ERRORS_PKT,
        VHOST_ERRORS_FRAGMENTED,
        VHOST_ERRORS_JABBER,
@@ -149,11 +150,11 @@ struct vhost_xstats_name_off {
 /* [rx]_is prepended to the name string here */
 static const struct vhost_xstats_name_off vhost_rxport_stat_strings[] = {
        {"good_packets",
-        offsetof(struct vhost_queue, stats.pkts)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_PKT])},
        {"total_bytes",
-        offsetof(struct vhost_queue, stats.bytes)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_BYTE])},
        {"missed_pkts",
-        offsetof(struct vhost_queue, stats.missed_pkts)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_MISSED_PKT])},
        {"broadcast_packets",
         offsetof(struct vhost_queue, stats.xstats[VHOST_BROADCAST_PKT])},
        {"multicast_packets",
@@ -189,11 +190,11 @@ static const struct vhost_xstats_name_off vhost_rxport_stat_strings[] = {
 /* [tx]_ is prepended to the name string here */
 static const struct vhost_xstats_name_off vhost_txport_stat_strings[] = {
        {"good_packets",
-        offsetof(struct vhost_queue, stats.pkts)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_PKT])},
        {"total_bytes",
-        offsetof(struct vhost_queue, stats.bytes)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_BYTE])},
        {"missed_pkts",
-        offsetof(struct vhost_queue, stats.missed_pkts)},
+        offsetof(struct vhost_queue, stats.xstats[VHOST_MISSED_PKT])},
        {"broadcast_packets",
         offsetof(struct vhost_queue, stats.xstats[VHOST_BROADCAST_PKT])},
        {"multicast_packets",
@@ -287,23 +288,6 @@ vhost_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        if (n < nxstats)
                return nxstats;
 
-       for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               vq = dev->data->rx_queues[i];
-               if (!vq)
-                       continue;
-               vq->stats.xstats[VHOST_UNICAST_PKT] = vq->stats.pkts
-                               - (vq->stats.xstats[VHOST_BROADCAST_PKT]
-                               + vq->stats.xstats[VHOST_MULTICAST_PKT]);
-       }
-       for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               vq = dev->data->tx_queues[i];
-               if (!vq)
-                       continue;
-               vq->stats.xstats[VHOST_UNICAST_PKT] = vq->stats.pkts
-                               + vq->stats.missed_pkts
-                               - (vq->stats.xstats[VHOST_BROADCAST_PKT]
-                               + vq->stats.xstats[VHOST_MULTICAST_PKT]);
-       }
        for (t = 0; t < VHOST_NB_XSTATS_RXPORT; t++) {
                xstats[count].value = 0;
                for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -334,7 +318,7 @@ vhost_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
 }
 
 static inline void
-vhost_count_multicast_broadcast(struct vhost_queue *vq,
+vhost_count_xcast_packets(struct vhost_queue *vq,
                                struct rte_mbuf *mbuf)
 {
        struct rte_ether_addr *ea = NULL;
@@ -346,37 +330,35 @@ vhost_count_multicast_broadcast(struct vhost_queue *vq,
                        pstats->xstats[VHOST_BROADCAST_PKT]++;
                else
                        pstats->xstats[VHOST_MULTICAST_PKT]++;
+       } else {
+               pstats->xstats[VHOST_UNICAST_PKT]++;
        }
 }
 
-static void
-vhost_update_packet_xstats(struct vhost_queue *vq,
-                          struct rte_mbuf **bufs,
-                          uint16_t count)
+static __rte_always_inline void
+vhost_update_single_packet_xstats(struct vhost_queue *vq, struct rte_mbuf *buf)
 {
        uint32_t pkt_len = 0;
-       uint64_t i = 0;
        uint64_t index;
        struct vhost_stats *pstats = &vq->stats;
 
-       for (i = 0; i < count ; i++) {
-               pkt_len = bufs[i]->pkt_len;
-               if (pkt_len == 64) {
-                       pstats->xstats[VHOST_64_PKT]++;
-               } else if (pkt_len > 64 && pkt_len < 1024) {
-                       index = (sizeof(pkt_len) * 8)
-                               - __builtin_clz(pkt_len) - 5;
-                       pstats->xstats[index]++;
-               } else {
-                       if (pkt_len < 64)
-                               pstats->xstats[VHOST_UNDERSIZE_PKT]++;
-                       else if (pkt_len <= 1522)
-                               pstats->xstats[VHOST_1024_TO_1522_PKT]++;
-                       else if (pkt_len > 1522)
-                               pstats->xstats[VHOST_1523_TO_MAX_PKT]++;
-               }
-               vhost_count_multicast_broadcast(vq, bufs[i]);
-       }
+       pstats->xstats[VHOST_PKT]++;
+       pkt_len = buf->pkt_len;
+       if (pkt_len == 64) {
+               pstats->xstats[VHOST_64_PKT]++;
+       } else if (pkt_len > 64 && pkt_len < 1024) {
+               index = (sizeof(pkt_len) * 8)
+                       - __builtin_clz(pkt_len) - 5;
+               pstats->xstats[index]++;
+       } else {
+               if (pkt_len < 64)
+                       pstats->xstats[VHOST_UNDERSIZE_PKT]++;
+               else if (pkt_len <= 1522)
+                       pstats->xstats[VHOST_1024_TO_1522_PKT]++;
+               else if (pkt_len > 1522)
+                       pstats->xstats[VHOST_1523_TO_MAX_PKT]++;
+       }
+       vhost_count_xcast_packets(vq, buf);
 }
 
 static uint16_t
@@ -420,9 +402,10 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
                        rte_vlan_strip(bufs[i]);
 
                r->stats.bytes += bufs[i]->pkt_len;
-       }
+               r->stats.xstats[VHOST_BYTE] += bufs[i]->pkt_len;
 
-       vhost_update_packet_xstats(r, bufs, nb_rx);
+               vhost_update_single_packet_xstats(r, bufs[i]);
+       }
 
 out:
        rte_atomic32_set(&r->while_queuing, 0);
@@ -436,6 +419,8 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
        struct vhost_queue *r = q;
        uint16_t i, nb_tx = 0;
        uint16_t nb_send = 0;
+       uint64_t nb_bytes = 0;
+       uint64_t nb_missed = 0;
 
        if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
                return 0;
@@ -476,20 +461,27 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
                        break;
        }
 
-       r->stats.pkts += nb_tx;
-       r->stats.missed_pkts += nb_bufs - nb_tx;
+       for (i = 0; likely(i < nb_tx); i++) {
+               nb_bytes += bufs[i]->pkt_len;
+               vhost_update_single_packet_xstats(r, bufs[i]);
+       }
 
-       for (i = 0; likely(i < nb_tx); i++)
-               r->stats.bytes += bufs[i]->pkt_len;
+       nb_missed = nb_bufs - nb_tx;
+
+       r->stats.pkts += nb_tx;
+       r->stats.bytes += nb_bytes;
+       r->stats.missed_pkts += nb_missed;
 
-       vhost_update_packet_xstats(r, bufs, nb_tx);
+       r->stats.xstats[VHOST_BYTE] += nb_bytes;
+       r->stats.xstats[VHOST_MISSED_PKT] += nb_missed;
+       r->stats.xstats[VHOST_UNICAST_PKT] += nb_missed;
 
-       /* According to RFC2863 page42 section ifHCOutMulticastPkts and
-        * ifHCOutBroadcastPkts, the counters "multicast" and "broadcast"
-        * are increased when packets are not transmitted successfully.
+       /* According to RFC2863, ifHCOutUcastPkts, ifHCOutMulticastPkts and
+        * ifHCOutBroadcastPkts counters are increased when packets are not
+        * transmitted successfully.
         */
        for (i = nb_tx; i < nb_bufs; i++)
-               vhost_count_multicast_broadcast(r, bufs[i]);
+               vhost_count_xcast_packets(r, bufs[i]);
 
        for (i = 0; likely(i < nb_tx); i++)
                rte_pktmbuf_free(bufs[i]);
@@ -1155,27 +1147,33 @@ eth_dev_start(struct rte_eth_dev *eth_dev)
        return 0;
 }
 
-static void
+static int
 eth_dev_stop(struct rte_eth_dev *dev)
 {
        struct pmd_internal *internal = dev->data->dev_private;
 
+       dev->data->dev_started = 0;
        rte_atomic32_set(&internal->started, 0);
        update_queuing_status(dev);
+
+       return 0;
 }
 
-static void
+static int
 eth_dev_close(struct rte_eth_dev *dev)
 {
        struct pmd_internal *internal;
        struct internal_list *list;
-       unsigned int i;
+       unsigned int i, ret;
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
 
        internal = dev->data->dev_private;
        if (!internal)
-               return;
+               return 0;
 
-       eth_dev_stop(dev);
+       ret = eth_dev_stop(dev);
 
        list = find_internal_resource(internal->iface_name);
        if (list) {
@@ -1201,6 +1199,8 @@ eth_dev_close(struct rte_eth_dev *dev)
 
        rte_free(vring_states[dev->data->port_id]);
        vring_states[dev->data->port_id] = NULL;
+
+       return ret;
 }
 
 static int
@@ -1340,9 +1340,15 @@ eth_stats_reset(struct rte_eth_dev *dev)
 }
 
 static void
-eth_queue_release(void *q)
+eth_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
 {
-       rte_free(q);
+       rte_free(dev->data->rx_queues[qid]);
+}
+
+static void
+eth_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
+{
+       rte_free(dev->data->tx_queues[qid]);
 }
 
 static int
@@ -1363,11 +1369,11 @@ eth_link_update(struct rte_eth_dev *dev __rte_unused,
 }
 
 static uint32_t
-eth_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+eth_rx_queue_count(void *rx_queue)
 {
        struct vhost_queue *vq;
 
-       vq = dev->data->rx_queues[rx_queue_id];
+       vq = rx_queue;
        if (vq == NULL)
                return 0;
 
@@ -1382,8 +1388,8 @@ static const struct eth_dev_ops ops = {
        .dev_infos_get = eth_dev_info,
        .rx_queue_setup = eth_rx_queue_setup,
        .tx_queue_setup = eth_tx_queue_setup,
-       .rx_queue_release = eth_queue_release,
-       .tx_queue_release = eth_queue_release,
+       .rx_queue_release = eth_rx_queue_release,
+       .tx_queue_release = eth_tx_queue_release,
        .tx_done_cleanup = eth_tx_done_cleanup,
        .link_update = eth_link_update,
        .stats_get = eth_stats_get,
@@ -1441,7 +1447,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
        internal->flags = flags;
        internal->disable_flags = disable_flags;
        data->dev_link = pmd_link;
-       data->dev_flags = RTE_ETH_DEV_INTR_LSC | RTE_ETH_DEV_CLOSE_REMOVE;
+       data->dev_flags = RTE_ETH_DEV_INTR_LSC |
+                               RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
        data->promiscuous = 1;
        data->all_multicast = 1;
 
@@ -1501,7 +1508,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
        uint64_t flags = 0;
        uint64_t disable_flags = 0;
        int client_mode = 0;
-       int dequeue_zero_copy = 0;
        int iommu_support = 0;
        int postcopy_support = 0;
        int tso = 0;
@@ -1561,16 +1567,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
                        flags |= RTE_VHOST_USER_CLIENT;
        }
 
-       if (rte_kvargs_count(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY) == 1) {
-               ret = rte_kvargs_process(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY,
-                                        &open_int, &dequeue_zero_copy);
-               if (ret < 0)
-                       goto out_free;
-
-               if (dequeue_zero_copy)
-                       flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
-       }
-
        if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) {
                ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT,
                                         &open_int, &iommu_support);
@@ -1653,11 +1649,7 @@ rte_pmd_vhost_remove(struct rte_vdev_device *dev)
        if (eth_dev == NULL)
                return 0;
 
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return rte_eth_dev_release_port(eth_dev);
-
        eth_dev_close(eth_dev);
-
        rte_eth_dev_release_port(eth_dev);
 
        return 0;
@@ -1674,7 +1666,6 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vhost,
        "iface=<ifc> "
        "queues=<int> "
        "client=<0|1> "
-       "dequeue-zero-copy=<0|1> "
        "iommu-support=<0|1> "
        "postcopy-support=<0|1> "
        "tso=<0|1> "