drivers/net: do not use private ethdev data
[dpdk.git] / drivers / net / vhost / rte_eth_vhost.c
index cdd8c31..fea13eb 100644 (file)
 #include <stdbool.h>
 
 #include <rte_mbuf.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
+#include <rte_ethdev_vdev.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
-#include <rte_vdev.h>
+#include <rte_bus_vdev.h>
 #include <rte_kvargs.h>
 #include <rte_vhost.h>
 #include <rte_spinlock.h>
@@ -51,6 +52,7 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
 #define ETH_VHOST_QUEUES_ARG           "queues"
 #define ETH_VHOST_CLIENT_ARG           "client"
 #define ETH_VHOST_DEQUEUE_ZERO_COPY    "dequeue-zero-copy"
+#define ETH_VHOST_IOMMU_SUPPORT                "iommu-support"
 #define VHOST_MAX_PKT_BURST 32
 
 static const char *valid_arguments[] = {
@@ -58,6 +60,7 @@ static const char *valid_arguments[] = {
        ETH_VHOST_QUEUES_ARG,
        ETH_VHOST_CLIENT_ARG,
        ETH_VHOST_DEQUEUE_ZERO_COPY,
+       ETH_VHOST_IOMMU_SUPPORT,
        NULL
 };
 
@@ -104,7 +107,7 @@ struct vhost_queue {
        rte_atomic32_t while_queuing;
        struct pmd_internal *internal;
        struct rte_mempool *mb_pool;
-       uint8_t port;
+       uint16_t port;
        uint16_t virtqueue_id;
        struct vhost_stats stats;
 };
@@ -114,7 +117,9 @@ struct pmd_internal {
        char *dev_name;
        char *iface_name;
        uint16_t max_queues;
+       uint16_t vid;
        rte_atomic32_t started;
+       uint8_t vlan_strip;
 };
 
 struct internal_list {
@@ -418,6 +423,12 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 
        for (i = 0; likely(i < nb_rx); i++) {
                bufs[i]->port = r->port;
+               bufs[i]->ol_flags = 0;
+               bufs[i]->vlan_tci = 0;
+
+               if (r->internal->vlan_strip)
+                       rte_vlan_strip(bufs[i]);
+
                r->stats.bytes += bufs[i]->pkt_len;
        }
 
@@ -434,7 +445,7 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 {
        struct vhost_queue *r = q;
        uint16_t i, nb_tx = 0;
-       uint16_t nb_send = nb_bufs;
+       uint16_t nb_send = 0;
 
        if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
                return 0;
@@ -444,6 +455,22 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
        if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
                goto out;
 
+       for (i = 0; i < nb_bufs; i++) {
+               struct rte_mbuf *m = bufs[i];
+
+               /* Do VLAN tag insertion */
+               if (m->ol_flags & PKT_TX_VLAN_PKT) {
+                       int error = rte_vlan_insert(&m);
+                       if (unlikely(error)) {
+                               rte_pktmbuf_free(m);
+                               continue;
+                       }
+               }
+
+               bufs[nb_send] = m;
+               ++nb_send;
+       }
+
        /* Enqueue packets to guest RX queue */
        while (nb_send) {
                uint16_t nb_pkts;
@@ -485,6 +512,16 @@ out:
 static int
 eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
 {
+       struct pmd_internal *internal = dev->data->dev_private;
+       const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
+
+       internal->vlan_strip = rxmode->hw_vlan_strip;
+
+       if (rxmode->hw_vlan_filter)
+               RTE_LOG(WARNING, PMD,
+                       "vhost(%s): vlan filtering not available\n",
+                       internal->dev_name);
+
        return 0;
 }
 
@@ -516,6 +553,136 @@ find_internal_resource(char *ifname)
        return list;
 }
 
+static int
+eth_rxq_intr_enable(struct rte_eth_dev *dev, uint16_t qid)
+{
+       struct rte_vhost_vring vring;
+       struct vhost_queue *vq;
+       int ret = 0;
+
+       vq = dev->data->rx_queues[qid];
+       if (!vq) {
+               RTE_LOG(ERR, PMD, "rxq%d is not setup yet\n", qid);
+               return -1;
+       }
+
+       ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring);
+       if (ret < 0) {
+               RTE_LOG(ERR, PMD, "Failed to get rxq%d's vring\n", qid);
+               return ret;
+       }
+       RTE_LOG(INFO, PMD, "Enable interrupt for rxq%d\n", qid);
+       rte_vhost_enable_guest_notification(vq->vid, (qid << 1) + 1, 1);
+       rte_wmb();
+
+       return ret;
+}
+
+static int
+eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid)
+{
+       struct rte_vhost_vring vring;
+       struct vhost_queue *vq;
+       int ret = 0;
+
+       vq = dev->data->rx_queues[qid];
+       if (!vq) {
+               RTE_LOG(ERR, PMD, "rxq%d is not setup yet\n", qid);
+               return -1;
+       }
+
+       ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring);
+       if (ret < 0) {
+               RTE_LOG(ERR, PMD, "Failed to get rxq%d's vring", qid);
+               return ret;
+       }
+       RTE_LOG(INFO, PMD, "Disable interrupt for rxq%d\n", qid);
+       rte_vhost_enable_guest_notification(vq->vid, (qid << 1) + 1, 0);
+       rte_wmb();
+
+       return 0;
+}
+
+static void
+eth_vhost_uninstall_intr(struct rte_eth_dev *dev)
+{
+       struct rte_intr_handle *intr_handle = dev->intr_handle;
+
+       if (intr_handle) {
+               if (intr_handle->intr_vec)
+                       free(intr_handle->intr_vec);
+               free(intr_handle);
+       }
+
+       dev->intr_handle = NULL;
+}
+
+static int
+eth_vhost_install_intr(struct rte_eth_dev *dev)
+{
+       struct rte_vhost_vring vring;
+       struct vhost_queue *vq;
+       int count = 0;
+       int nb_rxq = dev->data->nb_rx_queues;
+       int i;
+       int ret;
+
+       /* uninstall firstly if we are reconnecting */
+       if (dev->intr_handle)
+               eth_vhost_uninstall_intr(dev);
+
+       dev->intr_handle = malloc(sizeof(*dev->intr_handle));
+       if (!dev->intr_handle) {
+               RTE_LOG(ERR, PMD, "Fail to allocate intr_handle\n");
+               return -ENOMEM;
+       }
+       memset(dev->intr_handle, 0, sizeof(*dev->intr_handle));
+
+       dev->intr_handle->efd_counter_size = sizeof(uint64_t);
+
+       dev->intr_handle->intr_vec =
+               malloc(nb_rxq * sizeof(dev->intr_handle->intr_vec[0]));
+
+       if (!dev->intr_handle->intr_vec) {
+               RTE_LOG(ERR, PMD,
+                       "Failed to allocate memory for interrupt vector\n");
+               free(dev->intr_handle);
+               return -ENOMEM;
+       }
+
+       RTE_LOG(INFO, PMD, "Prepare intr vec\n");
+       for (i = 0; i < nb_rxq; i++) {
+               vq = dev->data->rx_queues[i];
+               if (!vq) {
+                       RTE_LOG(INFO, PMD, "rxq-%d not setup yet, skip!\n", i);
+                       continue;
+               }
+
+               ret = rte_vhost_get_vhost_vring(vq->vid, (i << 1) + 1, &vring);
+               if (ret < 0) {
+                       RTE_LOG(INFO, PMD,
+                               "Failed to get rxq-%d's vring, skip!\n", i);
+                       continue;
+               }
+
+               if (vring.kickfd < 0) {
+                       RTE_LOG(INFO, PMD,
+                               "rxq-%d's kickfd is invalid, skip!\n", i);
+                       continue;
+               }
+               dev->intr_handle->intr_vec[i] = RTE_INTR_VEC_RXTX_OFFSET + i;
+               dev->intr_handle->efds[i] = vring.kickfd;
+               count++;
+               RTE_LOG(INFO, PMD, "Installed intr vec for rxq-%d\n", i);
+       }
+
+       dev->intr_handle->nb_efd = count;
+       dev->intr_handle->max_intr = count + 1;
+       dev->intr_handle->type = RTE_INTR_HANDLE_VDEV;
+
+       return 0;
+}
+
 static void
 update_queuing_status(struct rte_eth_dev *dev)
 {
@@ -524,6 +691,9 @@ update_queuing_status(struct rte_eth_dev *dev)
        unsigned int i;
        int allow_queuing = 1;
 
+       if (!dev->data->rx_queues || !dev->data->tx_queues)
+               return;
+
        if (rte_atomic32_read(&internal->started) == 0 ||
            rte_atomic32_read(&internal->dev_attached) == 0)
                allow_queuing = 0;
@@ -548,13 +718,37 @@ update_queuing_status(struct rte_eth_dev *dev)
        }
 }
 
+static void
+queue_setup(struct rte_eth_dev *eth_dev, struct pmd_internal *internal)
+{
+       struct vhost_queue *vq;
+       int i;
+
+       for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
+               vq = eth_dev->data->rx_queues[i];
+               if (!vq)
+                       continue;
+               vq->vid = internal->vid;
+               vq->internal = internal;
+               vq->port = eth_dev->data->port_id;
+       }
+       for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
+               vq = eth_dev->data->tx_queues[i];
+               if (!vq)
+                       continue;
+               vq->vid = internal->vid;
+               vq->internal = internal;
+               vq->port = eth_dev->data->port_id;
+       }
+}
+
 static int
 new_device(int vid)
 {
        struct rte_eth_dev *eth_dev;
        struct internal_list *list;
        struct pmd_internal *internal;
-       struct vhost_queue *vq;
+       struct rte_eth_conf *dev_conf;
        unsigned i;
        char ifname[PATH_MAX];
 #ifdef RTE_LIBRTE_VHOST_NUMA
@@ -570,6 +764,7 @@ new_device(int vid)
 
        eth_dev = list->eth_dev;
        internal = eth_dev->data->dev_private;
+       dev_conf = &eth_dev->data->dev_conf;
 
 #ifdef RTE_LIBRTE_VHOST_NUMA
        newnode = rte_vhost_get_numa_node(vid);
@@ -577,21 +772,19 @@ new_device(int vid)
                eth_dev->data->numa_node = newnode;
 #endif
 
-       for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
-               vq = eth_dev->data->rx_queues[i];
-               if (vq == NULL)
-                       continue;
-               vq->vid = vid;
-               vq->internal = internal;
-               vq->port = eth_dev->data->port_id;
-       }
-       for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
-               vq = eth_dev->data->tx_queues[i];
-               if (vq == NULL)
-                       continue;
-               vq->vid = vid;
-               vq->internal = internal;
-               vq->port = eth_dev->data->port_id;
+       internal->vid = vid;
+       if (rte_atomic32_read(&internal->started) == 1) {
+               queue_setup(eth_dev, internal);
+
+               if (dev_conf->intr_conf.rxq) {
+                       if (eth_vhost_install_intr(eth_dev) < 0) {
+                               RTE_LOG(INFO, PMD,
+                                       "Failed to install interrupt handler.");
+                                       return -1;
+                       }
+               }
+       } else {
+               RTE_LOG(INFO, PMD, "RX/TX queues not exist yet\n");
        }
 
        for (i = 0; i < rte_vhost_get_vring_num(vid); i++)
@@ -604,7 +797,7 @@ new_device(int vid)
        rte_atomic32_set(&internal->dev_attached, 1);
        update_queuing_status(eth_dev);
 
-       RTE_LOG(INFO, PMD, "New connection established\n");
+       RTE_LOG(INFO, PMD, "Vhost device %d created\n", vid);
 
        _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL);
 
@@ -636,17 +829,19 @@ destroy_device(int vid)
 
        eth_dev->data->dev_link.link_status = ETH_LINK_DOWN;
 
-       for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
-               vq = eth_dev->data->rx_queues[i];
-               if (vq == NULL)
-                       continue;
-               vq->vid = -1;
-       }
-       for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
-               vq = eth_dev->data->tx_queues[i];
-               if (vq == NULL)
-                       continue;
-               vq->vid = -1;
+       if (eth_dev->data->rx_queues && eth_dev->data->tx_queues) {
+               for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
+                       vq = eth_dev->data->rx_queues[i];
+                       if (!vq)
+                               continue;
+                       vq->vid = -1;
+               }
+               for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
+                       vq = eth_dev->data->tx_queues[i];
+                       if (!vq)
+                               continue;
+                       vq->vid = -1;
+               }
        }
 
        state = vring_states[eth_dev->data->port_id];
@@ -658,7 +853,8 @@ destroy_device(int vid)
        state->max_vring = 0;
        rte_spinlock_unlock(&state->lock);
 
-       RTE_LOG(INFO, PMD, "Connection closed\n");
+       RTE_LOG(INFO, PMD, "Vhost device %d destroyed\n", vid);
+       eth_vhost_uninstall_intr(eth_dev);
 
        _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL);
 }
@@ -701,7 +897,7 @@ static struct vhost_device_ops vhost_ops = {
 };
 
 int
-rte_eth_vhost_get_queue_event(uint8_t port_id,
+rte_eth_vhost_get_queue_event(uint16_t port_id,
                struct rte_eth_vhost_queue_event *event)
 {
        struct rte_vhost_vring_state *state;
@@ -738,7 +934,7 @@ rte_eth_vhost_get_queue_event(uint8_t port_id,
 }
 
 int
-rte_eth_vhost_get_vid_from_port_id(uint8_t port_id)
+rte_eth_vhost_get_vid_from_port_id(uint16_t port_id)
 {
        struct internal_list *list;
        struct rte_eth_dev *eth_dev;
@@ -767,12 +963,25 @@ rte_eth_vhost_get_vid_from_port_id(uint8_t port_id)
 }
 
 static int
-eth_dev_start(struct rte_eth_dev *dev)
+eth_dev_start(struct rte_eth_dev *eth_dev)
 {
-       struct pmd_internal *internal = dev->data->dev_private;
+       struct pmd_internal *internal = eth_dev->data->dev_private;
+       struct rte_eth_conf *dev_conf = &eth_dev->data->dev_conf;
+
+       queue_setup(eth_dev, internal);
+
+       if (rte_atomic32_read(&internal->dev_attached) == 1) {
+               if (dev_conf->intr_conf.rxq) {
+                       if (eth_vhost_install_intr(eth_dev) < 0) {
+                               RTE_LOG(INFO, PMD,
+                                       "Failed to install interrupt handler.");
+                                       return -1;
+                       }
+               }
+       }
 
        rte_atomic32_set(&internal->started, 1);
-       update_queuing_status(dev);
+       update_queuing_status(eth_dev);
 
        return 0;
 }
@@ -791,11 +1000,14 @@ eth_dev_close(struct rte_eth_dev *dev)
 {
        struct pmd_internal *internal;
        struct internal_list *list;
+       unsigned int i;
 
        internal = dev->data->dev_private;
        if (!internal)
                return;
 
+       eth_dev_stop(dev);
+
        rte_vhost_driver_unregister(internal->iface_name);
 
        list = find_internal_resource(internal->iface_name);
@@ -807,9 +1019,20 @@ eth_dev_close(struct rte_eth_dev *dev)
        pthread_mutex_unlock(&internal_list_lock);
        rte_free(list);
 
+       if (dev->data->rx_queues)
+               for (i = 0; i < dev->data->nb_rx_queues; i++)
+                       rte_free(dev->data->rx_queues[i]);
+
+       if (dev->data->tx_queues)
+               for (i = 0; i < dev->data->nb_tx_queues; i++)
+                       rte_free(dev->data->tx_queues[i]);
+
+       rte_free(dev->data->mac_addrs);
        free(internal->dev_name);
        free(internal->iface_name);
        rte_free(internal);
+
+       dev->data->dev_private = NULL;
 }
 
 static int
@@ -875,7 +1098,7 @@ eth_dev_info(struct rte_eth_dev *dev,
        dev_info->min_rx_bufsize = 0;
 }
 
-static void
+static int
 eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
        unsigned i;
@@ -913,6 +1136,8 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        stats->oerrors = tx_missed_total;
        stats->ibytes = rx_total_bytes;
        stats->obytes = tx_total_bytes;
+
+       return 0;
 }
 
 static void
@@ -961,6 +1186,18 @@ eth_link_update(struct rte_eth_dev *dev __rte_unused,
        return 0;
 }
 
+static uint32_t
+eth_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       struct vhost_queue *vq;
+
+       vq = dev->data->rx_queues[rx_queue_id];
+       if (vq == NULL)
+               return 0;
+
+       return rte_vhost_rx_queue_count(vq->vid, vq->virtqueue_id);
+}
+
 static const struct eth_dev_ops ops = {
        .dev_start = eth_dev_start,
        .dev_stop = eth_dev_stop,
@@ -972,21 +1209,25 @@ static const struct eth_dev_ops ops = {
        .rx_queue_release = eth_queue_release,
        .tx_queue_release = eth_queue_release,
        .tx_done_cleanup = eth_tx_done_cleanup,
+       .rx_queue_count = eth_rx_queue_count,
        .link_update = eth_link_update,
        .stats_get = eth_stats_get,
        .stats_reset = eth_stats_reset,
        .xstats_reset = vhost_dev_xstats_reset,
        .xstats_get = vhost_dev_xstats_get,
        .xstats_get_names = vhost_dev_xstats_get_names,
+       .rx_queue_intr_enable = eth_rxq_intr_enable,
+       .rx_queue_intr_disable = eth_rxq_intr_disable,
 };
 
 static struct rte_vdev_driver pmd_vhost_drv;
 
 static int
-eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues,
-                    const unsigned numa_node, uint64_t flags)
+eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
+       int16_t queues, const unsigned int numa_node, uint64_t flags)
 {
-       struct rte_eth_dev_data *data = NULL;
+       const char *name = rte_vdev_device_name(dev);
+       struct rte_eth_dev_data *data;
        struct pmd_internal *internal = NULL;
        struct rte_eth_dev *eth_dev = NULL;
        struct ether_addr *eth_addr = NULL;
@@ -996,23 +1237,12 @@ eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues,
        RTE_LOG(INFO, PMD, "Creating VHOST-USER backend on numa socket %u\n",
                numa_node);
 
-       /* now do all data allocation - for eth_dev structure, dummy pci driver
-        * and internal (private) data
-        */
-       data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);
-       if (data == NULL)
-               goto error;
-
-       internal = rte_zmalloc_socket(name, sizeof(*internal), 0, numa_node);
-       if (internal == NULL)
-               goto error;
-
        list = rte_zmalloc_socket(name, sizeof(*list), 0, numa_node);
        if (list == NULL)
                goto error;
 
        /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocate(name);
+       eth_dev = rte_eth_vdev_allocate(dev, sizeof(*internal));
        if (eth_dev == NULL)
                goto error;
 
@@ -1029,10 +1259,10 @@ eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues,
 
        /* now put it all together
         * - store queue data in internal,
-        * - store numa_node info in ethdev data
         * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
+       internal = eth_dev->data->dev_private;
        internal->dev_name = strdup(name);
        if (internal->dev_name == NULL)
                goto error;
@@ -1048,26 +1278,15 @@ eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues,
        rte_spinlock_init(&vring_state->lock);
        vring_states[eth_dev->data->port_id] = vring_state;
 
-       data->dev_private = internal;
-       data->port_id = eth_dev->data->port_id;
-       memmove(data->name, eth_dev->data->name, sizeof(data->name));
+       data = eth_dev->data;
        data->nb_rx_queues = queues;
        data->nb_tx_queues = queues;
        internal->max_queues = queues;
        data->dev_link = pmd_link;
        data->mac_addrs = eth_addr;
+       data->dev_flags = RTE_ETH_DEV_INTR_LSC;
 
-       /* We'll replace the 'data' originally allocated by eth_dev. So the
-        * vhost PMD resources won't be shared between multi processes.
-        */
-       eth_dev->data = data;
        eth_dev->dev_ops = &ops;
-       eth_dev->driver = NULL;
-       data->dev_flags =
-               RTE_ETH_DEV_DETACHABLE | RTE_ETH_DEV_INTR_LSC;
-       data->kdrv = RTE_KDRV_NONE;
-       data->drv_name = pmd_vhost_drv.driver.name;
-       data->numa_node = numa_node;
 
        /* finally assign rx and tx ops */
        eth_dev->rx_pkt_burst = eth_vhost_rx;
@@ -1090,15 +1309,16 @@ eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues,
        return data->port_id;
 
 error:
-       if (internal)
+       if (internal) {
+               free(internal->iface_name);
                free(internal->dev_name);
+       }
        rte_free(vring_state);
        rte_free(eth_addr);
        if (eth_dev)
                rte_eth_dev_release_port(eth_dev);
        rte_free(internal);
        rte_free(list);
-       rte_free(data);
 
        return -1;
 }
@@ -1134,7 +1354,6 @@ open_int(const char *key __rte_unused, const char *value, void *extra_args)
 static int
 rte_pmd_vhost_probe(struct rte_vdev_device *dev)
 {
-       const char *name;
        struct rte_kvargs *kvlist = NULL;
        int ret = 0;
        char *iface_name;
@@ -1142,9 +1361,10 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
        uint64_t flags = 0;
        int client_mode = 0;
        int dequeue_zero_copy = 0;
+       int iommu_support = 0;
 
-       name = rte_vdev_device_name(dev);
-       RTE_LOG(INFO, PMD, "Initializing pmd_vhost for %s\n", name);
+       RTE_LOG(INFO, PMD, "Initializing pmd_vhost for %s\n",
+               rte_vdev_device_name(dev));
 
        kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_arguments);
        if (kvlist == NULL)
@@ -1189,7 +1409,21 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
                        flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
        }
 
-       eth_dev_vhost_create(name, iface_name, queues, rte_socket_id(), flags);
+       if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) {
+               ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT,
+                                        &open_int, &iommu_support);
+               if (ret < 0)
+                       goto out_free;
+
+               if (iommu_support)
+                       flags |= RTE_VHOST_USER_IOMMU_SUPPORT;
+       }
+
+       if (dev->device.numa_node == SOCKET_ID_ANY)
+               dev->device.numa_node = rte_socket_id();
+
+       eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
+               flags);
 
 out_free:
        rte_kvargs_free(kvlist);
@@ -1201,7 +1435,6 @@ rte_pmd_vhost_remove(struct rte_vdev_device *dev)
 {
        const char *name;
        struct rte_eth_dev *eth_dev = NULL;
-       unsigned int i;
 
        name = rte_vdev_device_name(dev);
        RTE_LOG(INFO, PMD, "Un-Initializing pmd_vhost for %s\n", name);
@@ -1211,21 +1444,11 @@ rte_pmd_vhost_remove(struct rte_vdev_device *dev)
        if (eth_dev == NULL)
                return -ENODEV;
 
-       eth_dev_stop(eth_dev);
-
        eth_dev_close(eth_dev);
 
        rte_free(vring_states[eth_dev->data->port_id]);
        vring_states[eth_dev->data->port_id] = NULL;
 
-       for (i = 0; i < eth_dev->data->nb_rx_queues; i++)
-               rte_free(eth_dev->data->rx_queues[i]);
-       for (i = 0; i < eth_dev->data->nb_tx_queues; i++)
-               rte_free(eth_dev->data->tx_queues[i]);
-
-       rte_free(eth_dev->data->mac_addrs);
-       rte_free(eth_dev->data);
-
        rte_eth_dev_release_port(eth_dev);
 
        return 0;