ethdev: remove legacy Rx descriptor done API
[dpdk.git] / drivers / net / virtio / virtio_user / virtio_user_dev.c
index 7941271..6a61455 100644 (file)
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2016 Intel Corporation
  */
 
 #include <stdint.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 
+#include <rte_alarm.h>
+#include <rte_string_fns.h>
+#include <rte_eal_memconfig.h>
+
 #include "vhost.h"
 #include "virtio_user_dev.h"
 #include "../virtio_ethdev.h"
 
+#define VIRTIO_USER_MEM_EVENT_CLB_NAME "virtio_user_mem_event_clb"
+
+const char * const virtio_user_backend_strings[] = {
+       [VIRTIO_USER_BACKEND_UNKNOWN] = "VIRTIO_USER_BACKEND_UNKNOWN",
+       [VIRTIO_USER_BACKEND_VHOST_USER] = "VHOST_USER",
+       [VIRTIO_USER_BACKEND_VHOST_KERNEL] = "VHOST_NET",
+       [VIRTIO_USER_BACKEND_VHOST_VDPA] = "VHOST_VDPA",
+};
+
 static int
 virtio_user_create_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
 {
@@ -54,10 +38,15 @@ virtio_user_create_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
         * pair.
         */
        struct vhost_vring_file file;
+       int ret;
 
        file.index = queue_sel;
        file.fd = dev->callfds[queue_sel];
-       dev->ops->send_request(dev, VHOST_USER_SET_VRING_CALL, &file);
+       ret = dev->ops->set_vring_call(dev, &file);
+       if (ret < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to create queue %u", dev->path, queue_sel);
+               return -1;
+       }
 
        return 0;
 }
@@ -65,27 +54,47 @@ virtio_user_create_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
 static int
 virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
 {
+       int ret;
        struct vhost_vring_file file;
        struct vhost_vring_state state;
        struct vring *vring = &dev->vrings[queue_sel];
+       struct vring_packed *pq_vring = &dev->packed_vrings[queue_sel];
        struct vhost_vring_addr addr = {
                .index = queue_sel,
-               .desc_user_addr = (uint64_t)(uintptr_t)vring->desc,
-               .avail_user_addr = (uint64_t)(uintptr_t)vring->avail,
-               .used_user_addr = (uint64_t)(uintptr_t)vring->used,
                .log_guest_addr = 0,
                .flags = 0, /* disable log */
        };
 
+       if (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {
+               addr.desc_user_addr =
+                       (uint64_t)(uintptr_t)pq_vring->desc;
+               addr.avail_user_addr =
+                       (uint64_t)(uintptr_t)pq_vring->driver;
+               addr.used_user_addr =
+                       (uint64_t)(uintptr_t)pq_vring->device;
+       } else {
+               addr.desc_user_addr = (uint64_t)(uintptr_t)vring->desc;
+               addr.avail_user_addr = (uint64_t)(uintptr_t)vring->avail;
+               addr.used_user_addr = (uint64_t)(uintptr_t)vring->used;
+       }
+
        state.index = queue_sel;
        state.num = vring->num;
-       dev->ops->send_request(dev, VHOST_USER_SET_VRING_NUM, &state);
+       ret = dev->ops->set_vring_num(dev, &state);
+       if (ret < 0)
+               goto err;
 
        state.index = queue_sel;
        state.num = 0; /* no reservation */
-       dev->ops->send_request(dev, VHOST_USER_SET_VRING_BASE, &state);
+       if (dev->features & (1ULL << VIRTIO_F_RING_PACKED))
+               state.num |= (1 << 15);
+       ret = dev->ops->set_vring_base(dev, &state);
+       if (ret < 0)
+               goto err;
 
-       dev->ops->send_request(dev, VHOST_USER_SET_VRING_ADDR, &addr);
+       ret = dev->ops->set_vring_addr(dev, &addr);
+       if (ret < 0)
+               goto err;
 
        /* Of all per virtqueue MSGs, make sure VHOST_USER_SET_VRING_KICK comes
         * lastly because vhost depends on this msg to judge if
@@ -93,9 +102,15 @@ virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
         */
        file.index = queue_sel;
        file.fd = dev->kickfds[queue_sel];
-       dev->ops->send_request(dev, VHOST_USER_SET_VRING_KICK, &file);
+       ret = dev->ops->set_vring_kick(dev, &file);
+       if (ret < 0)
+               goto err;
 
        return 0;
+err:
+       PMD_INIT_LOG(ERR, "(%s) Failed to kick queue %u", dev->path, queue_sel);
+
+       return -1;
 }
 
 static int
@@ -107,14 +122,14 @@ virtio_user_queue_setup(struct virtio_user_dev *dev,
        for (i = 0; i < dev->max_queue_pairs; ++i) {
                queue_sel = 2 * i + VTNET_SQ_RQ_QUEUE_IDX;
                if (fn(dev, queue_sel) < 0) {
-                       PMD_DRV_LOG(INFO, "setup rx vq fails: %u", i);
+                       PMD_DRV_LOG(ERR, "(%s) setup rx vq %u failed", dev->path, i);
                        return -1;
                }
        }
        for (i = 0; i < dev->max_queue_pairs; ++i) {
                queue_sel = 2 * i + VTNET_SQ_TQ_QUEUE_IDX;
                if (fn(dev, queue_sel) < 0) {
-                       PMD_DRV_LOG(INFO, "setup tx vq fails: %u", i);
+                       PMD_DRV_LOG(INFO, "(%s) setup tx vq %u failed", dev->path, i);
                        return -1;
                }
        }
@@ -123,87 +138,206 @@ virtio_user_queue_setup(struct virtio_user_dev *dev,
 }
 
 int
-virtio_user_start_device(struct virtio_user_dev *dev)
+virtio_user_dev_set_features(struct virtio_user_dev *dev)
 {
        uint64_t features;
-       int ret;
+       int ret = -1;
+
+       pthread_mutex_lock(&dev->mutex);
 
        /* Step 0: tell vhost to create queues */
        if (virtio_user_queue_setup(dev, virtio_user_create_queue) < 0)
                goto error;
 
-       /* Step 1: set features */
        features = dev->features;
+
        /* Strip VIRTIO_NET_F_MAC, as MAC address is handled in vdev init */
        features &= ~(1ull << VIRTIO_NET_F_MAC);
        /* Strip VIRTIO_NET_F_CTRL_VQ, as devices do not really need to know */
        features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ);
        features &= ~(1ull << VIRTIO_NET_F_STATUS);
-       ret = dev->ops->send_request(dev, VHOST_USER_SET_FEATURES, &features);
+       ret = dev->ops->set_features(dev, features);
        if (ret < 0)
                goto error;
-       PMD_DRV_LOG(INFO, "set features: %" PRIx64, features);
+       PMD_DRV_LOG(INFO, "(%s) set features: 0x%" PRIx64, dev->path, features);
+error:
+       pthread_mutex_unlock(&dev->mutex);
+
+       return ret;
+}
+
+int
+virtio_user_start_device(struct virtio_user_dev *dev)
+{
+       int ret;
+
+       /*
+        * XXX workaround!
+        *
+        * We need to make sure that the locks will be
+        * taken in the correct order to avoid deadlocks.
+        *
+        * Before releasing this lock, this thread should
+        * not trigger any memory hotplug events.
+        *
+        * This is a temporary workaround, and should be
+        * replaced when we get proper supports from the
+        * memory subsystem in the future.
+        */
+       rte_mcfg_mem_read_lock();
+       pthread_mutex_lock(&dev->mutex);
 
        /* Step 2: share memory regions */
-       ret = dev->ops->send_request(dev, VHOST_USER_SET_MEM_TABLE, NULL);
+       ret = dev->ops->set_memory_table(dev);
        if (ret < 0)
                goto error;
 
        /* Step 3: kick queues */
-       if (virtio_user_queue_setup(dev, virtio_user_kick_queue) < 0)
+       ret = virtio_user_queue_setup(dev, virtio_user_kick_queue);
+       if (ret < 0)
                goto error;
 
        /* Step 4: enable queues
         * we enable the 1st queue pair by default.
         */
-       dev->ops->enable_qp(dev, 0, 1);
+       ret = dev->ops->enable_qp(dev, 0, 1);
+       if (ret < 0)
+               goto error;
+
+       dev->started = true;
+
+       pthread_mutex_unlock(&dev->mutex);
+       rte_mcfg_mem_read_unlock();
 
        return 0;
 error:
+       pthread_mutex_unlock(&dev->mutex);
+       rte_mcfg_mem_read_unlock();
+
+       PMD_INIT_LOG(ERR, "(%s) Failed to start device", dev->path);
+
        /* TODO: free resource here or caller to check */
        return -1;
 }
 
 int virtio_user_stop_device(struct virtio_user_dev *dev)
 {
+       struct vhost_vring_state state;
        uint32_t i;
+       int ret;
 
-       for (i = 0; i < dev->max_queue_pairs; ++i)
-               dev->ops->enable_qp(dev, i, 0);
+       pthread_mutex_lock(&dev->mutex);
+       if (!dev->started)
+               goto out;
+
+       for (i = 0; i < dev->max_queue_pairs; ++i) {
+               ret = dev->ops->enable_qp(dev, i, 0);
+               if (ret < 0)
+                       goto err;
+       }
+
+       /* Stop the backend. */
+       for (i = 0; i < dev->max_queue_pairs * 2; ++i) {
+               state.index = i;
+               ret = dev->ops->get_vring_base(dev, &state);
+               if (ret < 0) {
+                       PMD_DRV_LOG(ERR, "(%s) get_vring_base failed, index=%u", dev->path, i);
+                       goto err;
+               }
+       }
+
+       dev->started = false;
+
+out:
+       pthread_mutex_unlock(&dev->mutex);
 
        return 0;
+err:
+       pthread_mutex_unlock(&dev->mutex);
+
+       PMD_INIT_LOG(ERR, "(%s) Failed to stop device", dev->path);
+
+       return -1;
 }
 
-static inline void
-parse_mac(struct virtio_user_dev *dev, const char *mac)
+int
+virtio_user_dev_set_mac(struct virtio_user_dev *dev)
 {
-       int i, r;
-       uint32_t tmp[ETHER_ADDR_LEN];
+       int ret = 0;
 
-       if (!mac)
-               return;
+       if (!(dev->device_features & (1ULL << VIRTIO_NET_F_MAC)))
+               return -ENOTSUP;
 
-       r = sscanf(mac, "%x:%x:%x:%x:%x:%x", &tmp[0],
-                       &tmp[1], &tmp[2], &tmp[3], &tmp[4], &tmp[5]);
-       if (r == ETHER_ADDR_LEN) {
-               for (i = 0; i < ETHER_ADDR_LEN; ++i)
-                       dev->mac_addr[i] = (uint8_t)tmp[i];
-               dev->mac_specified = 1;
-       } else {
-               /* ignore the wrong mac, use random mac */
-               PMD_DRV_LOG(ERR, "wrong format of mac: %s", mac);
-       }
+       if (!dev->ops->set_config)
+               return -ENOTSUP;
+
+       ret = dev->ops->set_config(dev, dev->mac_addr,
+                       offsetof(struct virtio_net_config, mac),
+                       RTE_ETHER_ADDR_LEN);
+       if (ret)
+               PMD_DRV_LOG(ERR, "(%s) Failed to set MAC address in device", dev->path);
+
+       return ret;
 }
 
 int
-is_vhost_user_by_type(const char *path)
+virtio_user_dev_get_mac(struct virtio_user_dev *dev)
 {
-       struct stat sb;
+       int ret = 0;
+
+       if (!(dev->device_features & (1ULL << VIRTIO_NET_F_MAC)))
+               return -ENOTSUP;
+
+       if (!dev->ops->get_config)
+               return -ENOTSUP;
 
-       if (stat(path, &sb) == -1)
-               return 0;
+       ret = dev->ops->get_config(dev, dev->mac_addr,
+                       offsetof(struct virtio_net_config, mac),
+                       RTE_ETHER_ADDR_LEN);
+       if (ret)
+               PMD_DRV_LOG(ERR, "(%s) Failed to get MAC address from device", dev->path);
 
-       return S_ISSOCK(sb.st_mode);
+       return ret;
+}
+
+static void
+virtio_user_dev_init_mac(struct virtio_user_dev *dev, const char *mac)
+{
+       struct rte_ether_addr cmdline_mac;
+       char buf[RTE_ETHER_ADDR_FMT_SIZE];
+       int ret;
+
+       if (mac && rte_ether_unformat_addr(mac, &cmdline_mac) == 0) {
+               /*
+                * MAC address was passed from command-line, try to store
+                * it in the device if it supports it. Otherwise try to use
+                * the device one.
+                */
+               memcpy(dev->mac_addr, &cmdline_mac, RTE_ETHER_ADDR_LEN);
+               dev->mac_specified = 1;
+
+               /* Setting MAC may fail, continue to get the device one in this case */
+               virtio_user_dev_set_mac(dev);
+               ret = virtio_user_dev_get_mac(dev);
+               if (ret == -ENOTSUP)
+                       goto out;
+
+               if (memcmp(&cmdline_mac, dev->mac_addr, RTE_ETHER_ADDR_LEN))
+                       PMD_DRV_LOG(INFO, "(%s) Device MAC update failed", dev->path);
+       } else {
+               ret = virtio_user_dev_get_mac(dev);
+               if (ret) {
+                       PMD_DRV_LOG(ERR, "(%s) No valid MAC in devargs or device, use random",
+                                       dev->path);
+                       return;
+               }
+
+               dev->mac_specified = 1;
+       }
+out:
+       rte_ether_format_addr(buf, RTE_ETHER_ADDR_FMT_SIZE,
+                       (struct rte_ether_addr *)dev->mac_addr);
+       PMD_DRV_LOG(INFO, "(%s) MAC %s specified", dev->path, buf);
 }
 
 static int
@@ -213,106 +347,181 @@ virtio_user_dev_init_notify(struct virtio_user_dev *dev)
        int callfd;
        int kickfd;
 
-       for (i = 0; i < VIRTIO_MAX_VIRTQUEUES; ++i) {
-               if (i >= dev->max_queue_pairs * 2) {
-                       dev->kickfds[i] = -1;
-                       dev->callfds[i] = -1;
-                       continue;
-               }
-
+       for (i = 0; i < dev->max_queue_pairs * 2; i++) {
                /* May use invalid flag, but some backend uses kickfd and
                 * callfd as criteria to judge if dev is alive. so finally we
                 * use real event_fd.
                 */
                callfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
                if (callfd < 0) {
-                       PMD_DRV_LOG(ERR, "callfd error, %s", strerror(errno));
-                       break;
+                       PMD_DRV_LOG(ERR, "(%s) callfd error, %s", dev->path, strerror(errno));
+                       goto err;
                }
                kickfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
                if (kickfd < 0) {
-                       PMD_DRV_LOG(ERR, "kickfd error, %s", strerror(errno));
-                       break;
+                       close(callfd);
+                       PMD_DRV_LOG(ERR, "(%s) kickfd error, %s", dev->path, strerror(errno));
+                       goto err;
                }
                dev->callfds[i] = callfd;
                dev->kickfds[i] = kickfd;
        }
 
-       if (i < VIRTIO_MAX_VIRTQUEUES) {
-               for (j = 0; j <= i; ++j) {
-                       close(dev->callfds[j]);
+       return 0;
+err:
+       for (j = 0; j < i; j++) {
+               if (dev->kickfds[j] >= 0) {
                        close(dev->kickfds[j]);
+                       dev->kickfds[j] = -1;
+               }
+               if (dev->callfds[j] >= 0) {
+                       close(dev->callfds[j]);
+                       dev->callfds[j] = -1;
                }
-
-               return -1;
        }
 
-       return 0;
+       return -1;
+}
+
+static void
+virtio_user_dev_uninit_notify(struct virtio_user_dev *dev)
+{
+       uint32_t i;
+
+       for (i = 0; i < dev->max_queue_pairs * 2; ++i) {
+               if (dev->kickfds[i] >= 0) {
+                       close(dev->kickfds[i]);
+                       dev->kickfds[i] = -1;
+               }
+               if (dev->callfds[i] >= 0) {
+                       close(dev->callfds[i]);
+                       dev->callfds[i] = -1;
+               }
+       }
 }
 
 static int
 virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
 {
        uint32_t i;
-       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->port_id];
+       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
 
        if (!eth_dev->intr_handle) {
                eth_dev->intr_handle = malloc(sizeof(*eth_dev->intr_handle));
                if (!eth_dev->intr_handle) {
-                       PMD_DRV_LOG(ERR, "fail to allocate intr_handle");
+                       PMD_DRV_LOG(ERR, "(%s) failed to allocate intr_handle", dev->path);
                        return -1;
                }
                memset(eth_dev->intr_handle, 0, sizeof(*eth_dev->intr_handle));
        }
 
        for (i = 0; i < dev->max_queue_pairs; ++i)
-               eth_dev->intr_handle->efds[i] = dev->callfds[i];
+               eth_dev->intr_handle->efds[i] = dev->callfds[2 * i];
        eth_dev->intr_handle->nb_efd = dev->max_queue_pairs;
        eth_dev->intr_handle->max_intr = dev->max_queue_pairs + 1;
        eth_dev->intr_handle->type = RTE_INTR_HANDLE_VDEV;
-       if (dev->vhostfd >= 0)
-               eth_dev->intr_handle->fd = dev->vhostfd;
+       /* For virtio vdev, no need to read counter for clean */
+       eth_dev->intr_handle->efd_counter_size = 0;
+       eth_dev->intr_handle->fd = dev->ops->get_intr_fd(dev);
 
        return 0;
 }
 
-static int
-virtio_user_dev_setup(struct virtio_user_dev *dev)
+static void
+virtio_user_mem_event_cb(enum rte_mem_event type __rte_unused,
+                        const void *addr,
+                        size_t len __rte_unused,
+                        void *arg)
 {
-       uint32_t q;
+       struct virtio_user_dev *dev = arg;
+       struct rte_memseg_list *msl;
+       uint16_t i;
+       int ret = 0;
 
-       dev->vhostfd = -1;
-       dev->vhostfds = NULL;
-       dev->tapfds = NULL;
+       /* ignore externally allocated memory */
+       msl = rte_mem_virt2memseg_list(addr);
+       if (msl->external)
+               return;
 
-       if (is_vhost_user_by_type(dev->path)) {
-               dev->ops = &ops_user;
-       } else {
-               dev->ops = &ops_kernel;
+       pthread_mutex_lock(&dev->mutex);
 
-               dev->vhostfds = malloc(dev->max_queue_pairs * sizeof(int));
-               dev->tapfds = malloc(dev->max_queue_pairs * sizeof(int));
-               if (!dev->vhostfds || !dev->tapfds) {
-                       PMD_INIT_LOG(ERR, "Failed to malloc");
-                       return -1;
-               }
+       if (dev->started == false)
+               goto exit;
 
-               for (q = 0; q < dev->max_queue_pairs; ++q) {
-                       dev->vhostfds[q] = -1;
-                       dev->tapfds[q] = -1;
+       /* Step 1: pause the active queues */
+       for (i = 0; i < dev->queue_pairs; i++) {
+               ret = dev->ops->enable_qp(dev, i, 0);
+               if (ret < 0)
+                       goto exit;
+       }
+
+       /* Step 2: update memory regions */
+       ret = dev->ops->set_memory_table(dev);
+       if (ret < 0)
+               goto exit;
+
+       /* Step 3: resume the active queues */
+       for (i = 0; i < dev->queue_pairs; i++) {
+               ret = dev->ops->enable_qp(dev, i, 1);
+               if (ret < 0)
+                       goto exit;
+       }
+
+exit:
+       pthread_mutex_unlock(&dev->mutex);
+
+       if (ret < 0)
+               PMD_DRV_LOG(ERR, "(%s) Failed to update memory table", dev->path);
+}
+
+static int
+virtio_user_dev_setup(struct virtio_user_dev *dev)
+{
+       if (dev->is_server) {
+               if (dev->backend_type != VIRTIO_USER_BACKEND_VHOST_USER) {
+                       PMD_DRV_LOG(ERR, "Server mode only supports vhost-user!");
+                       return -1;
                }
        }
 
-       if (dev->ops->setup(dev) < 0)
+       switch (dev->backend_type) {
+       case VIRTIO_USER_BACKEND_VHOST_USER:
+               dev->ops = &virtio_ops_user;
+               break;
+       case VIRTIO_USER_BACKEND_VHOST_KERNEL:
+               dev->ops = &virtio_ops_kernel;
+               break;
+       case VIRTIO_USER_BACKEND_VHOST_VDPA:
+               dev->ops = &virtio_ops_vdpa;
+               break;
+       default:
+               PMD_DRV_LOG(ERR, "(%s) Unknown backend type", dev->path);
                return -1;
+       }
 
-       if (virtio_user_dev_init_notify(dev) < 0)
+       if (dev->ops->setup(dev) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to setup backend", dev->path);
                return -1;
+       }
 
-       if (virtio_user_fill_intr_handle(dev) < 0)
-               return -1;
+       if (virtio_user_dev_init_notify(dev) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to init notifiers", dev->path);
+               goto destroy;
+       }
+
+       if (virtio_user_fill_intr_handle(dev) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to init interrupt handler", dev->path);
+               goto uninit;
+       }
 
        return 0;
+
+uninit:
+       virtio_user_dev_uninit_notify(dev);
+destroy:
+       dev->ops->destroy(dev);
+
+       return -1;
 }
 
 /* Use below macro to filter features from vhost backend */
@@ -332,18 +541,36 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
         1ULL << VIRTIO_NET_F_GUEST_CSUM        |       \
         1ULL << VIRTIO_NET_F_GUEST_TSO4        |       \
         1ULL << VIRTIO_NET_F_GUEST_TSO6        |       \
-        1ULL << VIRTIO_F_VERSION_1)
+        1ULL << VIRTIO_F_IN_ORDER              |       \
+        1ULL << VIRTIO_F_VERSION_1             |       \
+        1ULL << VIRTIO_F_RING_PACKED)
 
 int
 virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
-                    int cq, int queue_size, const char *mac, char **ifname)
+                    int cq, int queue_size, const char *mac, char **ifname,
+                    int server, int mrg_rxbuf, int in_order, int packed_vq,
+                    enum virtio_user_backend_type backend_type)
 {
-       snprintf(dev->path, PATH_MAX, "%s", path);
+       uint64_t backend_features;
+       int i;
+
+       pthread_mutex_init(&dev->mutex, NULL);
+       strlcpy(dev->path, path, PATH_MAX);
+
+       for (i = 0; i < VIRTIO_MAX_VIRTQUEUES; i++) {
+               dev->kickfds[i] = -1;
+               dev->callfds[i] = -1;
+       }
+
+       dev->started = 0;
        dev->max_queue_pairs = queues;
        dev->queue_pairs = 1; /* mq disabled by default */
        dev->queue_size = queue_size;
+       dev->is_server = server;
        dev->mac_specified = 0;
-       parse_mac(dev, mac);
+       dev->frontend_features = 0;
+       dev->unsupported_features = 0;
+       dev->backend_type = backend_type;
 
        if (*ifname) {
                dev->ifname = *ifname;
@@ -351,42 +578,75 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
        }
 
        if (virtio_user_dev_setup(dev) < 0) {
-               PMD_INIT_LOG(ERR, "backend set up fails");
+               PMD_INIT_LOG(ERR, "(%s) backend set up fails", dev->path);
                return -1;
        }
-       if (dev->ops->send_request(dev, VHOST_USER_SET_OWNER, NULL) < 0) {
-               PMD_INIT_LOG(ERR, "set_owner fails: %s", strerror(errno));
+
+       if (dev->ops->set_owner(dev) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev->path);
+               return -1;
+       }
+
+       if (dev->ops->get_backend_features(&backend_features) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to get backend features", dev->path);
                return -1;
        }
 
-       if (dev->ops->send_request(dev, VHOST_USER_GET_FEATURES,
-                           &dev->device_features) < 0) {
-               PMD_INIT_LOG(ERR, "get_features failed: %s", strerror(errno));
+       dev->unsupported_features = ~(VIRTIO_USER_SUPPORTED_FEATURES | backend_features);
+
+       if (dev->ops->get_features(dev, &dev->device_features) < 0) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to get device features", dev->path);
                return -1;
        }
+
+       virtio_user_dev_init_mac(dev, mac);
+
+       if (!mrg_rxbuf)
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_MRG_RXBUF);
+
+       if (!in_order)
+               dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);
+
+       if (!packed_vq)
+               dev->unsupported_features |= (1ull << VIRTIO_F_RING_PACKED);
+
        if (dev->mac_specified)
-               dev->device_features |= (1ull << VIRTIO_NET_F_MAC);
+               dev->frontend_features |= (1ull << VIRTIO_NET_F_MAC);
+       else
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_MAC);
 
        if (cq) {
                /* device does not really need to know anything about CQ,
                 * so if necessary, we just claim to support CQ
                 */
-               dev->device_features |= (1ull << VIRTIO_NET_F_CTRL_VQ);
+               dev->frontend_features |= (1ull << VIRTIO_NET_F_CTRL_VQ);
        } else {
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ);
-               /* Also disable features depends on VIRTIO_NET_F_CTRL_VQ */
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX);
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN);
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_GUEST_ANNOUNCE);
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_MQ);
-               dev->device_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR);
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_CTRL_VQ);
+               /* Also disable features that depend on VIRTIO_NET_F_CTRL_VQ */
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_CTRL_RX);
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_CTRL_VLAN);
+               dev->unsupported_features |=
+                       (1ull << VIRTIO_NET_F_GUEST_ANNOUNCE);
+               dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ);
+               dev->unsupported_features |=
+                       (1ull << VIRTIO_NET_F_CTRL_MAC_ADDR);
        }
 
        /* The backend will not report this feature, we add it explicitly */
-       if (is_vhost_user_by_type(dev->path))
-               dev->device_features |= (1ull << VIRTIO_NET_F_STATUS);
+       if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER)
+               dev->frontend_features |= (1ull << VIRTIO_NET_F_STATUS);
 
-       dev->device_features &= VIRTIO_USER_SUPPORTED_FEATURES;
+       dev->frontend_features &= ~dev->unsupported_features;
+       dev->device_features &= ~dev->unsupported_features;
+
+       if (rte_mem_event_callback_register(VIRTIO_USER_MEM_EVENT_CLB_NAME,
+                               virtio_user_mem_event_cb, dev)) {
+               if (rte_errno != ENOTSUP) {
+                       PMD_INIT_LOG(ERR, "(%s) Failed to register mem event callback",
+                                       dev->path);
+                       return -1;
+               }
+       }
 
        return 0;
 }
@@ -394,36 +654,36 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
 void
 virtio_user_dev_uninit(struct virtio_user_dev *dev)
 {
-       uint32_t i;
-
-       virtio_user_stop_device(dev);
+       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
 
-       for (i = 0; i < dev->max_queue_pairs * 2; ++i) {
-               close(dev->callfds[i]);
-               close(dev->kickfds[i]);
+       if (eth_dev->intr_handle) {
+               free(eth_dev->intr_handle);
+               eth_dev->intr_handle = NULL;
        }
 
-       close(dev->vhostfd);
+       virtio_user_stop_device(dev);
 
-       if (dev->vhostfds) {
-               for (i = 0; i < dev->max_queue_pairs; ++i)
-                       close(dev->vhostfds[i]);
-               free(dev->vhostfds);
-               free(dev->tapfds);
-       }
+       rte_mem_event_callback_unregister(VIRTIO_USER_MEM_EVENT_CLB_NAME, dev);
+
+       virtio_user_dev_uninit_notify(dev);
 
        free(dev->ifname);
+
+       if (dev->is_server)
+               unlink(dev->path);
+
+       dev->ops->destroy(dev);
 }
 
-static uint8_t
+uint8_t
 virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs)
 {
        uint16_t i;
        uint8_t ret = 0;
 
        if (q_pairs > dev->max_queue_pairs) {
-               PMD_INIT_LOG(ERR, "multi-q config %u, but only %u supported",
-                            q_pairs, dev->max_queue_pairs);
+               PMD_INIT_LOG(ERR, "(%s) multi-q config %u, but only %u supported",
+                            dev->path, q_pairs, dev->max_queue_pairs);
                return -1;
        }
 
@@ -467,6 +727,10 @@ virtio_user_handle_ctrl_msg(struct virtio_user_dev *dev, struct vring *vring,
 
                queues = *(uint16_t *)(uintptr_t)vring->desc[idx_data].addr;
                status = virtio_user_handle_mq(dev, queues);
+       } else if (hdr->class == VIRTIO_NET_CTRL_RX  ||
+                  hdr->class == VIRTIO_NET_CTRL_MAC ||
+                  hdr->class == VIRTIO_NET_CTRL_VLAN) {
+               status = 0;
        }
 
        /* Update status */
@@ -475,6 +739,98 @@ virtio_user_handle_ctrl_msg(struct virtio_user_dev *dev, struct vring *vring,
        return n_descs;
 }
 
+static inline int
+desc_is_avail(struct vring_packed_desc *desc, bool wrap_counter)
+{
+       uint16_t flags = __atomic_load_n(&desc->flags, __ATOMIC_ACQUIRE);
+
+       return wrap_counter == !!(flags & VRING_PACKED_DESC_F_AVAIL) &&
+               wrap_counter != !!(flags & VRING_PACKED_DESC_F_USED);
+}
+
+static uint32_t
+virtio_user_handle_ctrl_msg_packed(struct virtio_user_dev *dev,
+                                  struct vring_packed *vring,
+                                  uint16_t idx_hdr)
+{
+       struct virtio_net_ctrl_hdr *hdr;
+       virtio_net_ctrl_ack status = ~0;
+       uint16_t idx_data, idx_status;
+       /* initialize to one, header is first */
+       uint32_t n_descs = 1;
+
+       /* locate desc for header, data, and status */
+       idx_data = idx_hdr + 1;
+       if (idx_data >= dev->queue_size)
+               idx_data -= dev->queue_size;
+
+       n_descs++;
+
+       idx_status = idx_data;
+       while (vring->desc[idx_status].flags & VRING_DESC_F_NEXT) {
+               idx_status++;
+               if (idx_status >= dev->queue_size)
+                       idx_status -= dev->queue_size;
+               n_descs++;
+       }
+
+       hdr = (void *)(uintptr_t)vring->desc[idx_hdr].addr;
+       if (hdr->class == VIRTIO_NET_CTRL_MQ &&
+           hdr->cmd == VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET) {
+               uint16_t queues;
+
+               queues = *(uint16_t *)(uintptr_t)
+                               vring->desc[idx_data].addr;
+               status = virtio_user_handle_mq(dev, queues);
+       } else if (hdr->class == VIRTIO_NET_CTRL_RX  ||
+                  hdr->class == VIRTIO_NET_CTRL_MAC ||
+                  hdr->class == VIRTIO_NET_CTRL_VLAN) {
+               status = 0;
+       }
+
+       /* Update status */
+       *(virtio_net_ctrl_ack *)(uintptr_t)
+               vring->desc[idx_status].addr = status;
+
+       /* Update used descriptor */
+       vring->desc[idx_hdr].id = vring->desc[idx_status].id;
+       vring->desc[idx_hdr].len = sizeof(status);
+
+       return n_descs;
+}
+
+void
+virtio_user_handle_cq_packed(struct virtio_user_dev *dev, uint16_t queue_idx)
+{
+       struct virtio_user_queue *vq = &dev->packed_queues[queue_idx];
+       struct vring_packed *vring = &dev->packed_vrings[queue_idx];
+       uint16_t n_descs, flags;
+
+       /* Perform a load-acquire barrier in desc_is_avail to
+        * enforce the ordering between desc flags and desc
+        * content.
+        */
+       while (desc_is_avail(&vring->desc[vq->used_idx],
+                            vq->used_wrap_counter)) {
+
+               n_descs = virtio_user_handle_ctrl_msg_packed(dev, vring,
+                               vq->used_idx);
+
+               flags = VRING_DESC_F_WRITE;
+               if (vq->used_wrap_counter)
+                       flags |= VRING_PACKED_DESC_F_AVAIL_USED;
+
+               __atomic_store_n(&vring->desc[vq->used_idx].flags, flags,
+                                __ATOMIC_RELEASE);
+
+               vq->used_idx += n_descs;
+               if (vq->used_idx >= dev->queue_size) {
+                       vq->used_idx -= dev->queue_size;
+                       vq->used_wrap_counter ^= 1;
+               }
+       }
+}
+
 void
 virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx)
 {
@@ -484,17 +840,253 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx)
        struct vring *vring = &dev->vrings[queue_idx];
 
        /* Consume avail ring, using used ring idx as first one */
-       while (vring->used->idx != vring->avail->idx) {
-               avail_idx = (vring->used->idx) & (vring->num - 1);
+       while (__atomic_load_n(&vring->used->idx, __ATOMIC_RELAXED)
+              != vring->avail->idx) {
+               avail_idx = __atomic_load_n(&vring->used->idx, __ATOMIC_RELAXED)
+                           & (vring->num - 1);
                desc_idx = vring->avail->ring[avail_idx];
 
                n_descs = virtio_user_handle_ctrl_msg(dev, vring, desc_idx);
 
                /* Update used ring */
                uep = &vring->used->ring[avail_idx];
-               uep->id = avail_idx;
+               uep->id = desc_idx;
                uep->len = n_descs;
 
-               vring->used->idx++;
+               __atomic_add_fetch(&vring->used->idx, 1, __ATOMIC_RELAXED);
+       }
+}
+
+int
+virtio_user_dev_set_status(struct virtio_user_dev *dev, uint8_t status)
+{
+       int ret;
+
+       pthread_mutex_lock(&dev->mutex);
+       dev->status = status;
+       ret = dev->ops->set_status(dev, status);
+       if (ret && ret != -ENOTSUP)
+               PMD_INIT_LOG(ERR, "(%s) Failed to set backend status", dev->path);
+
+       pthread_mutex_unlock(&dev->mutex);
+       return ret;
+}
+
+int
+virtio_user_dev_update_status(struct virtio_user_dev *dev)
+{
+       int ret;
+       uint8_t status;
+
+       pthread_mutex_lock(&dev->mutex);
+
+       ret = dev->ops->get_status(dev, &status);
+       if (!ret) {
+               dev->status = status;
+               PMD_INIT_LOG(DEBUG, "Updated Device Status(0x%08x):\n"
+                       "\t-RESET: %u\n"
+                       "\t-ACKNOWLEDGE: %u\n"
+                       "\t-DRIVER: %u\n"
+                       "\t-DRIVER_OK: %u\n"
+                       "\t-FEATURES_OK: %u\n"
+                       "\t-DEVICE_NEED_RESET: %u\n"
+                       "\t-FAILED: %u",
+                       dev->status,
+                       (dev->status == VIRTIO_CONFIG_STATUS_RESET),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_ACK),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER_OK),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_DEV_NEED_RESET),
+                       !!(dev->status & VIRTIO_CONFIG_STATUS_FAILED));
+       } else if (ret != -ENOTSUP) {
+               PMD_INIT_LOG(ERR, "(%s) Failed to get backend status", dev->path);
+       }
+
+       pthread_mutex_unlock(&dev->mutex);
+       return ret;
+}
+
+int
+virtio_user_dev_update_link_state(struct virtio_user_dev *dev)
+{
+       if (dev->ops->update_link_state)
+               return dev->ops->update_link_state(dev);
+
+       return 0;
+}
+
+static void
+virtio_user_dev_reset_queues_packed(struct rte_eth_dev *eth_dev)
+{
+       struct virtio_user_dev *dev = eth_dev->data->dev_private;
+       struct virtio_hw *hw = &dev->hw;
+       struct virtnet_rx *rxvq;
+       struct virtnet_tx *txvq;
+       uint16_t i;
+
+       /* Add lock to avoid queue contention. */
+       rte_spinlock_lock(&hw->state_lock);
+       hw->started = 0;
+
+       /*
+        * Waiting for datapath to complete before resetting queues.
+        * 1 ms should be enough for the ongoing Tx/Rx function to finish.
+        */
+       rte_delay_ms(1);
+
+       /* Vring reset for each Tx queue and Rx queue. */
+       for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
+               rxvq = eth_dev->data->rx_queues[i];
+               virtqueue_rxvq_reset_packed(virtnet_rxq_to_vq(rxvq));
+               virtio_dev_rx_queue_setup_finish(eth_dev, i);
+       }
+
+       for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
+               txvq = eth_dev->data->tx_queues[i];
+               virtqueue_txvq_reset_packed(virtnet_txq_to_vq(txvq));
+       }
+
+       hw->started = 1;
+       rte_spinlock_unlock(&hw->state_lock);
+}
+
+void
+virtio_user_dev_delayed_disconnect_handler(void *param)
+{
+       struct virtio_user_dev *dev = param;
+       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
+
+       if (rte_intr_disable(eth_dev->intr_handle) < 0) {
+               PMD_DRV_LOG(ERR, "interrupt disable failed");
+               return;
        }
+       PMD_DRV_LOG(DEBUG, "Unregistering intr fd: %d",
+                   eth_dev->intr_handle->fd);
+       if (rte_intr_callback_unregister(eth_dev->intr_handle,
+                                        virtio_interrupt_handler,
+                                        eth_dev) != 1)
+               PMD_DRV_LOG(ERR, "interrupt unregister failed");
+
+       if (dev->is_server) {
+               if (dev->ops->server_disconnect)
+                       dev->ops->server_disconnect(dev);
+
+               eth_dev->intr_handle->fd = dev->ops->get_intr_fd(dev);
+
+               PMD_DRV_LOG(DEBUG, "Registering intr fd: %d",
+                           eth_dev->intr_handle->fd);
+
+               if (rte_intr_callback_register(eth_dev->intr_handle,
+                                              virtio_interrupt_handler,
+                                              eth_dev))
+                       PMD_DRV_LOG(ERR, "interrupt register failed");
+
+               if (rte_intr_enable(eth_dev->intr_handle) < 0) {
+                       PMD_DRV_LOG(ERR, "interrupt enable failed");
+                       return;
+               }
+       }
+}
+
+static void
+virtio_user_dev_delayed_intr_reconfig_handler(void *param)
+{
+       struct virtio_user_dev *dev = param;
+       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
+
+       PMD_DRV_LOG(DEBUG, "Unregistering intr fd: %d",
+                   eth_dev->intr_handle->fd);
+
+       if (rte_intr_callback_unregister(eth_dev->intr_handle,
+                                        virtio_interrupt_handler,
+                                        eth_dev) != 1)
+               PMD_DRV_LOG(ERR, "interrupt unregister failed");
+
+       eth_dev->intr_handle->fd = dev->ops->get_intr_fd(dev);
+
+       PMD_DRV_LOG(DEBUG, "Registering intr fd: %d", eth_dev->intr_handle->fd);
+
+       if (rte_intr_callback_register(eth_dev->intr_handle,
+                                      virtio_interrupt_handler, eth_dev))
+               PMD_DRV_LOG(ERR, "interrupt register failed");
+
+       if (rte_intr_enable(eth_dev->intr_handle) < 0)
+               PMD_DRV_LOG(ERR, "interrupt enable failed");
+}
+
+int
+virtio_user_dev_server_reconnect(struct virtio_user_dev *dev)
+{
+       int ret, old_status;
+       struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
+       struct virtio_hw *hw = &dev->hw;
+
+       if (!dev->ops->server_reconnect) {
+               PMD_DRV_LOG(ERR, "(%s) Missing server reconnect callback", dev->path);
+               return -1;
+       }
+
+       if (dev->ops->server_reconnect(dev)) {
+               PMD_DRV_LOG(ERR, "(%s) Reconnect callback call failed", dev->path);
+               return -1;
+       }
+
+       old_status = dev->status;
+
+       virtio_reset(hw);
+
+       virtio_set_status(hw, VIRTIO_CONFIG_STATUS_ACK);
+
+       virtio_set_status(hw, VIRTIO_CONFIG_STATUS_DRIVER);
+
+       if (dev->ops->get_features(dev, &dev->device_features) < 0) {
+               PMD_INIT_LOG(ERR, "get_features failed: %s",
+                            strerror(errno));
+               return -1;
+       }
+
+       /* unmask vhost-user unsupported features */
+       dev->device_features &= ~(dev->unsupported_features);
+
+       dev->features &= (dev->device_features | dev->frontend_features);
+
+       /* For packed ring, resetting queues is required in reconnection. */
+       if (virtio_with_packed_queue(hw) &&
+          (old_status & VIRTIO_CONFIG_STATUS_DRIVER_OK)) {
+               PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped"
+                               " when packed ring reconnecting.");
+               virtio_user_dev_reset_queues_packed(eth_dev);
+       }
+
+       virtio_set_status(hw, VIRTIO_CONFIG_STATUS_FEATURES_OK);
+
+       /* Start the device */
+       virtio_set_status(hw, VIRTIO_CONFIG_STATUS_DRIVER_OK);
+       if (!dev->started)
+               return -1;
+
+       if (dev->queue_pairs > 1) {
+               ret = virtio_user_handle_mq(dev, dev->queue_pairs);
+               if (ret != 0) {
+                       PMD_INIT_LOG(ERR, "Fails to enable multi-queue pairs!");
+                       return -1;
+               }
+       }
+       if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {
+               if (rte_intr_disable(eth_dev->intr_handle) < 0) {
+                       PMD_DRV_LOG(ERR, "interrupt disable failed");
+                       return -1;
+               }
+               /*
+                * This function can be called from the interrupt handler, so
+                * we can't unregister interrupt handler here.  Setting
+                * alarm to do that later.
+                */
+               rte_eal_alarm_set(1,
+                       virtio_user_dev_delayed_intr_reconfig_handler,
+                       (void *)dev);
+       }
+       PMD_INIT_LOG(NOTICE, "server mode virtio-user reconnection succeeds!");
+       return 0;
 }