net/virtio-user: lock-protect status updates

[dpdk.git] / drivers / net / virtio / virtio_user_ethdev.c

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 38b49ba..97ddc56 100644 (file)
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -6,7 +6,9 @@
 #include <sys/types.h>
 #include <unistd.h>
 #include <fcntl.h>
+#include <linux/major.h>
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <sys/socket.h>
 
 #include <rte_malloc.h>
@@ -267,13 +269,17 @@ static void
 virtio_user_set_status(struct virtio_hw *hw, uint8_t status)
 {
        struct virtio_user_dev *dev = virtio_user_get_dev(hw);
+       uint8_t old_status = dev->status;
 
+       if (status & VIRTIO_CONFIG_STATUS_FEATURES_OK &&
+                       ~old_status & VIRTIO_CONFIG_STATUS_FEATURES_OK)
+               virtio_user_dev_set_features(dev);
        if (status & VIRTIO_CONFIG_STATUS_DRIVER_OK)
                virtio_user_start_device(dev);
        else if (status == VIRTIO_CONFIG_STATUS_RESET)
                virtio_user_reset(hw);
-       dev->status = status;
-       virtio_user_send_status_update(dev, status);
+
+       virtio_user_dev_set_status(dev, status);
 }
 
 static uint8_t
@@ -281,7 +287,7 @@ virtio_user_get_status(struct virtio_hw *hw)
 {
        struct virtio_user_dev *dev = virtio_user_get_dev(hw);
 
-       virtio_user_update_status(dev);
+       virtio_user_dev_update_status(dev);
 
        return dev->status;
 }
@@ -519,17 +525,58 @@ get_integer_arg(const char *key __rte_unused,
        return -errno;
 }
 
+static uint32_t
+vdpa_dynamic_major_num(void)
+{
+       FILE *fp;
+       char *line = NULL;
+       size_t size;
+       char name[11];
+       bool found = false;
+       uint32_t num;
+
+       fp = fopen("/proc/devices", "r");
+       if (fp == NULL) {
+               PMD_INIT_LOG(ERR, "Cannot open /proc/devices: %s",
+                            strerror(errno));
+               return UNNAMED_MAJOR;
+       }
+
+       while (getline(&line, &size, fp) > 0) {
+               char *stripped = line + strspn(line, " ");
+               if ((sscanf(stripped, "%u %10s", &num, name) == 2) &&
+                   (strncmp(name, "vhost-vdpa", 10) == 0)) {
+                       found = true;
+                       break;
+               }
+       }
+       fclose(fp);
+       return found ? num : UNNAMED_MAJOR;
+}
+
 static enum virtio_user_backend_type
 virtio_user_backend_type(const char *path)
 {
        struct stat sb;
 
-       if (stat(path, &sb) == -1)
+       if (stat(path, &sb) == -1) {
+               if (errno == ENOENT)
+                       return VIRTIO_USER_BACKEND_VHOST_USER;
+
+               PMD_INIT_LOG(ERR, "Stat fails: %s (%s)\n", path,
+                            strerror(errno));
                return VIRTIO_USER_BACKEND_UNKNOWN;
+       }
 
-       return S_ISSOCK(sb.st_mode) ?
-               VIRTIO_USER_BACKEND_VHOST_USER :
-               VIRTIO_USER_BACKEND_VHOST_KERNEL;
+       if (S_ISSOCK(sb.st_mode)) {
+               return VIRTIO_USER_BACKEND_VHOST_USER;
+       } else if (S_ISCHR(sb.st_mode)) {
+               if (major(sb.st_rdev) == MISC_MAJOR)
+                       return VIRTIO_USER_BACKEND_VHOST_KERNEL;
+               if (major(sb.st_rdev) == vdpa_dynamic_major_num())
+                       return VIRTIO_USER_BACKEND_VHOST_VDPA;
+       }
+       return VIRTIO_USER_BACKEND_UNKNOWN;
 }
 
 static struct rte_eth_dev *
@@ -653,7 +700,8 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
                        path);
                goto end;
        }
-
+       PMD_INIT_LOG(INFO, "Backend type detected: %s",
+                    virtio_user_backend_strings[backend_type]);
 
        if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME) == 1) {
                if (backend_type != VIRTIO_USER_BACKEND_VHOST_KERNEL) {
@@ -837,9 +885,7 @@ virtio_user_pmd_remove(struct rte_vdev_device *vdev)
                return rte_eth_dev_release_port(eth_dev);
 
        /* make sure the device is stopped, queues freed */
-       rte_eth_dev_close(eth_dev->data->port_id);
-
-       return 0;
+       return rte_eth_dev_close(eth_dev->data->port_id);
 }
 
 static int virtio_user_pmd_dma_map(struct rte_vdev_device *vdev, void *addr,