ethdev: use constants for link state
[dpdk.git] / drivers / net / vmxnet3 / vmxnet3_ethdev.c
index 1685ce4..b492837 100644 (file)
@@ -70,6 +70,7 @@
 #define PROCESS_SYS_EVENTS 0
 
 static int eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev);
+static int eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev);
 static int vmxnet3_dev_configure(struct rte_eth_dev *dev);
 static int vmxnet3_dev_start(struct rte_eth_dev *dev);
 static void vmxnet3_dev_stop(struct rte_eth_dev *dev);
@@ -85,6 +86,14 @@ static void vmxnet3_dev_stats_get(struct rte_eth_dev *dev,
                                struct rte_eth_stats *stats);
 static void vmxnet3_dev_info_get(struct rte_eth_dev *dev,
                                struct rte_eth_dev_info *dev_info);
+static const uint32_t *
+vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev);
+static int vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev,
+                                      uint16_t vid, int on);
+static void vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+static void vmxnet3_mac_addr_set(struct rte_eth_dev *dev,
+                                struct ether_addr *mac_addr);
+
 #if PROCESS_SYS_EVENTS == 1
 static void vmxnet3_process_events(struct vmxnet3_hw *);
 #endif
@@ -110,7 +119,11 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
        .allmulticast_disable = vmxnet3_dev_allmulticast_disable,
        .link_update          = vmxnet3_dev_link_update,
        .stats_get            = vmxnet3_dev_stats_get,
+       .mac_addr_set         = vmxnet3_mac_addr_set,
        .dev_infos_get        = vmxnet3_dev_info_get,
+       .dev_supported_ptypes_get = vmxnet3_dev_supported_ptypes_get,
+       .vlan_filter_set      = vmxnet3_dev_vlan_filter_set,
+       .vlan_offload_set     = vmxnet3_dev_vlan_offload_set,
        .rx_queue_setup       = vmxnet3_dev_rx_queue_setup,
        .rx_queue_release     = vmxnet3_dev_rx_queue_release,
        .tx_queue_setup       = vmxnet3_dev_tx_queue_setup,
@@ -147,9 +160,36 @@ gpa_zone_reserve(struct rte_eth_dev *dev, uint32_t size,
  *   - On success, zero.
  *   - On failure, negative value.
  */
-static inline int
-rte_vmxnet3_dev_atomic_write_link_status(struct rte_eth_dev *dev,
-                               struct rte_eth_link *link)
+
+static int
+vmxnet3_dev_atomic_read_link_status(struct rte_eth_dev *dev,
+                                   struct rte_eth_link *link)
+{
+       struct rte_eth_link *dst = link;
+       struct rte_eth_link *src = &(dev->data->dev_link);
+
+       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+                               *(uint64_t *)src) == 0)
+               return -1;
+
+       return 0;
+}
+
+/**
+ * Atomically writes the link status information into global
+ * structure rte_eth_dev.
+ *
+ * @param dev
+ *   - Pointer to the structure rte_eth_dev to write to.
+ *   - Pointer to the buffer to be saved with the link status.
+ *
+ * @return
+ *   - On success, zero.
+ *   - On failure, negative value.
+ */
+static int
+vmxnet3_dev_atomic_write_link_status(struct rte_eth_dev *dev,
+                                    struct rte_eth_link *link)
 {
        struct rte_eth_link *dst = &(dev->data->dev_link);
        struct rte_eth_link *src = link;
@@ -194,12 +234,14 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
        pci_dev = eth_dev->pci_dev;
 
        /*
-        * for secondary processes, we don't initialise any further as primary
+        * for secondary processes, we don't initialize any further as primary
         * has already done this work.
         */
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return 0;
 
+       rte_eth_copy_pci_info(eth_dev, pci_dev);
+
        /* Vendor and Device ID need to be set before init of shared code */
        hw->device_id = pci_dev->id.device_id;
        hw->vendor_id = pci_dev->id.vendor_id;
@@ -208,26 +250,25 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
 
        hw->num_rx_queues = 1;
        hw->num_tx_queues = 1;
-       hw->cur_mtu = ETHER_MTU;
        hw->bufs_per_pkt = 1;
 
        /* Check h/w version compatibility with driver. */
        ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_VRRS);
-       PMD_INIT_LOG(DEBUG, "Harware version : %d", ver);
+       PMD_INIT_LOG(DEBUG, "Hardware version : %d", ver);
        if (ver & 0x1)
                VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS, 1);
        else {
-               PMD_INIT_LOG(ERR, "Uncompatiable h/w version, should be 0x1");
+               PMD_INIT_LOG(ERR, "Incompatible h/w version, should be 0x1");
                return -EIO;
        }
 
        /* Check UPT version compatibility with driver. */
        ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_UVRS);
-       PMD_INIT_LOG(DEBUG, "UPT harware version : %d", ver);
+       PMD_INIT_LOG(DEBUG, "UPT hardware version : %d", ver);
        if (ver & 0x1)
                VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_UVRS, 1);
        else {
-               PMD_INIT_LOG(ERR, "Incompatiable UPT version.");
+               PMD_INIT_LOG(ERR, "Incompatible UPT version.");
                return -EIO;
        }
 
@@ -257,16 +298,43 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
        /* Put device in Quiesce Mode */
        VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_QUIESCE_DEV);
 
+       /* allow untagged pkts */
+       VMXNET3_SET_VFTABLE_ENTRY(hw->shadow_vfta, 0);
+
+       return 0;
+}
+
+static int
+eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)
+{
+       struct vmxnet3_hw *hw = eth_dev->data->dev_private;
+
+       PMD_INIT_FUNC_TRACE();
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       if (hw->adapter_stopped == 0)
+               vmxnet3_dev_close(eth_dev);
+
+       eth_dev->dev_ops = NULL;
+       eth_dev->rx_pkt_burst = NULL;
+       eth_dev->tx_pkt_burst = NULL;
+
+       rte_free(eth_dev->data->mac_addrs);
+       eth_dev->data->mac_addrs = NULL;
+
        return 0;
 }
 
 static struct eth_driver rte_vmxnet3_pmd = {
-       {
+       .pci_drv = {
                .name = "rte_vmxnet3_pmd",
                .id_table = pci_id_vmxnet3_map,
-               .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+               .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,
        },
        .eth_dev_init = eth_vmxnet3_dev_init,
+       .eth_dev_uninit = eth_vmxnet3_dev_uninit,
        .dev_private_size = sizeof(struct vmxnet3_hw),
 };
 
@@ -359,15 +427,32 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
        return 0;
 }
 
+static void
+vmxnet3_write_mac(struct vmxnet3_hw *hw, const uint8_t *addr)
+{
+       uint32_t val;
+
+       PMD_INIT_LOG(DEBUG,
+                    "Writing MAC Address : %02x:%02x:%02x:%02x:%02x:%02x",
+                    addr[0], addr[1], addr[2],
+                    addr[3], addr[4], addr[5]);
+
+       val = *(const uint32_t *)addr;
+       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_MACL, val);
+
+       val = (addr[5] << 8) | addr[4];
+       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_MACH, val);
+}
+
 static int
 vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 {
        struct rte_eth_conf port_conf = dev->data->dev_conf;
        struct vmxnet3_hw *hw = dev->data->dev_private;
+       uint32_t mtu = dev->data->mtu;
        Vmxnet3_DriverShared *shared = hw->shared;
        Vmxnet3_DSDevRead *devRead = &shared->devRead;
-       uint32_t *mac_ptr;
-       uint32_t val, i;
+       uint32_t i;
        int ret;
 
        shared->magic = VMXNET3_REV1_MAGIC;
@@ -381,9 +466,9 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
        devRead->misc.driverInfo.vmxnet3RevSpt = 1;
        devRead->misc.driverInfo.uptVerSpt     = 1;
 
+       devRead->misc.mtu = rte_le_to_cpu_32(mtu);
        devRead->misc.queueDescPA  = hw->queueDescPA;
        devRead->misc.queueDescLen = hw->queue_desc_len;
-       devRead->misc.mtu          = hw->cur_mtu;
        devRead->misc.numTxQueues  = hw->num_tx_queues;
        devRead->misc.numRxQueues  = hw->num_rx_queues;
 
@@ -439,9 +524,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
        if (dev->data->dev_conf.rxmode.hw_ip_checksum)
                devRead->misc.uptFeatures |= VMXNET3_F_RXCSUM;
 
-       if (dev->data->dev_conf.rxmode.hw_vlan_strip)
-               devRead->misc.uptFeatures |= VMXNET3_F_RXVLAN;
-
        if (port_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
                ret = vmxnet3_rss_configure(dev);
                if (ret != VMXNET3_SUCCESS)
@@ -453,24 +535,10 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
                devRead->rssConfDesc.confPA  = hw->rss_confPA;
        }
 
-       if (dev->data->dev_conf.rxmode.hw_vlan_filter) {
-               ret = vmxnet3_vlan_configure(dev);
-               if (ret != VMXNET3_SUCCESS)
-                       return ret;
-       }
+       vmxnet3_dev_vlan_offload_set(dev,
+                            ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK);
 
-       PMD_INIT_LOG(DEBUG,
-                    "Writing MAC Address : %02x:%02x:%02x:%02x:%02x:%02x",
-                    hw->perm_addr[0], hw->perm_addr[1], hw->perm_addr[2],
-                    hw->perm_addr[3], hw->perm_addr[4], hw->perm_addr[5]);
-
-       /* Write MAC Address back to device */
-       mac_ptr = (uint32_t *)hw->perm_addr;
-       val = *mac_ptr;
-       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_MACL, val);
-
-       val = (hw->perm_addr[5] << 8) | hw->perm_addr[4];
-       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_MACH, val);
+       vmxnet3_write_mac(hw, hw->perm_addr);
 
        return VMXNET3_SUCCESS;
 }
@@ -503,7 +571,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
        status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
 
        if (status != 0) {
-               PMD_INIT_LOG(ERR, "Device activation in %s(): UNSUCCESSFUL", __func__);
+               PMD_INIT_LOG(ERR, "Device activation: UNSUCCESSFUL");
                return -1;
        }
 
@@ -516,7 +584,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
         */
        ret = vmxnet3_dev_rxtx_init(dev);
        if (ret != VMXNET3_SUCCESS) {
-               PMD_INIT_LOG(ERR, "Device receive init in %s: UNSUCCESSFUL", __func__);
+               PMD_INIT_LOG(ERR, "Device receive init: UNSUCCESSFUL");
                return ret;
        }
 
@@ -545,7 +613,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE();
 
-       if (hw->adapter_stopped == TRUE) {
+       if (hw->adapter_stopped == 1) {
                PMD_INIT_LOG(DEBUG, "Device already closed.");
                return;
        }
@@ -561,13 +629,13 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
        /* reset the device */
        VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_RESET_DEV);
        PMD_INIT_LOG(DEBUG, "Device reset.");
-       hw->adapter_stopped = FALSE;
+       hw->adapter_stopped = 0;
 
        vmxnet3_dev_clear_queues(dev);
 
        /* Clear recorded link status */
        memset(&link, 0, sizeof(link));
-       rte_vmxnet3_dev_atomic_write_link_status(dev, &link);
+       vmxnet3_dev_atomic_write_link_status(dev, &link);
 }
 
 /*
@@ -581,7 +649,7 @@ vmxnet3_dev_close(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE();
 
        vmxnet3_dev_stop(dev);
-       hw->adapter_stopped = TRUE;
+       hw->adapter_stopped = 1;
 }
 
 static void
@@ -632,7 +700,8 @@ vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 }
 
 static void
-vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
+vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev,
+                    struct rte_eth_dev_info *dev_info)
 {
        dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES;
        dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES;
@@ -640,9 +709,53 @@ vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_
        dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */
        dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS;
 
-       dev_info->default_txconf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
-                                               ETH_TXQ_FLAGS_NOOFFLOADS;
+       dev_info->default_txconf.txq_flags = ETH_TXQ_FLAGS_NOXSUMSCTP;
        dev_info->flow_type_rss_offloads = VMXNET3_RSS_OFFLOAD_ALL;
+
+       dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
+               .nb_max = VMXNET3_RX_RING_MAX_SIZE,
+               .nb_min = VMXNET3_DEF_RX_RING_SIZE,
+               .nb_align = 1,
+       };
+
+       dev_info->tx_desc_lim = (struct rte_eth_desc_lim) {
+               .nb_max = VMXNET3_TX_RING_MAX_SIZE,
+               .nb_min = VMXNET3_DEF_TX_RING_SIZE,
+               .nb_align = 1,
+       };
+
+       dev_info->rx_offload_capa =
+               DEV_RX_OFFLOAD_VLAN_STRIP |
+               DEV_RX_OFFLOAD_UDP_CKSUM |
+               DEV_RX_OFFLOAD_TCP_CKSUM;
+
+       dev_info->tx_offload_capa =
+               DEV_TX_OFFLOAD_VLAN_INSERT |
+               DEV_TX_OFFLOAD_TCP_CKSUM |
+               DEV_TX_OFFLOAD_UDP_CKSUM |
+               DEV_TX_OFFLOAD_TCP_TSO;
+}
+
+static const uint32_t *
+vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev)
+{
+       static const uint32_t ptypes[] = {
+               RTE_PTYPE_L3_IPV4_EXT,
+               RTE_PTYPE_L3_IPV4,
+               RTE_PTYPE_UNKNOWN
+       };
+
+       if (dev->rx_pkt_burst == vmxnet3_recv_pkts)
+               return ptypes;
+       return NULL;
+}
+
+static void
+vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
+{
+       struct vmxnet3_hw *hw = dev->data->dev_private;
+
+       vmxnet3_write_mac(hw, mac_addr->addr_bytes);
 }
 
 /* return 0 means link status changed, -1 means not changed */
@@ -650,28 +763,27 @@ static int
 vmxnet3_dev_link_update(struct rte_eth_dev *dev, __attribute__((unused)) int wait_to_complete)
 {
        struct vmxnet3_hw *hw = dev->data->dev_private;
-       struct rte_eth_link link;
+       struct rte_eth_link old, link;
        uint32_t ret;
 
+       if (dev->data->dev_started == 0)
+               return -1; /* Link status doesn't change for stopped dev */
+
+       memset(&link, 0, sizeof(link));
+       vmxnet3_dev_atomic_read_link_status(dev, &old);
+
        VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_LINK);
        ret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
 
-       if (!ret) {
-               PMD_INIT_LOG(ERR, "Link Status Negative : %s()", __func__);
-               return -1;
-       }
-
        if (ret & 0x1) {
-               link.link_status = 1;
+               link.link_status = ETH_LINK_UP;
                link.link_duplex = ETH_LINK_FULL_DUPLEX;
                link.link_speed = ETH_LINK_SPEED_10000;
-
-               rte_vmxnet3_dev_atomic_write_link_status(dev, &link);
-
-               return 0;
        }
 
-       return -1;
+       vmxnet3_dev_atomic_write_link_status(dev, &link);
+
+       return (old.link_status == link.link_status) ? -1 : 0;
 }
 
 /* Updating rxmode through Vmxnet3_DriverShared structure in adapter */
@@ -693,8 +805,13 @@ static void
 vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 {
        struct vmxnet3_hw *hw = dev->data->dev_private;
+       uint32_t *vf_table = hw->shared->devRead.rxFilterConf.vfTable;
 
+       memset(vf_table, 0, VMXNET3_VFT_TABLE_SIZE);
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 1);
+
+       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
+                              VMXNET3_CMD_UPDATE_VLAN_FILTERS);
 }
 
 /* Promiscuous supported only if Vmxnet3_DriverShared is initialized in adapter */
@@ -702,8 +819,12 @@ static void
 vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev)
 {
        struct vmxnet3_hw *hw = dev->data->dev_private;
+       uint32_t *vf_table = hw->shared->devRead.rxFilterConf.vfTable;
 
+       memcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE);
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 0);
+       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
+                              VMXNET3_CMD_UPDATE_VLAN_FILTERS);
 }
 
 /* Allmulticast supported only if Vmxnet3_DriverShared is initialized in adapter */
@@ -724,6 +845,63 @@ vmxnet3_dev_allmulticast_disable(struct rte_eth_dev *dev)
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_ALL_MULTI, 0);
 }
 
+/* Enable/disable filter on vlan */
+static int
+vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)
+{
+       struct vmxnet3_hw *hw = dev->data->dev_private;
+       struct Vmxnet3_RxFilterConf *rxConf = &hw->shared->devRead.rxFilterConf;
+       uint32_t *vf_table = rxConf->vfTable;
+
+       /* save state for restore */
+       if (on)
+               VMXNET3_SET_VFTABLE_ENTRY(hw->shadow_vfta, vid);
+       else
+               VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid);
+
+       /* don't change active filter if in promiscuous mode */
+       if (rxConf->rxMode & VMXNET3_RXM_PROMISC)
+               return 0;
+
+       /* set in hardware */
+       if (on)
+               VMXNET3_SET_VFTABLE_ENTRY(vf_table, vid);
+       else
+               VMXNET3_CLEAR_VFTABLE_ENTRY(vf_table, vid);
+
+       VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
+                              VMXNET3_CMD_UPDATE_VLAN_FILTERS);
+       return 0;
+}
+
+static void
+vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+       struct vmxnet3_hw *hw = dev->data->dev_private;
+       Vmxnet3_DSDevRead *devRead = &hw->shared->devRead;
+       uint32_t *vf_table = devRead->rxFilterConf.vfTable;
+
+       if (mask & ETH_VLAN_STRIP_MASK) {
+               if (dev->data->dev_conf.rxmode.hw_vlan_strip)
+                       devRead->misc.uptFeatures |= UPT1_F_RXVLAN;
+               else
+                       devRead->misc.uptFeatures &= ~UPT1_F_RXVLAN;
+
+               VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
+                                      VMXNET3_CMD_UPDATE_FEATURE);
+       }
+
+       if (mask & ETH_VLAN_FILTER_MASK) {
+               if (dev->data->dev_conf.rxmode.hw_vlan_filter)
+                       memcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE);
+               else
+                       memset(vf_table, 0xff, VMXNET3_VFT_TABLE_SIZE);
+
+               VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
+                                      VMXNET3_CMD_UPDATE_VLAN_FILTERS);
+       }
+}
+
 #if PROCESS_SYS_EVENTS == 1
 static void
 vmxnet3_process_events(struct vmxnet3_hw *hw)
@@ -731,7 +909,7 @@ vmxnet3_process_events(struct vmxnet3_hw *hw)
        uint32_t events = hw->shared->ecr;
 
        if (!events) {
-               PMD_INIT_LOG(ERR, "No events to process in %s()", __func__);
+               PMD_INIT_LOG(ERR, "No events to process");
                return;
        }