kvargs: use SPDX tags
[dpdk.git] / examples / ip_pipeline / config_parse.c
index 2a222b2..e90499e 100644 (file)
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2016 Intel Corporation
  */
 
 #include <stdint.h>
@@ -81,6 +52,11 @@ static const struct app_link_params link_params_default = {
        .tcp_local_q = 0,
        .udp_local_q = 0,
        .sctp_local_q = 0,
+       .rss_qs = {0},
+       .n_rss_qs = 0,
+       .rss_proto_ipv4 = ETH_RSS_IPV4,
+       .rss_proto_ipv6 = ETH_RSS_IPV6,
+       .rss_proto_l2 = 0,
        .state = 0,
        .ip = 0,
        .depth = 0,
@@ -92,18 +68,19 @@ static const struct app_link_params link_params_default = {
                .rxmode = {
                        .mq_mode = ETH_MQ_RX_NONE,
 
-                       .header_split   = 0, /* Header split */
-                       .hw_ip_checksum = 0, /* IP checksum offload */
-                       .hw_vlan_filter = 0, /* VLAN filtering */
-                       .hw_vlan_strip  = 0, /* VLAN strip */
-                       .hw_vlan_extend = 0, /* Extended VLAN */
-                       .jumbo_frame    = 0, /* Jumbo frame support */
-                       .hw_strip_crc   = 0, /* CRC strip by HW */
-                       .enable_scatter = 0, /* Scattered packets RX handler */
+                       .ignore_offload_bitfield = 1,
+                       .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
 
                        .max_rx_pkt_len = 9000, /* Jumbo frame max packet len */
                        .split_hdr_size = 0, /* Header split buffer size */
                },
+               .rx_adv_conf = {
+                       .rss_conf = {
+                               .rss_key = NULL,
+                               .rss_key_len = 40,
+                               .rss_hf = 0,
+                       },
+               },
                .txmode = {
                        .mq_mode = ETH_MQ_TX_NONE,
                },
@@ -146,8 +123,7 @@ static const struct app_pktq_hwq_out_params default_hwq_out_params = {
                },
                .tx_rs_thresh = 0,
                .tx_free_thresh = 0,
-               .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
-                       ETH_TXQ_FLAGS_NOOFFLOADS,
+               .txq_flags = ETH_TXQ_FLAGS_IGNORE,
                .tx_deferred_start = 0,
        }
 };
@@ -173,15 +149,38 @@ static const struct app_pktq_swq_params default_swq_params = {
 struct app_pktq_tm_params default_tm_params = {
        .parsed = 0,
        .file_name = "./config/tm_profile.cfg",
-       .burst_read = 64,
+       .burst_read = 24,
+       .burst_write = 32,
+};
+
+struct app_pktq_tap_params default_tap_params = {
+       .parsed = 0,
+       .burst_read = 32,
+       .burst_write = 32,
+       .dropless = 0,
+       .n_retries = 0,
+       .mempool_id = 0,
+};
+
+struct app_pktq_kni_params default_kni_params = {
+       .parsed = 0,
+       .socket_id = 0,
+       .core_id = 0,
+       .hyper_th_id = 0,
+       .force_bind = 0,
+
+       .mempool_id = 0,
+       .burst_read = 32,
        .burst_write = 32,
+       .dropless = 0,
+       .n_retries = 0,
 };
 
 struct app_pktq_source_params default_source_params = {
        .parsed = 0,
        .mempool_id = 0,
        .burst = 32,
-       .file_name = NULL,
+       .file_name = "./config/packets.pcap",
        .n_bytes_per_pkt = 0,
 };
 
@@ -288,6 +287,18 @@ app_print_usage(char *prgname)
        link_param_pos;                                                 \
 })
 
+#define APP_PARAM_ADD_LINK_FOR_KNI(app, kni_name)                      \
+({                                                                     \
+       char link_name[APP_PARAM_NAME_SIZE];                            \
+       ssize_t link_param_pos;                                         \
+       uint32_t link_id;                                               \
+                                                                       \
+       sscanf((kni_name), "KNI%" SCNu32, &link_id);            \
+       sprintf(link_name, "LINK%" PRIu32, link_id);                    \
+       link_param_pos = APP_PARAM_ADD((app)->link_params, link_name);  \
+       link_param_pos;                                                 \
+})
+
 #define PARSE_CHECK_DUPLICATE_SECTION(obj)                             \
 do {                                                                   \
        APP_CHECK(((obj)->parsed == 0),                                 \
@@ -762,21 +773,6 @@ parse_eal(struct app_params *app,
                        continue;
                }
 
-               /* xen_dom0 */
-               if (strcmp(entry->name, "xen_dom0") == 0) {
-                       int val;
-
-                       PARSE_ERROR_DUPLICATE((p->xen_dom0_present == 0),
-                               section_name,
-                               entry->name);
-                       p->xen_dom0_present = 1;
-
-                       val = parser_read_arg_bool(entry->value);
-                       PARSE_ERROR((val >= 0), section_name, entry->name);
-                       p->xen_dom0 = val;
-                       continue;
-               }
-
                /* unrecognized */
                PARSE_ERROR_INVALID(0, section_name, entry->name);
        }
@@ -814,6 +810,13 @@ parse_pipeline_pktq_in(struct app_params *app,
                        type = APP_PKTQ_IN_TM;
                        id = APP_PARAM_ADD(app->tm_params, name);
                        APP_PARAM_ADD_LINK_FOR_TM(app, name);
+               } else if (validate_name(name, "TAP", 1) == 0) {
+                       type = APP_PKTQ_IN_TAP;
+                       id = APP_PARAM_ADD(app->tap_params, name);
+               } else if (validate_name(name, "KNI", 1) == 0) {
+                       type = APP_PKTQ_IN_KNI;
+                       id = APP_PARAM_ADD(app->kni_params, name);
+                       APP_PARAM_ADD_LINK_FOR_KNI(app, name);
                } else if (validate_name(name, "SOURCE", 1) == 0) {
                        type = APP_PKTQ_IN_SOURCE;
                        id = APP_PARAM_ADD(app->source_params, name);
@@ -859,6 +862,13 @@ parse_pipeline_pktq_out(struct app_params *app,
                        type = APP_PKTQ_OUT_TM;
                        id = APP_PARAM_ADD(app->tm_params, name);
                        APP_PARAM_ADD_LINK_FOR_TM(app, name);
+               } else if (validate_name(name, "TAP", 1) == 0) {
+                       type = APP_PKTQ_OUT_TAP;
+                       id = APP_PARAM_ADD(app->tap_params, name);
+               } else if (validate_name(name, "KNI", 1) == 0) {
+                       type = APP_PKTQ_OUT_KNI;
+                       id = APP_PARAM_ADD(app->kni_params, name);
+                       APP_PARAM_ADD_LINK_FOR_KNI(app, name);
                } else if (validate_name(name, "SINK", 1) == 0) {
                        type = APP_PKTQ_OUT_SINK;
                        id = APP_PARAM_ADD(app->sink_params, name);
@@ -1125,6 +1135,149 @@ parse_mempool(struct app_params *app,
        free(entries);
 }
 
+static int
+parse_link_rss_qs(struct app_link_params *p,
+       char *value)
+{
+       p->n_rss_qs = 0;
+
+       while (1) {
+               char *token = strtok_r(value, PARSE_DELIMITER, &value);
+
+               if (token == NULL)
+                       break;
+
+               if (p->n_rss_qs == RTE_DIM(p->rss_qs))
+                       return -ENOMEM;
+
+               if (parser_read_uint32(&p->rss_qs[p->n_rss_qs++], token))
+                       return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int
+parse_link_rss_proto_ipv4(struct app_link_params *p,
+       char *value)
+{
+       uint64_t mask = 0;
+
+       while (1) {
+               char *token = strtok_r(value, PARSE_DELIMITER, &value);
+
+               if (token == NULL)
+                       break;
+
+               if (strcmp(token, "IP") == 0) {
+                       mask |= ETH_RSS_IPV4;
+                       continue;
+               }
+               if (strcmp(token, "FRAG") == 0) {
+                       mask |= ETH_RSS_FRAG_IPV4;
+                       continue;
+               }
+               if (strcmp(token, "TCP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV4_TCP;
+                       continue;
+               }
+               if (strcmp(token, "UDP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV4_UDP;
+                       continue;
+               }
+               if (strcmp(token, "SCTP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV4_SCTP;
+                       continue;
+               }
+               if (strcmp(token, "OTHER") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV4_OTHER;
+                       continue;
+               }
+               return -EINVAL;
+       }
+
+       p->rss_proto_ipv4 = mask;
+       return 0;
+}
+
+static int
+parse_link_rss_proto_ipv6(struct app_link_params *p,
+       char *value)
+{
+       uint64_t mask = 0;
+
+       while (1) {
+               char *token = strtok_r(value, PARSE_DELIMITER, &value);
+
+               if (token == NULL)
+                       break;
+
+               if (strcmp(token, "IP") == 0) {
+                       mask |= ETH_RSS_IPV6;
+                       continue;
+               }
+               if (strcmp(token, "FRAG") == 0) {
+                       mask |= ETH_RSS_FRAG_IPV6;
+                       continue;
+               }
+               if (strcmp(token, "TCP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV6_TCP;
+                       continue;
+               }
+               if (strcmp(token, "UDP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV6_UDP;
+                       continue;
+               }
+               if (strcmp(token, "SCTP") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV6_SCTP;
+                       continue;
+               }
+               if (strcmp(token, "OTHER") == 0) {
+                       mask |= ETH_RSS_NONFRAG_IPV6_OTHER;
+                       continue;
+               }
+               if (strcmp(token, "IP_EX") == 0) {
+                       mask |= ETH_RSS_IPV6_EX;
+                       continue;
+               }
+               if (strcmp(token, "TCP_EX") == 0) {
+                       mask |= ETH_RSS_IPV6_TCP_EX;
+                       continue;
+               }
+               if (strcmp(token, "UDP_EX") == 0) {
+                       mask |= ETH_RSS_IPV6_UDP_EX;
+                       continue;
+               }
+               return -EINVAL;
+       }
+
+       p->rss_proto_ipv6 = mask;
+       return 0;
+}
+
+static int
+parse_link_rss_proto_l2(struct app_link_params *p,
+       char *value)
+{
+       uint64_t mask = 0;
+
+       while (1) {
+               char *token = strtok_r(value, PARSE_DELIMITER, &value);
+
+               if (token == NULL)
+                       break;
+
+               if (strcmp(token, "L2") == 0) {
+                       mask |= ETH_RSS_L2_PAYLOAD;
+                       continue;
+               }
+               return -EINVAL;
+       }
+
+       p->rss_proto_l2 = mask;
+       return 0;
+}
+
 static void
 parse_link(struct app_params *app,
        const char *section_name,
@@ -1133,6 +1286,10 @@ parse_link(struct app_params *app,
        struct app_link_params *param;
        struct rte_cfgfile_entry *entries;
        int n_entries, i;
+       int rss_qs_present = 0;
+       int rss_proto_ipv4_present = 0;
+       int rss_proto_ipv6_present = 0;
+       int rss_proto_l2_present = 0;
        int pci_bdf_present = 0;
        ssize_t param_idx;
 
@@ -1186,7 +1343,6 @@ parse_link(struct app_params *app,
                        continue;
                }
 
-
                if (strcmp(ent->name, "tcp_local_q") == 0) {
                        int status = parser_read_uint32(
                                &param->tcp_local_q, ent->value);
@@ -1214,6 +1370,44 @@ parse_link(struct app_params *app,
                        continue;
                }
 
+               if (strcmp(ent->name, "rss_qs") == 0) {
+                       int status = parse_link_rss_qs(param, ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+                       rss_qs_present = 1;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "rss_proto_ipv4") == 0) {
+                       int status =
+                               parse_link_rss_proto_ipv4(param, ent->value);
+
+                       PARSE_ERROR((status != -EINVAL), section_name,
+                               ent->name);
+                       rss_proto_ipv4_present = 1;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "rss_proto_ipv6") == 0) {
+                       int status =
+                               parse_link_rss_proto_ipv6(param, ent->value);
+
+                       PARSE_ERROR((status != -EINVAL), section_name,
+                               ent->name);
+                       rss_proto_ipv6_present = 1;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "rss_proto_l2") == 0) {
+                       int status = parse_link_rss_proto_l2(param, ent->value);
+
+                       PARSE_ERROR((status != -EINVAL), section_name,
+                               ent->name);
+                       rss_proto_l2_present = 1;
+                       continue;
+               }
+
                if (strcmp(ent->name, "pci_bdf") == 0) {
                        PARSE_ERROR_DUPLICATE((pci_bdf_present == 0),
                                section_name, ent->name);
@@ -1239,6 +1433,29 @@ parse_link(struct app_params *app,
                        "this entry is mandatory (port_mask is not "
                        "provided)");
 
+       if (rss_proto_ipv4_present)
+               PARSE_ERROR_MESSAGE((rss_qs_present),
+                       section_name, "rss_proto_ipv4",
+                       "entry not allowed (rss_qs entry is not provided)");
+       if (rss_proto_ipv6_present)
+               PARSE_ERROR_MESSAGE((rss_qs_present),
+                       section_name, "rss_proto_ipv6",
+                       "entry not allowed (rss_qs entry is not provided)");
+       if (rss_proto_l2_present)
+               PARSE_ERROR_MESSAGE((rss_qs_present),
+                       section_name, "rss_proto_l2",
+                       "entry not allowed (rss_qs entry is not provided)");
+       if (rss_proto_ipv4_present |
+               rss_proto_ipv6_present |
+               rss_proto_l2_present){
+               if (rss_proto_ipv4_present == 0)
+                       param->rss_proto_ipv4 = 0;
+               if (rss_proto_ipv6_present == 0)
+                       param->rss_proto_ipv6 = 0;
+               if (rss_proto_l2_present == 0)
+                       param->rss_proto_l2 = 0;
+       }
+
        free(entries);
 }
 
@@ -1362,6 +1579,15 @@ parse_txq(struct app_params *app,
                        continue;
                }
 
+               if (strcmp(ent->name, "n_retries") == 0) {
+                       int status = parser_read_uint64(&param->n_retries,
+                               ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+                       continue;
+               }
+
                /* unrecognized */
                PARSE_ERROR_INVALID(0, section_name, ent->name);
        }
@@ -1597,7 +1823,7 @@ parse_tm(struct app_params *app,
        param = &app->tm_params[param_idx];
        PARSE_CHECK_DUPLICATE_SECTION(param);
 
-       APP_PARAM_ADD_LINK_FOR_TXQ(app, section_name);
+       APP_PARAM_ADD_LINK_FOR_TM(app, section_name);
 
        for (i = 0; i < n_entries; i++) {
                struct rte_cfgfile_entry *ent = &entries[i];
@@ -1633,6 +1859,184 @@ parse_tm(struct app_params *app,
        free(entries);
 }
 
+static void
+parse_tap(struct app_params *app,
+       const char *section_name,
+       struct rte_cfgfile *cfg)
+{
+       struct app_pktq_tap_params *param;
+       struct rte_cfgfile_entry *entries;
+       int n_entries, i;
+       ssize_t param_idx;
+
+       n_entries = rte_cfgfile_section_num_entries(cfg, section_name);
+       PARSE_ERROR_SECTION_NO_ENTRIES((n_entries > 0), section_name);
+
+       entries = malloc(n_entries * sizeof(struct rte_cfgfile_entry));
+       PARSE_ERROR_MALLOC(entries != NULL);
+
+       rte_cfgfile_section_entries(cfg, section_name, entries, n_entries);
+
+       param_idx = APP_PARAM_ADD(app->tap_params, section_name);
+       param = &app->tap_params[param_idx];
+       PARSE_CHECK_DUPLICATE_SECTION(param);
+
+       for (i = 0; i < n_entries; i++) {
+               struct rte_cfgfile_entry *ent = &entries[i];
+
+               if (strcmp(ent->name, "burst_read") == 0) {
+                       int status = parser_read_uint32(
+                               &param->burst_read, ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+                       continue;
+               }
+
+               if (strcmp(ent->name, "burst_write") == 0) {
+                       int status = parser_read_uint32(
+                               &param->burst_write, ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+                       continue;
+               }
+
+               if (strcmp(ent->name, "dropless") == 0) {
+                       int status = parser_read_arg_bool(ent->value);
+
+                       PARSE_ERROR((status != -EINVAL), section_name,
+                               ent->name);
+                       param->dropless = status;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "n_retries") == 0) {
+                       int status = parser_read_uint64(&param->n_retries,
+                               ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+                       continue;
+               }
+
+               if (strcmp(ent->name, "mempool") == 0) {
+                       int status = validate_name(ent->value,
+                               "MEMPOOL", 1);
+                       ssize_t idx;
+
+                       PARSE_ERROR((status == 0), section_name,
+                               ent->name);
+
+                       idx = APP_PARAM_ADD(app->mempool_params, ent->value);
+                       param->mempool_id = idx;
+
+                       continue;
+               }
+
+               /* unrecognized */
+               PARSE_ERROR_INVALID(0, section_name, ent->name);
+       }
+
+       free(entries);
+}
+
+static void
+parse_kni(struct app_params *app,
+                 const char *section_name,
+                 struct rte_cfgfile *cfg)
+{
+       struct app_pktq_kni_params *param;
+       struct rte_cfgfile_entry *entries;
+       int n_entries, i;
+       ssize_t param_idx;
+
+       n_entries = rte_cfgfile_section_num_entries(cfg, section_name);
+       PARSE_ERROR_SECTION_NO_ENTRIES((n_entries > 0), section_name);
+
+       entries = malloc(n_entries * sizeof(struct rte_cfgfile_entry));
+       PARSE_ERROR_MALLOC(entries != NULL);
+
+       rte_cfgfile_section_entries(cfg, section_name, entries, n_entries);
+
+       param_idx = APP_PARAM_ADD(app->kni_params, section_name);
+       param = &app->kni_params[param_idx];
+       PARSE_CHECK_DUPLICATE_SECTION(param);
+
+       APP_PARAM_ADD_LINK_FOR_KNI(app, section_name);
+
+       for (i = 0; i < n_entries; i++) {
+               struct rte_cfgfile_entry *ent = &entries[i];
+
+               if (strcmp(ent->name, "core") == 0) {
+                       int status = parse_pipeline_core(
+                                       &param->socket_id,
+                                       &param->core_id,
+                                       &param->hyper_th_id,
+                                       ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                                               ent->name);
+                       param->force_bind = 1;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "mempool") == 0) {
+                       int status = validate_name(ent->value,
+                               "MEMPOOL", 1);
+                       ssize_t idx;
+
+                       PARSE_ERROR((status == 0), section_name,
+                                               ent->name);
+
+                       idx = APP_PARAM_ADD(app->mempool_params, ent->value);
+                       param->mempool_id = idx;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "burst_read") == 0) {
+                       int status = parser_read_uint32(&param->burst_read,
+                                               ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                                               ent->name);
+                       continue;
+               }
+
+               if (strcmp(ent->name, "burst_write") == 0) {
+                       int status = parser_read_uint32(&param->burst_write,
+                                               ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                                               ent->name);
+                       continue;
+               }
+
+               if (strcmp(ent->name, "dropless") == 0) {
+                       int status = parser_read_arg_bool(ent->value);
+
+                       PARSE_ERROR((status != -EINVAL), section_name,
+                                               ent->name);
+                       param->dropless = status;
+                       continue;
+               }
+
+               if (strcmp(ent->name, "n_retries") == 0) {
+                       int status = parser_read_uint64(&param->n_retries,
+                                               ent->value);
+
+                       PARSE_ERROR((status == 0), section_name,
+                                               ent->name);
+                       continue;
+               }
+
+               /* unrecognized */
+               PARSE_ERROR_INVALID(0, section_name, ent->name);
+       }
+
+       free(entries);
+}
+
 static void
 parse_source(struct app_params *app,
        const char *section_name,
@@ -1928,6 +2332,8 @@ static const struct config_section cfg_file_scheme[] = {
        {"TXQ", 2, parse_txq},
        {"SWQ", 1, parse_swq},
        {"TM", 1, parse_tm},
+       {"TAP", 1, parse_tap},
+       {"KNI", 1, parse_kni},
        {"SOURCE", 1, parse_source},
        {"SINK", 1, parse_sink},
        {"MSGQ-REQ-PIPELINE", 1, parse_msgq_req_pipeline},
@@ -2066,6 +2472,8 @@ app_config_parse(struct app_params *app, const char *file_name)
        APP_PARAM_COUNT(app->hwq_out_params, app->n_pktq_hwq_out);
        APP_PARAM_COUNT(app->swq_params, app->n_pktq_swq);
        APP_PARAM_COUNT(app->tm_params, app->n_pktq_tm);
+       APP_PARAM_COUNT(app->tap_params, app->n_pktq_tap);
+       APP_PARAM_COUNT(app->kni_params, app->n_pktq_kni);
        APP_PARAM_COUNT(app->source_params, app->n_pktq_source);
        APP_PARAM_COUNT(app->sink_params, app->n_pktq_sink);
        APP_PARAM_COUNT(app->msgq_params, app->n_msgq);
@@ -2184,10 +2592,6 @@ save_eal_params(struct app_params *app, FILE *f)
        if (p->vfio_intr)
                fprintf(f, "%s = %s\n", "vfio_intr", p->vfio_intr);
 
-       if (p->xen_dom0_present)
-               fprintf(f, "%s = %s\n", "xen_dom0",
-                       (p->xen_dom0) ? "yes" : "no");
-
        fputc('\n', f);
 }
 
@@ -2237,6 +2641,84 @@ save_links_params(struct app_params *app, FILE *f)
                fprintf(f, "%s = %" PRIu32 "\n", "sctp_local_q",
                        p->sctp_local_q);
 
+               if (p->n_rss_qs) {
+                       uint32_t j;
+
+                       /* rss_qs */
+                       fprintf(f, "rss_qs = ");
+                       for (j = 0; j < p->n_rss_qs; j++)
+                               fprintf(f, "%" PRIu32 " ",      p->rss_qs[j]);
+                       fputc('\n', f);
+
+                       /* rss_proto_ipv4 */
+                       if (p->rss_proto_ipv4) {
+                               fprintf(f, "rss_proto_ipv4 = ");
+                               if (p->rss_proto_ipv4 & ETH_RSS_IPV4)
+                                       fprintf(f, "IP ");
+                               if (p->rss_proto_ipv4 & ETH_RSS_FRAG_IPV4)
+                                       fprintf(f, "FRAG ");
+                               if (p->rss_proto_ipv4 &
+                                       ETH_RSS_NONFRAG_IPV4_TCP)
+                                       fprintf(f, "TCP ");
+                               if (p->rss_proto_ipv4 &
+                                       ETH_RSS_NONFRAG_IPV4_UDP)
+                                       fprintf(f, "UDP ");
+                               if (p->rss_proto_ipv4 &
+                                       ETH_RSS_NONFRAG_IPV4_SCTP)
+                                       fprintf(f, "SCTP ");
+                               if (p->rss_proto_ipv4 &
+                                       ETH_RSS_NONFRAG_IPV4_OTHER)
+                                       fprintf(f, "OTHER ");
+                               fprintf(f, "\n");
+                       } else
+                               fprintf(f, "; rss_proto_ipv4 = <NONE>\n");
+
+                       /* rss_proto_ipv6 */
+                       if (p->rss_proto_ipv6) {
+                               fprintf(f, "rss_proto_ipv6 = ");
+                               if (p->rss_proto_ipv6 & ETH_RSS_IPV6)
+                                       fprintf(f, "IP ");
+                               if (p->rss_proto_ipv6 & ETH_RSS_FRAG_IPV6)
+                                       fprintf(f, "FRAG ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_NONFRAG_IPV6_TCP)
+                                       fprintf(f, "TCP ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_NONFRAG_IPV6_UDP)
+                                       fprintf(f, "UDP ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_NONFRAG_IPV6_SCTP)
+                                       fprintf(f, "SCTP ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_NONFRAG_IPV6_OTHER)
+                                       fprintf(f, "OTHER ");
+                               if (p->rss_proto_ipv6 & ETH_RSS_IPV6_EX)
+                                       fprintf(f, "IP_EX ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_IPV6_TCP_EX)
+                                       fprintf(f, "TCP_EX ");
+                               if (p->rss_proto_ipv6 &
+                                       ETH_RSS_IPV6_UDP_EX)
+                                       fprintf(f, "UDP_EX ");
+                               fprintf(f, "\n");
+                       } else
+                               fprintf(f, "; rss_proto_ipv6 = <NONE>\n");
+
+                       /* rss_proto_l2 */
+                       if (p->rss_proto_l2) {
+                               fprintf(f, "rss_proto_l2 = ");
+                               if (p->rss_proto_l2 & ETH_RSS_L2_PAYLOAD)
+                                       fprintf(f, "L2 ");
+                               fprintf(f, "\n");
+                       } else
+                               fprintf(f, "; rss_proto_l2 = <NONE>\n");
+               } else {
+                       fprintf(f, "; rss_qs = <NONE>\n");
+                       fprintf(f, "; rss_proto_ipv4 = <NONE>\n");
+                       fprintf(f, "; rss_proto_ipv6 = <NONE>\n");
+                       fprintf(f, "; rss_proto_l2 = <NONE>\n");
+               }
+
                if (strlen(p->pci_bdf))
                        fprintf(f, "%s = %s\n", "pci_bdf", p->pci_bdf);
 
@@ -2285,6 +2767,7 @@ save_txq_params(struct app_params *app, FILE *f)
                fprintf(f, "%s = %s\n",
                        "dropless",
                        p->dropless ? "yes" : "no");
+               fprintf(f, "%s = %" PRIu64 "\n", "n_retries", p->n_retries);
 
                fputc('\n', f);
        }
@@ -2349,6 +2832,77 @@ save_tm_params(struct app_params *app, FILE *f)
        }
 }
 
+static void
+save_tap_params(struct app_params *app, FILE *f)
+{
+       struct app_pktq_tap_params *p;
+       size_t i, count;
+
+       count = RTE_DIM(app->tap_params);
+       for (i = 0; i < count; i++) {
+               p = &app->tap_params[i];
+               if (!APP_PARAM_VALID(p))
+                       continue;
+
+               fprintf(f, "[%s]\n", p->name);
+               fprintf(f, "%s = %" PRIu32 "\n", "burst_read", p->burst_read);
+               fprintf(f, "%s = %" PRIu32 "\n", "burst_write", p->burst_write);
+               fprintf(f, "%s = %s\n", "dropless", p->dropless ? "yes" : "no");
+               fprintf(f, "%s = %" PRIu64 "\n", "n_retries", p->n_retries);
+               fprintf(f, "%s = %s\n", "mempool",
+                       app->mempool_params[p->mempool_id].name);
+
+               fputc('\n', f);
+       }
+}
+
+static void
+save_kni_params(struct app_params *app, FILE *f)
+{
+       struct app_pktq_kni_params *p;
+       size_t i, count;
+
+       count = RTE_DIM(app->kni_params);
+       for (i = 0; i < count; i++) {
+               p = &app->kni_params[i];
+               if (!APP_PARAM_VALID(p))
+                       continue;
+
+               /* section name */
+               fprintf(f, "[%s]\n", p->name);
+
+               /* core */
+               if (p->force_bind) {
+                       fprintf(f, "; force_bind = 1\n");
+                       fprintf(f, "core = s%" PRIu32 "c%" PRIu32 "%s\n",
+                                       p->socket_id,
+                                       p->core_id,
+                                       (p->hyper_th_id) ? "h" : "");
+               } else
+                       fprintf(f, "; force_bind = 0\n");
+
+               /* mempool */
+               fprintf(f, "%s = %s\n", "mempool",
+                               app->mempool_params[p->mempool_id].name);
+
+               /* burst_read */
+               fprintf(f, "%s = %" PRIu32 "\n", "burst_read", p->burst_read);
+
+               /* burst_write */
+               fprintf(f, "%s = %" PRIu32 "\n", "burst_write", p->burst_write);
+
+               /* dropless */
+               fprintf(f, "%s = %s\n",
+                               "dropless",
+                               p->dropless ? "yes" : "no");
+
+               /* n_retries */
+               fprintf(f, "%s = %" PRIu64 "\n", "n_retries", p->n_retries);
+
+               fputc('\n', f);
+       }
+}
+
 static void
 save_source_params(struct app_params *app, FILE *f)
 {
@@ -2456,6 +3010,12 @@ save_pipeline_params(struct app_params *app, FILE *f)
                                case APP_PKTQ_IN_TM:
                                        name = app->tm_params[pp->id].name;
                                        break;
+                               case APP_PKTQ_IN_TAP:
+                                       name = app->tap_params[pp->id].name;
+                                       break;
+                               case APP_PKTQ_IN_KNI:
+                                       name = app->kni_params[pp->id].name;
+                                       break;
                                case APP_PKTQ_IN_SOURCE:
                                        name = app->source_params[pp->id].name;
                                        break;
@@ -2490,6 +3050,12 @@ save_pipeline_params(struct app_params *app, FILE *f)
                                case APP_PKTQ_OUT_TM:
                                        name = app->tm_params[pp->id].name;
                                        break;
+                               case APP_PKTQ_OUT_TAP:
+                                       name = app->tap_params[pp->id].name;
+                                       break;
+                               case APP_PKTQ_OUT_KNI:
+                                       name = app->kni_params[pp->id].name;
+                                       break;
                                case APP_PKTQ_OUT_SINK:
                                        name = app->sink_params[pp->id].name;
                                        break;
@@ -2575,6 +3141,8 @@ app_config_save(struct app_params *app, const char *file_name)
        save_txq_params(app, file);
        save_swq_params(app, file);
        save_tm_params(app, file);
+       save_tap_params(app, file);
+       save_kni_params(app, file);
        save_source_params(app, file);
        save_sink_params(app, file);
        save_msgq_params(app, file);
@@ -2590,10 +3158,6 @@ app_config_init(struct app_params *app)
 
        memcpy(app, &app_params_default, sizeof(struct app_params));
 
-       /* configure default_source_params */
-       default_source_params.file_name = strdup("./config/packets.pcap");
-       PARSE_ERROR_MALLOC(default_source_params.file_name != NULL);
-
        for (i = 0; i < RTE_DIM(app->mempool_params); i++)
                memcpy(&app->mempool_params[i],
                        &mempool_params_default,
@@ -2624,6 +3188,16 @@ app_config_init(struct app_params *app)
                        &default_tm_params,
                        sizeof(default_tm_params));
 
+       for (i = 0; i < RTE_DIM(app->tap_params); i++)
+               memcpy(&app->tap_params[i],
+                       &default_tap_params,
+                       sizeof(default_tap_params));
+
+       for (i = 0; i < RTE_DIM(app->kni_params); i++)
+               memcpy(&app->kni_params[i],
+                          &default_kni_params,
+                          sizeof(default_kni_params));
+
        for (i = 0; i < RTE_DIM(app->source_params); i++)
                memcpy(&app->source_params[i],
                        &default_source_params,
@@ -2778,7 +3352,7 @@ app_config_args(struct app_params *app, int argc, char **argv)
                        app_print_usage(argv[0]);
                }
 
-       optind = 0; /* reset getopt lib */
+       optind = 1; /* reset getopt lib */
 
        /* Check dependencies between args */
        if (preproc_params_present && (preproc_present == 0))