event/cnxk: add macros to set eventdev operations
[dpdk.git] / examples / l3fwd-power / main.c
index c02b0a3..aa7b8db 100644 (file)
@@ -47,6 +47,7 @@
 #include <rte_power_empty_poll.h>
 #include <rte_metrics.h>
 #include <rte_telemetry.h>
+#include <rte_power_pmd_mgmt.h>
 
 #include "perf_core.h"
 #include "main.h"
@@ -198,11 +199,16 @@ enum appmode {
        APP_MODE_DEFAULT = 0,
        APP_MODE_LEGACY,
        APP_MODE_EMPTY_POLL,
-       APP_MODE_TELEMETRY
+       APP_MODE_TELEMETRY,
+       APP_MODE_INTERRUPT,
+       APP_MODE_PMD_MGMT
 };
 
 enum appmode app_mode;
 
+static enum rte_power_pmd_mgmt_type pmgmt_type;
+bool baseline_enabled;
+
 enum freq_scale_hint_t
 {
        FREQ_LOWER    =      -1,
@@ -820,20 +826,23 @@ power_freq_scaleup_heuristic(unsigned lcore_id,
  *  0 on success
  */
 static int
-sleep_until_rx_interrupt(int num)
+sleep_until_rx_interrupt(int num, int lcore)
 {
        /*
         * we want to track when we are woken up by traffic so that we can go
-        * back to sleep again without log spamming.
+        * back to sleep again without log spamming. Avoid cache line sharing
+        * to prevent threads stepping on each others' toes.
         */
-       static bool timeout;
+       static struct {
+               bool wakeup;
+       } __rte_cache_aligned status[RTE_MAX_LCORE];
        struct rte_epoll_event event[num];
        int n, i;
        uint16_t port_id;
        uint8_t queue_id;
        void *data;
 
-       if (!timeout) {
+       if (status[lcore].wakeup) {
                RTE_LOG(INFO, L3FWD_POWER,
                                "lcore %u sleeps until interrupt triggers\n",
                                rte_lcore_id());
@@ -850,7 +859,7 @@ sleep_until_rx_interrupt(int num)
                        " port %d queue %d\n",
                        rte_lcore_id(), port_id, queue_id);
        }
-       timeout = n == 0;
+       status[lcore].wakeup = n != 0;
 
        return 0;
 }
@@ -901,6 +910,172 @@ static int event_register(struct lcore_conf *qconf)
 
        return 0;
 }
+
+/* Main processing loop. 8< */
+static int main_intr_loop(__rte_unused void *dummy)
+{
+       struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
+       unsigned int lcore_id;
+       uint64_t prev_tsc, diff_tsc, cur_tsc;
+       int i, j, nb_rx;
+       uint8_t queueid;
+       uint16_t portid;
+       struct lcore_conf *qconf;
+       struct lcore_rx_queue *rx_queue;
+       uint32_t lcore_rx_idle_count = 0;
+       uint32_t lcore_idle_hint = 0;
+       int intr_en = 0;
+
+       const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) /
+                                  US_PER_S * BURST_TX_DRAIN_US;
+
+       prev_tsc = 0;
+
+       lcore_id = rte_lcore_id();
+       qconf = &lcore_conf[lcore_id];
+
+       if (qconf->n_rx_queue == 0) {
+               RTE_LOG(INFO, L3FWD_POWER, "lcore %u has nothing to do\n",
+                               lcore_id);
+               return 0;
+       }
+
+       RTE_LOG(INFO, L3FWD_POWER, "entering main interrupt loop on lcore %u\n",
+                       lcore_id);
+
+       for (i = 0; i < qconf->n_rx_queue; i++) {
+               portid = qconf->rx_queue_list[i].port_id;
+               queueid = qconf->rx_queue_list[i].queue_id;
+               RTE_LOG(INFO, L3FWD_POWER,
+                               " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+                               lcore_id, portid, queueid);
+       }
+
+       /* add into event wait list */
+       if (event_register(qconf) == 0)
+               intr_en = 1;
+       else
+               RTE_LOG(INFO, L3FWD_POWER, "RX interrupt won't enable.\n");
+
+       while (!is_done()) {
+               stats[lcore_id].nb_iteration_looped++;
+
+               cur_tsc = rte_rdtsc();
+
+               /*
+                * TX burst queue drain
+                */
+               diff_tsc = cur_tsc - prev_tsc;
+               if (unlikely(diff_tsc > drain_tsc)) {
+                       for (i = 0; i < qconf->n_tx_port; ++i) {
+                               portid = qconf->tx_port_id[i];
+                               rte_eth_tx_buffer_flush(portid,
+                                               qconf->tx_queue_id[portid],
+                                               qconf->tx_buffer[portid]);
+                       }
+                       prev_tsc = cur_tsc;
+               }
+
+start_rx:
+               /*
+                * Read packet from RX queues
+                */
+               lcore_rx_idle_count = 0;
+               for (i = 0; i < qconf->n_rx_queue; ++i) {
+                       rx_queue = &(qconf->rx_queue_list[i]);
+                       rx_queue->idle_hint = 0;
+                       portid = rx_queue->port_id;
+                       queueid = rx_queue->queue_id;
+
+                       nb_rx = rte_eth_rx_burst(portid, queueid, pkts_burst,
+                                       MAX_PKT_BURST);
+
+                       stats[lcore_id].nb_rx_processed += nb_rx;
+                       if (unlikely(nb_rx == 0)) {
+                               /**
+                                * no packet received from rx queue, try to
+                                * sleep for a while forcing CPU enter deeper
+                                * C states.
+                                */
+                               rx_queue->zero_rx_packet_count++;
+
+                               if (rx_queue->zero_rx_packet_count <=
+                                               MIN_ZERO_POLL_COUNT)
+                                       continue;
+
+                               rx_queue->idle_hint = power_idle_heuristic(
+                                               rx_queue->zero_rx_packet_count);
+                               lcore_rx_idle_count++;
+                       } else {
+                               rx_queue->zero_rx_packet_count = 0;
+                       }
+
+                       /* Prefetch first packets */
+                       for (j = 0; j < PREFETCH_OFFSET && j < nb_rx; j++) {
+                               rte_prefetch0(rte_pktmbuf_mtod(
+                                               pkts_burst[j], void *));
+                       }
+
+                       /* Prefetch and forward already prefetched packets */
+                       for (j = 0; j < (nb_rx - PREFETCH_OFFSET); j++) {
+                               rte_prefetch0(rte_pktmbuf_mtod(
+                                               pkts_burst[j + PREFETCH_OFFSET],
+                                               void *));
+                               l3fwd_simple_forward(
+                                               pkts_burst[j], portid, qconf);
+                       }
+
+                       /* Forward remaining prefetched packets */
+                       for (; j < nb_rx; j++) {
+                               l3fwd_simple_forward(
+                                               pkts_burst[j], portid, qconf);
+                       }
+               }
+
+               if (unlikely(lcore_rx_idle_count == qconf->n_rx_queue)) {
+                       /**
+                        * All Rx queues empty in recent consecutive polls,
+                        * sleep in a conservative manner, meaning sleep as
+                        * less as possible.
+                        */
+                       for (i = 1,
+                           lcore_idle_hint = qconf->rx_queue_list[0].idle_hint;
+                                       i < qconf->n_rx_queue; ++i) {
+                               rx_queue = &(qconf->rx_queue_list[i]);
+                               if (rx_queue->idle_hint < lcore_idle_hint)
+                                       lcore_idle_hint = rx_queue->idle_hint;
+                       }
+
+                       if (lcore_idle_hint < SUSPEND_THRESHOLD)
+                               /**
+                                * execute "pause" instruction to avoid context
+                                * switch which generally take hundred of
+                                * microseconds for short sleep.
+                                */
+                               rte_delay_us(lcore_idle_hint);
+                       else {
+                               /* suspend until rx interrupt triggers */
+                               if (intr_en) {
+                                       turn_on_off_intr(qconf, 1);
+                                       sleep_until_rx_interrupt(
+                                                       qconf->n_rx_queue,
+                                                       lcore_id);
+                                       turn_on_off_intr(qconf, 0);
+                                       /**
+                                        * start receiving packets immediately
+                                        */
+                                       if (likely(!is_done()))
+                                               goto start_rx;
+                               }
+                       }
+                       stats[lcore_id].sleep_time += lcore_idle_hint;
+               }
+       }
+
+       return 0;
+}
+/* >8 End of main processing loop. */
+
 /* main processing loop */
 static int
 main_telemetry_loop(__rte_unused void *dummy)
@@ -1308,7 +1483,8 @@ start_rx:
                                if (intr_en) {
                                        turn_on_off_intr(qconf, 1);
                                        sleep_until_rx_interrupt(
-                                               qconf->n_rx_queue);
+                                                       qconf->n_rx_queue,
+                                                       lcore_id);
                                        turn_on_off_intr(qconf, 0);
                                        /**
                                         * start receiving packets immediately
@@ -1349,7 +1525,7 @@ check_lcore_params(void)
                                                "off\n", lcore, socketid);
                }
                if (app_mode == APP_MODE_TELEMETRY && lcore == rte_lcore_id()) {
-                       printf("cannot enable master core %d in config for telemetry mode\n",
+                       printf("cannot enable main core %d in config for telemetry mode\n",
                                rte_lcore_id());
                        return -1;
                }
@@ -1440,7 +1616,10 @@ print_usage(const char *prgname)
                "  --empty-poll: enable empty poll detection"
                " follow (training_flag, high_threshold, med_threshold)\n"
                " --telemetry: enable telemetry mode, to update"
-               " empty polls, full polls, and core busyness to telemetry\n",
+               " empty polls, full polls, and core busyness to telemetry\n"
+               " --interrupt-only: enable interrupt-only mode\n"
+               " --pmd-mgmt MODE: enable PMD power management mode. "
+               "Currently supported modes: baseline, monitor, pause, scale\n",
                prgname);
 }
 
@@ -1469,10 +1648,7 @@ parse_portmask(const char *portmask)
        /* parse hexadecimal string */
        pm = strtoul(portmask, &end, 16);
        if ((portmask[0] == '\0') || (end == NULL) || (*end != '\0'))
-               return -1;
-
-       if (pm == 0)
-               return -1;
+               return 0;
 
        return pm;
 }
@@ -1533,6 +1709,37 @@ parse_config(const char *q_arg)
 
        return 0;
 }
+
+static int
+parse_pmd_mgmt_config(const char *name)
+{
+#define PMD_MGMT_MONITOR "monitor"
+#define PMD_MGMT_PAUSE   "pause"
+#define PMD_MGMT_SCALE   "scale"
+#define PMD_MGMT_BASELINE  "baseline"
+
+       if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) {
+               pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR;
+               return 0;
+       }
+
+       if (strncmp(PMD_MGMT_PAUSE, name, sizeof(PMD_MGMT_PAUSE)) == 0) {
+               pmgmt_type = RTE_POWER_MGMT_TYPE_PAUSE;
+               return 0;
+       }
+
+       if (strncmp(PMD_MGMT_SCALE, name, sizeof(PMD_MGMT_SCALE)) == 0) {
+               pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE;
+               return 0;
+       }
+       if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) {
+               baseline_enabled = true;
+               return 0;
+       }
+       /* unknown PMD power management mode */
+       return -1;
+}
+
 static int
 parse_ep_config(const char *q_arg)
 {
@@ -1548,7 +1755,7 @@ parse_ep_config(const char *q_arg)
        int hgh_edpi;
 
        ep_med_edpi = EMPTY_POLL_MED_THRESHOLD;
-       ep_hgh_edpi = EMPTY_POLL_MED_THRESHOLD;
+       ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
 
        strlcpy(s, p, sizeof(s));
 
@@ -1571,7 +1778,7 @@ parse_ep_config(const char *q_arg)
                if (med_edpi > 0)
                        ep_med_edpi = med_edpi;
 
-               if (med_edpi > 0)
+               if (hgh_edpi > 0)
                        ep_hgh_edpi = hgh_edpi;
 
        } else {
@@ -1585,7 +1792,9 @@ parse_ep_config(const char *q_arg)
 #define CMD_LINE_OPT_PARSE_PTYPE "parse-ptype"
 #define CMD_LINE_OPT_LEGACY "legacy"
 #define CMD_LINE_OPT_EMPTY_POLL "empty-poll"
+#define CMD_LINE_OPT_INTERRUPT_ONLY "interrupt-only"
 #define CMD_LINE_OPT_TELEMETRY "telemetry"
+#define CMD_LINE_OPT_PMD_MGMT "pmd-mgmt"
 
 /* Parse the argument given in the command line of the application */
 static int
@@ -1606,6 +1815,8 @@ parse_args(int argc, char **argv)
                {CMD_LINE_OPT_PARSE_PTYPE, 0, 0, 0},
                {CMD_LINE_OPT_LEGACY, 0, 0, 0},
                {CMD_LINE_OPT_TELEMETRY, 0, 0, 0},
+               {CMD_LINE_OPT_INTERRUPT_ONLY, 0, 0, 0},
+               {CMD_LINE_OPT_PMD_MGMT, 1, 0, 0},
                {NULL, 0, 0, 0}
        };
 
@@ -1716,6 +1927,32 @@ parse_args(int argc, char **argv)
                                printf("telemetry mode is enabled\n");
                        }
 
+                       if (!strncmp(lgopts[option_index].name,
+                                       CMD_LINE_OPT_PMD_MGMT,
+                                       sizeof(CMD_LINE_OPT_PMD_MGMT))) {
+                               if (app_mode != APP_MODE_DEFAULT) {
+                                       printf(" power mgmt mode is mutually exclusive with other modes\n");
+                                       return -1;
+                               }
+                               if (parse_pmd_mgmt_config(optarg) < 0) {
+                                       printf(" Invalid PMD power management mode: %s\n",
+                                                       optarg);
+                                       return -1;
+                               }
+                               app_mode = APP_MODE_PMD_MGMT;
+                               printf("PMD power mgmt mode is enabled\n");
+                       }
+                       if (!strncmp(lgopts[option_index].name,
+                                       CMD_LINE_OPT_INTERRUPT_ONLY,
+                                       sizeof(CMD_LINE_OPT_INTERRUPT_ONLY))) {
+                               if (app_mode != APP_MODE_DEFAULT) {
+                                       printf(" interrupt-only mode is mutually exclusive with other modes\n");
+                                       return -1;
+                               }
+                               app_mode = APP_MODE_INTERRUPT;
+                               printf("interrupt-only mode is enabled\n");
+                       }
+
                        if (!strncmp(lgopts[option_index].name,
                                        "enable-jumbo", 12)) {
                                struct option lenopts =
@@ -1958,6 +2195,7 @@ check_all_ports_link_status(uint32_t port_mask)
        uint16_t portid;
        struct rte_eth_link link;
        int ret;
+       char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
 
        printf("\nChecking link status");
        fflush(stdout);
@@ -1977,15 +2215,10 @@ check_all_ports_link_status(uint32_t port_mask)
                        }
                        /* print link status if flag set */
                        if (print_flag == 1) {
-                               if (link.link_status)
-                                       printf("Port %d Link Up - speed %u "
-                                               "Mbps - %s\n", (uint8_t)portid,
-                                               (unsigned)link.link_speed,
-                               (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
-                                       ("full-duplex") : ("half-duplex"));
-                               else
-                                       printf("Port %d Link Down\n",
-                                               (uint8_t)portid);
+                               rte_eth_link_to_str(link_status_text,
+                                       sizeof(link_status_text), &link);
+                               printf("Port %d %s\n", portid,
+                                      link_status_text);
                                continue;
                        }
                        /* clear all_ports_up flag if any link down */
@@ -2111,7 +2344,7 @@ get_current_stat_values(uint64_t *values)
        uint64_t app_eps = 0, app_fps = 0, app_br = 0;
        uint64_t count = 0;
 
-       RTE_LCORE_FOREACH_SLAVE(lcore_id) {
+       RTE_LCORE_FOREACH_WORKER(lcore_id) {
                qconf = &lcore_conf[lcore_id];
                if (qconf->n_rx_queue == 0)
                        continue;
@@ -2203,10 +2436,10 @@ launch_timer(unsigned int lcore_id)
        RTE_SET_USED(lcore_id);
 
 
-       if (rte_get_master_lcore() != lcore_id) {
-               rte_panic("timer on lcore:%d which is not master core:%d\n",
+       if (rte_get_main_lcore() != lcore_id) {
+               rte_panic("timer on lcore:%d which is not main core:%d\n",
                                lcore_id,
-                               rte_get_master_lcore());
+                               rte_get_main_lcore());
        }
 
        RTE_LOG(INFO, POWER, "Bring up the Timer\n");
@@ -2233,7 +2466,46 @@ launch_timer(unsigned int lcore_id)
        return 0;
 }
 
+static int
+autodetect_mode(void)
+{
+       RTE_LOG(NOTICE, L3FWD_POWER, "Operating mode not specified, probing frequency scaling support...\n");
+
+       /*
+        * Empty poll and telemetry modes have to be specifically requested to
+        * be enabled, but we can auto-detect between interrupt mode with or
+        * without frequency scaling. Both ACPI and pstate can be used.
+        */
+       if (rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ))
+               return APP_MODE_LEGACY;
+       if (rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ))
+               return APP_MODE_LEGACY;
+
+       RTE_LOG(NOTICE, L3FWD_POWER, "Frequency scaling not supported, selecting interrupt-only mode\n");
+
+       return APP_MODE_INTERRUPT;
+}
 
+static const char *
+mode_to_str(enum appmode mode)
+{
+       switch (mode) {
+       case APP_MODE_LEGACY:
+               return "legacy";
+       case APP_MODE_EMPTY_POLL:
+               return "empty poll";
+       case APP_MODE_TELEMETRY:
+               return "telemetry";
+       case APP_MODE_INTERRUPT:
+               return "interrupt-only";
+       case APP_MODE_PMD_MGMT:
+               return "pmd mgmt";
+       default:
+               return "invalid";
+       }
+}
+
+/* Power library initialized in the main routine. 8< */
 int
 main(int argc, char **argv)
 {
@@ -2264,13 +2536,19 @@ main(int argc, char **argv)
        /* init RTE timer library to be used late */
        rte_timer_subsystem_init();
 
+       /* if we're running pmd-mgmt mode, don't default to baseline mode */
+       baseline_enabled = false;
+
        /* parse application arguments (after the EAL ones) */
        ret = parse_args(argc, argv);
        if (ret < 0)
                rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
 
        if (app_mode == APP_MODE_DEFAULT)
-               app_mode = APP_MODE_LEGACY;
+               app_mode = autodetect_mode();
+
+       RTE_LOG(INFO, L3FWD_POWER, "Selected operation mode: %s\n",
+                       mode_to_str(app_mode));
 
        /* only legacy and empty poll mode rely on power library */
        if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
@@ -2298,7 +2576,8 @@ main(int argc, char **argv)
        RTE_ETH_FOREACH_DEV(portid) {
                struct rte_eth_conf local_port_conf = port_conf;
                /* not all app modes need interrupts */
-               bool need_intr = app_mode == APP_MODE_LEGACY;
+               bool need_intr = app_mode == APP_MODE_LEGACY ||
+                               app_mode == APP_MODE_INTERRUPT;
 
                /* skip ports that are not enabled */
                if ((enabled_port_mask & (1 << portid)) == 0) {
@@ -2454,6 +2733,7 @@ main(int argc, char **argv)
                qconf = &lcore_conf[lcore_id];
                printf("\nInitializing rx queues on lcore %u ... ", lcore_id );
                fflush(stdout);
+
                /* init RX queues */
                for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
                        struct rte_eth_rxconf rxq_conf;
@@ -2490,11 +2770,20 @@ main(int argc, char **argv)
                                if (add_cb_parse_ptype(portid, queueid) < 0)
                                        rte_exit(EXIT_FAILURE,
                                                 "Fail to add ptype cb\n");
-                       } else if (!check_ptype(portid))
-                               rte_exit(EXIT_FAILURE,
-                                        "PMD can not provide needed ptypes\n");
+                       }
+
+                       if (app_mode == APP_MODE_PMD_MGMT && !baseline_enabled) {
+                               ret = rte_power_ethdev_pmgmt_queue_enable(
+                                               lcore_id, portid, queueid,
+                                               pmgmt_type);
+                               if (ret < 0)
+                                       rte_exit(EXIT_FAILURE,
+                                               "rte_power_ethdev_pmgmt_queue_enable: err=%d, port=%d\n",
+                                                       ret, portid);
+                       }
                }
        }
+       /* >8 End of power library initialization. */
 
        printf("\n");
 
@@ -2523,6 +2812,11 @@ main(int argc, char **argv)
                }
                /* initialize spinlock for each port */
                rte_spinlock_init(&(locks[portid]));
+
+               if (!parse_ptype)
+                       if (!check_ptype(portid))
+                               rte_exit(EXIT_FAILURE,
+                                       "PMD can not provide needed ptypes\n");
        }
 
        check_all_ports_link_status(enabled_port_mask);
@@ -2547,11 +2841,11 @@ main(int argc, char **argv)
 
        /* launch per-lcore init on every lcore */
        if (app_mode == APP_MODE_LEGACY) {
-               rte_eal_mp_remote_launch(main_legacy_loop, NULL, CALL_MASTER);
+               rte_eal_mp_remote_launch(main_legacy_loop, NULL, CALL_MAIN);
        } else if (app_mode == APP_MODE_EMPTY_POLL) {
                empty_poll_stop = false;
                rte_eal_mp_remote_launch(main_empty_poll_loop, NULL,
-                               SKIP_MASTER);
+                               SKIP_MAIN);
        } else if (app_mode == APP_MODE_TELEMETRY) {
                unsigned int i;
 
@@ -2567,7 +2861,7 @@ main(int argc, char **argv)
                else
                        rte_exit(EXIT_FAILURE, "failed to register metrics names");
 
-               RTE_LCORE_FOREACH_SLAVE(lcore_id) {
+               RTE_LCORE_FOREACH_WORKER(lcore_id) {
                        rte_spinlock_init(&stats[lcore_id].telemetry_lock);
                }
                rte_timer_init(&telemetry_timer);
@@ -2575,23 +2869,47 @@ main(int argc, char **argv)
                                handle_app_stats,
                                "Returns global power stats. Parameters: None");
                rte_eal_mp_remote_launch(main_telemetry_loop, NULL,
-                                               SKIP_MASTER);
+                                               SKIP_MAIN);
+       } else if (app_mode == APP_MODE_INTERRUPT) {
+               rte_eal_mp_remote_launch(main_intr_loop, NULL, CALL_MAIN);
+       } else if (app_mode == APP_MODE_PMD_MGMT) {
+               /* reuse telemetry loop for PMD power management mode */
+               rte_eal_mp_remote_launch(main_telemetry_loop, NULL, CALL_MAIN);
        }
 
        if (app_mode == APP_MODE_EMPTY_POLL || app_mode == APP_MODE_TELEMETRY)
                launch_timer(rte_lcore_id());
 
-       RTE_LCORE_FOREACH_SLAVE(lcore_id) {
+       RTE_LCORE_FOREACH_WORKER(lcore_id) {
                if (rte_eal_wait_lcore(lcore_id) < 0)
                        return -1;
        }
 
+       if (app_mode == APP_MODE_PMD_MGMT) {
+               for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+                       if (rte_lcore_is_enabled(lcore_id) == 0)
+                               continue;
+                       qconf = &lcore_conf[lcore_id];
+                       for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
+                               portid = qconf->rx_queue_list[queue].port_id;
+                               queueid = qconf->rx_queue_list[queue].queue_id;
+
+                               rte_power_ethdev_pmgmt_queue_disable(lcore_id,
+                                               portid, queueid);
+                       }
+               }
+       }
+
        RTE_ETH_FOREACH_DEV(portid)
        {
                if ((enabled_port_mask & (1 << portid)) == 0)
                        continue;
 
-               rte_eth_dev_stop(portid);
+               ret = rte_eth_dev_stop(portid);
+               if (ret != 0)
+                       RTE_LOG(ERR, L3FWD_POWER, "rte_eth_dev_stop: err=%d, port=%u\n",
+                               ret, portid);
+
                rte_eth_dev_close(portid);
        }