ring: guarantee load/load order in enqueue and dequeue

[dpdk.git] / examples / qos_sched / args.c

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
old mode 100755 (executable)
new mode 100644 (file)
index 42ef5f9..203a347
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -112,7 +112,7 @@ app_usage(const char *prgname)
 
 static inline int str_is(const char *str, const char *is)
 {
-       return (strcmp(str, is) == 0);
+       return strcmp(str, is) == 0;
 }
 
 /* returns core mask used by DPDK */
@@ -123,7 +123,7 @@ app_eal_core_mask(void)
        uint64_t cm = 0;
        struct rte_config *cfg = rte_eal_get_configuration();
 
-       for (i = 0; i < RTE_MAX_LCORE; i++) {
+       for (i = 0; i < APP_MAX_LCORE; i++) {
                if (cfg->lcore_role[i] == ROLE_RTE)
                        cm |= (1ULL << i);
        }
@@ -142,8 +142,8 @@ app_cpu_core_count(void)
        char path[PATH_MAX];
        uint32_t ncores = 0;
 
-       for(i = 0; i < RTE_MAX_LCORE; i++) {
-               len = rte_snprintf(path, sizeof(path), SYS_CPU_DIR, i);
+       for (i = 0; i < APP_MAX_LCORE; i++) {
+               len = snprintf(path, sizeof(path), SYS_CPU_DIR, i);
                if (len <= 0 || (unsigned)len >= sizeof(path))
                        continue;
 
@@ -162,7 +162,7 @@ static int
 app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32_t *opt_vals)
 {
        char *string;
-       uint32_t i, n_tokens;
+       int i, n_tokens;
        char *tokens[MAX_OPT_VALUES];
 
        if (conf_str == NULL || opt_vals == NULL || n_vals == 0 || n_vals > MAX_OPT_VALUES)
@@ -175,9 +175,11 @@ app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32
 
        n_tokens = rte_strsplit(string, strnlen(string, 32), tokens, n_vals, separator);
 
-       for(i = 0; i < n_tokens; i++) {
+       if (n_tokens > MAX_OPT_VALUES)
+               return -1;
+
+       for (i = 0; i < n_tokens; i++)
                opt_vals[i] = (uint32_t)atol(tokens[i]);
-       }
 
        free(string);
 
@@ -243,14 +245,15 @@ app_parse_flow_conf(const char *conf_str)
        struct flow_conf *pconf;
        uint64_t mask;
 
+       memset(vals, 0, sizeof(vals));
        ret = app_parse_opt_vals(conf_str, ',', 6, vals);
        if (ret < 4 || ret > 5)
                return ret;
 
        pconf = &qos_conf[nb_pfc];
 
-       pconf->rx_port = (uint8_t)vals[0];
-       pconf->tx_port = (uint8_t)vals[1];
+       pconf->rx_port = vals[0];
+       pconf->tx_port = vals[1];
        pconf->rx_core = (uint8_t)vals[2];
        pconf->wt_core = (uint8_t)vals[3];
        if (ret == 5)
@@ -264,19 +267,19 @@ app_parse_flow_conf(const char *conf_str)
        }
 
        if (pconf->rx_port >= RTE_MAX_ETHPORTS) {
-               RTE_LOG(ERR, APP, "pfc %u: invalid rx port %"PRIu8" index\n",
+               RTE_LOG(ERR, APP, "pfc %u: invalid rx port %"PRIu16" index\n",
                                nb_pfc, pconf->rx_port);
                return -1;
        }
        if (pconf->tx_port >= RTE_MAX_ETHPORTS) {
-               RTE_LOG(ERR, APP, "pfc %u: invalid tx port %"PRIu8" index\n",
-                               nb_pfc, pconf->rx_port);
+               RTE_LOG(ERR, APP, "pfc %u: invalid tx port %"PRIu16" index\n",
+                               nb_pfc, pconf->tx_port);
                return -1;
        }
 
        mask = 1lu << pconf->rx_port;
        if (app_used_rx_port_mask & mask) {
-               RTE_LOG(ERR, APP, "pfc %u: rx port %"PRIu8" is used already\n",
+               RTE_LOG(ERR, APP, "pfc %u: rx port %"PRIu16" is used already\n",
                                nb_pfc, pconf->rx_port);
                return -1;
        }
@@ -285,7 +288,7 @@ app_parse_flow_conf(const char *conf_str)
 
        mask = 1lu << pconf->tx_port;
        if (app_used_tx_port_mask & mask) {
-               RTE_LOG(ERR, APP, "pfc %u: port %"PRIu8" is used already\n",
+               RTE_LOG(ERR, APP, "pfc %u: port %"PRIu16" is used already\n",
                                nb_pfc, pconf->tx_port);
                return -1;
        }
@@ -483,4 +486,3 @@ app_parse_args(int argc, char **argv)
 
        return 0;
 }
-