replace snprintf with strlcpy

[dpdk.git] / examples / vm_power_manager / channel_monitor.c

diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 1a3a0fa..74df0fe 100644 (file)
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -21,6 +21,7 @@
 #else
 #pragma message "Jansson dev libs unavailable, not including JSON parsing"
 #endif
+#include <rte_string_fns.h>
 #include <rte_log.h>
 #include <rte_memory.h>
 #include <rte_malloc.h>
@@ -161,7 +162,7 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
                        strcpy(pkt->vm_name, json_string_value(value));
                } else if (!strcmp(key, "command")) {
                        char command[32];
-                       snprintf(command, 32, "%s", json_string_value(value));
+                       strlcpy(command, json_string_value(value), 32);
                        if (!strcmp(command, "power")) {
                                pkt->command = CPU_POWER;
                        } else if (!strcmp(command, "create")) {
@@ -175,7 +176,7 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
                        }
                } else if (!strcmp(key, "policy_type")) {
                        char command[32];
-                       snprintf(command, 32, "%s", json_string_value(value));
+                       strlcpy(command, json_string_value(value), 32);
                        if (!strcmp(command, "TIME")) {
                                pkt->policy_to_use = TIME;
                        } else if (!strcmp(command, "TRAFFIC")) {
@@ -191,7 +192,7 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
                        }
                } else if (!strcmp(key, "workload")) {
                        char command[32];
-                       snprintf(command, 32, "%s", json_string_value(value));
+                       strlcpy(command, json_string_value(value), 32);
                        if (!strcmp(command, "HIGH")) {
                                pkt->workload = HIGH;
                        } else if (!strcmp(command, "MEDIUM")) {
@@ -237,8 +238,9 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
 
                        for (i = 0; i < size; i++) {
                                char mac[32];
-                               snprintf(mac, 32, "%s", json_string_value(
-                                               json_array_get(value, i)));
+                               strlcpy(mac,
+                                       json_string_value(json_array_get(value, i)),
+                                       32);
                                set_policy_mac(pkt, i, mac);
                        }
                        pkt->nb_mac_to_monitor = size;
@@ -250,7 +252,7 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
                                        (uint32_t)json_integer_value(value);
                } else if (!strcmp(key, "unit")) {
                        char unit[32];
-                       snprintf(unit, 32, "%s", json_string_value(value));
+                       strlcpy(unit, json_string_value(value), 32);
                        if (!strcmp(unit, "SCALE_UP")) {
                                pkt->unit = CPU_POWER_SCALE_UP;
                        } else if (!strcmp(unit, "SCALE_DOWN")) {
@@ -435,7 +437,7 @@ update_policy(struct channel_packet *pkt)
                        /* Copy the contents of *pkt into the policy.pkt */
                        policies[i].pkt = *pkt;
                        get_pcpu_to_control(&policies[i]);
-                       if (get_pfid(&policies[i]) == -1) {
+                       if (get_pfid(&policies[i]) < 0) {
                                updated = 1;
                                break;
                        }
@@ -449,7 +451,7 @@ update_policy(struct channel_packet *pkt)
                        if (policies[i].enabled == 0) {
                                policies[i].pkt = *pkt;
                                get_pcpu_to_control(&policies[i]);
-                               if (get_pfid(&policies[i]) == -1)
+                               if (get_pfid(&policies[i]) < 0)
                                        break;
                                core_share_status(i);
                                policies[i].enabled = 1;
@@ -630,6 +632,8 @@ apply_policy(struct policy *pol)
 static int
 process_request(struct channel_packet *pkt, struct channel_info *chan_info)
 {
+       int ret;
+
        if (chan_info == NULL)
                return -1;
 
@@ -645,6 +649,9 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
                else
                        core_num = pkt->resource_id;
 
+               RTE_LOG(DEBUG, CHANNEL_MONITOR, "Processing requested cmd for cpu:%d\n",
+                       core_num);
+
                switch (pkt->unit) {
                case(CPU_POWER_SCALE_MIN):
                        power_manager_scale_core_min(core_num);
@@ -677,9 +684,13 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
        }
 
        if (pkt->command == PKT_POLICY_REMOVE) {
-               RTE_LOG(INFO, CHANNEL_MONITOR,
-                                "Removing policy %s\n", pkt->vm_name);
-               remove_policy(pkt);
+               ret = remove_policy(pkt);
+               if (ret == 0)
+                       RTE_LOG(INFO, CHANNEL_MONITOR,
+                                "Removed policy %s\n", pkt->vm_name);
+               else
+                       RTE_LOG(INFO, CHANNEL_MONITOR,
+                                "Policy %s does not exist\n", pkt->vm_name);
        }
 
        /*
@@ -756,7 +767,7 @@ read_binary_packet(struct channel_info *chan_info)
                                buffer, buffer_len);
                if (n_bytes == buffer_len)
                        break;
-               if (n_bytes == -1) {
+               if (n_bytes < 0) {
                        err = errno;
                        RTE_LOG(DEBUG, CHANNEL_MONITOR,
                                "Received error on "