common/cnxk: fix null pointer dereference
[dpdk.git] / lib / eventdev / rte_event_eth_rx_adapter.c
index f946137..ff83ce8 100644 (file)
@@ -293,6 +293,30 @@ rxa_event_buf_get(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id,
        } \
 } while (0)
 
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(id, retval) do { \
+       if (!rxa_validate_id(id)) { \
+               RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d\n", id); \
+               ret = retval; \
+               goto error; \
+       } \
+} while (0)
+
+#define RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, retval) do { \
+       if ((token) == NULL || strlen(token) == 0 || !isdigit(*token)) { \
+               RTE_EDEV_LOG_ERR("Invalid eth Rx adapter token\n"); \
+               ret = retval; \
+               goto error; \
+       } \
+} while (0)
+
+#define RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(port_id, retval) do { \
+       if (!rte_eth_dev_is_valid_port(port_id)) { \
+               RTE_ETHDEV_LOG(ERR, "Invalid port_id=%u\n", port_id); \
+               ret = retval; \
+               goto error; \
+       } \
+} while (0)
+
 static inline int
 rxa_sw_adapter_queue_count(struct event_eth_rx_adapter *rx_adapter)
 {
@@ -3123,6 +3147,26 @@ rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id)
        return rx_adapter->service_inited ? 0 : -ESRCH;
 }
 
+int
+rte_event_eth_rx_adapter_event_port_get(uint8_t id, uint8_t *event_port_id)
+{
+       struct event_eth_rx_adapter *rx_adapter;
+
+       if (rxa_memzone_lookup())
+               return -ENOMEM;
+
+       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+       rx_adapter = rxa_id_to_adapter(id);
+       if (rx_adapter == NULL || event_port_id == NULL)
+               return -EINVAL;
+
+       if (rx_adapter->service_inited)
+               *event_port_id = rx_adapter->event_port_id;
+
+       return rx_adapter->service_inited ? 0 : -ESRCH;
+}
+
 int
 rte_event_eth_rx_adapter_cb_register(uint8_t id,
                                        uint16_t eth_dev_id,
@@ -3174,11 +3218,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
                        uint16_t rx_queue_id,
                        struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
 {
+#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq))
        struct rte_eventdev *dev;
        struct event_eth_rx_adapter *rx_adapter;
        struct eth_device_info *dev_info;
        struct eth_rx_queue_info *queue_info;
-       struct rte_event *qi_ev;
        int ret;
 
        if (rxa_memzone_lookup())
@@ -3209,7 +3253,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
        }
 
        queue_info = &dev_info->rx_queue[rx_queue_id];
-       qi_ev = (struct rte_event *)&queue_info->event;
 
        memset(queue_conf, 0, sizeof(*queue_conf));
        queue_conf->rx_queue_flags = 0;
@@ -3218,7 +3261,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
                        RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
        queue_conf->servicing_weight = queue_info->wt;
 
-       memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev));
+       queue_conf->ev.event = queue_info->event;
+
+       queue_conf->vector_sz = queue_info->vector_data.max_vector_count;
+       queue_conf->vector_mp = queue_info->vector_data.vector_pool;
+       /* need to be converted from ticks to ns */
+       queue_conf->vector_timeout_ns = TICK2NSEC(
+               queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz());
+
+       if (queue_info->event_buf != NULL)
+               queue_conf->event_buf_size = queue_info->event_buf->events_size;
+       else
+               queue_conf->event_buf_size = 0;
 
        dev = &rte_eventdevs[rx_adapter->eventdev_id];
        if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) {
@@ -3303,7 +3357,7 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 {
        uint8_t rx_adapter_id;
        uint16_t rx_queue_id;
-       int eth_dev_id;
+       int eth_dev_id, ret = -1;
        char *token, *l_params;
        struct rte_event_eth_rx_adapter_queue_conf queue_conf;
 
@@ -3312,33 +3366,37 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 
        /* Get Rx adapter ID from parameter string */
        l_params = strdup(params);
+       if (l_params == NULL)
+               return -ENOMEM;
        token = strtok(l_params, ",");
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
        rx_adapter_id = strtoul(token, NULL, 10);
-       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(rx_adapter_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get device ID from parameter string */
        eth_dev_id = strtoul(token, NULL, 10);
-       RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+       RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get Rx queue ID from parameter string */
        rx_queue_id = strtoul(token, NULL, 10);
        if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
                RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
-               return -EINVAL;
+               ret = -EINVAL;
+               goto error;
        }
 
        token = strtok(NULL, "\0");
        if (token != NULL)
                RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
                                 " telemetry command, ignoring");
+       /* Parsing parameter finished */
+       free(l_params);
 
        if (rte_event_eth_rx_adapter_queue_conf_get(rx_adapter_id, eth_dev_id,
                                                    rx_queue_id, &queue_conf)) {
@@ -3358,6 +3416,10 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
        RXA_ADD_DICT(queue_conf.ev, flow_id);
 
        return 0;
+
+error:
+       free(l_params);
+       return ret;
 }
 
 static int
@@ -3367,7 +3429,7 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 {
        uint8_t rx_adapter_id;
        uint16_t rx_queue_id;
-       int eth_dev_id;
+       int eth_dev_id, ret = -1;
        char *token, *l_params;
        struct rte_event_eth_rx_adapter_queue_stats q_stats;
 
@@ -3376,33 +3438,37 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 
        /* Get Rx adapter ID from parameter string */
        l_params = strdup(params);
+       if (l_params == NULL)
+               return -ENOMEM;
        token = strtok(l_params, ",");
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
        rx_adapter_id = strtoul(token, NULL, 10);
-       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(rx_adapter_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get device ID from parameter string */
        eth_dev_id = strtoul(token, NULL, 10);
-       RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+       RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get Rx queue ID from parameter string */
        rx_queue_id = strtoul(token, NULL, 10);
        if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
                RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
-               return -EINVAL;
+               ret = -EINVAL;
+               goto error;
        }
 
        token = strtok(NULL, "\0");
        if (token != NULL)
                RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
                                 " telemetry command, ignoring");
+       /* Parsing parameter finished */
+       free(l_params);
 
        if (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,
                                                    rx_queue_id, &q_stats)) {
@@ -3421,6 +3487,10 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
        RXA_ADD_DICT(q_stats, rx_dropped);
 
        return 0;
+
+error:
+       free(l_params);
+       return ret;
 }
 
 static int
@@ -3430,7 +3500,7 @@ handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 {
        uint8_t rx_adapter_id;
        uint16_t rx_queue_id;
-       int eth_dev_id;
+       int eth_dev_id, ret = -1;
        char *token, *l_params;
 
        if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -3438,33 +3508,37 @@ handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 
        /* Get Rx adapter ID from parameter string */
        l_params = strdup(params);
+       if (l_params == NULL)
+               return -ENOMEM;
        token = strtok(l_params, ",");
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
        rx_adapter_id = strtoul(token, NULL, 10);
-       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+       RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(rx_adapter_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get device ID from parameter string */
        eth_dev_id = strtoul(token, NULL, 10);
-       RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+       RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -EINVAL);
 
        token = strtok(NULL, ",");
-       if (token == NULL || strlen(token) == 0 || !isdigit(*token))
-               return -1;
+       RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
        /* Get Rx queue ID from parameter string */
        rx_queue_id = strtoul(token, NULL, 10);
        if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
                RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
-               return -EINVAL;
+               ret = -EINVAL;
+               goto error;
        }
 
        token = strtok(NULL, "\0");
        if (token != NULL)
                RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
                                 " telemetry command, ignoring");
+       /* Parsing parameter finished */
+       free(l_params);
 
        if (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,
                                                       eth_dev_id,
@@ -3474,6 +3548,10 @@ handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
        }
 
        return 0;
+
+error:
+       free(l_params);
+       return ret;
 }
 
 RTE_INIT(rxa_init_telemetry)