lib: remove extra parenthesis after return

[dpdk.git] / lib / librte_cmdline / cmdline_parse_ipaddr.c

diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c
index 68f4625..d3d3e04 100644 (file)
--- a/lib/librte_cmdline/cmdline_parse_ipaddr.c
+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c
@@ -1,13 +1,13 @@
 /*-
  *   BSD LICENSE
- * 
+ *
  *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
  *   All rights reserved.
- * 
+ *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
  *   are met:
- * 
+ *
  *     * Redistributions of source code must retain the above copyright
  *       notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above copyright
@@ -17,7 +17,7 @@
  *     * Neither the name of Intel Corporation nor the names of its
  *       contributors may be used to endorse or promote products derived
  *       from this software without specific prior written permission.
- * 
+ *
  *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -87,7 +87,11 @@
 #include <errno.h>
 #include <netinet/in.h>
 #ifndef __linux__
+#ifndef __FreeBSD__
 #include <net/socket.h>
+#else
+#include <sys/socket.h>
+#endif
 #endif
 
 #include <rte_string_fns.h>
@@ -131,12 +135,12 @@ my_inet_pton(int af, const char *src, void *dst)
 {
        switch (af) {
                case AF_INET:
-                       return (inet_pton4(src, dst));
+                       return inet_pton4(src, dst);
                case AF_INET6:
-                       return (inet_pton6(src, dst));
+                       return inet_pton6(src, dst);
                default:
                        errno = EAFNOSUPPORT;
-                       return (-1);
+                       return -1;
        }
        /* NOTREACHED */
 }
@@ -168,26 +172,26 @@ inet_pton4(const char *src, unsigned char *dst)
                        unsigned int new = *tp * 10 + (pch - digits);
 
                        if (new > 255)
-                               return (0);
+                               return 0;
                        if (! saw_digit) {
                                if (++octets > 4)
-                                       return (0);
+                                       return 0;
                                saw_digit = 1;
                        }
                        *tp = (unsigned char)new;
                } else if (ch == '.' && saw_digit) {
                        if (octets == 4)
-                               return (0);
+                               return 0;
                        *++tp = 0;
                        saw_digit = 0;
                } else
-                       return (0);
+                       return 0;
        }
        if (octets < 4)
-               return (0);
+               return 0;
 
        memcpy(dst, tmp, INADDRSZ);
-       return (1);
+       return 1;
 }
 
 /* int
@@ -220,7 +224,7 @@ inet_pton6(const char *src, unsigned char *dst)
        /* Leading :: requires some special handling. */
        if (*src == ':')
                if (*++src != ':')
-                       return (0);
+                       return 0;
        curtok = src;
        saw_xdigit = count_xdigit = 0;
        val = 0;
@@ -232,11 +236,11 @@ inet_pton6(const char *src, unsigned char *dst)
                        pch = strchr((xdigits = xdigits_u), ch);
                if (pch != NULL) {
                        if (count_xdigit >= 4)
-                               return (0);
+                               return 0;
                        val <<= 4;
                        val |= (pch - xdigits);
                        if (val > 0xffff)
-                               return (0);
+                               return 0;
                        saw_xdigit = 1;
                        count_xdigit++;
                        continue;
@@ -245,14 +249,14 @@ inet_pton6(const char *src, unsigned char *dst)
                        curtok = src;
                        if (!saw_xdigit) {
                                if (colonp)
-                                       return (0);
+                                       return 0;
                                colonp = tp;
                                continue;
                        } else if (*src == '\0') {
-                               return (0);
+                               return 0;
                        }
                        if (tp + sizeof(int16_t) > endp)
-                               return (0);
+                               return 0;
                        *tp++ = (unsigned char) ((val >> 8) & 0xff);
                        *tp++ = (unsigned char) (val & 0xff);
                        saw_xdigit = 0;
@@ -268,11 +272,11 @@ inet_pton6(const char *src, unsigned char *dst)
                        dbloct_count += 2;
                        break;  /* '\0' was seen by inet_pton4(). */
                }
-               return (0);
+               return 0;
        }
        if (saw_xdigit) {
                if (tp + sizeof(int16_t) > endp)
-                       return (0);
+                       return 0;
                *tp++ = (unsigned char) ((val >> 8) & 0xff);
                *tp++ = (unsigned char) (val & 0xff);
                dbloct_count++;
@@ -296,13 +300,14 @@ inet_pton6(const char *src, unsigned char *dst)
                tp = endp;
        }
        if (tp != endp)
-               return (0);
+               return 0;
        memcpy(dst, tmp, IN6ADDRSZ);
-       return (1);
+       return 1;
 }
 
 int
-cmdline_parse_ipaddr(cmdline_parse_token_hdr_t *tk, const char *buf, void *res)
+cmdline_parse_ipaddr(cmdline_parse_token_hdr_t *tk, const char *buf, void *res,
+       unsigned ressize)
 {
        struct cmdline_token_ipaddr *tk2;
        unsigned int token_len = 0;
@@ -311,6 +316,9 @@ cmdline_parse_ipaddr(cmdline_parse_token_hdr_t *tk, const char *buf, void *res)
        char *prefix, *prefix_end;
        long prefixlen = 0;
 
+       if (res && ressize < sizeof(cmdline_ipaddr_t))
+               return -1;
+
        if (!buf || !tk || ! *buf)
                return -1;
 
@@ -323,7 +331,7 @@ cmdline_parse_ipaddr(cmdline_parse_token_hdr_t *tk, const char *buf, void *res)
        if (token_len >= INET6_ADDRSTRLEN+4)
                return -1;
 
-       rte_snprintf(ip_str, token_len+1, "%s", buf);
+       snprintf(ip_str, token_len+1, "%s", buf);
 
        /* convert the network prefix */
        if (tk2->ipaddr_data.flags & CMDLINE_IPADDR_NETWORK) {
@@ -375,25 +383,25 @@ int cmdline_get_help_ipaddr(cmdline_parse_token_hdr_t *tk, char *dstbuf,
 
        switch (tk2->ipaddr_data.flags) {
        case CMDLINE_IPADDR_V4:
-               rte_snprintf(dstbuf, size, "IPv4");
+               snprintf(dstbuf, size, "IPv4");
                break;
        case CMDLINE_IPADDR_V6:
-               rte_snprintf(dstbuf, size, "IPv6");
+               snprintf(dstbuf, size, "IPv6");
                break;
        case CMDLINE_IPADDR_V4|CMDLINE_IPADDR_V6:
-               rte_snprintf(dstbuf, size, "IPv4/IPv6");
+               snprintf(dstbuf, size, "IPv4/IPv6");
                break;
        case CMDLINE_IPADDR_NETWORK|CMDLINE_IPADDR_V4:
-               rte_snprintf(dstbuf, size, "IPv4 network");
+               snprintf(dstbuf, size, "IPv4 network");
                break;
        case CMDLINE_IPADDR_NETWORK|CMDLINE_IPADDR_V6:
-               rte_snprintf(dstbuf, size, "IPv6 network");
+               snprintf(dstbuf, size, "IPv6 network");
                break;
        case CMDLINE_IPADDR_NETWORK|CMDLINE_IPADDR_V4|CMDLINE_IPADDR_V6:
-               rte_snprintf(dstbuf, size, "IPv4/IPv6 network");
+               snprintf(dstbuf, size, "IPv4/IPv6 network");
                break;
        default:
-               rte_snprintf(dstbuf, size, "IPaddr (bad flags)");
+               snprintf(dstbuf, size, "IPaddr (bad flags)");
                break;
        }
        return 0;