lib: remove extra parenthesis after return

[dpdk.git] / lib / librte_cmdline / cmdline_parse_num.c

diff --git a/lib/librte_cmdline/cmdline_parse_num.c b/lib/librte_cmdline/cmdline_parse_num.c
index dc0c628..b0f9a35 100644 (file)
--- a/lib/librte_cmdline/cmdline_parse_num.c
+++ b/lib/librte_cmdline/cmdline_parse_num.c
@@ -1,13 +1,13 @@
 /*-
  *   BSD LICENSE
- * 
+ *
  *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
  *   All rights reserved.
- * 
+ *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
  *   are met:
- * 
+ *
  *     * Redistributions of source code must retain the above copyright
  *       notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above copyright
@@ -17,7 +17,7 @@
  *     * Neither the name of Intel Corporation nor the names of its
  *       contributors may be used to endorse or promote products derived
  *       from this software without specific prior written permission.
- * 
+ *
  *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -119,10 +119,40 @@ add_to_res(unsigned int c, uint64_t *res, unsigned int base)
        return 0;
 }
 
+static int
+check_res_size(struct cmdline_token_num_data *nd, unsigned ressize)
+{
+       switch (nd->type) {
+       case INT8:
+       case UINT8:
+               if (ressize < sizeof(int8_t))
+                       return -1;
+               break;
+       case INT16:
+       case UINT16:
+               if (ressize < sizeof(int16_t))
+                       return -1;
+               break;
+       case INT32:
+       case UINT32:
+               if (ressize < sizeof(int32_t))
+                       return -1;
+               break;
+       case INT64:
+       case UINT64:
+               if (ressize < sizeof(int64_t))
+                       return -1;
+               break;
+       default:
+               return -1;
+       }
+       return 0;
+}
 
 /* parse an int */
 int
-cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res)
+cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res,
+       unsigned ressize)
 {
        struct cmdline_token_num_data nd;
        enum num_parse_state_t st = START;
@@ -141,6 +171,12 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res)
 
        memcpy(&nd, &((struct cmdline_token_num *)tk)->num_data, sizeof(nd));
 
+       /* check that we have enough room in res */
+       if (res) {
+               if (check_res_size(&nd, ressize) < 0)
+                       return -1;
+       }
+
        while ( st != ERROR && c && ! cmdline_isendoftoken(c) ) {
                debug_printf("%c %x -> ", c, c);
                switch (st) {
@@ -279,35 +315,35 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res)
        case BIN_OK:
                if ( nd.type == INT8 && res1 <= INT8_MAX ) {
                        if (res) *(int8_t *)res = (int8_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT16 && res1 <= INT16_MAX ) {
                        if (res) *(int16_t *)res = (int16_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT32 && res1 <= INT32_MAX ) {
                        if (res) *(int32_t *)res = (int32_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT64 && res1 <= INT64_MAX ) {
                        if (res) *(int64_t *)res = (int64_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == UINT8 && res1 <= UINT8_MAX ) {
                        if (res) *(uint8_t *)res = (uint8_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if (nd.type == UINT16  && res1 <= UINT16_MAX ) {
                        if (res) *(uint16_t *)res = (uint16_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == UINT32 && res1 <= UINT32_MAX ) {
                        if (res) *(uint32_t *)res = (uint32_t) res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == UINT64 ) {
                        if (res) *(uint64_t *)res = res1;
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else {
                        return -1;
@@ -317,19 +353,19 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res)
        case DEC_NEG_OK:
                if ( nd.type == INT8 && res1 <= INT8_MAX + 1 ) {
                        if (res) *(int8_t *)res = (int8_t) (-res1);
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
                        if (res) *(int16_t *)res = (int16_t) (-res1);
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
                        if (res) *(int32_t *)res = (int32_t) (-res1);
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else if ( nd.type == INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
                        if (res) *(int64_t *)res = (int64_t) (-res1);
-                       return (buf-srcbuf);
+                       return buf-srcbuf;
                }
                else {
                        return -1;
@@ -358,7 +394,7 @@ cmdline_get_help_num(cmdline_parse_token_hdr_t *tk, char *dstbuf, unsigned int s
        /* if (nd.type >= (sizeof(num_help)/sizeof(const char *))) */
        /* return -1; */
 
-       ret = rte_snprintf(dstbuf, size, "%s", num_help[nd.type]);
+       ret = snprintf(dstbuf, size, "%s", num_help[nd.type]);
        if (ret < 0)
                return -1;
        dstbuf[size-1] = '\0';