eal: fix checkpatch issues before moving code
[dpdk.git] / lib / librte_eal / bsdapp / eal / eal.c
index adb9e6e..81d1a65 100644 (file)
@@ -1,14 +1,14 @@
 /*-
  *   BSD LICENSE
- * 
+ *
  *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
  *   Copyright(c) 2014 6WIND S.A.
  *   All rights reserved.
- * 
+ *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
  *   are met:
- * 
+ *
  *     * Redistributions of source code must retain the above copyright
  *       notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above copyright
@@ -18,7 +18,7 @@
  *     * Neither the name of Intel Corporation nor the names of its
  *       contributors may be used to endorse or promote products derived
  *       from this software without specific prior written permission.
- * 
+ *
  *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -66,6 +66,7 @@
 #include <rte_cpuflags.h>
 #include <rte_interrupts.h>
 #include <rte_pci.h>
+#include <rte_dev.h>
 #include <rte_devargs.h>
 #include <rte_common.h>
 #include <rte_version.h>
 #define OPT_NO_HUGE     "no-huge"
 #define OPT_FILE_PREFIX "file-prefix"
 #define OPT_SOCKET_MEM  "socket-mem"
-#define OPT_USE_DEVICE  "use-device"
+#define OPT_PCI_WHITELIST "pci-whitelist"
+#define OPT_PCI_BLACKLIST "pci-blacklist"
+#define OPT_VDEV        "vdev"
 #define OPT_SYSLOG      "syslog"
-
-#define RTE_EAL_BLACKLIST_SIZE 0x100
+#define OPT_LOG_LEVEL   "log-level"
 
 #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
 
-#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
-
-#define HIGHEST_RPL 3
-
 #define BITS_PER_HEX 4
 
-#define GET_BLACKLIST_FIELD(in, fd, lim, dlm)                   \
-{                                                               \
-       unsigned long val;                                      \
-       char *end;                                              \
-       errno = 0;                                              \
-       val = strtoul((in), &end, 16);                          \
-       if (errno != 0 || end[0] != (dlm) || val > (lim))       \
-               return (-EINVAL);                               \
-       (fd) = (typeof (fd))val;                                \
-       (in) = end + 1;                                         \
-}
-
 /* Allow the application to print its usage message too if set */
 static rte_usage_hook_t        rte_application_usage_hook = NULL;
 /* early configuration structure, when memory config is not mmapped */
@@ -244,7 +230,7 @@ rte_eal_config_attach(void)
                        rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
        }
 
-       rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config), 
+       rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config),
                                PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
        close(mem_cfg_fd);
        if (rte_mem_cfg_addr == MAP_FAILED)
@@ -277,8 +263,6 @@ eal_proc_type_detect(void)
 static void
 rte_config_init(void)
 {
-       /* set the magic in configuration structure */
-       rte_config.magic = RTE_MAGIC;
        rte_config.process_type = (internal_config.process_type == RTE_PROC_AUTO) ?
                        eal_proc_type_detect() : /* for auto, detect the type */
                        internal_config.process_type; /* otherwise use what's already set */
@@ -306,18 +290,23 @@ eal_usage(const char *prgname)
               "EAL options:\n"
               "  -c COREMASK  : A hexadecimal bitmask of cores to run on\n"
               "  -n NUM       : Number of memory channels\n"
-                  "  -v           : Display version information on startup\n"
-              "                 (multiple -b options are allowed)\n"
+              "  -v           : Display version information on startup\n"
               "  -m MB        : memory to allocate\n"
               "  -r NUM       : force number of memory ranks (don't detect)\n"
+              "  --"OPT_LOG_LEVEL"  : set default log level\n"
               "  --"OPT_PROC_TYPE"  : type of this process\n"
-              " --"OPT_USE_DEVICE": use the specified ethernet device(s) only.\n"
-              " The argument format is <[domain:]bus:devid.func> to add\n"
-              " a PCI device to the white list or <driver><id>[;key=val;...]\n"
-              " to add a virtual device.\n"
-              " [NOTE: PCI whitelist cannot be used with -b option]\n"
-              "  --"OPT_VMWARE_TSC_MAP": use VMware TSC map instead of "
-                          "native RDTSC\n"
+              "  --"OPT_PCI_BLACKLIST", -b: add a PCI device in black list.\n"
+              "               Prevent EAL from using this PCI device. The argument\n"
+              "               format is <domain:bus:devid.func>.\n"
+              "  --"OPT_PCI_WHITELIST", -w: add a PCI device in white list.\n"
+              "               Only use the specified PCI devices. The argument format\n"
+              "               is <[domain:]bus:devid.func>. This option can be present\n"
+              "               several times (once per device).\n"
+              "               [NOTE: PCI whitelist cannot be used with -b option]\n"
+              "  --"OPT_VDEV": add a virtual device.\n"
+              "               The argument format is <driver><id>[,key=val,...]\n"
+              "               (ex: --vdev=eth_pcap0,iface=eth2).\n"
+              "  --"OPT_VMWARE_TSC_MAP": use VMware TSC map instead of native RDTSC\n"
               "\nEAL options for DEBUG use only:\n"
               "  --"OPT_NO_HUGE"  : use malloc instead of hugetlbfs\n"
               "  --"OPT_NO_PCI"   : disable pci\n"
@@ -352,11 +341,11 @@ rte_set_application_usage_hook( rte_usage_hook_t usage_func )
 static int xdigit2val(unsigned char c)
 {
        int val;
-       if(isdigit(c)) 
+       if(isdigit(c))
                val = c - '0';
        else if(isupper(c))
                val = c - 'A' + 10;
-       else 
+       else
                val = c - 'a' + 10;
        return val;
 }
@@ -452,6 +441,28 @@ eal_parse_syslog(const char *facility)
        return -1;
 }
 
+static int
+eal_parse_log_level(const char *level, uint32_t *log_level)
+{
+       char *end;
+       unsigned long tmp;
+
+       errno = 0;
+       tmp = strtoul(level, &end, 0);
+
+       /* check for errors */
+       if ((errno != 0) || (level[0] == '\0') ||
+           end == NULL || (*end != '\0'))
+               return -1;
+
+       /* log_level is a uint32_t */
+       if (tmp >= UINT32_MAX)
+               return -1;
+
+       *log_level = tmp;
+       return 0;
+}
+
 static inline size_t
 eal_get_hugepage_mem_size(void)
 {
@@ -483,33 +494,6 @@ eal_parse_proc_type(const char *arg)
        return RTE_PROC_INVALID;
 }
 
-static int
-eal_parse_use_device(const char *optarg)
-{
-       struct rte_pci_addr addr;
-       char *dup, *sep;
-
-       dup = strdup(optarg);
-       if (dup == NULL)
-               return -1;
-
-       /* remove arguments in 'dup' string */
-       sep = strchr(dup, ',');
-       if (sep != NULL)
-               *sep = '\0';
-
-       /* if argument is a PCI address, it's a whitelisted device */
-       if (eal_parse_pci_DomBDF(dup, &addr) == 0 ||
-               eal_parse_pci_BDF(dup, &addr) == 0) {
-               rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, optarg);
-       } else {
-               rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL, optarg);
-       }
-
-       free(dup);
-       return 0;
-}
-
 /* Parse the argument given in the command line of the application */
 static int
 eal_parse_args(int argc, char **argv)
@@ -529,8 +513,11 @@ eal_parse_args(int argc, char **argv)
                {OPT_PROC_TYPE, 1, 0, 0},
                {OPT_FILE_PREFIX, 1, 0, 0},
                {OPT_SOCKET_MEM, 1, 0, 0},
-               {OPT_USE_DEVICE, 1, 0, 0},
+               {OPT_PCI_WHITELIST, 1, 0, 'w'},
+               {OPT_PCI_BLACKLIST, 1, 0, 'b'},
+               {OPT_VDEV, 1, 0, 0},
                {OPT_SYSLOG, 1, NULL, 0},
+               {OPT_LOG_LEVEL, 1, NULL, 0},
                {0, 0, 0, 0}
        };
 
@@ -543,6 +530,8 @@ eal_parse_args(int argc, char **argv)
        internal_config.hugepage_dir = NULL;
        internal_config.force_sockets = 0;
        internal_config.syslog_facility = LOG_DAEMON;
+       /* default value from build option */
+       internal_config.log_level = RTE_LOG_LEVEL;
 #ifdef RTE_LIBEAL_USE_HPET
        internal_config.no_hpet = 0;
 #else
@@ -558,7 +547,7 @@ eal_parse_args(int argc, char **argv)
 
        internal_config.vmware_tsc_map = 0;
 
-       while ((opt = getopt_long(argc, argvopt, "b:c:m:n:r:v",
+       while ((opt = getopt_long(argc, argvopt, "b:w:c:m:n:r:v",
                                  lgopts, &option_index)) != EOF) {
 
                switch (opt) {
@@ -570,6 +559,14 @@ eal_parse_args(int argc, char **argv)
                                return (-1);
                        }
                        break;
+               /* whitelist */
+               case 'w':
+                       if (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI,
+                                       optarg) < 0) {
+                               eal_usage(prgname);
+                               return -1;
+                       }
+                       break;
                /* coremask */
                case 'c':
                        if (eal_parse_coremask(optarg) < 0) {
@@ -616,52 +613,47 @@ eal_parse_args(int argc, char **argv)
                case 0:
                        if (!strcmp(lgopts[option_index].name, OPT_NO_HUGE)) {
                                internal_config.no_hugetlbfs = 1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {
                                internal_config.no_pci = 1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {
                                internal_config.no_hpet = 1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {
                                internal_config.vmware_tsc_map = 1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {
                                internal_config.no_shconf = 1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_HUGE_DIR)) {
-                               RTE_LOG(ERR, EAL, "Option "OPT_HUGE_DIR" is not supported on"
-                                               "FreeBSD\n");
-                               return -1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {
                                internal_config.process_type = eal_parse_proc_type(optarg);
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_FILE_PREFIX)) {
-                               RTE_LOG(ERR, EAL, "Option "OPT_FILE_PREFIX" is not supported on"
-                                               "FreeBSD\n");
-                               return -1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_SOCKET_MEM)) {
-                               RTE_LOG(ERR, EAL, "Option "OPT_SOCKET_MEM" is not supported on"
-                                               "FreeBSD\n");
-                               return -1;
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_USE_DEVICE)) {
-                               if (eal_parse_use_device(optarg) < 0) {
-                                       RTE_LOG(ERR, EAL, "invalid parameters for --"
-                                               OPT_USE_DEVICE "\n");
+                       } else if (!strcmp(lgopts[option_index].name, OPT_VDEV)) {
+                               if (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL,
+                                               optarg) < 0) {
                                        eal_usage(prgname);
                                        return -1;
                                }
-                       }
-                       else if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {
+                       } else if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {
                                if (eal_parse_syslog(optarg) < 0) {
                                        RTE_LOG(ERR, EAL, "invalid parameters for --"
                                                        OPT_SYSLOG "\n");
                                        eal_usage(prgname);
                                        return -1;
                                }
+                       } else if (!strcmp(lgopts[option_index].name,
+                                        OPT_LOG_LEVEL)) {
+                               uint32_t log;
+
+                               if (eal_parse_log_level(optarg, &log) < 0) {
+                                       RTE_LOG(ERR, EAL,
+                                               "invalid parameters for --"
+                                               OPT_LOG_LEVEL "\n");
+                                       eal_usage(prgname);
+                                       return -1;
+                               }
+                               internal_config.log_level = log;
+                       } else {
+                               RTE_LOG(ERR, EAL, "Option %s is not supported "
+                                       "on FreeBSD\n",
+                                       lgopts[option_index].name);
+                               eal_usage(prgname);
+                               return -1;
                        }
                        break;
 
@@ -715,7 +707,7 @@ eal_parse_args(int argc, char **argv)
        if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) != 0 &&
                rte_eal_devargs_type_count(RTE_DEVTYPE_BLACKLISTED_PCI) != 0) {
                RTE_LOG(ERR, EAL, "Error: blacklist [-b] and whitelist "
-                       "[--use-device] options cannot be used at the same time\n");
+                       "[-w] options cannot be used at the same time\n");
                eal_usage(prgname);
                return -1;
        }
@@ -758,7 +750,7 @@ sync_func(__attribute__((unused)) void *arg)
        return 0;
 }
 
-inline static void 
+inline static void
 rte_eal_mcfg_complete(void)
 {
        /* ALL shared mem_config related INIT DONE */
@@ -772,7 +764,7 @@ int rte_eal_has_hugepages(void)
        return !internal_config.no_hugetlbfs;
 }
 
-/* Abstraction for port I/0 privilage */
+/* Abstraction for port I/0 privilege */
 static int
 rte_eal_iopl_init(void)
 {
@@ -803,6 +795,9 @@ rte_eal_init(int argc, char **argv)
        if (fctret < 0)
                exit(1);
 
+       /* set log level as early as possible */
+       rte_set_log_level(internal_config.log_level);
+
        if (internal_config.no_hugetlbfs == 0 &&
                        internal_config.process_type != RTE_PROC_SECONDARY &&
                        eal_hugepage_info_init() < 0)
@@ -867,8 +862,8 @@ rte_eal_init(int argc, char **argv)
 
        rte_eal_mcfg_complete();
 
-       if (rte_eal_vdev_init() < 0)
-               rte_panic("Cannot init virtual devices\n");
+       if (rte_eal_dev_init(PMD_INIT_PRE_PCI_PROBE) < 0)
+               rte_panic("Cannot init pmd devices\n");
 
        RTE_LCORE_FOREACH_SLAVE(i) {
 
@@ -899,6 +894,14 @@ rte_eal_init(int argc, char **argv)
        rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MASTER);
        rte_eal_mp_wait_lcore();
 
+       /* Probe & Initialize PCI devices */
+       if (rte_eal_pci_probe())
+                       rte_panic("Cannot probe PCI\n");
+
+       /* Initialize any outstanding devices */
+       if (rte_eal_dev_init(PMD_INIT_POST_PCI_PROBE) < 0)
+               rte_panic("Cannot init pmd devices\n");
+
        return fctret;
 }