vfio: document multiprocess limitation for container API

[dpdk.git] / lib / librte_eal / common / eal_common_dev.c

diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index 62e9ed4..fd7f5ca 100644 (file)
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -150,10 +150,11 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)
                goto err_devarg;
        }
 
-       ret = rte_devargs_insert(da);
+       ret = rte_devargs_insert(&da);
        if (ret)
                goto err_devarg;
 
+       /* the rte_devargs will be referenced in the matching rte_device */
        ret = da->bus->scan();
        if (ret)
                goto err_devarg;
@@ -165,18 +166,20 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)
                ret = -ENODEV;
                goto err_devarg;
        }
+       /* Since there is a matching device, it is now its responsibility
+        * to manage the devargs we've just inserted. From this point
+        * those devargs shouldn't be removed manually anymore.
+        */
 
        ret = dev->bus->plug(dev);
-       if (ret) {
-               if (rte_dev_is_probed(dev)) /* if already succeeded earlier */
-                       return ret; /* no rollback */
+       if (ret && !rte_dev_is_probed(dev)) { /* if hasn't ever succeeded */
                RTE_LOG(ERR, EAL, "Driver cannot attach the device (%s)\n",
                        dev->name);
-               goto err_devarg;
+               return ret;
        }
 
        *new_dev = dev;
-       return 0;
+       return ret;
 
 err_devarg:
        if (rte_devargs_remove(da) != 0) {
@@ -186,7 +189,7 @@ err_devarg:
        return ret;
 }
 
-int __rte_experimental
+int
 rte_dev_probe(const char *devargs)
 {
        struct eal_dev_mp_req req;
@@ -322,7 +325,7 @@ local_dev_remove(struct rte_device *dev)
        return 0;
 }
 
-int __rte_experimental
+int
 rte_dev_remove(struct rte_device *dev)
 {
        struct eal_dev_mp_req req;