devargs: use log functions

[dpdk.git] / lib / librte_eal / common / eal_common_devargs.c

diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 810b3e1..894749e 100644 (file)
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -11,13 +11,18 @@
 
 #include <stdio.h>
 #include <string.h>
+#include <stdarg.h>
 
 #include <rte_compat.h>
 #include <rte_dev.h>
 #include <rte_devargs.h>
+#include <rte_log.h>
 #include <rte_tailq.h>
 #include "eal_private.h"
 
+/** user device double-linked queue type definition */
+TAILQ_HEAD(rte_devargs_list, rte_devargs);
+
 /** Global list of user devices */
 struct rte_devargs_list devargs_list =
        TAILQ_HEAD_INITIALIZER(devargs_list);
@@ -59,15 +64,23 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)
 }
 
 int __rte_experimental
-rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)
+rte_devargs_parse(struct rte_devargs *da, const char *format, ...)
 {
        struct rte_bus *bus = NULL;
+       va_list ap;
+       va_start(ap, format);
+       char dev[vsnprintf(NULL, 0, format, ap) + 1];
        const char *devname;
        const size_t maxlen = sizeof(da->name);
        size_t i;
 
-       if (dev == NULL || da == NULL)
+       va_end(ap);
+       if (da == NULL)
                return -EINVAL;
+
+       va_start(ap, format);
+       vsnprintf(dev, sizeof(dev), format, ap);
+       va_end(ap);
        /* Retrieve eventual bus info */
        do {
                devname = dev;
@@ -84,7 +97,7 @@ rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)
                da->name[i] = devname[i];
                i++;
                if (i == maxlen) {
-                       fprintf(stderr, "WARNING: Parsing \"%s\": device name should be shorter than %zu\n",
+                       RTE_LOG(WARNING, EAL, "Parsing \"%s\": device name should be shorter than %zu\n",
                                dev, maxlen);
                        da->name[i - 1] = '\0';
                        return -EINVAL;
@@ -94,7 +107,7 @@ rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)
        if (bus == NULL) {
                bus = rte_bus_find_by_device_name(da->name);
                if (bus == NULL) {
-                       fprintf(stderr, "ERROR: failed to parse device \"%s\"\n",
+                       RTE_LOG(ERR, EAL, "failed to parse device \"%s\"\n",
                                da->name);
                        return -EFAULT;
                }
@@ -106,18 +119,18 @@ rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)
        else
                da->args = strdup("");
        if (da->args == NULL) {
-               fprintf(stderr, "ERROR: not enough memory to parse arguments\n");
+               RTE_LOG(ERR, EAL, "not enough memory to parse arguments\n");
                return -ENOMEM;
        }
        return 0;
 }
 
 int __rte_experimental
-rte_eal_devargs_insert(struct rte_devargs *da)
+rte_devargs_insert(struct rte_devargs *da)
 {
        int ret;
 
-       ret = rte_eal_devargs_remove(da->bus->name, da->name);
+       ret = rte_devargs_remove(da->bus->name, da->name);
        if (ret < 0)
                return ret;
        TAILQ_INSERT_TAIL(&devargs_list, da, next);
@@ -125,8 +138,9 @@ rte_eal_devargs_insert(struct rte_devargs *da)
 }
 
 /* store a whitelist parameter for later parsing */
+__rte_experimental
 int
-rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
+rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)
 {
        struct rte_devargs *devargs = NULL;
        struct rte_bus *bus = NULL;
@@ -137,7 +151,7 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
        if (devargs == NULL)
                goto fail;
 
-       if (rte_eal_devargs_parse(dev, devargs))
+       if (rte_devargs_parse(devargs, "%s", dev))
                goto fail;
        devargs->type = devtype;
        bus = devargs->bus;
@@ -162,7 +176,7 @@ fail:
 }
 
 int __rte_experimental
-rte_eal_devargs_remove(const char *busname, const char *devname)
+rte_devargs_remove(const char *busname, const char *devname)
 {
        struct rte_devargs *d;
        void *tmp;
@@ -180,8 +194,9 @@ rte_eal_devargs_remove(const char *busname, const char *devname)
 }
 
 /* count the number of devices of a specified type */
+__rte_experimental
 unsigned int
-rte_eal_devargs_type_count(enum rte_devtype devtype)
+rte_devargs_type_count(enum rte_devtype devtype)
 {
        struct rte_devargs *devargs;
        unsigned int count = 0;
@@ -195,8 +210,9 @@ rte_eal_devargs_type_count(enum rte_devtype devtype)
 }
 
 /* dump the user devices on the console */
+__rte_experimental
 void
-rte_eal_devargs_dump(FILE *f)
+rte_devargs_dump(FILE *f)
 {
        struct rte_devargs *devargs;
 
@@ -207,3 +223,23 @@ rte_eal_devargs_dump(FILE *f)
                        devargs->name, devargs->args);
        }
 }
+
+/* bus-aware rte_devargs iterator. */
+__rte_experimental
+struct rte_devargs *
+rte_devargs_next(const char *busname, const struct rte_devargs *start)
+{
+       struct rte_devargs *da;
+
+       if (start != NULL)
+               da = TAILQ_NEXT(start, next);
+       else
+               da = TAILQ_FIRST(&devargs_list);
+       while (da != NULL) {
+               if (busname == NULL ||
+                   (strcmp(busname, da->bus->name) == 0))
+                       return da;
+               da = TAILQ_NEXT(da, next);
+       }
+       return NULL;
+}