ipc: handle unsupported IPC in action register

[dpdk.git] / lib / librte_eal / common / eal_common_proc.c

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 8586474..7f86c12 100644 (file)
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -202,9 +202,15 @@ rte_mp_action_register(const char *name, rte_mp_t action)
 {
        struct action_entry *entry;
 
-       if (validate_action_name(name))
+       if (validate_action_name(name) != 0)
                return -1;
 
+       if (internal_config.no_shconf) {
+               RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n");
+               rte_errno = ENOTSUP;
+               return -1;
+       }
+
        entry = malloc(sizeof(struct action_entry));
        if (entry == NULL) {
                rte_errno = ENOMEM;
@@ -230,7 +236,7 @@ rte_mp_action_unregister(const char *name)
 {
        struct action_entry *entry;
 
-       if (validate_action_name(name))
+       if (validate_action_name(name) != 0)
                return;
 
        pthread_mutex_lock(&mp_mutex_action);
@@ -285,7 +291,15 @@ read_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
                        break;
                }
        }
-
+       /* sanity-check the response */
+       if (m->msg.num_fds < 0 || m->msg.num_fds > RTE_MP_MAX_FD_NUM) {
+               RTE_LOG(ERR, EAL, "invalid number of fd's received\n");
+               return -1;
+       }
+       if (m->msg.len_param < 0 || m->msg.len_param > RTE_MP_MAX_PARAM_LEN) {
+               RTE_LOG(ERR, EAL, "invalid received data length\n");
+               return -1;
+       }
        return 0;
 }
 
@@ -568,7 +582,8 @@ rte_mp_channel_init(void)
         */
        if (internal_config.no_shconf) {
                RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC will be disabled\n");
-               return 0;
+               rte_errno = ENOTSUP;
+               return -1;
        }
 
        /* create filter path */
@@ -741,38 +756,50 @@ mp_send(struct rte_mp_msg *msg, const char *peer, int type)
        return ret;
 }
 
-static bool
+static int
 check_input(const struct rte_mp_msg *msg)
 {
        if (msg == NULL) {
                RTE_LOG(ERR, EAL, "Msg cannot be NULL\n");
                rte_errno = EINVAL;
-               return false;
+               return -1;
        }
 
-       if (validate_action_name(msg->name))
-               return false;
+       if (validate_action_name(msg->name) != 0)
+               return -1;
+
+       if (msg->len_param < 0) {
+               RTE_LOG(ERR, EAL, "Message data length is negative\n");
+               rte_errno = EINVAL;
+               return -1;
+       }
+
+       if (msg->num_fds < 0) {
+               RTE_LOG(ERR, EAL, "Number of fd's is negative\n");
+               rte_errno = EINVAL;
+               return -1;
+       }
 
        if (msg->len_param > RTE_MP_MAX_PARAM_LEN) {
                RTE_LOG(ERR, EAL, "Message data is too long\n");
                rte_errno = E2BIG;
-               return false;
+               return -1;
        }
 
        if (msg->num_fds > RTE_MP_MAX_FD_NUM) {
                RTE_LOG(ERR, EAL, "Cannot send more than %d FDs\n",
                        RTE_MP_MAX_FD_NUM);
                rte_errno = E2BIG;
-               return false;
+               return -1;
        }
 
-       return true;
+       return 0;
 }
 
 int __rte_experimental
 rte_mp_sendmsg(struct rte_mp_msg *msg)
 {
-       if (!check_input(msg))
+       if (check_input(msg) != 0)
                return -1;
 
        RTE_LOG(DEBUG, EAL, "sendmsg: %s\n", msg->name);
@@ -914,7 +941,7 @@ int __rte_experimental
 rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
                const struct timespec *ts)
 {
-       int dir_fd, ret = 0;
+       int dir_fd, ret = -1;
        DIR *mp_dir;
        struct dirent *ent;
        struct timeval now;
@@ -926,8 +953,8 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
        reply->nb_received = 0;
        reply->msgs = NULL;
 
-       if (check_input(req) == false)
-               goto err;
+       if (check_input(req) != 0)
+               goto end;
 
        if (internal_config.no_shconf) {
                RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n");
@@ -937,7 +964,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
        if (gettimeofday(&now, NULL) < 0) {
                RTE_LOG(ERR, EAL, "Failed to get current time\n");
                rte_errno = errno;
-               goto err;
+               goto end;
        }
 
        end.tv_nsec = (now.tv_usec * 1000 + ts->tv_nsec) % 1000000000;
@@ -949,9 +976,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
                pthread_mutex_lock(&pending_requests.lock);
                ret = mp_request_sync(eal_mp_socket_path(), req, reply, &end);
                pthread_mutex_unlock(&pending_requests.lock);
-               if (ret)
-                       goto err;
-               return ret;
+               goto end;
        }
 
        /* for primary process, broadcast request, and collect reply 1 by 1 */
@@ -959,7 +984,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
        if (!mp_dir) {
                RTE_LOG(ERR, EAL, "Unable to open directory %s\n", mp_dir_path);
                rte_errno = errno;
-               goto err;
+               goto end;
        }
 
        dir_fd = dirfd(mp_dir);
@@ -967,9 +992,8 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
        if (flock(dir_fd, LOCK_SH)) {
                RTE_LOG(ERR, EAL, "Unable to lock directory %s\n",
                        mp_dir_path);
-               closedir(mp_dir);
                rte_errno = errno;
-               goto err;
+               goto close_end;
        }
 
        pthread_mutex_lock(&pending_requests.lock);
@@ -986,21 +1010,26 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
                 * locks on receive
                 */
                if (mp_request_sync(path, req, reply, &end))
-                       goto err;
+                       goto unlock_end;
        }
+       ret = 0;
+
+unlock_end:
        pthread_mutex_unlock(&pending_requests.lock);
        /* unlock the directory */
        flock(dir_fd, LOCK_UN);
 
+close_end:
        /* dir_fd automatically closed on closedir */
        closedir(mp_dir);
-       return ret;
 
-err:
-       free(reply->msgs);
-       reply->nb_received = 0;
-       reply->msgs = NULL;
-       return -1;
+end:
+       if (ret) {
+               free(reply->msgs);
+               reply->nb_received = 0;
+               reply->msgs = NULL;
+       }
+       return ret;
 }
 
 int __rte_experimental
@@ -1020,7 +1049,7 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
 
        RTE_LOG(DEBUG, EAL, "request: %s\n", req->name);
 
-       if (check_input(req) == false)
+       if (check_input(req) != 0)
                return -1;
 
        if (internal_config.no_shconf) {
@@ -1157,7 +1186,7 @@ rte_mp_reply(struct rte_mp_msg *msg, const char *peer)
 {
        RTE_LOG(DEBUG, EAL, "reply: %s\n", msg->name);
 
-       if (check_input(msg) == false)
+       if (check_input(msg) != 0)
                return -1;
 
        if (peer == NULL) {