eal: add API to lock/unlock tailq list

[dpdk.git] / lib / librte_eal / common / eal_common_tailqs.c

diff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c
index bb08ec8..dc2c13c 100644 (file)
--- a/lib/librte_eal/common/eal_common_tailqs.c
+++ b/lib/librte_eal/common/eal_common_tailqs.c
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2014 Intel Corporation
  */
 
 #include <sys/queue.h>
@@ -40,13 +11,11 @@
 #include <inttypes.h>
 
 #include <rte_memory.h>
-#include <rte_memzone.h>
 #include <rte_launch.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_per_lcore.h>
 #include <rte_lcore.h>
-#include <rte_memory.h>
 #include <rte_atomic.h>
 #include <rte_branch_prediction.h>
 #include <rte_log.h>
@@ -89,7 +58,7 @@ rte_dump_tailq(FILE *f)
 
        mcfg = rte_eal_get_configuration()->mem_config;
 
-       rte_rwlock_read_lock(&mcfg->qlock);
+       rte_mcfg_tailq_read_lock();
        for (i = 0; i < RTE_MAX_TAILQ; i++) {
                const struct rte_tailq_head *tailq = &mcfg->tailq_head[i];
                const struct rte_tailq_entry_head *head = &tailq->tailq_head;
@@ -97,7 +66,7 @@ rte_dump_tailq(FILE *f)
                fprintf(f, "Tailq %u: qname:<%s>, tqh_first:%p, tqh_last:%p\n",
                        i, tailq->name, head->tqh_first, head->tqh_last);
        }
-       rte_rwlock_read_unlock(&mcfg->qlock);
+       rte_mcfg_tailq_read_unlock();
 }
 
 static struct rte_tailq_head *
@@ -111,7 +80,7 @@ rte_eal_tailq_create(const char *name)
 
                mcfg = rte_eal_get_configuration()->mem_config;
                head = &mcfg->tailq_head[rte_tailqs_count];
-               snprintf(head->name, sizeof(head->name) - 1, "%s", name);
+               strlcpy(head->name, name, sizeof(head->name) - 1);
                TAILQ_INIT(&head->tailq_head);
                rte_tailqs_count++;
        }
@@ -188,8 +157,7 @@ rte_eal_tailqs_init(void)
                if (t->head == NULL) {
                        RTE_LOG(ERR, EAL,
                                "Cannot initialize tailq: %s\n", t->name);
-                       /* no need to TAILQ_REMOVE, we are going to panic in
-                        * rte_eal_init() */
+                       /* TAILQ_REMOVE not needed, error is already fatal */
                        goto fail;
                }
        }