eal: include missing hypervisor files in meson
[dpdk.git] / lib / librte_eal / common / eal_common_thread.c
index 4e75cb8..48ef4d6 100644 (file)
@@ -34,10 +34,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)
        if (lcore_id >= RTE_MAX_LCORE)
                return -EINVAL;
 
-       if (cfg->lcore_role[lcore_id] == role)
-               return 0;
-
-       return -EINVAL;
+       return cfg->lcore_role[lcore_id] == role;
 }
 
 int eal_cpuset_socket_id(rte_cpuset_t *cpusetp)
@@ -152,11 +149,16 @@ struct rte_thread_ctrl_params {
 
 static void *rte_thread_init(void *arg)
 {
+       int ret;
        struct rte_thread_ctrl_params *params = arg;
        void *(*start_routine)(void *) = params->start_routine;
        void *routine_arg = params->arg;
 
-       pthread_barrier_wait(&params->configured);
+       ret = pthread_barrier_wait(&params->configured);
+       if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
+               pthread_barrier_destroy(&params->configured);
+               free(params);
+       }
 
        return start_routine(routine_arg);
 }
@@ -166,24 +168,31 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
                const pthread_attr_t *attr,
                void *(*start_routine)(void *), void *arg)
 {
-       struct rte_thread_ctrl_params params = {
-               .start_routine = start_routine,
-               .arg = arg,
-       };
+       struct rte_thread_ctrl_params *params;
        unsigned int lcore_id;
        rte_cpuset_t cpuset;
        int cpu_found, ret;
 
-       pthread_barrier_init(&params.configured, NULL, 2);
+       params = malloc(sizeof(*params));
+       if (!params)
+               return -ENOMEM;
 
-       ret = pthread_create(thread, attr, rte_thread_init, (void *)&params);
-       if (ret != 0)
-               return ret;
+       params->start_routine = start_routine;
+       params->arg = arg;
+
+       pthread_barrier_init(&params->configured, NULL, 2);
+
+       ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
+       if (ret != 0) {
+               free(params);
+               return -ret;
+       }
 
        if (name != NULL) {
                ret = rte_thread_setname(*thread, name);
                if (ret < 0)
-                       goto fail;
+                       RTE_LOG(DEBUG, EAL,
+                               "Cannot set name for ctrl thread\n");
        }
 
        cpu_found = 0;
@@ -203,12 +212,21 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
        if (ret < 0)
                goto fail;
 
-       pthread_barrier_wait(&params.configured);
+       ret = pthread_barrier_wait(&params->configured);
+       if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
+               pthread_barrier_destroy(&params->configured);
+               free(params);
+       }
 
        return 0;
 
 fail:
+       if (PTHREAD_BARRIER_SERIAL_THREAD ==
+           pthread_barrier_wait(&params->configured)) {
+               pthread_barrier_destroy(&params->configured);
+               free(params);
+       }
        pthread_cancel(*thread);
        pthread_join(*thread, NULL);
-       return ret;
+       return -ret;
 }