bus/vdev: remove probe with driver name option
[dpdk.git] / lib / librte_eal / common / eal_common_vdev.c
index c922297..2ca0cdb 100644 (file)
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdint.h>
+#include <stdbool.h>
 #include <sys/queue.h>
 
 #include <rte_eal.h>
+#include <rte_dev.h>
 #include <rte_bus.h>
 #include <rte_vdev.h>
 #include <rte_common.h>
 #include <rte_devargs.h>
 #include <rte_memory.h>
+#include <rte_errno.h>
 
 /** Double linked list of virtual device drivers. */
 TAILQ_HEAD(vdev_device_list, rte_vdev_device);
@@ -52,64 +55,60 @@ static struct vdev_device_list vdev_device_list =
 struct vdev_driver_list vdev_driver_list =
        TAILQ_HEAD_INITIALIZER(vdev_driver_list);
 
-static void rte_vdev_bus_register(void);
-
 /* register a driver */
 void
-rte_eal_vdrv_register(struct rte_vdev_driver *driver)
+rte_vdev_register(struct rte_vdev_driver *driver)
 {
-       rte_vdev_bus_register();
-
        TAILQ_INSERT_TAIL(&vdev_driver_list, driver, next);
-       rte_eal_driver_register(&driver->driver);
 }
 
 /* unregister a driver */
 void
-rte_eal_vdrv_unregister(struct rte_vdev_driver *driver)
+rte_vdev_unregister(struct rte_vdev_driver *driver)
 {
-       rte_eal_driver_unregister(&driver->driver);
        TAILQ_REMOVE(&vdev_driver_list, driver, next);
 }
 
+static int
+vdev_parse(const char *name, void *addr)
+{
+       struct rte_vdev_driver **out = addr;
+       struct rte_vdev_driver *driver = NULL;
+
+       TAILQ_FOREACH(driver, &vdev_driver_list, next) {
+               if (strncmp(driver->driver.name, name,
+                           strlen(driver->driver.name)) == 0)
+                       break;
+               if (driver->driver.alias &&
+                   strncmp(driver->driver.alias, name,
+                           strlen(driver->driver.alias)) == 0)
+                       break;
+       }
+       if (driver != NULL &&
+           addr != NULL)
+               *out = driver;
+       return driver == NULL;
+}
+
 static int
 vdev_probe_all_drivers(struct rte_vdev_device *dev)
 {
-       const char *name = rte_vdev_device_name(dev);
+       const char *name;
        struct rte_vdev_driver *driver;
        int ret;
 
-       TAILQ_FOREACH(driver, &vdev_driver_list, next) {
-               /*
-                * search a driver prefix in virtual device name.
-                * For example, if the driver is pcap PMD, driver->name
-                * will be "net_pcap", but "name" will be "net_pcapN".
-                * So use strncmp to compare.
-                */
-               if (!strncmp(driver->driver.name, name,
-                           strlen(driver->driver.name))) {
-                       dev->device.driver = &driver->driver;
-                       ret = driver->probe(dev);
-                       if (ret)
-                               dev->device.driver = NULL;
-                       return ret;
-               }
-       }
+       name = rte_vdev_device_name(dev);
 
-       /* Give new names precedence over aliases. */
-       TAILQ_FOREACH(driver, &vdev_driver_list, next) {
-               if (driver->driver.alias &&
-                   !strncmp(driver->driver.alias, name,
-                           strlen(driver->driver.alias))) {
-                       dev->device.driver = &driver->driver;
-                       ret = driver->probe(dev);
-                       if (ret)
-                               dev->device.driver = NULL;
-                       return ret;
-               }
-       }
+       RTE_LOG(DEBUG, EAL, "Search driver %s to probe device %s\n", name,
+               rte_vdev_device_name(dev));
 
-       return 1;
+       if (vdev_parse(name, &driver))
+               return -1;
+       dev->device.driver = &driver->driver;
+       ret = driver->probe(dev);
+       if (ret)
+               dev->device.driver = NULL;
+       return ret;
 }
 
 static struct rte_vdev_device *
@@ -139,13 +138,12 @@ alloc_devargs(const char *name, const char *args)
        if (!devargs)
                return NULL;
 
-       devargs->type = RTE_DEVTYPE_VIRTUAL;
+       devargs->bus = rte_bus_find_by_name("vdev");
        if (args)
                devargs->args = strdup(args);
 
-       ret = snprintf(devargs->virt.drv_name,
-                              sizeof(devargs->virt.drv_name), "%s", name);
-       if (ret < 0 || ret >= (int)sizeof(devargs->virt.drv_name)) {
+       ret = snprintf(devargs->name, sizeof(devargs->name), "%s", name);
+       if (ret < 0 || ret >= (int)sizeof(devargs->name)) {
                free(devargs->args);
                free(devargs);
                return NULL;
@@ -155,7 +153,7 @@ alloc_devargs(const char *name, const char *args)
 }
 
 int
-rte_eal_vdev_init(const char *name, const char *args)
+rte_vdev_init(const char *name, const char *args)
 {
        struct rte_vdev_device *dev;
        struct rte_devargs *devargs;
@@ -180,7 +178,7 @@ rte_eal_vdev_init(const char *name, const char *args)
 
        dev->device.devargs = devargs;
        dev->device.numa_node = SOCKET_ID_ANY;
-       dev->device.name = devargs->virt.drv_name;
+       dev->device.name = devargs->name;
 
        ret = vdev_probe_all_drivers(dev);
        if (ret) {
@@ -191,7 +189,6 @@ rte_eal_vdev_init(const char *name, const char *args)
 
        TAILQ_INSERT_TAIL(&devargs_list, devargs, next);
 
-       rte_eal_device_insert(&dev->device);
        TAILQ_INSERT_TAIL(&vdev_device_list, dev, next);
        return 0;
 
@@ -219,7 +216,7 @@ vdev_remove_driver(struct rte_vdev_device *dev)
 }
 
 int
-rte_eal_vdev_uninit(const char *name)
+rte_vdev_uninit(const char *name)
 {
        struct rte_vdev_device *dev;
        struct rte_devargs *devargs;
@@ -239,7 +236,6 @@ rte_eal_vdev_uninit(const char *name)
                return ret;
 
        TAILQ_REMOVE(&vdev_device_list, dev, next);
-       rte_eal_device_remove(&dev->device);
 
        TAILQ_REMOVE(&devargs_list, devargs, next);
 
@@ -254,15 +250,16 @@ vdev_scan(void)
 {
        struct rte_vdev_device *dev;
        struct rte_devargs *devargs;
+       struct rte_bus *vbus;
 
        /* for virtual devices we scan the devargs_list populated via cmdline */
-
+       vbus = rte_bus_find_by_name("vdev");
        TAILQ_FOREACH(devargs, &devargs_list, next) {
 
-               if (devargs->type != RTE_DEVTYPE_VIRTUAL)
+               if (devargs->bus != vbus)
                        continue;
 
-               dev = find_vdev(devargs->virt.drv_name);
+               dev = find_vdev(devargs->name);
                if (dev)
                        continue;
 
@@ -272,9 +269,8 @@ vdev_scan(void)
 
                dev->device.devargs = devargs;
                dev->device.numa_node = SOCKET_ID_ANY;
-               dev->device.name = devargs->virt.drv_name;
+               dev->device.name = devargs->name;
 
-               rte_eal_device_insert(&dev->device);
                TAILQ_INSERT_TAIL(&vdev_device_list, dev, next);
        }
 
@@ -286,12 +282,6 @@ vdev_probe(void)
 {
        struct rte_vdev_device *dev;
 
-       /*
-        * Note that the dev_driver_list is populated here
-        * from calls made to rte_eal_driver_register from constructor functions
-        * embedded into PMD modules via the RTE_PMD_REGISTER_VDEV macro
-        */
-
        /* call the init function for each virtual device */
        TAILQ_FOREACH(dev, &vdev_device_list, next) {
 
@@ -308,21 +298,40 @@ vdev_probe(void)
        return 0;
 }
 
-static struct rte_bus rte_vdev_bus = {
-       .scan = vdev_scan,
-       .probe = vdev_probe,
-};
+static struct rte_device *
+vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
+                const void *data)
+{
+       struct rte_vdev_device *dev;
 
-RTE_INIT(rte_vdev_bus_register);
+       TAILQ_FOREACH(dev, &vdev_device_list, next) {
+               if (start && &dev->device == start) {
+                       start = NULL;
+                       continue;
+               }
+               if (cmp(&dev->device, data) == 0)
+                       return &dev->device;
+       }
+       return NULL;
+}
 
-static void rte_vdev_bus_register(void)
+static int
+vdev_unplug(struct rte_device *dev)
 {
-       static int registered;
+       /*
+        * The virtual bus doesn't support 'unattached' devices so this is
+        * actually equal to hotplugging removal of it.
+        */
+       return rte_vdev_uninit(dev->name);
+}
 
-       if (registered)
-               return;
+static struct rte_bus rte_vdev_bus = {
+       .scan = vdev_scan,
+       .probe = vdev_probe,
+       .find_device = vdev_find_device,
+       /* .plug = NULL, see comment on vdev_unplug */
+       .unplug = vdev_unplug,
+       .parse = vdev_parse,
+};
 
-       registered = 1;
-       rte_vdev_bus.name = RTE_STR(virtual);
-       rte_bus_register(&rte_vdev_bus);
-}
+RTE_REGISTER_BUS(vdev, rte_vdev_bus);