malloc: add option --match-allocations
[dpdk.git] / lib / librte_eal / linuxapp / eal / eal.c
index 76536ba..dadba33 100644 (file)
@@ -13,7 +13,9 @@
 #include <syslog.h>
 #include <getopt.h>
 #include <sys/file.h>
+#include <dirent.h>
 #include <fcntl.h>
+#include <fnmatch.h>
 #include <stddef.h>
 #include <errno.h>
 #include <limits.h>
@@ -48,6 +50,7 @@
 #include <rte_atomic.h>
 #include <malloc_heap.h>
 #include <rte_vfio.h>
+#include <rte_option.h>
 
 #include "eal_private.h"
 #include "eal_thread.h"
@@ -148,8 +151,93 @@ eal_create_runtime_dir(void)
        return 0;
 }
 
+int
+eal_clean_runtime_dir(void)
+{
+       DIR *dir;
+       struct dirent *dirent;
+       int dir_fd, fd, lck_result;
+       static const char * const filters[] = {
+               "fbarray_*",
+               "mp_socket_*"
+       };
+
+       /* open directory */
+       dir = opendir(runtime_dir);
+       if (!dir) {
+               RTE_LOG(ERR, EAL, "Unable to open runtime directory %s\n",
+                               runtime_dir);
+               goto error;
+       }
+       dir_fd = dirfd(dir);
+
+       /* lock the directory before doing anything, to avoid races */
+       if (flock(dir_fd, LOCK_EX) < 0) {
+               RTE_LOG(ERR, EAL, "Unable to lock runtime directory %s\n",
+                       runtime_dir);
+               goto error;
+       }
+
+       dirent = readdir(dir);
+       if (!dirent) {
+               RTE_LOG(ERR, EAL, "Unable to read runtime directory %s\n",
+                               runtime_dir);
+               goto error;
+       }
+
+       while (dirent != NULL) {
+               unsigned int f_idx;
+               bool skip = true;
+
+               /* skip files that don't match the patterns */
+               for (f_idx = 0; f_idx < RTE_DIM(filters); f_idx++) {
+                       const char *filter = filters[f_idx];
+
+                       if (fnmatch(filter, dirent->d_name, 0) == 0) {
+                               skip = false;
+                               break;
+                       }
+               }
+               if (skip) {
+                       dirent = readdir(dir);
+                       continue;
+               }
+
+               /* try and lock the file */
+               fd = openat(dir_fd, dirent->d_name, O_RDONLY);
+
+               /* skip to next file */
+               if (fd == -1) {
+                       dirent = readdir(dir);
+                       continue;
+               }
+
+               /* non-blocking lock */
+               lck_result = flock(fd, LOCK_EX | LOCK_NB);
+
+               /* if lock succeeds, remove the file */
+               if (lck_result != -1)
+                       unlinkat(dir_fd, dirent->d_name, 0);
+               close(fd);
+               dirent = readdir(dir);
+       }
+
+       /* closedir closes dir_fd and drops the lock */
+       closedir(dir);
+       return 0;
+
+error:
+       if (dir)
+               closedir(dir);
+
+       RTE_LOG(ERR, EAL, "Error while clearing runtime dir: %s\n",
+               strerror(errno));
+
+       return -1;
+}
+
 const char *
-eal_get_runtime_dir(void)
+rte_eal_get_runtime_dir(void)
 {
        return runtime_dir;
 }
@@ -263,6 +351,8 @@ rte_eal_config_create(void)
         * processes could later map the config into this exact location */
        rte_config.mem_config->mem_cfg_addr = (uintptr_t) rte_mem_cfg_addr;
 
+       rte_config.mem_config->dma_maskbits = 0;
+
 }
 
 /* attach to an existing shared memory config */
@@ -428,6 +518,7 @@ eal_usage(const char *prgname)
               "  --"OPT_VFIO_INTR"         Interrupt mode for VFIO (legacy|msi|msix)\n"
               "  --"OPT_LEGACY_MEM"        Legacy memory mode (no dynamic allocation, contiguous segments)\n"
               "  --"OPT_SINGLE_FILE_SEGMENTS" Put all hugepage memory in single files\n"
+              "  --"OPT_MATCH_ALLOCATIONS" Free hugepages exactly as allocated\n"
               "\n");
        /* Allow the application to print its usage message too if hook is set */
        if ( rte_application_usage_hook ) {
@@ -600,12 +691,20 @@ eal_parse_args(int argc, char **argv)
 
        argvopt = argv;
        optind = 1;
+       opterr = 0;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                                  eal_long_options, &option_index)) != EOF) {
 
-               /* getopt is not happy, stop right now */
+               /*
+                * getopt didn't recognise the option, lets parse the
+                * registered options to see if the flag is valid
+                */
                if (opt == '?') {
+                       ret = rte_option_parse(argv[optind-1]);
+                       if (ret == 0)
+                               continue;
+
                        eal_usage(prgname);
                        ret = -1;
                        goto out;
@@ -688,6 +787,10 @@ eal_parse_args(int argc, char **argv)
                            strdup(optarg);
                        break;
 
+               case OPT_MATCH_ALLOCATIONS_NUM:
+                       internal_config.match_allocations = 1;
+                       break;
+
                default:
                        if (opt < OPT_LONG_MIN_NUM && isprint(opt)) {
                                RTE_LOG(ERR, EAL, "Option %c is not supported "
@@ -816,7 +919,8 @@ rte_eal_init(int argc, char **argv)
        int i, fctret, ret;
        pthread_t thread_id;
        static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
-       const char *logid;
+       const char *p;
+       static char logid[PATH_MAX];
        char cpuset[RTE_CPU_AFFINITY_STR_LEN];
        char thread_name[RTE_MAX_THREAD_NAME_LEN];
 
@@ -833,9 +937,8 @@ rte_eal_init(int argc, char **argv)
                return -1;
        }
 
-       logid = strrchr(argv[0], '/');
-       logid = strdup(logid ? logid + 1: argv[0]);
-
+       p = strrchr(argv[0], '/');
+       strlcpy(logid, p ? p + 1 : argv[0], sizeof(logid));
        thread_id = pthread_self();
 
        eal_reset_internal_config(&internal_config);
@@ -901,16 +1004,23 @@ rte_eal_init(int argc, char **argv)
                return -1;
        }
 
-       /* autodetect the iova mapping mode (default is iova_pa) */
-       rte_eal_get_configuration()->iova_mode = rte_bus_get_iommu_class();
-
-       /* Workaround for KNI which requires physical address to work */
-       if (rte_eal_get_configuration()->iova_mode == RTE_IOVA_VA &&
-                       rte_eal_check_module("rte_kni") == 1) {
-               rte_eal_get_configuration()->iova_mode = RTE_IOVA_PA;
-               RTE_LOG(WARNING, EAL,
-                       "Some devices want IOVA as VA but PA will be used because.. "
-                       "KNI module inserted\n");
+       /* if no EAL option "--iova-mode=<pa|va>", use bus IOVA scheme */
+       if (internal_config.iova_mode == RTE_IOVA_DC) {
+               /* autodetect the IOVA mapping mode (default is RTE_IOVA_PA) */
+               rte_eal_get_configuration()->iova_mode =
+                       rte_bus_get_iommu_class();
+
+               /* Workaround for KNI which requires physical address to work */
+               if (rte_eal_get_configuration()->iova_mode == RTE_IOVA_VA &&
+                               rte_eal_check_module("rte_kni") == 1) {
+                       rte_eal_get_configuration()->iova_mode = RTE_IOVA_PA;
+                       RTE_LOG(WARNING, EAL,
+                               "Some devices want IOVA as VA but PA will be used because.. "
+                               "KNI module inserted\n");
+               }
+       } else {
+               rte_eal_get_configuration()->iova_mode =
+                       internal_config.iova_mode;
        }
 
        if (internal_config.no_hugetlbfs == 0) {
@@ -1078,8 +1188,23 @@ rte_eal_init(int argc, char **argv)
                return -1;
        }
 
+       /*
+        * Clean up unused files in runtime directory. We do this at the end of
+        * init and not at the beginning because we want to clean stuff up
+        * whether we are primary or secondary process, but we cannot remove
+        * primary process' files because secondary should be able to run even
+        * if primary process is dead.
+        */
+       if (eal_clean_runtime_dir() < 0) {
+               rte_eal_init_alert("Cannot clear runtime directory\n");
+               return -1;
+       }
+
        rte_eal_mcfg_complete();
 
+       /* Call each registered callback, if enabled */
+       rte_option_init();
+
        return fctret;
 }