eventdev: move Rx adapter to separate function
[dpdk.git] / lib / librte_eventdev / rte_event_eth_rx_adapter.c
index aec2703..8fe037f 100644 (file)
@@ -1,3 +1,7 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Intel Corporation.
+ * All rights reserved.
+ */
 #include <rte_cycles.h>
 #include <rte_common.h>
 #include <rte_dev.h>
@@ -27,7 +31,7 @@
  */
 struct eth_rx_poll_entry {
        /* Eth port to poll */
-       uint8_t eth_dev_id;
+       uint16_t eth_dev_id;
        /* Eth rx queue to poll */
        uint16_t eth_rx_qid;
 };
@@ -87,6 +91,8 @@ struct rte_event_eth_rx_adapter {
        int socket_id;
        /* Per adapter EAL service */
        uint32_t service_id;
+       /* Adapter started flag */
+       uint8_t rxa_started;
 } __rte_cache_aligned;
 
 /* Per eth device */
@@ -103,10 +109,16 @@ struct eth_device_info {
         * rx_adapter_stop callback needs to be invoked
         */
        uint8_t dev_rx_started;
-       /* If nb_dev_queues > 0, the start callback will
+       /* Number of queues added for this device */
+       uint16_t nb_dev_queues;
+       /* If nb_rx_poll > 0, the start callback will
         * be invoked if not already invoked
         */
-       uint16_t nb_dev_queues;
+       uint16_t nb_rx_poll;
+       /* sum(wrr(q)) for all queues within the device
+        * useful when deleting all device queues
+        */
+       uint32_t wrr_len;
 };
 
 /* Per Rx queue */
@@ -123,30 +135,30 @@ struct eth_rx_queue_info {
 static struct rte_event_eth_rx_adapter **event_eth_rx_adapter;
 
 static inline int
-valid_id(uint8_t id)
+rxa_validate_id(uint8_t id)
 {
        return id < RTE_EVENT_ETH_RX_ADAPTER_MAX_INSTANCE;
 }
 
 #define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) do { \
-       if (!valid_id(id)) { \
+       if (!rxa_validate_id(id)) { \
                RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d\n", id); \
                return retval; \
        } \
 } while (0)
 
 static inline int
-sw_rx_adapter_queue_count(struct rte_event_eth_rx_adapter *rx_adapter)
+rxa_sw_adapter_queue_count(struct rte_event_eth_rx_adapter *rx_adapter)
 {
        return rx_adapter->num_rx_polled;
 }
 
 /* Greatest common divisor */
-static uint16_t gcd_u16(uint16_t a, uint16_t b)
+static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
 {
        uint16_t r = a % b;
 
-       return r ? gcd_u16(b, r) : b;
+       return r ? rxa_gcd_u16(b, r) : b;
 }
 
 /* Returns the next queue in the polling sequence
@@ -154,7 +166,7 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
  * http://kb.linuxvirtualserver.org/wiki/Weighted_Round-Robin_Scheduling
  */
 static int
-wrr_next(struct rte_event_eth_rx_adapter *rx_adapter,
+rxa_wrr_next(struct rte_event_eth_rx_adapter *rx_adapter,
         unsigned int n, int *cw,
         struct eth_rx_poll_entry *eth_rx_poll, uint16_t max_wt,
         uint16_t gcd, int prev)
@@ -164,7 +176,7 @@ wrr_next(struct rte_event_eth_rx_adapter *rx_adapter,
 
        while (1) {
                uint16_t q;
-               uint8_t d;
+               uint16_t d;
 
                i = (i + 1) % n;
                if (i == 0) {
@@ -182,13 +194,170 @@ wrr_next(struct rte_event_eth_rx_adapter *rx_adapter,
        }
 }
 
-/* Precalculate WRR polling sequence for all queues in rx_adapter */
+static inline int
+rxa_polled_queue(struct eth_device_info *dev_info,
+       int rx_queue_id)
+{
+       struct eth_rx_queue_info *queue_info;
+
+       queue_info = &dev_info->rx_queue[rx_queue_id];
+       return !dev_info->internal_event_port &&
+               dev_info->rx_queue &&
+               queue_info->queue_enabled && queue_info->wt != 0;
+}
+
+/* Calculate size of the eth_rx_poll and wrr_sched arrays
+ * after deleting poll mode rx queues
+ */
+static void
+rxa_calc_nb_post_poll_del(struct rte_event_eth_rx_adapter *rx_adapter,
+                       struct eth_device_info *dev_info,
+                       int rx_queue_id,
+                       uint32_t *nb_rx_poll,
+                       uint32_t *nb_wrr)
+{
+       uint32_t poll_diff;
+       uint32_t wrr_len_diff;
+
+       if (rx_queue_id == -1) {
+               poll_diff = dev_info->nb_rx_poll;
+               wrr_len_diff = dev_info->wrr_len;
+       } else {
+               poll_diff = rxa_polled_queue(dev_info, rx_queue_id);
+               wrr_len_diff = poll_diff ? dev_info->rx_queue[rx_queue_id].wt :
+                                       0;
+       }
+
+       *nb_rx_poll = rx_adapter->num_rx_polled - poll_diff;
+       *nb_wrr = rx_adapter->wrr_len - wrr_len_diff;
+}
+
+/* Calculate nb_rx_* after adding poll mode rx queues
+ */
+static void
+rxa_calc_nb_post_add_poll(struct rte_event_eth_rx_adapter *rx_adapter,
+                       struct eth_device_info *dev_info,
+                       int rx_queue_id,
+                       uint16_t wt,
+                       uint32_t *nb_rx_poll,
+                       uint32_t *nb_wrr)
+{
+       uint32_t poll_diff;
+       uint32_t wrr_len_diff;
+
+       if (rx_queue_id == -1) {
+               poll_diff = dev_info->dev->data->nb_rx_queues -
+                                               dev_info->nb_rx_poll;
+               wrr_len_diff = wt*dev_info->dev->data->nb_rx_queues
+                               - dev_info->wrr_len;
+       } else {
+               poll_diff = !rxa_polled_queue(dev_info, rx_queue_id);
+               wrr_len_diff = rxa_polled_queue(dev_info, rx_queue_id) ?
+                               wt - dev_info->rx_queue[rx_queue_id].wt :
+                               wt;
+       }
+
+       *nb_rx_poll = rx_adapter->num_rx_polled + poll_diff;
+       *nb_wrr = rx_adapter->wrr_len + wrr_len_diff;
+}
+
+/* Calculate nb_rx_* after adding rx_queue_id */
+static void
+rxa_calc_nb_post_add(struct rte_event_eth_rx_adapter *rx_adapter,
+               struct eth_device_info *dev_info,
+               int rx_queue_id,
+               uint16_t wt,
+               uint32_t *nb_rx_poll,
+               uint32_t *nb_wrr)
+{
+       rxa_calc_nb_post_add_poll(rx_adapter, dev_info, rx_queue_id,
+                               wt, nb_rx_poll, nb_wrr);
+}
+
+/* Calculate nb_rx_* after deleting rx_queue_id */
+static void
+rxa_calc_nb_post_del(struct rte_event_eth_rx_adapter *rx_adapter,
+               struct eth_device_info *dev_info,
+               int rx_queue_id,
+               uint32_t *nb_rx_poll,
+               uint32_t *nb_wrr)
+{
+       rxa_calc_nb_post_poll_del(rx_adapter, dev_info, rx_queue_id, nb_rx_poll,
+                               nb_wrr);
+}
+
+/*
+ * Allocate the rx_poll array
+ */
+static struct eth_rx_poll_entry *
+rxa_alloc_poll(struct rte_event_eth_rx_adapter *rx_adapter,
+       uint32_t num_rx_polled)
+{
+       size_t len;
+
+       len  = RTE_ALIGN(num_rx_polled * sizeof(*rx_adapter->eth_rx_poll),
+                                                       RTE_CACHE_LINE_SIZE);
+       return  rte_zmalloc_socket(rx_adapter->mem_name,
+                               len,
+                               RTE_CACHE_LINE_SIZE,
+                               rx_adapter->socket_id);
+}
+
+/*
+ * Allocate the WRR array
+ */
+static uint32_t *
+rxa_alloc_wrr(struct rte_event_eth_rx_adapter *rx_adapter, int nb_wrr)
+{
+       size_t len;
+
+       len = RTE_ALIGN(nb_wrr * sizeof(*rx_adapter->wrr_sched),
+                       RTE_CACHE_LINE_SIZE);
+       return  rte_zmalloc_socket(rx_adapter->mem_name,
+                               len,
+                               RTE_CACHE_LINE_SIZE,
+                               rx_adapter->socket_id);
+}
+
 static int
-eth_poll_wrr_calc(struct rte_event_eth_rx_adapter *rx_adapter)
+rxa_alloc_poll_arrays(struct rte_event_eth_rx_adapter *rx_adapter,
+               uint32_t nb_poll,
+               uint32_t nb_wrr,
+               struct eth_rx_poll_entry **rx_poll,
+               uint32_t **wrr_sched)
+{
+
+       if (nb_poll == 0) {
+               *rx_poll = NULL;
+               *wrr_sched = NULL;
+               return 0;
+       }
+
+       *rx_poll = rxa_alloc_poll(rx_adapter, nb_poll);
+       if (*rx_poll == NULL) {
+               *wrr_sched = NULL;
+               return -ENOMEM;
+       }
+
+       *wrr_sched = rxa_alloc_wrr(rx_adapter, nb_wrr);
+       if (*wrr_sched == NULL) {
+               rte_free(*rx_poll);
+               return -ENOMEM;
+       }
+       return 0;
+}
+
+/* Precalculate WRR polling sequence for all queues in rx_adapter */
+static void
+rxa_calc_wrr_sequence(struct rte_event_eth_rx_adapter *rx_adapter,
+               struct eth_rx_poll_entry *rx_poll,
+               uint32_t *rx_wrr)
 {
-       uint8_t d;
+       uint16_t d;
        uint16_t q;
        unsigned int i;
+       int prev = -1;
+       int cw = -1;
 
        /* Initialize variables for calculation of wrr schedule */
        uint16_t max_wrr_pos = 0;
@@ -196,79 +365,52 @@ eth_poll_wrr_calc(struct rte_event_eth_rx_adapter *rx_adapter)
        uint16_t max_wt = 0;
        uint16_t gcd = 0;
 
-       struct eth_rx_poll_entry *rx_poll = NULL;
-       uint32_t *rx_wrr = NULL;
+       if (rx_poll == NULL)
+               return;
 
-       if (rx_adapter->num_rx_polled) {
-               size_t len = RTE_ALIGN(rx_adapter->num_rx_polled *
-                               sizeof(*rx_adapter->eth_rx_poll),
-                               RTE_CACHE_LINE_SIZE);
-               rx_poll = rte_zmalloc_socket(rx_adapter->mem_name,
-                                            len,
-                                            RTE_CACHE_LINE_SIZE,
-                                            rx_adapter->socket_id);
-               if (rx_poll == NULL)
-                       return -ENOMEM;
+       /* Generate array of all queues to poll, the size of this
+        * array is poll_q
+        */
+       RTE_ETH_FOREACH_DEV(d) {
+               uint16_t nb_rx_queues;
+               struct eth_device_info *dev_info =
+                               &rx_adapter->eth_devices[d];
+               nb_rx_queues = dev_info->dev->data->nb_rx_queues;
+               if (dev_info->rx_queue == NULL)
+                       continue;
+               if (dev_info->internal_event_port)
+                       continue;
+               dev_info->wrr_len = 0;
+               for (q = 0; q < nb_rx_queues; q++) {
+                       struct eth_rx_queue_info *queue_info =
+                               &dev_info->rx_queue[q];
+                       uint16_t wt;
 
-               /* Generate array of all queues to poll, the size of this
-                * array is poll_q
-                */
-               RTE_ETH_FOREACH_DEV(d) {
-                       uint16_t nb_rx_queues;
-                       struct eth_device_info *dev_info =
-                                       &rx_adapter->eth_devices[d];
-                       nb_rx_queues = dev_info->dev->data->nb_rx_queues;
-                       if (dev_info->rx_queue == NULL)
+                       if (!rxa_polled_queue(dev_info, q))
                                continue;
-                       for (q = 0; q < nb_rx_queues; q++) {
-                               struct eth_rx_queue_info *queue_info =
-                                       &dev_info->rx_queue[q];
-                               if (queue_info->queue_enabled == 0)
-                                       continue;
-
-                               uint16_t wt = queue_info->wt;
-                               rx_poll[poll_q].eth_dev_id = d;
-                               rx_poll[poll_q].eth_rx_qid = q;
-                               max_wrr_pos += wt;
-                               max_wt = RTE_MAX(max_wt, wt);
-                               gcd = (gcd) ? gcd_u16(gcd, wt) : wt;
-                               poll_q++;
-                       }
-               }
-
-               len = RTE_ALIGN(max_wrr_pos * sizeof(*rx_wrr),
-                               RTE_CACHE_LINE_SIZE);
-               rx_wrr = rte_zmalloc_socket(rx_adapter->mem_name,
-                                           len,
-                                           RTE_CACHE_LINE_SIZE,
-                                           rx_adapter->socket_id);
-               if (rx_wrr == NULL) {
-                       rte_free(rx_poll);
-                       return -ENOMEM;
-               }
-
-               /* Generate polling sequence based on weights */
-               int prev = -1;
-               int cw = -1;
-               for (i = 0; i < max_wrr_pos; i++) {
-                       rx_wrr[i] = wrr_next(rx_adapter, poll_q, &cw,
-                                            rx_poll, max_wt, gcd, prev);
-                       prev = rx_wrr[i];
+                       wt = queue_info->wt;
+                       rx_poll[poll_q].eth_dev_id = d;
+                       rx_poll[poll_q].eth_rx_qid = q;
+                       max_wrr_pos += wt;
+                       dev_info->wrr_len += wt;
+                       max_wt = RTE_MAX(max_wt, wt);
+                       gcd = (gcd) ? rxa_gcd_u16(gcd, wt) : wt;
+                       poll_q++;
                }
        }
 
-       rte_free(rx_adapter->eth_rx_poll);
-       rte_free(rx_adapter->wrr_sched);
-
-       rx_adapter->eth_rx_poll = rx_poll;
-       rx_adapter->wrr_sched = rx_wrr;
-       rx_adapter->wrr_len = max_wrr_pos;
-
-       return 0;
+       /* Generate polling sequence based on weights */
+       prev = -1;
+       cw = -1;
+       for (i = 0; i < max_wrr_pos; i++) {
+               rx_wrr[i] = rxa_wrr_next(rx_adapter, poll_q, &cw,
+                                    rx_poll, max_wt, gcd, prev);
+               prev = rx_wrr[i];
+       }
 }
 
 static inline void
-mtoip(struct rte_mbuf *m, struct ipv4_hdr **ipv4_hdr,
+rxa_mtoip(struct rte_mbuf *m, struct ipv4_hdr **ipv4_hdr,
        struct ipv6_hdr **ipv6_hdr)
 {
        struct ether_hdr *eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);
@@ -307,7 +449,7 @@ mtoip(struct rte_mbuf *m, struct ipv4_hdr **ipv4_hdr,
 
 /* Calculate RSS hash for IPv4/6 */
 static inline uint32_t
-do_softrss(struct rte_mbuf *m, const uint8_t *rss_key_be)
+rxa_do_softrss(struct rte_mbuf *m, const uint8_t *rss_key_be)
 {
        uint32_t input_len;
        void *tuple;
@@ -316,7 +458,7 @@ do_softrss(struct rte_mbuf *m, const uint8_t *rss_key_be)
        struct ipv4_hdr *ipv4_hdr;
        struct ipv6_hdr *ipv6_hdr;
 
-       mtoip(m, &ipv4_hdr, &ipv6_hdr);
+       rxa_mtoip(m, &ipv4_hdr, &ipv6_hdr);
 
        if (ipv4_hdr) {
                ipv4_tuple.src_addr = rte_be_to_cpu_32(ipv4_hdr->src_addr);
@@ -335,13 +477,13 @@ do_softrss(struct rte_mbuf *m, const uint8_t *rss_key_be)
 }
 
 static inline int
-rx_enq_blocked(struct rte_event_eth_rx_adapter *rx_adapter)
+rxa_enq_blocked(struct rte_event_eth_rx_adapter *rx_adapter)
 {
        return !!rx_adapter->enq_block_count;
 }
 
 static inline void
-rx_enq_block_start_ts(struct rte_event_eth_rx_adapter *rx_adapter)
+rxa_enq_block_start_ts(struct rte_event_eth_rx_adapter *rx_adapter)
 {
        if (rx_adapter->rx_enq_block_start_ts)
                return;
@@ -354,13 +496,13 @@ rx_enq_block_start_ts(struct rte_event_eth_rx_adapter *rx_adapter)
 }
 
 static inline void
-rx_enq_block_end_ts(struct rte_event_eth_rx_adapter *rx_adapter,
+rxa_enq_block_end_ts(struct rte_event_eth_rx_adapter *rx_adapter,
                    struct rte_event_eth_rx_adapter_stats *stats)
 {
        if (unlikely(!stats->rx_enq_start_ts))
                stats->rx_enq_start_ts = rte_get_tsc_cycles();
 
-       if (likely(!rx_enq_blocked(rx_adapter)))
+       if (likely(!rxa_enq_blocked(rx_adapter)))
                return;
 
        rx_adapter->enq_block_count = 0;
@@ -376,8 +518,8 @@ rx_enq_block_end_ts(struct rte_event_eth_rx_adapter *rx_adapter,
  * this function
  */
 static inline void
-buf_event_enqueue(struct rte_event_eth_rx_adapter *rx_adapter,
-                 struct rte_event *ev)
+rxa_buffer_event(struct rte_event_eth_rx_adapter *rx_adapter,
+               struct rte_event *ev)
 {
        struct rte_eth_event_enqueue_buffer *buf =
            &rx_adapter->event_enqueue_buffer;
@@ -386,7 +528,7 @@ buf_event_enqueue(struct rte_event_eth_rx_adapter *rx_adapter,
 
 /* Enqueue buffered events to event device */
 static inline uint16_t
-flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
+rxa_flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
 {
        struct rte_eth_event_enqueue_buffer *buf =
            &rx_adapter->event_enqueue_buffer;
@@ -403,8 +545,8 @@ flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
                stats->rx_enq_retry++;
        }
 
-       n ? rx_enq_block_end_ts(rx_adapter, stats) :
-               rx_enq_block_start_ts(rx_adapter);
+       n ? rxa_enq_block_end_ts(rx_adapter, stats) :
+               rxa_enq_block_start_ts(rx_adapter);
 
        buf->count -= n;
        stats->rx_enq_count += n;
@@ -413,15 +555,15 @@ flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
 }
 
 static inline void
-fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
-       uint8_t dev_id,
-       uint16_t rx_queue_id,
-       struct rte_mbuf **mbufs,
-       uint16_t num)
+rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,
+               uint16_t eth_dev_id,
+               uint16_t rx_queue_id,
+               struct rte_mbuf **mbufs,
+               uint16_t num)
 {
        uint32_t i;
        struct eth_device_info *eth_device_info =
-                                       &rx_adapter->eth_devices[dev_id];
+                                       &rx_adapter->eth_devices[eth_dev_id];
        struct eth_rx_queue_info *eth_rx_queue_info =
                                        &eth_device_info->rx_queue[rx_queue_id];
 
@@ -455,7 +597,8 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
                struct rte_event *ev = &events[i];
 
                rss = do_rss ?
-                       do_softrss(m, rx_adapter->rss_key_be) : m->hash.rss;
+                       rxa_do_softrss(m, rx_adapter->rss_key_be) :
+                       m->hash.rss;
                flow_id =
                    eth_rx_queue_info->flow_id &
                                eth_rx_queue_info->flow_id_mask;
@@ -469,8 +612,47 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
                ev->priority = priority;
                ev->mbuf = m;
 
-               buf_event_enqueue(rx_adapter, ev);
+               rxa_buffer_event(rx_adapter, ev);
+       }
+}
+
+/* Enqueue packets from  <port, q>  to event buffer */
+static inline uint32_t
+rxa_eth_rx(struct rte_event_eth_rx_adapter *rx_adapter,
+       uint16_t port_id,
+       uint16_t queue_id,
+       uint32_t rx_count,
+       uint32_t max_rx)
+{
+       struct rte_mbuf *mbufs[BATCH_SIZE];
+       struct rte_eth_event_enqueue_buffer *buf =
+                                       &rx_adapter->event_enqueue_buffer;
+       struct rte_event_eth_rx_adapter_stats *stats =
+                                       &rx_adapter->stats;
+       uint16_t n;
+       uint32_t nb_rx = 0;
+
+       /* Don't do a batch dequeue from the rx queue if there isn't
+        * enough space in the enqueue buffer.
+        */
+       while (BATCH_SIZE <= (RTE_DIM(buf->events) - buf->count)) {
+               if (buf->count >= BATCH_SIZE)
+                       rxa_flush_event_buffer(rx_adapter);
+
+               stats->rx_poll_count++;
+               n = rte_eth_rx_burst(port_id, queue_id, mbufs, BATCH_SIZE);
+               if (unlikely(!n))
+                       break;
+               rxa_buffer_mbufs(rx_adapter, port_id, queue_id, mbufs, n);
+               nb_rx += n;
+               if (rx_count + nb_rx > max_rx)
+                       break;
        }
+
+       if (buf->count >= BATCH_SIZE)
+               rxa_flush_event_buffer(rx_adapter);
+
+       return nb_rx;
 }
 
 /*
@@ -486,71 +668,63 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
  * the hypervisor's switching layer where adjustments can be made to deal with
  * it.
  */
-static inline uint32_t
-eth_rx_poll(struct rte_event_eth_rx_adapter *rx_adapter)
+static inline void
+rxa_poll(struct rte_event_eth_rx_adapter *rx_adapter)
 {
        uint32_t num_queue;
-       uint16_t n;
        uint32_t nb_rx = 0;
-       struct rte_mbuf *mbufs[BATCH_SIZE];
        struct rte_eth_event_enqueue_buffer *buf;
        uint32_t wrr_pos;
        uint32_t max_nb_rx;
+       struct rte_event_eth_rx_adapter_stats *stats;
 
        wrr_pos = rx_adapter->wrr_pos;
        max_nb_rx = rx_adapter->max_nb_rx;
        buf = &rx_adapter->event_enqueue_buffer;
-       struct rte_event_eth_rx_adapter_stats *stats = &rx_adapter->stats;
+       stats = &rx_adapter->stats;
 
        /* Iterate through a WRR sequence */
        for (num_queue = 0; num_queue < rx_adapter->wrr_len; num_queue++) {
                unsigned int poll_idx = rx_adapter->wrr_sched[wrr_pos];
                uint16_t qid = rx_adapter->eth_rx_poll[poll_idx].eth_rx_qid;
-               uint8_t d = rx_adapter->eth_rx_poll[poll_idx].eth_dev_id;
+               uint16_t d = rx_adapter->eth_rx_poll[poll_idx].eth_dev_id;
 
                /* Don't do a batch dequeue from the rx queue if there isn't
                 * enough space in the enqueue buffer.
                 */
                if (buf->count >= BATCH_SIZE)
-                       flush_event_buffer(rx_adapter);
-               if (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count))
+                       rxa_flush_event_buffer(rx_adapter);
+               if (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count)) {
+                       rx_adapter->wrr_pos = wrr_pos;
                        break;
+               }
 
-               stats->rx_poll_count++;
-               n = rte_eth_rx_burst(d, qid, mbufs, BATCH_SIZE);
-
-               if (n) {
-                       stats->rx_packets += n;
-                       /* The check before rte_eth_rx_burst() ensures that
-                        * all n mbufs can be buffered
-                        */
-                       fill_event_buffer(rx_adapter, d, qid, mbufs, n);
-                       nb_rx += n;
-                       if (nb_rx > max_nb_rx) {
-                               rx_adapter->wrr_pos =
+               nb_rx += rxa_eth_rx(rx_adapter, d, qid, nb_rx, max_nb_rx);
+               if (nb_rx > max_nb_rx) {
+                       rx_adapter->wrr_pos =
                                    (wrr_pos + 1) % rx_adapter->wrr_len;
-                               return nb_rx;
-                       }
+                       break;
                }
 
                if (++wrr_pos == rx_adapter->wrr_len)
                        wrr_pos = 0;
        }
 
-       return nb_rx;
+       stats->rx_packets += nb_rx;
 }
 
 static int
-event_eth_rx_adapter_service_func(void *args)
+rxa_service_func(void *args)
 {
        struct rte_event_eth_rx_adapter *rx_adapter = args;
-       struct rte_eth_event_enqueue_buffer *buf;
 
-       buf = &rx_adapter->event_enqueue_buffer;
        if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0)
                return 0;
-       if (eth_rx_poll(rx_adapter) == 0 && buf->count)
-               flush_event_buffer(rx_adapter);
+       if (!rx_adapter->rxa_started) {
+               return 0;
+               rte_spinlock_unlock(&rx_adapter->rx_lock);
+       }
+       rxa_poll(rx_adapter);
        rte_spinlock_unlock(&rx_adapter->rx_lock);
        return 0;
 }
@@ -582,14 +756,14 @@ rte_event_eth_rx_adapter_init(void)
 }
 
 static inline struct rte_event_eth_rx_adapter *
-id_to_rx_adapter(uint8_t id)
+rxa_id_to_adapter(uint8_t id)
 {
        return event_eth_rx_adapter ?
                event_eth_rx_adapter[id] : NULL;
 }
 
 static int
-default_conf_cb(uint8_t id, uint8_t dev_id,
+rxa_default_conf_cb(uint8_t id, uint8_t dev_id,
                struct rte_event_eth_rx_adapter_conf *conf, void *arg)
 {
        int ret;
@@ -598,7 +772,7 @@ default_conf_cb(uint8_t id, uint8_t dev_id,
        int started;
        uint8_t port_id;
        struct rte_event_port_conf *port_conf = arg;
-       struct rte_event_eth_rx_adapter *rx_adapter = id_to_rx_adapter(id);
+       struct rte_event_eth_rx_adapter *rx_adapter = rxa_id_to_adapter(id);
 
        dev = &rte_eventdevs[rx_adapter->eventdev_id];
        dev_conf = dev->data->dev_conf;
@@ -635,7 +809,7 @@ default_conf_cb(uint8_t id, uint8_t dev_id,
 }
 
 static int
-init_service(struct rte_event_eth_rx_adapter *rx_adapter, uint8_t id)
+rxa_init_service(struct rte_event_eth_rx_adapter *rx_adapter, uint8_t id)
 {
        int ret;
        struct rte_service_spec service;
@@ -648,7 +822,7 @@ init_service(struct rte_event_eth_rx_adapter *rx_adapter, uint8_t id)
        snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,
                "rte_event_eth_rx_adapter_%d", id);
        service.socket_id = rx_adapter->socket_id;
-       service.callback = event_eth_rx_adapter_service_func;
+       service.callback = rxa_service_func;
        service.callback_userdata = rx_adapter;
        /* Service function handles locking for queue add/del updates */
        service.capabilities = RTE_SERVICE_CAP_MT_SAFE;
@@ -676,9 +850,8 @@ err_done:
        return ret;
 }
 
-
 static void
-update_queue_info(struct rte_event_eth_rx_adapter *rx_adapter,
+rxa_update_queue(struct rte_event_eth_rx_adapter *rx_adapter,
                struct eth_device_info *dev_info,
                int32_t rx_queue_id,
                uint8_t add)
@@ -692,7 +865,7 @@ update_queue_info(struct rte_event_eth_rx_adapter *rx_adapter,
 
        if (rx_queue_id == -1) {
                for (i = 0; i < dev_info->dev->data->nb_rx_queues; i++)
-                       update_queue_info(rx_adapter, dev_info, i, add);
+                       rxa_update_queue(rx_adapter, dev_info, i, add);
        } else {
                queue_info = &dev_info->rx_queue[rx_queue_id];
                enabled = queue_info->queue_enabled;
@@ -707,31 +880,53 @@ update_queue_info(struct rte_event_eth_rx_adapter *rx_adapter,
        }
 }
 
-static int
-event_eth_rx_adapter_queue_del(struct rte_event_eth_rx_adapter *rx_adapter,
-                           struct eth_device_info *dev_info,
-                           uint16_t rx_queue_id)
+static void
+rxa_sw_del(struct rte_event_eth_rx_adapter *rx_adapter,
+       struct eth_device_info *dev_info,
+       int32_t rx_queue_id)
 {
-       struct eth_rx_queue_info *queue_info;
+       int pollq;
 
        if (rx_adapter->nb_queues == 0)
-               return 0;
+               return;
 
-       queue_info = &dev_info->rx_queue[rx_queue_id];
-       rx_adapter->num_rx_polled -= queue_info->queue_enabled;
-       update_queue_info(rx_adapter, dev_info, rx_queue_id, 0);
-       return 0;
+       if (rx_queue_id == -1) {
+               uint16_t nb_rx_queues;
+               uint16_t i;
+
+               nb_rx_queues = dev_info->dev->data->nb_rx_queues;
+               for (i = 0; i < nb_rx_queues; i++)
+                       rxa_sw_del(rx_adapter, dev_info, i);
+               return;
+       }
+
+       pollq = rxa_polled_queue(dev_info, rx_queue_id);
+       rxa_update_queue(rx_adapter, dev_info, rx_queue_id, 0);
+       rx_adapter->num_rx_polled -= pollq;
+       dev_info->nb_rx_poll -= pollq;
 }
 
 static void
-event_eth_rx_adapter_queue_add(struct rte_event_eth_rx_adapter *rx_adapter,
-               struct eth_device_info *dev_info,
-               uint16_t rx_queue_id,
-               const struct rte_event_eth_rx_adapter_queue_conf *conf)
-
+rxa_add_queue(struct rte_event_eth_rx_adapter *rx_adapter,
+       struct eth_device_info *dev_info,
+       int32_t rx_queue_id,
+       const struct rte_event_eth_rx_adapter_queue_conf *conf)
 {
        struct eth_rx_queue_info *queue_info;
        const struct rte_event *ev = &conf->ev;
+       int pollq;
+
+       if (rx_queue_id == -1) {
+               uint16_t nb_rx_queues;
+               uint16_t i;
+
+               nb_rx_queues = dev_info->dev->data->nb_rx_queues;
+               for (i = 0; i < nb_rx_queues; i++)
+                       rxa_add_queue(rx_adapter, dev_info, i, conf);
+               return;
+       }
+
+       pollq = rxa_polled_queue(dev_info, rx_queue_id);
 
        queue_info = &dev_info->rx_queue[rx_queue_id];
        queue_info->event_queue_id = ev->queue_id;
@@ -745,20 +940,26 @@ event_eth_rx_adapter_queue_add(struct rte_event_eth_rx_adapter *rx_adapter,
                queue_info->flow_id_mask = ~0;
        }
 
-       /* The same queue can be added more than once */
-       rx_adapter->num_rx_polled += !queue_info->queue_enabled;
-       update_queue_info(rx_adapter, dev_info, rx_queue_id, 1);
+       rxa_update_queue(rx_adapter, dev_info, rx_queue_id, 1);
+       if (rxa_polled_queue(dev_info, rx_queue_id)) {
+               rx_adapter->num_rx_polled += !pollq;
+               dev_info->nb_rx_poll += !pollq;
+       }
 }
 
-static int add_rx_queue(struct rte_event_eth_rx_adapter *rx_adapter,
-               uint8_t eth_dev_id,
+static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
+               uint16_t eth_dev_id,
                int rx_queue_id,
                const struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
 {
        struct eth_device_info *dev_info = &rx_adapter->eth_devices[eth_dev_id];
        struct rte_event_eth_rx_adapter_queue_conf temp_conf;
-       uint32_t i;
        int ret;
+       struct eth_rx_poll_entry *rx_poll;
+       struct eth_rx_queue_info *rx_queue;
+       uint32_t *rx_wrr;
+       uint16_t nb_rx_queues;
+       uint32_t nb_rx_poll, nb_wrr;
 
        if (queue_conf->servicing_weight == 0) {
 
@@ -775,39 +976,55 @@ static int add_rx_queue(struct rte_event_eth_rx_adapter *rx_adapter,
                queue_conf = &temp_conf;
        }
 
+       nb_rx_queues = dev_info->dev->data->nb_rx_queues;
+       rx_queue = dev_info->rx_queue;
+
        if (dev_info->rx_queue == NULL) {
                dev_info->rx_queue =
                    rte_zmalloc_socket(rx_adapter->mem_name,
-                                      dev_info->dev->data->nb_rx_queues *
+                                      nb_rx_queues *
                                       sizeof(struct eth_rx_queue_info), 0,
                                       rx_adapter->socket_id);
                if (dev_info->rx_queue == NULL)
                        return -ENOMEM;
        }
+       rx_wrr = NULL;
+       rx_poll = NULL;
 
-       if (rx_queue_id == -1) {
-               for (i = 0; i < dev_info->dev->data->nb_rx_queues; i++)
-                       event_eth_rx_adapter_queue_add(rx_adapter,
-                                               dev_info, i,
-                                               queue_conf);
-       } else {
-               event_eth_rx_adapter_queue_add(rx_adapter, dev_info,
-                                         (uint16_t)rx_queue_id,
-                                         queue_conf);
-       }
+       rxa_calc_nb_post_add(rx_adapter, dev_info, rx_queue_id,
+                       queue_conf->servicing_weight,
+                       &nb_rx_poll, &nb_wrr);
 
-       ret = eth_poll_wrr_calc(rx_adapter);
-       if (ret) {
-               event_eth_rx_adapter_queue_del(rx_adapter,
-                                       dev_info, rx_queue_id);
-               return ret;
+       ret = rxa_alloc_poll_arrays(rx_adapter, nb_rx_poll, nb_wrr,
+                               &rx_poll, &rx_wrr);
+       if (ret)
+               goto err_free_rxqueue;
+
+       rxa_add_queue(rx_adapter, dev_info, rx_queue_id, queue_conf);
+       rxa_calc_wrr_sequence(rx_adapter, rx_poll, rx_wrr);
+
+       rte_free(rx_adapter->eth_rx_poll);
+       rte_free(rx_adapter->wrr_sched);
+
+       rx_adapter->eth_rx_poll = rx_poll;
+       rx_adapter->wrr_sched = rx_wrr;
+       rx_adapter->wrr_len = nb_wrr;
+       return 0;
+
+err_free_rxqueue:
+       if (rx_queue == NULL) {
+               rte_free(dev_info->rx_queue);
+               dev_info->rx_queue = NULL;
        }
 
-       return ret;
+       rte_free(rx_poll);
+       rte_free(rx_wrr);
+
+       return 0;
 }
 
 static int
-rx_adapter_ctrl(uint8_t id, int start)
+rxa_ctrl(uint8_t id, int start)
 {
        struct rte_event_eth_rx_adapter *rx_adapter;
        struct rte_eventdev *dev;
@@ -817,7 +1034,7 @@ rx_adapter_ctrl(uint8_t id, int start)
        int stop = !start;
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter == NULL)
                return -EINVAL;
 
@@ -841,8 +1058,12 @@ rx_adapter_ctrl(uint8_t id, int start)
                                                &rte_eth_devices[i]);
        }
 
-       if (use_service)
+       if (use_service) {
+               rte_spinlock_lock(&rx_adapter->rx_lock);
+               rx_adapter->rxa_started = start;
                rte_service_runstate_set(rx_adapter->service_id, start);
+               rte_spinlock_unlock(&rx_adapter->rx_lock);
+       }
 
        return 0;
 }
@@ -855,7 +1076,7 @@ rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
        struct rte_event_eth_rx_adapter *rx_adapter;
        int ret;
        int socket_id;
-       uint8_t i;
+       uint16_t i;
        char mem_name[ETH_RX_ADAPTER_SERVICE_NAME_LEN];
        const uint8_t default_rss_key[] = {
                0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
@@ -876,7 +1097,7 @@ rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
                        return ret;
        }
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter != NULL) {
                RTE_EDEV_LOG_ERR("Eth Rx adapter exists id = %" PRIu8, id);
                return -EEXIST;
@@ -918,7 +1139,7 @@ rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
                rx_adapter->eth_devices[i].dev = &rte_eth_devices[i];
 
        event_eth_rx_adapter[id] = rx_adapter;
-       if (conf_cb == default_conf_cb)
+       if (conf_cb == rxa_default_conf_cb)
                rx_adapter->default_cb_arg = 1;
        return 0;
 }
@@ -939,7 +1160,7 @@ rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,
                return -ENOMEM;
        *pc = *port_config;
        ret = rte_event_eth_rx_adapter_create_ext(id, dev_id,
-                                       default_conf_cb,
+                                       rxa_default_conf_cb,
                                        pc);
        if (ret)
                rte_free(pc);
@@ -953,7 +1174,7 @@ rte_event_eth_rx_adapter_free(uint8_t id)
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter == NULL)
                return -EINVAL;
 
@@ -974,7 +1195,7 @@ rte_event_eth_rx_adapter_free(uint8_t id)
 
 int
 rte_event_eth_rx_adapter_queue_add(uint8_t id,
-               uint8_t eth_dev_id,
+               uint16_t eth_dev_id,
                int32_t rx_queue_id,
                const struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
 {
@@ -983,12 +1204,11 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
        struct rte_event_eth_rx_adapter *rx_adapter;
        struct rte_eventdev *dev;
        struct eth_device_info *dev_info;
-       int start_service;
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
        RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if ((rx_adapter == NULL) || (queue_conf == NULL))
                return -EINVAL;
 
@@ -998,7 +1218,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
                                                &cap);
        if (ret) {
                RTE_EDEV_LOG_ERR("Failed to get adapter caps edev %" PRIu8
-                       "eth port %" PRIu8, id, eth_dev_id);
+                       "eth port %" PRIu16, id, eth_dev_id);
                return ret;
        }
 
@@ -1006,7 +1226,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
                && (queue_conf->rx_queue_flags &
                        RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID)) {
                RTE_EDEV_LOG_ERR("Flow ID override is not supported,"
-                               " eth port: %" PRIu8 " adapter id: %" PRIu8,
+                               " eth port: %" PRIu16 " adapter id: %" PRIu8,
                                eth_dev_id, id);
                return -EINVAL;
        }
@@ -1014,7 +1234,8 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
        if ((cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ) == 0 &&
                (rx_queue_id != -1)) {
                RTE_EDEV_LOG_ERR("Rx queues can only be connected to single "
-                       "event queue id %u eth port %u", id, eth_dev_id);
+                       "event queue, eth port: %" PRIu16 " adapter id: %"
+                       PRIu8, eth_dev_id, id);
                return -EINVAL;
        }
 
@@ -1025,7 +1246,6 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
                return -EINVAL;
        }
 
-       start_service = 0;
        dev_info = &rx_adapter->eth_devices[eth_dev_id];
 
        if (cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
@@ -1045,33 +1265,34 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
                                &rte_eth_devices[eth_dev_id],
                                rx_queue_id, queue_conf);
                if (ret == 0) {
-                       update_queue_info(rx_adapter,
+                       dev_info->internal_event_port = 1;
+                       rxa_update_queue(rx_adapter,
                                        &rx_adapter->eth_devices[eth_dev_id],
                                        rx_queue_id,
                                        1);
                }
        } else {
                rte_spinlock_lock(&rx_adapter->rx_lock);
-               ret = init_service(rx_adapter, id);
-               if (ret == 0)
-                       ret = add_rx_queue(rx_adapter, eth_dev_id, rx_queue_id,
+               dev_info->internal_event_port = 0;
+               ret = rxa_init_service(rx_adapter, id);
+               if (ret == 0) {
+                       uint32_t service_id = rx_adapter->service_id;
+                       ret = rxa_sw_add(rx_adapter, eth_dev_id, rx_queue_id,
                                        queue_conf);
+                       rte_service_component_runstate_set(service_id,
+                               rxa_sw_adapter_queue_count(rx_adapter));
+               }
                rte_spinlock_unlock(&rx_adapter->rx_lock);
-               if (ret == 0)
-                       start_service = !!sw_rx_adapter_queue_count(rx_adapter);
        }
 
        if (ret)
                return ret;
 
-       if (start_service)
-               rte_service_component_runstate_set(rx_adapter->service_id, 1);
-
        return 0;
 }
 
 int
-rte_event_eth_rx_adapter_queue_del(uint8_t id, uint8_t eth_dev_id,
+rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
                                int32_t rx_queue_id)
 {
        int ret = 0;
@@ -1079,12 +1300,15 @@ rte_event_eth_rx_adapter_queue_del(uint8_t id, uint8_t eth_dev_id,
        struct rte_event_eth_rx_adapter *rx_adapter;
        struct eth_device_info *dev_info;
        uint32_t cap;
-       uint16_t i;
+       uint32_t nb_rx_poll = 0;
+       uint32_t nb_wrr = 0;
+       struct eth_rx_poll_entry *rx_poll = NULL;
+       uint32_t *rx_wrr = NULL;
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
        RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter == NULL)
                return -EINVAL;
 
@@ -1111,7 +1335,7 @@ rte_event_eth_rx_adapter_queue_del(uint8_t id, uint8_t eth_dev_id,
                                                &rte_eth_devices[eth_dev_id],
                                                rx_queue_id);
                if (ret == 0) {
-                       update_queue_info(rx_adapter,
+                       rxa_update_queue(rx_adapter,
                                        &rx_adapter->eth_devices[eth_dev_id],
                                        rx_queue_id,
                                        0);
@@ -1121,32 +1345,33 @@ rte_event_eth_rx_adapter_queue_del(uint8_t id, uint8_t eth_dev_id,
                        }
                }
        } else {
-               int rc;
+               rxa_calc_nb_post_del(rx_adapter, dev_info, rx_queue_id,
+                       &nb_rx_poll, &nb_wrr);
+               ret = rxa_alloc_poll_arrays(rx_adapter, nb_rx_poll, nb_wrr,
+                       &rx_poll, &rx_wrr);
+               if (ret)
+                       return ret;
+
                rte_spinlock_lock(&rx_adapter->rx_lock);
-               if (rx_queue_id == -1) {
-                       for (i = 0; i < dev_info->dev->data->nb_rx_queues; i++)
-                               event_eth_rx_adapter_queue_del(rx_adapter,
-                                                       dev_info,
-                                                       i);
-               } else {
-                       event_eth_rx_adapter_queue_del(rx_adapter,
-                                               dev_info,
-                                               (uint16_t)rx_queue_id);
-               }
+               rxa_sw_del(rx_adapter, dev_info, rx_queue_id);
+               rxa_calc_wrr_sequence(rx_adapter, rx_poll, rx_wrr);
 
-               rc = eth_poll_wrr_calc(rx_adapter);
-               if (rc)
-                       RTE_EDEV_LOG_ERR("WRR recalculation failed %" PRId32,
-                                       rc);
+               rte_free(rx_adapter->eth_rx_poll);
+               rte_free(rx_adapter->wrr_sched);
+
+               rx_adapter->eth_rx_poll = rx_poll;
+               rx_adapter->num_rx_polled = nb_rx_poll;
+               rx_adapter->wrr_sched = rx_wrr;
+               rx_adapter->wrr_len = nb_wrr;
 
                if (dev_info->nb_dev_queues == 0) {
                        rte_free(dev_info->rx_queue);
                        dev_info->rx_queue = NULL;
                }
-
                rte_spinlock_unlock(&rx_adapter->rx_lock);
+
                rte_service_component_runstate_set(rx_adapter->service_id,
-                               sw_rx_adapter_queue_count(rx_adapter));
+                               rxa_sw_adapter_queue_count(rx_adapter));
        }
 
        return ret;
@@ -1156,13 +1381,13 @@ rte_event_eth_rx_adapter_queue_del(uint8_t id, uint8_t eth_dev_id,
 int
 rte_event_eth_rx_adapter_start(uint8_t id)
 {
-       return rx_adapter_ctrl(id, 1);
+       return rxa_ctrl(id, 1);
 }
 
 int
 rte_event_eth_rx_adapter_stop(uint8_t id)
 {
-       return rx_adapter_ctrl(id, 0);
+       return rxa_ctrl(id, 0);
 }
 
 int
@@ -1179,7 +1404,7 @@ rte_event_eth_rx_adapter_stats_get(uint8_t id,
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter  == NULL || stats == NULL)
                return -EINVAL;
 
@@ -1217,7 +1442,7 @@ rte_event_eth_rx_adapter_stats_reset(uint8_t id)
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter == NULL)
                return -EINVAL;
 
@@ -1242,7 +1467,7 @@ rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id)
 
        RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
 
-       rx_adapter = id_to_rx_adapter(id);
+       rx_adapter = rxa_id_to_adapter(id);
        if (rx_adapter == NULL || service_id == NULL)
                return -EINVAL;