eal/x86: fix atomic exchange for 32-bit
[dpdk.git] / lib / librte_hash / rte_fbk_hash.c
index 4d67554..c9b470d 100644 (file)
@@ -1,34 +1,5 @@
-/**
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2014 Intel Corporation
  */
 
 #include <stdint.h>
@@ -39,8 +10,6 @@
 
 #include <sys/queue.h>
 #include <rte_memory.h>
-#include <rte_memzone.h>
-#include <rte_tailq.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_malloc.h>
 
 #include "rte_fbk_hash.h"
 
-TAILQ_HEAD(rte_fbk_hash_list, rte_fbk_hash_table);
+TAILQ_HEAD(rte_fbk_hash_list, rte_tailq_entry);
+
+static struct rte_tailq_elem rte_fbk_hash_tailq = {
+       .name = "RTE_FBK_HASH",
+};
+EAL_REGISTER_TAILQ(rte_fbk_hash_tailq)
 
 /**
  * Performs a lookup for an existing hash table, and returns a pointer to
@@ -69,24 +43,24 @@ TAILQ_HEAD(rte_fbk_hash_list, rte_fbk_hash_table);
 struct rte_fbk_hash_table *
 rte_fbk_hash_find_existing(const char *name)
 {
-       struct rte_fbk_hash_table *h;
+       struct rte_fbk_hash_table *h = NULL;
+       struct rte_tailq_entry *te;
        struct rte_fbk_hash_list *fbk_hash_list;
 
-       /* check that we have an initialised tail queue */
-       if ((fbk_hash_list =
-            RTE_TAILQ_LOOKUP_BY_IDX(RTE_TAILQ_FBK_HASH, rte_fbk_hash_list)) == NULL) {
-               rte_errno = E_RTE_NO_TAILQ;
-               return NULL;
-       }
+       fbk_hash_list = RTE_TAILQ_CAST(rte_fbk_hash_tailq.head,
+                                      rte_fbk_hash_list);
 
        rte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);
-       TAILQ_FOREACH(h, fbk_hash_list, next) {
+       TAILQ_FOREACH(te, fbk_hash_list, next) {
+               h = (struct rte_fbk_hash_table *) te->data;
                if (strncmp(name, h->name, RTE_FBK_HASH_NAMESIZE) == 0)
                        break;
        }
        rte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);
-       if (h == NULL)
+       if (te == NULL) {
                rte_errno = ENOENT;
+               return NULL;
+       }
        return h;
 }
 
@@ -104,18 +78,16 @@ struct rte_fbk_hash_table *
 rte_fbk_hash_create(const struct rte_fbk_hash_params *params)
 {
        struct rte_fbk_hash_table *ht = NULL;
+       struct rte_tailq_entry *te;
        char hash_name[RTE_FBK_HASH_NAMESIZE];
        const uint32_t mem_size =
                        sizeof(*ht) + (sizeof(ht->t[0]) * params->entries);
        uint32_t i;
        struct rte_fbk_hash_list *fbk_hash_list;
+       rte_fbk_hash_fn default_hash_func = (rte_fbk_hash_fn)rte_jhash_1word;
 
-       /* check that we have an initialised tail queue */
-       if ((fbk_hash_list =
-            RTE_TAILQ_LOOKUP_BY_IDX(RTE_TAILQ_FBK_HASH, rte_fbk_hash_list)) == NULL) {
-               rte_errno = E_RTE_NO_TAILQ;
-               return NULL;
-       }
+       fbk_hash_list = RTE_TAILQ_CAST(rte_fbk_hash_tailq.head,
+                                      rte_fbk_hash_list);
 
        /* Error checking of parameters. */
        if ((!rte_is_power_of_2(params->entries)) ||
@@ -129,28 +101,47 @@ rte_fbk_hash_create(const struct rte_fbk_hash_params *params)
                return NULL;
        }
 
-       rte_snprintf(hash_name, sizeof(hash_name), "FBK_%s", params->name);
+       snprintf(hash_name, sizeof(hash_name), "FBK_%s", params->name);
 
        rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
 
        /* guarantee there's no existing */
-       TAILQ_FOREACH(ht, fbk_hash_list, next) {
+       TAILQ_FOREACH(te, fbk_hash_list, next) {
+               ht = (struct rte_fbk_hash_table *) te->data;
                if (strncmp(params->name, ht->name, RTE_FBK_HASH_NAMESIZE) == 0)
                        break;
        }
-       if (ht != NULL)
+       ht = NULL;
+       if (te != NULL) {
+               rte_errno = EEXIST;
+               goto exit;
+       }
+
+       te = rte_zmalloc("FBK_HASH_TAILQ_ENTRY", sizeof(*te), 0);
+       if (te == NULL) {
+               RTE_LOG(ERR, HASH, "Failed to allocate tailq entry\n");
                goto exit;
+       }
 
        /* Allocate memory for table. */
-       ht = (struct rte_fbk_hash_table *)rte_malloc_socket(hash_name, mem_size,
+       ht = rte_zmalloc_socket(hash_name, mem_size,
                        0, params->socket_id);
-       if (ht == NULL)
+       if (ht == NULL) {
+               RTE_LOG(ERR, HASH, "Failed to allocate fbk hash table\n");
+               rte_free(te);
                goto exit;
+       }
 
-       memset(ht, 0, mem_size);
+       /* Default hash function */
+#if defined(RTE_ARCH_X86)
+       default_hash_func = (rte_fbk_hash_fn)rte_hash_crc_4byte;
+#elif defined(RTE_ARCH_ARM64)
+       if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_CRC32))
+               default_hash_func = (rte_fbk_hash_fn)rte_hash_crc_4byte;
+#endif
 
        /* Set up hash table context. */
-       rte_snprintf(ht->name, sizeof(ht->name), "%s", params->name);
+       snprintf(ht->name, sizeof(ht->name), "%s", params->name);
        ht->entries = params->entries;
        ht->entries_per_bucket = params->entries_per_bucket;
        ht->used_entries = 0;
@@ -165,11 +156,13 @@ rte_fbk_hash_create(const struct rte_fbk_hash_params *params)
                ht->init_val = params->init_val;
        }
        else {
-               ht->hash_func = RTE_FBK_HASH_FUNC_DEFAULT;
+               ht->hash_func = default_hash_func;
                ht->init_val = RTE_FBK_HASH_INIT_VAL_DEFAULT;
        }
 
-       TAILQ_INSERT_TAIL(fbk_hash_list, ht, next);
+       te->data = (void *) ht;
+
+       TAILQ_INSERT_TAIL(fbk_hash_list, te, next);
 
 exit:
        rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
@@ -186,10 +179,32 @@ exit:
 void
 rte_fbk_hash_free(struct rte_fbk_hash_table *ht)
 {
+       struct rte_tailq_entry *te;
+       struct rte_fbk_hash_list *fbk_hash_list;
+
        if (ht == NULL)
                return;
 
-       RTE_EAL_TAILQ_REMOVE(RTE_TAILQ_FBK_HASH, rte_fbk_hash_list, ht);
+       fbk_hash_list = RTE_TAILQ_CAST(rte_fbk_hash_tailq.head,
+                                      rte_fbk_hash_list);
+
+       rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+
+       /* find out tailq entry */
+       TAILQ_FOREACH(te, fbk_hash_list, next) {
+               if (te->data == (void *) ht)
+                       break;
+       }
+
+       if (te == NULL) {
+               rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+               return;
+       }
+
+       TAILQ_REMOVE(fbk_hash_list, te, next);
+
+       rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+
        rte_free(ht);
+       rte_free(te);
 }
-