ethdev: fix missing imissed counter in xstats

[dpdk.git] / lib / librte_ip_frag / rte_ipv4_fragmentation.c

diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
index 0b10310..8c5f5ec 100644 (file)
--- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c
+++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
@@ -48,7 +48,7 @@
 #define        IPV4_HDR_DF_MASK                        (1 << IPV4_HDR_DF_SHIFT)
 #define        IPV4_HDR_MF_MASK                        (1 << IPV4_HDR_MF_SHIFT)
 
-#define        IPV4_HDR_FO_MASK                        ((1 << IPV4_HDR_FO_SHIFT) - 1)
+#define        IPV4_HDR_FO_ALIGN                       (1 << IPV4_HDR_FO_SHIFT)
 
 static inline void __fill_ipv4hdr_frag(struct ipv4_hdr *dst,
                const struct ipv4_hdr *src, uint16_t len, uint16_t fofs,
@@ -103,13 +103,16 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
        uint32_t out_pkt_pos, in_seg_data_pos;
        uint32_t more_in_segs;
        uint16_t fragment_offset, flag_offset, frag_size;
+       uint16_t frag_bytes_remaining;
 
-       frag_size = (uint16_t)(mtu_size - sizeof(struct ipv4_hdr));
+       /*
+        * Ensure the IP payload length of all fragments is aligned to a
+        * multiple of 8 bytes as per RFC791 section 2.3.
+        */
+       frag_size = RTE_ALIGN_FLOOR((mtu_size - sizeof(struct ipv4_hdr)),
+                                   IPV4_HDR_FO_ALIGN);
 
-       /* Fragment size should be a multiply of 8. */
-       IP_FRAG_ASSERT((frag_size & IPV4_HDR_FO_MASK) == 0);
-
-       in_hdr = (struct ipv4_hdr *) pkt_in->data;
+       in_hdr = rte_pktmbuf_mtod(pkt_in, struct ipv4_hdr *);
        flag_offset = rte_cpu_to_be_16(in_hdr->fragment_offset);
 
        /* If Don't Fragment flag is set */
@@ -142,6 +145,7 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
                /* Reserve space for the IP header that will be built later */
                out_pkt->data_len = sizeof(struct ipv4_hdr);
                out_pkt->pkt_len = sizeof(struct ipv4_hdr);
+               frag_bytes_remaining = frag_size;
 
                out_seg_prev = out_pkt;
                more_out_segs = 1;
@@ -161,19 +165,20 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
 
                        /* Prepare indirect buffer */
                        rte_pktmbuf_attach(out_seg, in_seg);
-                       len = mtu_size - out_pkt->pkt_len;
+                       len = frag_bytes_remaining;
                        if (len > (in_seg->data_len - in_seg_data_pos)) {
                                len = in_seg->data_len - in_seg_data_pos;
                        }
-                       out_seg->data = (char*) in_seg->data + (uint16_t)in_seg_data_pos;
+                       out_seg->data_off = in_seg->data_off + in_seg_data_pos;
                        out_seg->data_len = (uint16_t)len;
                        out_pkt->pkt_len = (uint16_t)(len +
                            out_pkt->pkt_len);
                        out_pkt->nb_segs += 1;
                        in_seg_data_pos += len;
+                       frag_bytes_remaining -= len;
 
                        /* Current output packet (i.e. fragment) done ? */
-                       if (unlikely(out_pkt->pkt_len >= mtu_size))
+                       if (unlikely(frag_bytes_remaining == 0))
                                more_out_segs = 0;
 
                        /* Current input segment done ? */
@@ -188,7 +193,7 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
 
                /* Build the IP header */
 
-               out_hdr = (struct ipv4_hdr*) out_pkt->data;
+               out_hdr = rte_pktmbuf_mtod(out_pkt, struct ipv4_hdr *);
 
                __fill_ipv4hdr_frag(out_hdr, in_hdr,
                    (uint16_t)out_pkt->pkt_len,
@@ -198,7 +203,7 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
                    out_pkt->pkt_len - sizeof(struct ipv4_hdr));
 
                out_pkt->ol_flags |= PKT_TX_IP_CKSUM;
-               out_pkt->vlan_macip.f.l3_len = sizeof(struct ipv4_hdr);
+               out_pkt->l3_len = sizeof(struct ipv4_hdr);
 
                /* Write the fragment to the output list */
                pkts_out[out_pkt_pos] = out_pkt;