pci: explain how empty strings are rejected in DBDF

[dpdk.git] / lib / librte_pci / rte_pci.c

diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
index 5f7726f..9c80c4b 100644 (file)
--- a/lib/librte_pci/rte_pci.c
+++ b/lib/librte_pci/rte_pci.c
@@ -84,6 +84,10 @@ pci_dbdf_parse(const char *input, struct rte_pci_addr *dev_addr)
 
        errno = 0;
        val = strtoul(in, &end, 16);
+       /* Empty string is not an error for strtoul, but the check
+        *   end[0] != ':'
+        * will detect the issue.
+        */
        if (errno != 0 || end[0] != ':' || val > UINT32_MAX)
                return -EINVAL;
        dev_addr->domain = (uint32_t)val;