i40e: VXLAN Tx checksum offload
[dpdk.git] / lib / librte_pmd_i40e / i40e_rxtx.c
index 0360617..7599df9 100644 (file)
@@ -208,34 +208,34 @@ i40e_rxd_ptype_to_pkt_flags(uint64_t qword)
                PKT_RX_IPV4_HDR_EXT, /* PTYPE 56 */
                PKT_RX_IPV4_HDR_EXT, /* PTYPE 57 */
                PKT_RX_IPV4_HDR_EXT, /* PTYPE 58 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 59 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 60 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 61 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 59 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 60 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 61 */
                0, /* PTYPE 62 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 63 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 64 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 65 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 66 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 67 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 68 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 63 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 64 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 65 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 66 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 67 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 68 */
                0, /* PTYPE 69 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 70 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 71 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 72 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 73 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 74 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 75 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 76 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 70 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 71 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 72 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 73 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 74 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 75 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 76 */
                0, /* PTYPE 77 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 78 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 79 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 80 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 81 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 82 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 83 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 78 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 79 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 80 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 81 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 82 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 83 */
                0, /* PTYPE 84 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 85 */
-               PKT_RX_IPV4_HDR_EXT, /* PTYPE 86 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 85 */
+               PKT_RX_TUNNEL_IPV4_HDR, /* PTYPE 86 */
                PKT_RX_IPV4_HDR_EXT, /* PTYPE 87 */
                PKT_RX_IPV6_HDR, /* PTYPE 88 */
                PKT_RX_IPV6_HDR, /* PTYPE 89 */
@@ -274,34 +274,34 @@ i40e_rxd_ptype_to_pkt_flags(uint64_t qword)
                PKT_RX_IPV6_HDR_EXT, /* PTYPE 122 */
                PKT_RX_IPV6_HDR_EXT, /* PTYPE 123 */
                PKT_RX_IPV6_HDR_EXT, /* PTYPE 124 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 125 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 126 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 127 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 125 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 126 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 127 */
                0, /* PTYPE 128 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 129 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 130 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 131 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 132 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 133 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 134 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 129 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 130 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 131 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 132 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 133 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 134 */
                0, /* PTYPE 135 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 136 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 137 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 138 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 139 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 140 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 141 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 142 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 136 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 137 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 138 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 139 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 140 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 141 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 142 */
                0, /* PTYPE 143 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 144 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 145 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 146 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 147 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 148 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 149 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 144 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 145 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 146 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 147 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 148 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 149 */
                0, /* PTYPE 150 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 151 */
-               PKT_RX_IPV6_HDR_EXT, /* PTYPE 152 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 151 */
+               PKT_RX_TUNNEL_IPV6_HDR, /* PTYPE 152 */
                PKT_RX_IPV6_HDR_EXT, /* PTYPE 153 */
                0, /* PTYPE 154 */
                0, /* PTYPE 155 */
@@ -411,23 +411,47 @@ i40e_rxd_ptype_to_pkt_flags(uint64_t qword)
 }
 
 static inline void
-i40e_txd_enable_checksum(uint32_t ol_flags,
+i40e_txd_enable_checksum(uint64_t ol_flags,
                        uint32_t *td_cmd,
                        uint32_t *td_offset,
                        uint8_t l2_len,
-                       uint8_t l3_len)
+                       uint16_t l3_len,
+                       uint8_t inner_l2_len,
+                       uint16_t inner_l3_len,
+                       uint32_t *cd_tunneling)
 {
        if (!l2_len) {
-               PMD_DRV_LOG(DEBUG, "L2 length set to 0\n");
+               PMD_DRV_LOG(DEBUG, "L2 length set to 0");
                return;
        }
        *td_offset |= (l2_len >> 1) << I40E_TX_DESC_LENGTH_MACLEN_SHIFT;
 
        if (!l3_len) {
-               PMD_DRV_LOG(DEBUG, "L3 length set to 0\n");
+               PMD_DRV_LOG(DEBUG, "L3 length set to 0");
                return;
        }
 
+       /* VxLAN packet TX checksum offload */
+       if (unlikely(ol_flags & PKT_TX_VXLAN_CKSUM)) {
+               uint8_t l4tun_len;
+
+               l4tun_len = ETHER_VXLAN_HLEN + inner_l2_len;
+
+               if (ol_flags & PKT_TX_IPV4_CSUM)
+                       *cd_tunneling |= I40E_TX_CTX_EXT_IP_IPV4;
+               else if (ol_flags & PKT_TX_IPV6)
+                       *cd_tunneling |= I40E_TX_CTX_EXT_IP_IPV6;
+
+               /* Now set the ctx descriptor fields */
+               *cd_tunneling |= (l3_len >> 2) <<
+                               I40E_TXD_CTX_QW0_EXT_IPLEN_SHIFT |
+                               I40E_TXD_CTX_UDP_TUNNELING |
+                               (l4tun_len >> 1) <<
+                               I40E_TXD_CTX_QW0_NATLEN_SHIFT;
+
+               l3_len = inner_l3_len;
+       }
+
        /* Enable L3 checksum offloads */
        if (ol_flags & PKT_TX_IPV4_CSUM) {
                *td_cmd |= I40E_TX_DESC_CMD_IIPT_IPV4_CSUM;
@@ -535,15 +559,34 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused struct i40e_rx_queue *rxq)
        int ret = 0;
 
 #ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
-       if (!(rxq->rx_free_thresh >= RTE_PMD_I40E_RX_MAX_BURST))
+       if (!(rxq->rx_free_thresh >= RTE_PMD_I40E_RX_MAX_BURST)) {
+               PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+                            "rxq->rx_free_thresh=%d, "
+                            "RTE_PMD_I40E_RX_MAX_BURST=%d",
+                            rxq->rx_free_thresh, RTE_PMD_I40E_RX_MAX_BURST);
                ret = -EINVAL;
-       else if (!(rxq->rx_free_thresh < rxq->nb_rx_desc))
+       } else if (!(rxq->rx_free_thresh < rxq->nb_rx_desc)) {
+               PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+                            "rxq->rx_free_thresh=%d, "
+                            "rxq->nb_rx_desc=%d",
+                            rxq->rx_free_thresh, rxq->nb_rx_desc);
                ret = -EINVAL;
-       else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) == 0)
+       } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) == 0) {
+               PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+                            "rxq->nb_rx_desc=%d, "
+                            "rxq->rx_free_thresh=%d",
+                            rxq->nb_rx_desc, rxq->rx_free_thresh);
                ret = -EINVAL;
-       else if (!(rxq->nb_rx_desc < (I40E_MAX_RING_DESC -
-                               RTE_PMD_I40E_RX_MAX_BURST)))
+       } else if (!(rxq->nb_rx_desc < (I40E_MAX_RING_DESC -
+                               RTE_PMD_I40E_RX_MAX_BURST))) {
+               PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+                            "rxq->nb_rx_desc=%d, "
+                            "I40E_MAX_RING_DESC=%d, "
+                            "RTE_PMD_I40E_RX_MAX_BURST=%d",
+                            rxq->nb_rx_desc, I40E_MAX_RING_DESC,
+                            RTE_PMD_I40E_RX_MAX_BURST);
                ret = -EINVAL;
+       }
 #else
        ret = -EINVAL;
 #endif
@@ -619,6 +662,10 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)
                        pkt_flags |= i40e_rxd_error_to_pkt_flags(qword1);
                        pkt_flags |= i40e_rxd_ptype_to_pkt_flags(qword1);
                        mb->ol_flags = pkt_flags;
+
+                       mb->packet_type = (uint16_t)((qword1 &
+                                       I40E_RXD_QW1_PTYPE_MASK) >>
+                                       I40E_RXD_QW1_PTYPE_SHIFT);
                        if (pkt_flags & PKT_RX_RSS_HASH)
                                mb->hash.rss = rte_le_to_cpu_32(\
                                        rxdp->wb.qword0.hi_dword.rss);
@@ -674,7 +721,7 @@ i40e_rx_alloc_bufs(struct i40e_rx_queue *rxq)
        diag = rte_mempool_get_bulk(rxq->mp, (void *)rxep,
                                        rxq->rx_free_thresh);
        if (unlikely(diag != 0)) {
-               PMD_DRV_LOG(ERR, "Failed to get mbufs in bulk\n");
+               PMD_DRV_LOG(ERR, "Failed to get mbufs in bulk");
                return -ENOMEM;
        }
 
@@ -726,8 +773,8 @@ rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                        uint16_t i, j;
 
                        PMD_RX_LOG(DEBUG, "Rx mbuf alloc failed for "
-                                       "port_id=%u, queue_id=%u\n",
-                                       rxq->port_id, rxq->queue_id);
+                                  "port_id=%u, queue_id=%u",
+                                  rxq->port_id, rxq->queue_id);
                        rxq->rx_nb_avail = 0;
                        rxq->rx_tail = (uint16_t)(rxq->rx_tail - nb_rx);
                        for (i = 0, j = rxq->rx_tail; i < nb_rx; i++, j++)
@@ -854,6 +901,8 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                pkt_flags = i40e_rxd_status_to_pkt_flags(qword1);
                pkt_flags |= i40e_rxd_error_to_pkt_flags(qword1);
                pkt_flags |= i40e_rxd_ptype_to_pkt_flags(qword1);
+               rxm->packet_type = (uint16_t)((qword1 & I40E_RXD_QW1_PTYPE_MASK) >>
+                               I40E_RXD_QW1_PTYPE_SHIFT);
                rxm->ol_flags = pkt_flags;
                if (pkt_flags & PKT_RX_RSS_HASH)
                        rxm->hash.rss =
@@ -1008,6 +1057,9 @@ i40e_recv_scattered_pkts(void *rx_queue,
                pkt_flags = i40e_rxd_status_to_pkt_flags(qword1);
                pkt_flags |= i40e_rxd_error_to_pkt_flags(qword1);
                pkt_flags |= i40e_rxd_ptype_to_pkt_flags(qword1);
+               first_seg->packet_type = (uint16_t)((qword1 &
+                                       I40E_RXD_QW1_PTYPE_MASK) >>
+                                       I40E_RXD_QW1_PTYPE_SHIFT);
                first_seg->ol_flags = pkt_flags;
                if (pkt_flags & PKT_RX_RSS_HASH)
                        rxm->hash.rss =
@@ -1049,7 +1101,10 @@ i40e_recv_scattered_pkts(void *rx_queue,
 static inline uint16_t
 i40e_calc_context_desc(uint64_t flags)
 {
-       uint16_t mask = 0;
+       uint64_t mask = 0ULL;
+
+       if (flags | PKT_TX_VXLAN_CKSUM)
+               mask |= PKT_TX_VXLAN_CKSUM;
 
 #ifdef RTE_LIBRTE_IEEE1588
        mask |= PKT_TX_IEEE1588_TMST;
@@ -1070,6 +1125,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
        volatile struct i40e_tx_desc *txr;
        struct rte_mbuf *tx_pkt;
        struct rte_mbuf *m_seg;
+       uint32_t cd_tunneling_params;
        uint16_t tx_id;
        uint16_t nb_tx;
        uint32_t td_cmd;
@@ -1078,7 +1134,9 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
        uint32_t td_tag;
        uint64_t ol_flags;
        uint8_t l2_len;
-       uint8_t l3_len;
+       uint16_t l3_len;
+       uint8_t inner_l2_len;
+       uint16_t inner_l3_len;
        uint16_t nb_used;
        uint16_t nb_ctx;
        uint16_t tx_last;
@@ -1106,7 +1164,9 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 
                ol_flags = tx_pkt->ol_flags;
                l2_len = tx_pkt->l2_len;
+               inner_l2_len = tx_pkt->inner_l2_len;
                l3_len = tx_pkt->l3_len;
+               inner_l3_len = tx_pkt->inner_l3_len;
 
                /* Calculate the number of context descriptors needed. */
                nb_ctx = i40e_calc_context_desc(ol_flags);
@@ -1154,15 +1214,17 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
                td_cmd |= I40E_TX_DESC_CMD_ICRC;
 
                /* Enable checksum offloading */
+               cd_tunneling_params = 0;
                i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset,
-                                                       l2_len, l3_len);
+                                               l2_len, l3_len, inner_l2_len,
+                                               inner_l3_len,
+                                               &cd_tunneling_params);
 
                if (unlikely(nb_ctx)) {
                        /* Setup TX context descriptor if required */
                        volatile struct i40e_tx_context_desc *ctx_txd =
                                (volatile struct i40e_tx_context_desc *)\
                                                        &txr[tx_id];
-                       uint32_t cd_tunneling_params = 0;
                        uint16_t cd_l2tag2 = 0;
                        uint64_t cd_type_cmd_tso_mss =
                                I40E_TX_DESC_DTYPE_CONTEXT;
@@ -1440,7 +1502,7 @@ i40e_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 
                err = i40e_alloc_rx_queue_mbufs(rxq);
                if (err) {
-                       PMD_DRV_LOG(ERR, "Failed to allocate RX queue mbuf\n");
+                       PMD_DRV_LOG(ERR, "Failed to allocate RX queue mbuf");
                        return err;
                }
 
@@ -1452,8 +1514,8 @@ i40e_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                err = i40e_switch_rx_queue(hw, rx_queue_id + q_base, TRUE);
 
                if (err) {
-                       PMD_DRV_LOG(ERR, "Failed to switch RX queue %u on\n",
-                               rx_queue_id);
+                       PMD_DRV_LOG(ERR, "Failed to switch RX queue %u on",
+                                   rx_queue_id);
 
                        i40e_rx_queue_release_mbufs(rxq);
                        i40e_reset_rx_queue(rxq);
@@ -1478,8 +1540,8 @@ i40e_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                err = i40e_switch_rx_queue(hw, rx_queue_id + q_base, FALSE);
 
                if (err) {
-                       PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off\n",
-                               rx_queue_id);
+                       PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off",
+                                   rx_queue_id);
                        return err;
                }
                i40e_rx_queue_release_mbufs(rxq);
@@ -1502,8 +1564,8 @@ i40e_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
        if (tx_queue_id < dev->data->nb_tx_queues) {
                err = i40e_switch_tx_queue(hw, tx_queue_id + q_base, TRUE);
                if (err)
-                       PMD_DRV_LOG(ERR, "Failed to switch TX queue %u on\n",
-                               tx_queue_id);
+                       PMD_DRV_LOG(ERR, "Failed to switch TX queue %u on",
+                                   tx_queue_id);
        }
 
        return err;
@@ -1524,8 +1586,8 @@ i40e_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
                err = i40e_switch_tx_queue(hw, tx_queue_id + q_base, FALSE);
 
                if (err) {
-                       PMD_DRV_LOG(ERR, "Failed to switch TX queue %u of\n",
-                               tx_queue_id);
+                       PMD_DRV_LOG(ERR, "Failed to switch TX queue %u of",
+                                   tx_queue_id);
                        return err;
                }
 
@@ -1553,14 +1615,14 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
 
        if (!vsi || queue_idx >= vsi->nb_qps) {
                PMD_DRV_LOG(ERR, "VSI not available or queue "
-                               "index exceeds the maximum\n");
+                           "index exceeds the maximum");
                return I40E_ERR_PARAM;
        }
        if (((nb_desc * sizeof(union i40e_rx_desc)) % I40E_ALIGN) != 0 ||
                                        (nb_desc > I40E_MAX_RING_DESC) ||
                                        (nb_desc < I40E_MIN_RING_DESC)) {
                PMD_DRV_LOG(ERR, "Number (%u) of receive descriptors is "
-                                               "invalid\n", nb_desc);
+                           "invalid", nb_desc);
                return I40E_ERR_PARAM;
        }
 
@@ -1577,7 +1639,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
                                 socket_id);
        if (!rxq) {
                PMD_DRV_LOG(ERR, "Failed to allocate memory for "
-                                       "rx queue data structure\n");
+                           "rx queue data structure");
                return (-ENOMEM);
        }
        rxq->mp = mp;
@@ -1590,7 +1652,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
                                                        0 : ETHER_CRC_LEN);
        rxq->drop_en = rx_conf->rx_drop_en;
        rxq->vsi = vsi;
-       rxq->start_rx_per_q = rx_conf->start_rx_per_q;
+       rxq->rx_deferred_start = rx_conf->rx_deferred_start;
 
        /* Allocate the maximun number of RX ring hardware descriptor. */
        ring_size = sizeof(union i40e_rx_desc) * I40E_MAX_RING_DESC;
@@ -1602,7 +1664,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
                                        socket_id);
        if (!rz) {
                i40e_dev_rx_queue_release(rxq);
-               PMD_DRV_LOG(ERR, "Failed to reserve DMA memory for RX\n");
+               PMD_DRV_LOG(ERR, "Failed to reserve DMA memory for RX");
                return (-ENOMEM);
        }
 
@@ -1631,7 +1693,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
                                   socket_id);
        if (!rxq->sw_ring) {
                i40e_dev_rx_queue_release(rxq);
-               PMD_DRV_LOG(ERR, "Failed to allocate memory for SW ring\n");
+               PMD_DRV_LOG(ERR, "Failed to allocate memory for SW ring");
                return (-ENOMEM);
        }
 
@@ -1644,17 +1706,17 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
        if (!use_def_burst_func && !dev->data->scattered_rx) {
 #ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
                PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
-                       "satisfied. Rx Burst Bulk Alloc function will be "
-                                       "used on port=%d, queue=%d.\n",
-                                       rxq->port_id, rxq->queue_id);
+                            "satisfied. Rx Burst Bulk Alloc function will be "
+                            "used on port=%d, queue=%d.",
+                            rxq->port_id, rxq->queue_id);
                dev->rx_pkt_burst = i40e_recv_pkts_bulk_alloc;
 #endif /* RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC */
        } else {
                PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
-                               "not satisfied, Scattered Rx is requested, "
-                               "or RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC is "
-                                       "not enabled on port=%d, queue=%d.\n",
-                                               rxq->port_id, rxq->queue_id);
+                            "not satisfied, Scattered Rx is requested, "
+                            "or RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC is "
+                            "not enabled on port=%d, queue=%d.",
+                            rxq->port_id, rxq->queue_id);
        }
 
        return 0;
@@ -1666,7 +1728,7 @@ i40e_dev_rx_queue_release(void *rxq)
        struct i40e_rx_queue *q = (struct i40e_rx_queue *)rxq;
 
        if (!q) {
-               PMD_DRV_LOG(DEBUG, "Pointer to rxq is NULL\n");
+               PMD_DRV_LOG(DEBUG, "Pointer to rxq is NULL");
                return;
        }
 
@@ -1684,7 +1746,7 @@ i40e_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        uint16_t desc = 0;
 
        if (unlikely(rx_queue_id >= dev->data->nb_rx_queues)) {
-               PMD_DRV_LOG(ERR, "Invalid RX queue id %u\n", rx_queue_id);
+               PMD_DRV_LOG(ERR, "Invalid RX queue id %u", rx_queue_id);
                return 0;
        }
 
@@ -1718,7 +1780,7 @@ i40e_dev_rx_descriptor_done(void *rx_queue, uint16_t offset)
        int ret;
 
        if (unlikely(offset >= rxq->nb_rx_desc)) {
-               PMD_DRV_LOG(ERR, "Invalid RX queue id %u\n", offset);
+               PMD_DRV_LOG(ERR, "Invalid RX queue id %u", offset);
                return 0;
        }
 
@@ -1750,7 +1812,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 
        if (!vsi || queue_idx >= vsi->nb_qps) {
                PMD_DRV_LOG(ERR, "VSI is NULL, or queue index (%u) "
-                               "exceeds the maximum\n", queue_idx);
+                           "exceeds the maximum", queue_idx);
                return I40E_ERR_PARAM;
        }
 
@@ -1758,7 +1820,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                        (nb_desc > I40E_MAX_RING_DESC) ||
                                        (nb_desc < I40E_MIN_RING_DESC)) {
                PMD_DRV_LOG(ERR, "Number (%u) of transmit descriptors is "
-                                                "invalid\n", nb_desc);
+                           "invalid", nb_desc);
                return I40E_ERR_PARAM;
        }
 
@@ -1847,7 +1909,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                  socket_id);
        if (!txq) {
                PMD_DRV_LOG(ERR, "Failed to allocate memory for "
-                                       "tx queue structure\n");
+                           "tx queue structure");
                return (-ENOMEM);
        }
 
@@ -1861,7 +1923,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                        socket_id);
        if (!tz) {
                i40e_dev_tx_queue_release(txq);
-               PMD_DRV_LOG(ERR, "Failed to reserve DMA memory for TX\n");
+               PMD_DRV_LOG(ERR, "Failed to reserve DMA memory for TX");
                return (-ENOMEM);
        }
 
@@ -1876,7 +1938,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
        txq->port_id = dev->data->port_id;
        txq->txq_flags = tx_conf->txq_flags;
        txq->vsi = vsi;
-       txq->start_tx_per_q = tx_conf->start_tx_per_q;
+       txq->tx_deferred_start = tx_conf->tx_deferred_start;
 
 #ifdef RTE_LIBRTE_XEN_DOM0
        txq->tx_ring_phys_addr = rte_mem_phy2mch(tz->memseg_id, tz->phys_addr);
@@ -1893,7 +1955,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                   socket_id);
        if (!txq->sw_ring) {
                i40e_dev_tx_queue_release(txq);
-               PMD_DRV_LOG(ERR, "Failed to allocate memory for SW TX ring\n");
+               PMD_DRV_LOG(ERR, "Failed to allocate memory for SW TX ring");
                return (-ENOMEM);
        }
 
@@ -1904,10 +1966,10 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
        /* Use a simple TX queue without offloads or multi segs if possible */
        if (((txq->txq_flags & I40E_SIMPLE_FLAGS) == I40E_SIMPLE_FLAGS) &&
                                (txq->tx_rs_thresh >= I40E_TX_MAX_BURST)) {
-               PMD_INIT_LOG(INFO, "Using simple tx path\n");
+               PMD_INIT_LOG(INFO, "Using simple tx path");
                dev->tx_pkt_burst = i40e_xmit_pkts_simple;
        } else {
-               PMD_INIT_LOG(INFO, "Using full-featured tx path\n");
+               PMD_INIT_LOG(INFO, "Using full-featured tx path");
                dev->tx_pkt_burst = i40e_xmit_pkts;
        }
 
@@ -1920,7 +1982,7 @@ i40e_dev_tx_queue_release(void *txq)
        struct i40e_tx_queue *q = (struct i40e_tx_queue *)txq;
 
        if (!q) {
-               PMD_DRV_LOG(DEBUG, "Pointer to TX queue is NULL\n");
+               PMD_DRV_LOG(DEBUG, "Pointer to TX queue is NULL");
                return;
        }
 
@@ -1961,7 +2023,7 @@ i40e_rx_queue_release_mbufs(struct i40e_rx_queue *rxq)
        uint16_t i;
 
        if (!rxq || !rxq->sw_ring) {
-               PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL\n");
+               PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL");
                return;
        }
 
@@ -2021,7 +2083,7 @@ i40e_tx_queue_release_mbufs(struct i40e_tx_queue *txq)
        uint16_t i;
 
        if (!txq || !txq->sw_ring) {
-               PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL\n");
+               PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL");
                return;
        }
 
@@ -2040,7 +2102,7 @@ i40e_reset_tx_queue(struct i40e_tx_queue *txq)
        uint16_t i, prev, size;
 
        if (!txq) {
-               PMD_DRV_LOG(DEBUG, "Pointer to txq is NULL\n");
+               PMD_DRV_LOG(DEBUG, "Pointer to txq is NULL");
                return;
        }
 
@@ -2053,7 +2115,7 @@ i40e_reset_tx_queue(struct i40e_tx_queue *txq)
        for (i = 0; i < txq->nb_tx_desc; i++) {
                volatile struct i40e_tx_desc *txd = &txq->tx_ring[i];
 
-               txd[i].cmd_type_offset_bsz =
+               txd->cmd_type_offset_bsz =
                        rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE);
                txe[i].mbuf =  NULL;
                txe[i].last_id = i;
@@ -2091,13 +2153,13 @@ i40e_tx_queue_init(struct i40e_tx_queue *txq)
 
        err = i40e_clear_lan_tx_queue_context(hw, pf_q);
        if (err != I40E_SUCCESS) {
-               PMD_DRV_LOG(ERR, "Failure of clean lan tx queue context\n");
+               PMD_DRV_LOG(ERR, "Failure of clean lan tx queue context");
                return err;
        }
 
        err = i40e_set_lan_tx_queue_context(hw, pf_q, &tx_ctx);
        if (err != I40E_SUCCESS) {
-               PMD_DRV_LOG(ERR, "Failure of set lan tx queue context\n");
+               PMD_DRV_LOG(ERR, "Failure of set lan tx queue context");
                return err;
        }
 
@@ -2125,7 +2187,7 @@ i40e_alloc_rx_queue_mbufs(struct i40e_rx_queue *rxq)
                struct rte_mbuf *mbuf = rte_rxmbuf_alloc(rxq->mp);
 
                if (unlikely(!mbuf)) {
-                       PMD_DRV_LOG(ERR, "Failed to allocate mbuf for RX\n");
+                       PMD_DRV_LOG(ERR, "Failed to allocate mbuf for RX");
                        return -ENOMEM;
                }
 
@@ -2192,20 +2254,20 @@ i40e_rx_queue_config(struct i40e_rx_queue *rxq)
                if (rxq->max_pkt_len <= ETHER_MAX_LEN ||
                        rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
                        PMD_DRV_LOG(ERR, "maximum packet length must "
-                               "be larger than %u and smaller than %u,"
-                                       "as jumbo frame is enabled\n",
-                                               (uint32_t)ETHER_MAX_LEN,
-                                       (uint32_t)I40E_FRAME_SIZE_MAX);
+                                   "be larger than %u and smaller than %u,"
+                                   "as jumbo frame is enabled",
+                                   (uint32_t)ETHER_MAX_LEN,
+                                   (uint32_t)I40E_FRAME_SIZE_MAX);
                        return I40E_ERR_CONFIG;
                }
        } else {
                if (rxq->max_pkt_len < ETHER_MIN_LEN ||
                        rxq->max_pkt_len > ETHER_MAX_LEN) {
                        PMD_DRV_LOG(ERR, "maximum packet length must be "
-                                       "larger than %u and smaller than %u, "
-                                       "as jumbo frame is disabled\n",
-                                               (uint32_t)ETHER_MIN_LEN,
-                                               (uint32_t)ETHER_MAX_LEN);
+                                   "larger than %u and smaller than %u, "
+                                   "as jumbo frame is disabled",
+                                   (uint32_t)ETHER_MIN_LEN,
+                                   (uint32_t)ETHER_MAX_LEN);
                        return I40E_ERR_CONFIG;
                }
        }
@@ -2228,7 +2290,7 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq)
 
        err = i40e_rx_queue_config(rxq);
        if (err < 0) {
-               PMD_DRV_LOG(ERR, "Failed to config RX queue\n");
+               PMD_DRV_LOG(ERR, "Failed to config RX queue");
                return err;
        }
 
@@ -2260,12 +2322,12 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq)
 
        err = i40e_clear_lan_rx_queue_context(hw, pf_q);
        if (err != I40E_SUCCESS) {
-               PMD_DRV_LOG(ERR, "Failed to clear LAN RX queue context\n");
+               PMD_DRV_LOG(ERR, "Failed to clear LAN RX queue context");
                return err;
        }
        err = i40e_set_lan_rx_queue_context(hw, pf_q, &rx_ctx);
        if (err != I40E_SUCCESS) {
-               PMD_DRV_LOG(ERR, "Failed to set LAN RX queue context\n");
+               PMD_DRV_LOG(ERR, "Failed to set LAN RX queue context");
                return err;
        }