lib: fix log typos
[dpdk.git] / lib / librte_timer / rte_timer.c
index d443b8c..381a9f4 100644 (file)
@@ -13,6 +13,7 @@
 #include <rte_atomic.h>
 #include <rte_common.h>
 #include <rte_cycles.h>
+#include <rte_eal_memconfig.h>
 #include <rte_per_lcore.h>
 #include <rte_memory.h>
 #include <rte_launch.h>
@@ -24,7 +25,8 @@
 #include <rte_pause.h>
 #include <rte_memzone.h>
 #include <rte_malloc.h>
-#include <rte_compat.h>
+#include <rte_errno.h>
+#include <rte_function_versioning.h>
 
 #include "rte_timer.h"
 
@@ -60,6 +62,8 @@ struct rte_timer_data {
 };
 
 #define RTE_MAX_DATA_ELS 64
+static const struct rte_memzone *rte_timer_data_mz;
+static int *volatile rte_timer_mz_refcnt;
 static struct rte_timer_data *rte_timer_data_arr;
 static const uint32_t default_data_id;
 static uint32_t rte_timer_subsystem_initialized;
@@ -81,7 +85,8 @@ static struct rte_timer_data default_timer_data;
 static inline int
 timer_data_valid(uint32_t id)
 {
-       return !!(rte_timer_data_arr[id].internal_flags & FL_ALLOCATED);
+       return rte_timer_data_arr &&
+               (rte_timer_data_arr[id].internal_flags & FL_ALLOCATED);
 }
 
 /* validate ID and retrieve timer data pointer, or return error value */
@@ -91,7 +96,7 @@ timer_data_valid(uint32_t id)
        timer_data = &rte_timer_data_arr[id];                           \
 } while (0)
 
-int __rte_experimental
+int
 rte_timer_data_alloc(uint32_t *id_ptr)
 {
        int i;
@@ -115,7 +120,7 @@ rte_timer_data_alloc(uint32_t *id_ptr)
        return -ENOSPC;
 }
 
-int __rte_experimental
+int
 rte_timer_data_dealloc(uint32_t id)
 {
        struct rte_timer_data *timer_data;
@@ -126,7 +131,7 @@ rte_timer_data_dealloc(uint32_t id)
        return 0;
 }
 
-void
+void __vsym
 rte_timer_subsystem_init_v20(void)
 {
        unsigned lcore_id;
@@ -148,51 +153,57 @@ VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);
  * secondary processes should be empty, the zeroth entry can be shared by
  * multiple processes.
  */
-int
+int __vsym
 rte_timer_subsystem_init_v1905(void)
 {
        const struct rte_memzone *mz;
        struct rte_timer_data *data;
        int i, lcore_id;
        static const char *mz_name = "rte_timer_mz";
+       const size_t data_arr_size =
+                       RTE_MAX_DATA_ELS * sizeof(*rte_timer_data_arr);
+       const size_t mem_size = data_arr_size + sizeof(*rte_timer_mz_refcnt);
+       bool do_full_init = true;
 
        if (rte_timer_subsystem_initialized)
                return -EALREADY;
 
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               mz = rte_memzone_lookup(mz_name);
-               if (mz == NULL)
-                       return -EEXIST;
-
-               rte_timer_data_arr = mz->addr;
-
-               rte_timer_data_arr[default_data_id].internal_flags |=
-                       FL_ALLOCATED;
-
-               rte_timer_subsystem_initialized = 1;
-
-               return 0;
-       }
+       rte_mcfg_timer_lock();
 
-       mz = rte_memzone_reserve_aligned(mz_name,
-                       RTE_MAX_DATA_ELS * sizeof(*rte_timer_data_arr),
-                       SOCKET_ID_ANY, 0, RTE_CACHE_LINE_SIZE);
-       if (mz == NULL)
-               return -ENOMEM;
+       mz = rte_memzone_lookup(mz_name);
+       if (mz == NULL) {
+               mz = rte_memzone_reserve_aligned(mz_name, mem_size,
+                               SOCKET_ID_ANY, 0, RTE_CACHE_LINE_SIZE);
+               if (mz == NULL) {
+                       rte_mcfg_timer_unlock();
+                       return -ENOMEM;
+               }
+               do_full_init = true;
+       } else
+               do_full_init = false;
 
+       rte_timer_data_mz = mz;
        rte_timer_data_arr = mz->addr;
-
-       for (i = 0; i < RTE_MAX_DATA_ELS; i++) {
-               data = &rte_timer_data_arr[i];
-
-               for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
-                       rte_spinlock_init(
-                               &data->priv_timer[lcore_id].list_lock);
-                       data->priv_timer[lcore_id].prev_lcore = lcore_id;
+       rte_timer_mz_refcnt = (void *)((char *)mz->addr + data_arr_size);
+
+       if (do_full_init) {
+               for (i = 0; i < RTE_MAX_DATA_ELS; i++) {
+                       data = &rte_timer_data_arr[i];
+
+                       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE;
+                            lcore_id++) {
+                               rte_spinlock_init(
+                                       &data->priv_timer[lcore_id].list_lock);
+                               data->priv_timer[lcore_id].prev_lcore =
+                                       lcore_id;
+                       }
                }
        }
 
        rte_timer_data_arr[default_data_id].internal_flags |= FL_ALLOCATED;
+       (*rte_timer_mz_refcnt)++;
+
+       rte_mcfg_timer_unlock();
 
        rte_timer_subsystem_initialized = 1;
 
@@ -202,11 +213,18 @@ MAP_STATIC_SYMBOL(int rte_timer_subsystem_init(void),
                  rte_timer_subsystem_init_v1905);
 BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05);
 
-void __rte_experimental
+void
 rte_timer_subsystem_finalize(void)
 {
-       if (rte_timer_data_arr)
-               rte_free(rte_timer_data_arr);
+       if (!rte_timer_subsystem_initialized)
+               return;
+
+       rte_mcfg_timer_lock();
+
+       if (--(*rte_timer_mz_refcnt) == 0)
+               rte_memzone_free(rte_timer_data_mz);
+
+       rte_mcfg_timer_unlock();
 
        rte_timer_subsystem_initialized = 0;
 }
@@ -533,7 +551,7 @@ __rte_timer_reset(struct rte_timer *tim, uint64_t expire,
 }
 
 /* Reset and start the timer associated with the timer handle tim */
-int
+int __vsym
 rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,
                    enum rte_timer_type type, unsigned int tim_lcore,
                    rte_timer_cb_t fct, void *arg)
@@ -556,7 +574,7 @@ rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,
 }
 VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);
 
-int
+int __vsym
 rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,
                      enum rte_timer_type type, unsigned int tim_lcore,
                      rte_timer_cb_t fct, void *arg)
@@ -571,7 +589,7 @@ MAP_STATIC_SYMBOL(int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
                  rte_timer_reset_v1905);
 BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05);
 
-int __rte_experimental
+int
 rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,
                    uint64_t ticks, enum rte_timer_type type,
                    unsigned int tim_lcore, rte_timer_cb_t fct, void *arg)
@@ -639,14 +657,14 @@ __rte_timer_stop(struct rte_timer *tim, int local_is_locked,
 }
 
 /* Stop the timer associated with the timer handle tim */
-int
+int __vsym
 rte_timer_stop_v20(struct rte_timer *tim)
 {
        return __rte_timer_stop(tim, 0, &default_timer_data);
 }
 VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);
 
-int
+int __vsym
 rte_timer_stop_v1905(struct rte_timer *tim)
 {
        return rte_timer_alt_stop(default_data_id, tim);
@@ -655,7 +673,7 @@ MAP_STATIC_SYMBOL(int rte_timer_stop(struct rte_timer *tim),
                  rte_timer_stop_v1905);
 BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05);
 
-int __rte_experimental
+int
 rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)
 {
        struct rte_timer_data *timer_data;
@@ -799,14 +817,14 @@ __rte_timer_manage(struct rte_timer_data *timer_data)
        priv_timer[lcore_id].running_tim = NULL;
 }
 
-void
+void __vsym
 rte_timer_manage_v20(void)
 {
        __rte_timer_manage(&default_timer_data);
 }
 VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);
 
-int
+int __vsym
 rte_timer_manage_v1905(void)
 {
        struct rte_timer_data *timer_data;
@@ -820,7 +838,7 @@ rte_timer_manage_v1905(void)
 MAP_STATIC_SYMBOL(int rte_timer_manage(void), rte_timer_manage_v1905);
 BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05);
 
-int __rte_experimental
+int
 rte_timer_alt_manage(uint32_t timer_data_id,
                     unsigned int *poll_lcores,
                     int nb_poll_lcores,
@@ -830,7 +848,6 @@ rte_timer_alt_manage(uint32_t timer_data_id,
        union rte_timer_status status;
        struct rte_timer *tim, *next_tim, **pprev;
        struct rte_timer *run_first_tims[RTE_MAX_LCORE];
-       unsigned int runlist_lcore_ids[RTE_MAX_LCORE];
        unsigned int this_lcore = rte_lcore_id();
        struct rte_timer *prev[MAX_SKIPLIST_DEPTH + 1];
        uint64_t cur_time;
@@ -899,7 +916,6 @@ rte_timer_alt_manage(uint32_t timer_data_id,
 
                /* transition run-list from PENDING to RUNNING */
                run_first_tims[nb_runlists] = tim;
-               runlist_lcore_ids[nb_runlists] = poll_lcore;
                pprev = &run_first_tims[nb_runlists];
                nb_runlists++;
 
@@ -946,25 +962,24 @@ rte_timer_alt_manage(uint32_t timer_data_id,
                        break;
 
                tim = run_first_tims[min_idx];
-               privp = &data->priv_timer[runlist_lcore_ids[min_idx]];
 
                /* Move down the runlist from which we picked a timer to
                 * execute
                 */
                run_first_tims[min_idx] = run_first_tims[min_idx]->sl_next[0];
 
-               privp->updated = 0;
-               privp->running_tim = tim;
+               data->priv_timer[this_lcore].updated = 0;
+               data->priv_timer[this_lcore].running_tim = tim;
 
                /* Call the provided callback function */
                f(tim);
 
-               __TIMER_STAT_ADD(privp, pending, -1);
+               __TIMER_STAT_ADD(data->priv_timer, pending, -1);
 
                /* the timer was stopped or reloaded by the callback
                 * function, we have nothing to do here
                 */
-               if (privp->updated == 1)
+               if (data->priv_timer[this_lcore].updated == 1)
                        continue;
 
                if (tim->period == 0) {
@@ -989,14 +1004,14 @@ rte_timer_alt_manage(uint32_t timer_data_id,
                                &data->priv_timer[this_lcore].list_lock);
                }
 
-               privp->running_tim = NULL;
+               data->priv_timer[this_lcore].running_tim = NULL;
        }
 
        return 0;
 }
 
 /* Walk pending lists, stopping timers and calling user-specified function */
-int __rte_experimental
+int
 rte_timer_stop_all(uint32_t timer_data_id, unsigned int *walk_lcores,
                   int nb_walk_lcores,
                   rte_timer_stop_all_cb_t f, void *f_arg)
@@ -1059,14 +1074,14 @@ __rte_timer_dump_stats(struct rte_timer_data *timer_data __rte_unused, FILE *f)
 #endif
 }
 
-void
+void __vsym
 rte_timer_dump_stats_v20(FILE *f)
 {
        __rte_timer_dump_stats(&default_timer_data, f);
 }
 VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);
 
-int
+int __vsym
 rte_timer_dump_stats_v1905(FILE *f)
 {
        return rte_timer_alt_dump_stats(default_data_id, f);
@@ -1075,7 +1090,7 @@ MAP_STATIC_SYMBOL(int rte_timer_dump_stats(FILE *f),
                  rte_timer_dump_stats_v1905);
 BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05);
 
-int __rte_experimental
+int
 rte_timer_alt_dump_stats(uint32_t timer_data_id __rte_unused, FILE *f)
 {
        struct rte_timer_data *timer_data;