vhost: rename device ops struct
[dpdk.git] / lib / librte_vhost / socket.c
index 967cb65..3b68fc9 100644 (file)
 #include "vhost.h"
 #include "vhost_user.h"
 
+
+TAILQ_HEAD(vhost_user_connection_list, vhost_user_connection);
+
 /*
  * Every time rte_vhost_driver_register() is invoked, an associated
  * vhost_user_socket struct will be created.
  */
 struct vhost_user_socket {
+       struct vhost_user_connection_list conn_list;
+       pthread_mutex_t conn_mutex;
        char *path;
        int listenfd;
-       int connfd;
        bool is_server;
        bool reconnect;
        bool dequeue_zero_copy;
+
+       /*
+        * The "supported_features" indicates the feature bits the
+        * vhost driver supports. The "features" indicates the feature
+        * bits after the rte_vhost_driver_features_disable/enable().
+        * It is also the final feature bits used for vhost-user
+        * features negotiation.
+        */
+       uint64_t supported_features;
+       uint64_t features;
+
+       struct vhost_device_ops const *notify_ops;
 };
 
 struct vhost_user_connection {
        struct vhost_user_socket *vsocket;
+       int connfd;
        int vid;
+
+       TAILQ_ENTRY(vhost_user_connection) next;
 };
 
 #define MAX_VHOST_SOCKET 1024
@@ -209,19 +228,23 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
 
        RTE_LOG(INFO, VHOST_CONFIG, "new device, handle is %d\n", vid);
 
-       vsocket->connfd = fd;
+       conn->connfd = fd;
        conn->vsocket = vsocket;
        conn->vid = vid;
        ret = fdset_add(&vhost_user.fdset, fd, vhost_user_read_cb,
                        NULL, conn);
        if (ret < 0) {
-               vsocket->connfd = -1;
+               conn->connfd = -1;
                free(conn);
                close(fd);
                RTE_LOG(ERR, VHOST_CONFIG,
                        "failed to add fd %d into vhost server fdset\n",
                        fd);
        }
+
+       pthread_mutex_lock(&vsocket->conn_mutex);
+       TAILQ_INSERT_TAIL(&vsocket->conn_list, conn, next);
+       pthread_mutex_unlock(&vsocket->conn_mutex);
 }
 
 /* call back when there is new vhost-user connection from client  */
@@ -247,12 +270,16 @@ vhost_user_read_cb(int connfd, void *dat, int *remove)
 
        ret = vhost_user_msg_handler(conn->vid, connfd);
        if (ret < 0) {
-               vsocket->connfd = -1;
                close(connfd);
                *remove = 1;
-               free(conn);
                vhost_destroy_device(conn->vid);
 
+               pthread_mutex_lock(&vsocket->conn_mutex);
+               TAILQ_REMOVE(&vsocket->conn_list, conn, next);
+               pthread_mutex_unlock(&vsocket->conn_mutex);
+
+               free(conn);
+
                if (vsocket->reconnect)
                        vhost_user_create_client(vsocket);
        }
@@ -448,7 +475,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
                return 0;
        }
 
-       RTE_LOG(ERR, VHOST_CONFIG,
+       RTE_LOG(WARNING, VHOST_CONFIG,
                "failed to connect to %s: %s\n",
                path, strerror(errno));
 
@@ -457,7 +484,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
                return -1;
        }
 
-       RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
+       RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
        reconn = malloc(sizeof(*reconn));
        if (reconn == NULL) {
                RTE_LOG(ERR, VHOST_CONFIG,
@@ -475,6 +502,94 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
        return 0;
 }
 
+static struct vhost_user_socket *
+find_vhost_user_socket(const char *path)
+{
+       int i;
+
+       for (i = 0; i < vhost_user.vsocket_cnt; i++) {
+               struct vhost_user_socket *vsocket = vhost_user.vsockets[i];
+
+               if (!strcmp(vsocket->path, path))
+                       return vsocket;
+       }
+
+       return NULL;
+}
+
+int
+rte_vhost_driver_disable_features(const char *path, uint64_t features)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       if (vsocket)
+               vsocket->features &= ~features;
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       return vsocket ? 0 : -1;
+}
+
+int
+rte_vhost_driver_enable_features(const char *path, uint64_t features)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       if (vsocket) {
+               if ((vsocket->supported_features & features) != features) {
+                       /*
+                        * trying to enable features the driver doesn't
+                        * support.
+                        */
+                       pthread_mutex_unlock(&vhost_user.mutex);
+                       return -1;
+               }
+               vsocket->features |= features;
+       }
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       return vsocket ? 0 : -1;
+}
+
+int
+rte_vhost_driver_set_features(const char *path, uint64_t features)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       if (vsocket) {
+               vsocket->supported_features = features;
+               vsocket->features = features;
+       }
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       return vsocket ? 0 : -1;
+}
+
+int
+rte_vhost_driver_get_features(const char *path, uint64_t *features)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       if (vsocket)
+               *features = vsocket->features;
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       if (!vsocket) {
+               RTE_LOG(ERR, VHOST_CONFIG,
+                       "socket file %s is not registered yet.\n", path);
+               return -1;
+       } else {
+               return 0;
+       }
+}
+
 /*
  * Register a new vhost-user socket; here we could act as server
  * (the default case), or client (when RTE_VHOST_USER_CLIENT) flag
@@ -502,9 +617,25 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
                goto out;
        memset(vsocket, 0, sizeof(struct vhost_user_socket));
        vsocket->path = strdup(path);
-       vsocket->connfd = -1;
+       TAILQ_INIT(&vsocket->conn_list);
+       pthread_mutex_init(&vsocket->conn_mutex, NULL);
        vsocket->dequeue_zero_copy = flags & RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
 
+       /*
+        * Set the supported features correctly for the builtin vhost-user
+        * net driver.
+        *
+        * Applications know nothing about features the builtin virtio net
+        * driver (virtio_net.c) supports, thus it's not possible for them
+        * to invoke rte_vhost_driver_set_features(). To workaround it, here
+        * we set it unconditionally. If the application want to implement
+        * another vhost-user driver (say SCSI), it should call the
+        * rte_vhost_driver_set_features(), which will overwrite following
+        * two values.
+        */
+       vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
+       vsocket->features           = VIRTIO_NET_SUPPORTED_FEATURES;
+
        if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
                vsocket->reconnect = !(flags & RTE_VHOST_USER_NO_RECONNECT);
                if (vsocket->reconnect && reconn_tid == 0) {
@@ -565,7 +696,7 @@ rte_vhost_driver_unregister(const char *path)
 {
        int i;
        int count;
-       struct vhost_user_connection *conn;
+       struct vhost_user_connection *conn, *next;
 
        pthread_mutex_lock(&vhost_user.mutex);
 
@@ -581,15 +712,22 @@ rte_vhost_driver_unregister(const char *path)
                                vhost_user_remove_reconnect(vsocket);
                        }
 
-                       conn = fdset_del(&vhost_user.fdset, vsocket->connfd);
-                       if (conn) {
+                       pthread_mutex_lock(&vsocket->conn_mutex);
+                       for (conn = TAILQ_FIRST(&vsocket->conn_list);
+                            conn != NULL;
+                            conn = next) {
+                               next = TAILQ_NEXT(conn, next);
+
+                               fdset_del(&vhost_user.fdset, conn->connfd);
                                RTE_LOG(INFO, VHOST_CONFIG,
                                        "free connfd = %d for device '%s'\n",
-                                       vsocket->connfd, path);
-                               close(vsocket->connfd);
+                                       conn->connfd, path);
+                               close(conn->connfd);
                                vhost_destroy_device(conn->vid);
+                               TAILQ_REMOVE(&vsocket->conn_list, conn, next);
                                free(conn);
                        }
+                       pthread_mutex_unlock(&vsocket->conn_mutex);
 
                        free(vsocket->path);
                        free(vsocket);
@@ -607,6 +745,36 @@ rte_vhost_driver_unregister(const char *path)
        return -1;
 }
 
+/*
+ * Register ops so that we can add/remove device to data core.
+ */
+int
+rte_vhost_driver_callback_register(const char *path,
+       struct vhost_device_ops const * const ops)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       if (vsocket)
+               vsocket->notify_ops = ops;
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       return vsocket ? 0 : -1;
+}
+
+struct vhost_device_ops const *
+vhost_driver_callback_get(const char *path)
+{
+       struct vhost_user_socket *vsocket;
+
+       pthread_mutex_lock(&vhost_user.mutex);
+       vsocket = find_vhost_user_socket(path);
+       pthread_mutex_unlock(&vhost_user.mutex);
+
+       return vsocket ? vsocket->notify_ops : NULL;
+}
+
 int
 rte_vhost_driver_session_start(void)
 {