vhost: pre update used ring for Tx and Rx
[dpdk.git] / lib / librte_vhost / vhost_rxtx.c
index 08cab08..52f87c1 100644 (file)
@@ -46,7 +46,6 @@
 #include <rte_arp.h>
 
 #include "vhost-net.h"
-#include "virtio-net.h"
 
 #define MAX_PKT_BURST 32
 #define VHOST_LOG_PAGE 4096
@@ -127,10 +126,10 @@ virtio_enqueue_offload(struct rte_mbuf *m_buf, struct virtio_net_hdr *net_hdr)
 }
 
 static inline void
-copy_virtio_net_hdr(struct vhost_virtqueue *vq, uint64_t desc_addr,
+copy_virtio_net_hdr(struct virtio_net *dev, uint64_t desc_addr,
                    struct virtio_net_hdr_mrg_rxbuf hdr)
 {
-       if (vq->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf))
+       if (dev->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf))
                *(struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr = hdr;
        else
                *(struct virtio_net_hdr *)(uintptr_t)desc_addr = hdr.hdr;
@@ -138,7 +137,7 @@ copy_virtio_net_hdr(struct vhost_virtqueue *vq, uint64_t desc_addr,
 
 static inline int __attribute__((always_inline))
 copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
-                 struct rte_mbuf *m, uint16_t desc_idx, uint32_t *copied)
+                 struct rte_mbuf *m, uint16_t desc_idx)
 {
        uint32_t desc_avail, desc_offset;
        uint32_t mbuf_avail, mbuf_offset;
@@ -148,21 +147,20 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
        struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, 0, 0, 0, 0, 0}, 0};
 
        desc = &vq->desc[desc_idx];
-       if (unlikely(desc->len < vq->vhost_hlen))
+       if (unlikely(desc->len < dev->vhost_hlen))
                return -1;
 
        desc_addr = gpa_to_vva(dev, desc->addr);
        rte_prefetch0((void *)(uintptr_t)desc_addr);
 
        virtio_enqueue_offload(m, &virtio_hdr.hdr);
-       copy_virtio_net_hdr(vq, desc_addr, virtio_hdr);
-       vhost_log_write(dev, desc->addr, vq->vhost_hlen);
-       PRINT_PACKET(dev, (uintptr_t)desc_addr, vq->vhost_hlen, 0);
+       copy_virtio_net_hdr(dev, desc_addr, virtio_hdr);
+       vhost_log_write(dev, desc->addr, dev->vhost_hlen);
+       PRINT_PACKET(dev, (uintptr_t)desc_addr, dev->vhost_hlen, 0);
 
-       desc_offset = vq->vhost_hlen;
-       desc_avail  = desc->len - vq->vhost_hlen;
+       desc_offset = dev->vhost_hlen;
+       desc_avail  = desc->len - dev->vhost_hlen;
 
-       *copied = rte_pktmbuf_pkt_len(m);
        mbuf_avail  = rte_pktmbuf_data_len(m);
        mbuf_offset = 0;
        while (mbuf_avail != 0 || m->next != NULL) {
@@ -263,6 +261,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
        struct vhost_virtqueue *vq;
        uint16_t res_start_idx, res_end_idx;
        uint16_t desc_indexes[MAX_PKT_BURST];
+       uint16_t used_idx;
        uint32_t i;
 
        LOG_DEBUG(VHOST_DATA, "(%d) %s\n", dev->vid, __func__);
@@ -286,27 +285,29 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
        /* Retrieve all of the desc indexes first to avoid caching issues. */
        rte_prefetch0(&vq->avail->ring[res_start_idx & (vq->size - 1)]);
        for (i = 0; i < count; i++) {
-               desc_indexes[i] = vq->avail->ring[(res_start_idx + i) &
-                                                 (vq->size - 1)];
+               used_idx = (res_start_idx + i) & (vq->size - 1);
+               desc_indexes[i] = vq->avail->ring[used_idx];
+               vq->used->ring[used_idx].id = desc_indexes[i];
+               vq->used->ring[used_idx].len = pkts[i]->pkt_len +
+                                              dev->vhost_hlen;
+               vhost_log_used_vring(dev, vq,
+                       offsetof(struct vring_used, ring[used_idx]),
+                       sizeof(vq->used->ring[used_idx]));
        }
 
        rte_prefetch0(&vq->desc[desc_indexes[0]]);
        for (i = 0; i < count; i++) {
                uint16_t desc_idx = desc_indexes[i];
-               uint16_t used_idx = (res_start_idx + i) & (vq->size - 1);
-               uint32_t copied;
                int err;
 
-               err = copy_mbuf_to_desc(dev, vq, pkts[i], desc_idx, &copied);
-
-               vq->used->ring[used_idx].id = desc_idx;
-               if (unlikely(err))
-                       vq->used->ring[used_idx].len = vq->vhost_hlen;
-               else
-                       vq->used->ring[used_idx].len = copied + vq->vhost_hlen;
-               vhost_log_used_vring(dev, vq,
-                       offsetof(struct vring_used, ring[used_idx]),
-                       sizeof(vq->used->ring[used_idx]));
+               err = copy_mbuf_to_desc(dev, vq, pkts[i], desc_idx);
+               if (unlikely(err)) {
+                       used_idx = (res_start_idx + i) & (vq->size - 1);
+                       vq->used->ring[used_idx].len = dev->vhost_hlen;
+                       vhost_log_used_vring(dev, vq,
+                               offsetof(struct vring_used, ring[used_idx]),
+                               sizeof(vq->used->ring[used_idx]));
+               }
 
                if (i + 1 < count)
                        rte_prefetch0(&vq->desc[desc_indexes[i+1]]);
@@ -336,7 +337,8 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
 
 static inline int
 fill_vec_buf(struct vhost_virtqueue *vq, uint32_t avail_idx,
-            uint32_t *allocated, uint32_t *vec_idx)
+            uint32_t *allocated, uint32_t *vec_idx,
+            struct buf_vector *buf_vec)
 {
        uint16_t idx = vq->avail->ring[avail_idx & (vq->size - 1)];
        uint32_t vec_id = *vec_idx;
@@ -347,9 +349,9 @@ fill_vec_buf(struct vhost_virtqueue *vq, uint32_t avail_idx,
                        return -1;
 
                len += vq->desc[idx].len;
-               vq->buf_vec[vec_id].buf_addr = vq->desc[idx].addr;
-               vq->buf_vec[vec_id].buf_len  = vq->desc[idx].len;
-               vq->buf_vec[vec_id].desc_idx = idx;
+               buf_vec[vec_id].buf_addr = vq->desc[idx].addr;
+               buf_vec[vec_id].buf_len  = vq->desc[idx].len;
+               buf_vec[vec_id].desc_idx = idx;
                vec_id++;
 
                if ((vq->desc[idx].flags & VRING_DESC_F_NEXT) == 0)
@@ -372,7 +374,8 @@ fill_vec_buf(struct vhost_virtqueue *vq, uint32_t avail_idx,
  */
 static inline int
 reserve_avail_buf_mergeable(struct vhost_virtqueue *vq, uint32_t size,
-                           uint16_t *start, uint16_t *end)
+                           uint16_t *start, uint16_t *end,
+                           struct buf_vector *buf_vec)
 {
        uint16_t res_start_idx;
        uint16_t res_cur_idx;
@@ -394,7 +397,7 @@ again:
                        return -1;
 
                if (unlikely(fill_vec_buf(vq, res_cur_idx, &allocated,
-                                         &vec_idx) < 0))
+                                         &vec_idx, buf_vec) < 0))
                        return -1;
 
                res_cur_idx++;
@@ -428,7 +431,7 @@ again:
 static inline uint32_t __attribute__((always_inline))
 copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
                            uint16_t res_start_idx, uint16_t res_end_idx,
-                           struct rte_mbuf *m)
+                           struct rte_mbuf *m, struct buf_vector *buf_vec)
 {
        struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, 0, 0, 0, 0, 0}, 0};
        uint32_t vec_idx = 0;
@@ -445,10 +448,10 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
        LOG_DEBUG(VHOST_DATA, "(%d) current index %d | end index %d\n",
                dev->vid, cur_idx, res_end_idx);
 
-       if (vq->buf_vec[vec_idx].buf_len < vq->vhost_hlen)
+       if (buf_vec[vec_idx].buf_len < dev->vhost_hlen)
                return -1;
 
-       desc_addr = gpa_to_vva(dev, vq->buf_vec[vec_idx].buf_addr);
+       desc_addr = gpa_to_vva(dev, buf_vec[vec_idx].buf_addr);
        rte_prefetch0((void *)(uintptr_t)desc_addr);
 
        virtio_hdr.num_buffers = res_end_idx - res_start_idx;
@@ -456,19 +459,19 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
                dev->vid, virtio_hdr.num_buffers);
 
        virtio_enqueue_offload(m, &virtio_hdr.hdr);
-       copy_virtio_net_hdr(vq, desc_addr, virtio_hdr);
-       vhost_log_write(dev, vq->buf_vec[vec_idx].buf_addr, vq->vhost_hlen);
-       PRINT_PACKET(dev, (uintptr_t)desc_addr, vq->vhost_hlen, 0);
+       copy_virtio_net_hdr(dev, desc_addr, virtio_hdr);
+       vhost_log_write(dev, buf_vec[vec_idx].buf_addr, dev->vhost_hlen);
+       PRINT_PACKET(dev, (uintptr_t)desc_addr, dev->vhost_hlen, 0);
 
-       desc_avail  = vq->buf_vec[vec_idx].buf_len - vq->vhost_hlen;
-       desc_offset = vq->vhost_hlen;
+       desc_avail  = buf_vec[vec_idx].buf_len - dev->vhost_hlen;
+       desc_offset = dev->vhost_hlen;
 
        mbuf_avail  = rte_pktmbuf_data_len(m);
        mbuf_offset = 0;
        while (mbuf_avail != 0 || m->next != NULL) {
                /* done with current desc buf, get the next one */
                if (desc_avail == 0) {
-                       desc_idx = vq->buf_vec[vec_idx].desc_idx;
+                       desc_idx = buf_vec[vec_idx].desc_idx;
 
                        if (!(vq->desc[desc_idx].flags & VRING_DESC_F_NEXT)) {
                                /* Update used ring with desc information */
@@ -482,12 +485,12 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
                        }
 
                        vec_idx++;
-                       desc_addr = gpa_to_vva(dev, vq->buf_vec[vec_idx].buf_addr);
+                       desc_addr = gpa_to_vva(dev, buf_vec[vec_idx].buf_addr);
 
                        /* Prefetch buffer address. */
                        rte_prefetch0((void *)(uintptr_t)desc_addr);
                        desc_offset = 0;
-                       desc_avail  = vq->buf_vec[vec_idx].buf_len;
+                       desc_avail  = buf_vec[vec_idx].buf_len;
                }
 
                /* done with current mbuf, get the next one */
@@ -502,7 +505,7 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
                rte_memcpy((void *)((uintptr_t)(desc_addr + desc_offset)),
                        rte_pktmbuf_mtod_offset(m, void *, mbuf_offset),
                        cpy_len);
-               vhost_log_write(dev, vq->buf_vec[vec_idx].buf_addr + desc_offset,
+               vhost_log_write(dev, buf_vec[vec_idx].buf_addr + desc_offset,
                        cpy_len);
                PRINT_PACKET(dev, (uintptr_t)(desc_addr + desc_offset),
                        cpy_len, 0);
@@ -514,7 +517,7 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
        }
 
        used_idx = cur_idx & (vq->size - 1);
-       vq->used->ring[used_idx].id = vq->buf_vec[vec_idx].desc_idx;
+       vq->used->ring[used_idx].id = buf_vec[vec_idx].desc_idx;
        vq->used->ring[used_idx].len = desc_offset;
        vhost_log_used_vring(dev, vq,
                offsetof(struct vring_used, ring[used_idx]),
@@ -530,6 +533,7 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id,
        struct vhost_virtqueue *vq;
        uint32_t pkt_idx = 0, nr_used = 0;
        uint16_t start, end;
+       struct buf_vector buf_vec[BUF_VECTOR_MAX];
 
        LOG_DEBUG(VHOST_DATA, "(%d) %s\n", dev->vid, __func__);
        if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->virt_qp_nb))) {
@@ -547,10 +551,10 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id,
                return 0;
 
        for (pkt_idx = 0; pkt_idx < count; pkt_idx++) {
-               uint32_t pkt_len = pkts[pkt_idx]->pkt_len + vq->vhost_hlen;
+               uint32_t pkt_len = pkts[pkt_idx]->pkt_len + dev->vhost_hlen;
 
-               if (unlikely(reserve_avail_buf_mergeable(vq, pkt_len,
-                                                        &start, &end) < 0)) {
+               if (unlikely(reserve_avail_buf_mergeable(vq, pkt_len, &start,
+                                                        &end, buf_vec) < 0)) {
                        LOG_DEBUG(VHOST_DATA,
                                "(%d) failed to get enough desc from vring\n",
                                dev->vid);
@@ -558,7 +562,7 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id,
                }
 
                nr_used = copy_mbuf_to_desc_mergeable(dev, vq, start, end,
-                                                     pkts[pkt_idx]);
+                                                     pkts[pkt_idx], buf_vec);
                rte_smp_wmb();
 
                /*
@@ -748,7 +752,7 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,
        uint32_t nr_desc = 1;
 
        desc = &vq->desc[desc_idx];
-       if (unlikely(desc->len < vq->vhost_hlen))
+       if (unlikely(desc->len < dev->vhost_hlen))
                return -1;
 
        desc_addr = gpa_to_vva(dev, desc->addr);
@@ -756,8 +760,8 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,
 
        /* Retrieve virtio net header */
        hdr = (struct virtio_net_hdr *)((uintptr_t)desc_addr);
-       desc_avail  = desc->len - vq->vhost_hlen;
-       desc_offset = vq->vhost_hlen;
+       desc_avail  = desc->len - dev->vhost_hlen;
+       desc_offset = dev->vhost_hlen;
 
        mbuf_offset = 0;
        mbuf_avail  = m->buf_len - RTE_PKTMBUF_HEADROOM;
@@ -880,6 +884,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
        /* Prefetch available ring to retrieve head indexes. */
        used_idx = vq->last_used_idx & (vq->size - 1);
        rte_prefetch0(&vq->avail->ring[used_idx]);
+       rte_prefetch0(&vq->used->ring[used_idx]);
 
        count = RTE_MIN(count, MAX_PKT_BURST);
        count = RTE_MIN(count, free_entries);
@@ -888,22 +893,23 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
 
        /* Retrieve all of the head indexes first to avoid caching issues. */
        for (i = 0; i < count; i++) {
-               desc_indexes[i] = vq->avail->ring[(vq->last_used_idx + i) &
-                                       (vq->size - 1)];
+               used_idx = (vq->last_used_idx + i) & (vq->size - 1);
+               desc_indexes[i] = vq->avail->ring[used_idx];
+
+               vq->used->ring[used_idx].id  = desc_indexes[i];
+               vq->used->ring[used_idx].len = 0;
+               vhost_log_used_vring(dev, vq,
+                               offsetof(struct vring_used, ring[used_idx]),
+                               sizeof(vq->used->ring[used_idx]));
        }
 
        /* Prefetch descriptor index. */
        rte_prefetch0(&vq->desc[desc_indexes[0]]);
-       rte_prefetch0(&vq->used->ring[vq->last_used_idx & (vq->size - 1)]);
-
        for (i = 0; i < count; i++) {
                int err;
 
-               if (likely(i + 1 < count)) {
+               if (likely(i + 1 < count))
                        rte_prefetch0(&vq->desc[desc_indexes[i + 1]]);
-                       rte_prefetch0(&vq->used->ring[(used_idx + 1) &
-                                                     (vq->size - 1)]);
-               }
 
                pkts[i] = rte_pktmbuf_alloc(mbuf_pool);
                if (unlikely(pkts[i] == NULL)) {
@@ -917,18 +923,12 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
                        rte_pktmbuf_free(pkts[i]);
                        break;
                }
-
-               used_idx = vq->last_used_idx++ & (vq->size - 1);
-               vq->used->ring[used_idx].id  = desc_indexes[i];
-               vq->used->ring[used_idx].len = 0;
-               vhost_log_used_vring(dev, vq,
-                               offsetof(struct vring_used, ring[used_idx]),
-                               sizeof(vq->used->ring[used_idx]));
        }
 
        rte_smp_wmb();
        rte_smp_rmb();
        vq->used->idx += i;
+       vq->last_used_idx += i;
        vhost_log_used_vring(dev, vq, offsetof(struct vring_used, idx),
                        sizeof(vq->used->idx));