net/sfc: allow to query RSS key and HF when RSS is disabled
[dpdk.git] / lib / librte_vhost / vhost_user.c
index bea6a04..7ef3fb4 100644 (file)
@@ -71,6 +71,16 @@ static const char *vhost_message_str[VHOST_USER_MAX] = {
        [VHOST_USER_CRYPTO_CLOSE_SESS] = "VHOST_USER_CRYPTO_CLOSE_SESS",
 };
 
+/* The possible results of a message handling function */
+enum vh_result {
+       /* Message handling failed */
+       VH_RESULT_ERR   = -1,
+       /* Message handling successful */
+       VH_RESULT_OK    =  0,
+       /* Message handling successful and reply prepared */
+       VH_RESULT_REPLY =  1,
+};
+
 static uint64_t
 get_blk_size(int fd)
 {
@@ -127,51 +137,66 @@ vhost_backend_cleanup(struct virtio_net *dev)
  * the device hasn't been initialised.
  */
 static int
-vhost_user_set_owner(void)
+vhost_user_set_owner(struct virtio_net **pdev __rte_unused,
+               struct VhostUserMsg *msg __rte_unused)
 {
-       return 0;
+       return VH_RESULT_OK;
 }
 
 static int
-vhost_user_reset_owner(struct virtio_net *dev)
+vhost_user_reset_owner(struct virtio_net **pdev,
+               struct VhostUserMsg *msg __rte_unused)
 {
+       struct virtio_net *dev = *pdev;
        vhost_destroy_device_notify(dev);
 
        cleanup_device(dev, 0);
        reset_device(dev);
-       return 0;
+       return VH_RESULT_OK;
 }
 
 /*
  * The features that we support are requested.
  */
-static uint64_t
-vhost_user_get_features(struct virtio_net *dev)
+static int
+vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        uint64_t features = 0;
 
        rte_vhost_driver_get_features(dev->ifname, &features);
-       return features;
+
+       msg->payload.u64 = features;
+       msg->size = sizeof(msg->payload.u64);
+
+       return VH_RESULT_REPLY;
 }
 
 /*
  * The queue number that we support are requested.
  */
-static uint32_t
-vhost_user_get_queue_num(struct virtio_net *dev)
+static int
+vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        uint32_t queue_num = 0;
 
        rte_vhost_driver_get_queue_num(dev->ifname, &queue_num);
-       return queue_num;
+
+       msg->payload.u64 = (uint64_t)queue_num;
+       msg->size = sizeof(msg->payload.u64);
+
+       return VH_RESULT_REPLY;
 }
 
 /*
  * We receive the negotiated features supported by us and the virtio device.
  */
 static int
-vhost_user_set_features(struct virtio_net *dev, uint64_t features)
+vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
+       uint64_t features = msg->payload.u64;
        uint64_t vhost_features = 0;
        struct rte_vdpa_device *vdpa_dev;
        int did = -1;
@@ -181,12 +206,12 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
                RTE_LOG(ERR, VHOST_CONFIG,
                        "(%d) received invalid negotiated features.\n",
                        dev->vid);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        if (dev->flags & VIRTIO_DEV_RUNNING) {
                if (dev->features == features)
-                       return 0;
+                       return VH_RESULT_OK;
 
                /*
                 * Error out if master tries to change features while device is
@@ -197,7 +222,7 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
                        RTE_LOG(ERR, VHOST_CONFIG,
                                "(%d) features changed while device is running.\n",
                                dev->vid);
-                       return -1;
+                       return VH_RESULT_ERR;
                }
 
                if (dev->notify_ops->features_changed)
@@ -233,7 +258,7 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
 
                        dev->virtqueue[dev->nr_vring] = NULL;
                        cleanup_vq(vq, 1);
-                       free_vq(vq);
+                       free_vq(dev, vq);
                }
        }
 
@@ -242,16 +267,17 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
        if (vdpa_dev && vdpa_dev->ops->set_features)
                vdpa_dev->ops->set_features(dev->vid);
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 /*
  * The virtio device sends us the size of the descriptor ring.
  */
 static int
-vhost_user_set_vring_num(struct virtio_net *dev,
-                        VhostUserMsg *msg)
+vhost_user_set_vring_num(struct virtio_net **pdev,
+                        struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];
 
        vq->size = msg->payload.state.num;
@@ -264,7 +290,7 @@ vhost_user_set_vring_num(struct virtio_net *dev,
        if ((vq->size & (vq->size - 1)) || vq->size > 32768) {
                RTE_LOG(ERR, VHOST_CONFIG,
                        "invalid virtqueue size %u\n", vq->size);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        if (dev->dequeue_zero_copy) {
@@ -282,13 +308,26 @@ vhost_user_set_vring_num(struct virtio_net *dev,
                TAILQ_INIT(&vq->zmbuf_list);
        }
 
-       vq->shadow_used_ring = rte_malloc(NULL,
+       if (vq_is_packed(dev)) {
+               vq->shadow_used_packed = rte_malloc(NULL,
+                               vq->size *
+                               sizeof(struct vring_used_elem_packed),
+                               RTE_CACHE_LINE_SIZE);
+               if (!vq->shadow_used_packed) {
+                       RTE_LOG(ERR, VHOST_CONFIG,
+                                       "failed to allocate memory for shadow used ring.\n");
+                       return VH_RESULT_ERR;
+               }
+
+       } else {
+               vq->shadow_used_split = rte_malloc(NULL,
                                vq->size * sizeof(struct vring_used_elem),
                                RTE_CACHE_LINE_SIZE);
-       if (!vq->shadow_used_ring) {
-               RTE_LOG(ERR, VHOST_CONFIG,
-                       "failed to allocate memory for shadow used ring.\n");
-               return -1;
+               if (!vq->shadow_used_split) {
+                       RTE_LOG(ERR, VHOST_CONFIG,
+                                       "failed to allocate memory for shadow used ring.\n");
+                       return VH_RESULT_ERR;
+               }
        }
 
        vq->batch_copy_elems = rte_malloc(NULL,
@@ -297,10 +336,10 @@ vhost_user_set_vring_num(struct virtio_net *dev,
        if (!vq->batch_copy_elems) {
                RTE_LOG(ERR, VHOST_CONFIG,
                        "failed to allocate memory for batching copy.\n");
-               return -1;
+               return VH_RESULT_ERR;
        }
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 /*
@@ -315,7 +354,8 @@ numa_realloc(struct virtio_net *dev, int index)
        struct virtio_net *old_dev;
        struct vhost_virtqueue *old_vq, *vq;
        struct zcopy_mbuf *new_zmbuf;
-       struct vring_used_elem *new_shadow_used_ring;
+       struct vring_used_elem *new_shadow_used_split;
+       struct vring_used_elem_packed *new_shadow_used_packed;
        struct batch_copy_elem *new_batch_copy_elems;
        int ret;
 
@@ -343,20 +383,35 @@ numa_realloc(struct virtio_net *dev, int index)
                memcpy(vq, old_vq, sizeof(*vq));
                TAILQ_INIT(&vq->zmbuf_list);
 
-               new_zmbuf = rte_malloc_socket(NULL, vq->zmbuf_size *
-                       sizeof(struct zcopy_mbuf), 0, newnode);
-               if (new_zmbuf) {
-                       rte_free(vq->zmbufs);
-                       vq->zmbufs = new_zmbuf;
+               if (dev->dequeue_zero_copy) {
+                       new_zmbuf = rte_malloc_socket(NULL, vq->zmbuf_size *
+                                       sizeof(struct zcopy_mbuf), 0, newnode);
+                       if (new_zmbuf) {
+                               rte_free(vq->zmbufs);
+                               vq->zmbufs = new_zmbuf;
+                       }
                }
 
-               new_shadow_used_ring = rte_malloc_socket(NULL,
-                       vq->size * sizeof(struct vring_used_elem),
-                       RTE_CACHE_LINE_SIZE,
-                       newnode);
-               if (new_shadow_used_ring) {
-                       rte_free(vq->shadow_used_ring);
-                       vq->shadow_used_ring = new_shadow_used_ring;
+               if (vq_is_packed(dev)) {
+                       new_shadow_used_packed = rte_malloc_socket(NULL,
+                                       vq->size *
+                                       sizeof(struct vring_used_elem_packed),
+                                       RTE_CACHE_LINE_SIZE,
+                                       newnode);
+                       if (new_shadow_used_packed) {
+                               rte_free(vq->shadow_used_packed);
+                               vq->shadow_used_packed = new_shadow_used_packed;
+                       }
+               } else {
+                       new_shadow_used_split = rte_malloc_socket(NULL,
+                                       vq->size *
+                                       sizeof(struct vring_used_elem),
+                                       RTE_CACHE_LINE_SIZE,
+                                       newnode);
+                       if (new_shadow_used_split) {
+                               rte_free(vq->shadow_used_split);
+                               vq->shadow_used_split = new_shadow_used_split;
+                       }
                }
 
                new_batch_copy_elems = rte_malloc_socket(NULL,
@@ -467,6 +522,51 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
        struct vhost_vring_addr *addr = &vq->ring_addrs;
        uint64_t len;
 
+       if (vq_is_packed(dev)) {
+               len = sizeof(struct vring_packed_desc) * vq->size;
+               vq->desc_packed = (struct vring_packed_desc *)(uintptr_t)
+                       ring_addr_to_vva(dev, vq, addr->desc_user_addr, &len);
+               vq->log_guest_addr = 0;
+               if (vq->desc_packed == NULL ||
+                               len != sizeof(struct vring_packed_desc) *
+                               vq->size) {
+                       RTE_LOG(DEBUG, VHOST_CONFIG,
+                               "(%d) failed to map desc_packed ring.\n",
+                               dev->vid);
+                       return dev;
+               }
+
+               dev = numa_realloc(dev, vq_index);
+               vq = dev->virtqueue[vq_index];
+               addr = &vq->ring_addrs;
+
+               len = sizeof(struct vring_packed_desc_event);
+               vq->driver_event = (struct vring_packed_desc_event *)
+                                       (uintptr_t)ring_addr_to_vva(dev,
+                                       vq, addr->avail_user_addr, &len);
+               if (vq->driver_event == NULL ||
+                               len != sizeof(struct vring_packed_desc_event)) {
+                       RTE_LOG(DEBUG, VHOST_CONFIG,
+                               "(%d) failed to find driver area address.\n",
+                               dev->vid);
+                       return dev;
+               }
+
+               len = sizeof(struct vring_packed_desc_event);
+               vq->device_event = (struct vring_packed_desc_event *)
+                                       (uintptr_t)ring_addr_to_vva(dev,
+                                       vq, addr->used_user_addr, &len);
+               if (vq->device_event == NULL ||
+                               len != sizeof(struct vring_packed_desc_event)) {
+                       RTE_LOG(DEBUG, VHOST_CONFIG,
+                               "(%d) failed to find device area address.\n",
+                               dev->vid);
+                       return dev;
+               }
+
+               return dev;
+       }
+
        /* The addresses are converted from QEMU virtual to Vhost virtual. */
        if (vq->desc && vq->avail && vq->used)
                return dev;
@@ -537,14 +637,14 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
  * This function then converts these to our address space.
  */
 static int
-vhost_user_set_vring_addr(struct virtio_net **pdev, VhostUserMsg *msg)
+vhost_user_set_vring_addr(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        struct vhost_virtqueue *vq;
        struct vhost_vring_addr *addr = &msg->payload.addr;
-       struct virtio_net *dev = *pdev;
 
        if (dev->mem == NULL)
-               return -1;
+               return VH_RESULT_ERR;
 
        /* addr->index refers to the queue index. The txq 1, rxq is 0. */
        vq = dev->virtqueue[msg->payload.addr.index];
@@ -561,27 +661,28 @@ vhost_user_set_vring_addr(struct virtio_net **pdev, VhostUserMsg *msg)
                                (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) {
                dev = translate_ring_addresses(dev, msg->payload.addr.index);
                if (!dev)
-                       return -1;
+                       return VH_RESULT_ERR;
 
                *pdev = dev;
        }
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 /*
  * The virtio device sends us the available ring last used index.
  */
 static int
-vhost_user_set_vring_base(struct virtio_net *dev,
-                         VhostUserMsg *msg)
+vhost_user_set_vring_base(struct virtio_net **pdev,
+                         struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        dev->virtqueue[msg->payload.state.index]->last_used_idx  =
                        msg->payload.state.num;
        dev->virtqueue[msg->payload.state.index]->last_avail_idx =
                        msg->payload.state.num;
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 static int
@@ -706,10 +807,10 @@ vhost_memory_changed(struct VhostUserMemory *new,
 }
 
 static int
-vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
+vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
        struct virtio_net *dev = *pdev;
-       struct VhostUserMemory memory = pmsg->payload.memory;
+       struct VhostUserMemory memory = msg->payload.memory;
        struct rte_vhost_mem_region *reg;
        void *mmap_addr;
        uint64_t mmap_size;
@@ -722,7 +823,7 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
        if (memory.nregions > VHOST_MEMORY_MAX_NREGIONS) {
                RTE_LOG(ERR, VHOST_CONFIG,
                        "too many memory regions (%u)\n", memory.nregions);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        if (dev->mem && !vhost_memory_changed(&memory, dev->mem)) {
@@ -730,9 +831,9 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
                        "(%d) memory regions not changed\n", dev->vid);
 
                for (i = 0; i < memory.nregions; i++)
-                       close(pmsg->fds[i]);
+                       close(msg->fds[i]);
 
-               return 0;
+               return VH_RESULT_OK;
        }
 
        if (dev->mem) {
@@ -741,6 +842,11 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
                dev->mem = NULL;
        }
 
+       /* Flush IOTLB cache as previous HVAs are now invalid */
+       if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))
+               for (i = 0; i < dev->nr_vring; i++)
+                       vhost_user_iotlb_flush_all(dev->virtqueue[i]);
+
        dev->nr_guest_pages = 0;
        if (!dev->guest_pages) {
                dev->max_guest_pages = 8;
@@ -751,7 +857,7 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
                                "(%d) failed to allocate memory "
                                "for dev->guest_pages\n",
                                dev->vid);
-                       return -1;
+                       return VH_RESULT_ERR;
                }
        }
 
@@ -761,12 +867,12 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
                RTE_LOG(ERR, VHOST_CONFIG,
                        "(%d) failed to allocate memory for dev->mem\n",
                        dev->vid);
-               return -1;
+               return VH_RESULT_ERR;
        }
        dev->mem->nregions = memory.nregions;
 
        for (i = 0; i < memory.nregions; i++) {
-               fd  = pmsg->fds[i];
+               fd  = msg->fds[i];
                reg = &dev->mem->regions[i];
 
                reg->guest_phys_addr = memory.regions[i].guest_phys_addr;
@@ -858,7 +964,7 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
 
                        dev = translate_ring_addresses(dev, i);
                        if (!dev)
-                               return -1;
+                               return VH_RESULT_ERR;
 
                        *pdev = dev;
                }
@@ -866,19 +972,29 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
 
        dump_guest_pages(dev);
 
-       return 0;
+       return VH_RESULT_OK;
 
 err_mmap:
        free_mem_region(dev);
        rte_free(dev->mem);
        dev->mem = NULL;
-       return -1;
+       return VH_RESULT_ERR;
 }
 
-static int
-vq_is_ready(struct vhost_virtqueue *vq)
+static bool
+vq_is_ready(struct virtio_net *dev, struct vhost_virtqueue *vq)
 {
-       return vq && vq->desc && vq->avail && vq->used &&
+       bool rings_ok;
+
+       if (!vq)
+               return false;
+
+       if (vq_is_packed(dev))
+               rings_ok = !!vq->desc_packed;
+       else
+               rings_ok = vq->desc && vq->avail && vq->used;
+
+       return rings_ok &&
               vq->kickfd != VIRTIO_UNINITIALIZED_EVENTFD &&
               vq->callfd != VIRTIO_UNINITIALIZED_EVENTFD;
 }
@@ -895,7 +1011,7 @@ virtio_is_ready(struct virtio_net *dev)
        for (i = 0; i < dev->nr_vring; i++) {
                vq = dev->virtqueue[i];
 
-               if (!vq_is_ready(vq))
+               if (!vq_is_ready(dev, vq))
                        return 0;
        }
 
@@ -904,17 +1020,18 @@ virtio_is_ready(struct virtio_net *dev)
        return 1;
 }
 
-static void
-vhost_user_set_vring_call(struct virtio_net *dev, struct VhostUserMsg *pmsg)
+static int
+vhost_user_set_vring_call(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        struct vhost_vring_file file;
        struct vhost_virtqueue *vq;
 
-       file.index = pmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
-       if (pmsg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
+       file.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
+       if (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
                file.fd = VIRTIO_INVALID_EVENTFD;
        else
-               file.fd = pmsg->fds[0];
+               file.fd = msg->fds[0];
        RTE_LOG(INFO, VHOST_CONFIG,
                "vring call idx:%d file:%d\n", file.index, file.fd);
 
@@ -923,27 +1040,39 @@ vhost_user_set_vring_call(struct virtio_net *dev, struct VhostUserMsg *pmsg)
                close(vq->callfd);
 
        vq->callfd = file.fd;
+
+       return VH_RESULT_OK;
 }
 
-static void
-vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
+static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
+                       struct VhostUserMsg *msg)
 {
+       if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
+               close(msg->fds[0]);
+       RTE_LOG(INFO, VHOST_CONFIG, "not implemented\n");
+
+       return VH_RESULT_OK;
+}
+
+static int
+vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg)
+{
+       struct virtio_net *dev = *pdev;
        struct vhost_vring_file file;
        struct vhost_virtqueue *vq;
-       struct virtio_net *dev = *pdev;
 
-       file.index = pmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
-       if (pmsg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
+       file.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
+       if (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
                file.fd = VIRTIO_INVALID_EVENTFD;
        else
-               file.fd = pmsg->fds[0];
+               file.fd = msg->fds[0];
        RTE_LOG(INFO, VHOST_CONFIG,
                "vring kick idx:%d file:%d\n", file.index, file.fd);
 
        /* Interpret ring addresses only when ring is started. */
        dev = translate_ring_addresses(dev, file.index);
        if (!dev)
-               return;
+               return VH_RESULT_ERR;
 
        *pdev = dev;
 
@@ -960,6 +1089,8 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *pmsg)
        if (vq->kickfd >= 0)
                close(vq->kickfd);
        vq->kickfd = file.fd;
+
+       return VH_RESULT_OK;
 }
 
 static void
@@ -982,9 +1113,10 @@ free_zmbufs(struct vhost_virtqueue *vq)
  * when virtio is stopped, qemu will send us the GET_VRING_BASE message.
  */
 static int
-vhost_user_get_vring_base(struct virtio_net *dev,
-                         VhostUserMsg *msg)
+vhost_user_get_vring_base(struct virtio_net **pdev,
+                         struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];
 
        /* We have to stop the queue (virtio) if it is running. */
@@ -1016,13 +1148,20 @@ vhost_user_get_vring_base(struct virtio_net *dev,
 
        if (dev->dequeue_zero_copy)
                free_zmbufs(vq);
-       rte_free(vq->shadow_used_ring);
-       vq->shadow_used_ring = NULL;
+       if (vq_is_packed(dev)) {
+               rte_free(vq->shadow_used_packed);
+               vq->shadow_used_packed = NULL;
+       } else {
+               rte_free(vq->shadow_used_split);
+               vq->shadow_used_split = NULL;
+       }
 
        rte_free(vq->batch_copy_elems);
        vq->batch_copy_elems = NULL;
 
-       return 0;
+       msg->size = sizeof(msg->payload.state);
+
+       return VH_RESULT_OK;
 }
 
 /*
@@ -1030,9 +1169,10 @@ vhost_user_get_vring_base(struct virtio_net *dev,
  * enable the virtio queue pair.
  */
 static int
-vhost_user_set_vring_enable(struct virtio_net *dev,
-                           VhostUserMsg *msg)
+vhost_user_set_vring_enable(struct virtio_net **pdev,
+                           struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        int enable = (int)msg->payload.state.num;
        int index = (int)msg->payload.state.index;
        struct rte_vdpa_device *vdpa_dev;
@@ -1053,13 +1193,14 @@ vhost_user_set_vring_enable(struct virtio_net *dev,
 
        dev->virtqueue[index]->enabled = enable;
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
-static void
-vhost_user_get_protocol_features(struct virtio_net *dev,
+static int
+vhost_user_get_protocol_features(struct virtio_net **pdev,
                                 struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        uint64_t features, protocol_features;
 
        rte_vhost_driver_get_features(dev->ifname, &features);
@@ -1076,35 +1217,46 @@ vhost_user_get_protocol_features(struct virtio_net *dev,
 
        msg->payload.u64 = protocol_features;
        msg->size = sizeof(msg->payload.u64);
+
+       return VH_RESULT_OK;
 }
 
-static void
-vhost_user_set_protocol_features(struct virtio_net *dev,
-                                uint64_t protocol_features)
+static int
+vhost_user_set_protocol_features(struct virtio_net **pdev,
+                                struct VhostUserMsg *msg)
 {
-       if (protocol_features & ~VHOST_USER_PROTOCOL_FEATURES)
-               return;
+       struct virtio_net *dev = *pdev;
+       uint64_t protocol_features = msg->payload.u64;
+       if (protocol_features & ~VHOST_USER_PROTOCOL_FEATURES) {
+               RTE_LOG(ERR, VHOST_CONFIG,
+                       "(%d) received invalid protocol features.\n",
+                       dev->vid);
+               return VH_RESULT_ERR;
+       }
 
        dev->protocol_features = protocol_features;
+
+       return VH_RESULT_OK;
 }
 
 static int
-vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)
+vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        int fd = msg->fds[0];
        uint64_t size, off;
        void *addr;
 
        if (fd < 0) {
                RTE_LOG(ERR, VHOST_CONFIG, "invalid log fd: %d\n", fd);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        if (msg->size != sizeof(VhostUserLog)) {
                RTE_LOG(ERR, VHOST_CONFIG,
                        "invalid log base msg size: %"PRId32" != %d\n",
                        msg->size, (int)sizeof(VhostUserLog));
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        size = msg->payload.log.mmap_size;
@@ -1115,7 +1267,7 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)
                RTE_LOG(ERR, VHOST_CONFIG,
                        "log offset %#"PRIx64" exceeds log size %#"PRIx64"\n",
                        off, size);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        RTE_LOG(INFO, VHOST_CONFIG,
@@ -1130,7 +1282,7 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)
        close(fd);
        if (addr == MAP_FAILED) {
                RTE_LOG(ERR, VHOST_CONFIG, "mmap log base failed!\n");
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        /*
@@ -1144,7 +1296,18 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)
        dev->log_base = dev->log_addr + off;
        dev->log_size = size;
 
-       return 0;
+       msg->size = sizeof(msg->payload.u64);
+
+       return VH_RESULT_OK;
+}
+
+static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
+                       struct VhostUserMsg *msg)
+{
+       close(msg->fds[0]);
+       RTE_LOG(INFO, VHOST_CONFIG, "not implemented.\n");
+
+       return VH_RESULT_OK;
 }
 
 /*
@@ -1156,8 +1319,9 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)
  * a flag 'broadcast_rarp' to let rte_vhost_dequeue_burst() inject it.
  */
 static int
-vhost_user_send_rarp(struct virtio_net *dev, struct VhostUserMsg *msg)
+vhost_user_send_rarp(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        uint8_t *mac = (uint8_t *)&msg->payload.u64;
        struct rte_vdpa_device *vdpa_dev;
        int did = -1;
@@ -1181,40 +1345,42 @@ vhost_user_send_rarp(struct virtio_net *dev, struct VhostUserMsg *msg)
        if (vdpa_dev && vdpa_dev->ops->migration_done)
                vdpa_dev->ops->migration_done(dev->vid);
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 static int
-vhost_user_net_set_mtu(struct virtio_net *dev, struct VhostUserMsg *msg)
+vhost_user_net_set_mtu(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        if (msg->payload.u64 < VIRTIO_MIN_MTU ||
                        msg->payload.u64 > VIRTIO_MAX_MTU) {
                RTE_LOG(ERR, VHOST_CONFIG, "Invalid MTU size (%"PRIu64")\n",
                                msg->payload.u64);
 
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        dev->mtu = msg->payload.u64;
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 static int
-vhost_user_set_req_fd(struct virtio_net *dev, struct VhostUserMsg *msg)
+vhost_user_set_req_fd(struct virtio_net **pdev, struct VhostUserMsg *msg)
 {
+       struct virtio_net *dev = *pdev;
        int fd = msg->fds[0];
 
        if (fd < 0) {
                RTE_LOG(ERR, VHOST_CONFIG,
                                "Invalid file descriptor for slave channel (%d)\n",
                                fd);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
        dev->slave_req_fd = fd;
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
 static int
@@ -1279,7 +1445,7 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg)
                len = imsg->size;
                vva = qva_to_vva(dev, imsg->uaddr, &len);
                if (!vva)
-                       return -1;
+                       return VH_RESULT_ERR;
 
                for (i = 0; i < dev->nr_vring; i++) {
                        struct vhost_virtqueue *vq = dev->virtqueue[i];
@@ -1305,12 +1471,41 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg)
        default:
                RTE_LOG(ERR, VHOST_CONFIG, "Invalid IOTLB message type (%d)\n",
                                imsg->type);
-               return -1;
+               return VH_RESULT_ERR;
        }
 
-       return 0;
+       return VH_RESULT_OK;
 }
 
+typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,
+                                       struct VhostUserMsg *msg);
+static vhost_message_handler_t vhost_message_handlers[VHOST_USER_MAX] = {
+       [VHOST_USER_NONE] = NULL,
+       [VHOST_USER_GET_FEATURES] = vhost_user_get_features,
+       [VHOST_USER_SET_FEATURES] = vhost_user_set_features,
+       [VHOST_USER_SET_OWNER] = vhost_user_set_owner,
+       [VHOST_USER_RESET_OWNER] = vhost_user_reset_owner,
+       [VHOST_USER_SET_MEM_TABLE] = vhost_user_set_mem_table,
+       [VHOST_USER_SET_LOG_BASE] = vhost_user_set_log_base,
+       [VHOST_USER_SET_LOG_FD] = vhost_user_set_log_fd,
+       [VHOST_USER_SET_VRING_NUM] = vhost_user_set_vring_num,
+       [VHOST_USER_SET_VRING_ADDR] = vhost_user_set_vring_addr,
+       [VHOST_USER_SET_VRING_BASE] = vhost_user_set_vring_base,
+       [VHOST_USER_GET_VRING_BASE] = vhost_user_get_vring_base,
+       [VHOST_USER_SET_VRING_KICK] = vhost_user_set_vring_kick,
+       [VHOST_USER_SET_VRING_CALL] = vhost_user_set_vring_call,
+       [VHOST_USER_SET_VRING_ERR] = vhost_user_set_vring_err,
+       [VHOST_USER_GET_PROTOCOL_FEATURES] = vhost_user_get_protocol_features,
+       [VHOST_USER_SET_PROTOCOL_FEATURES] = vhost_user_set_protocol_features,
+       [VHOST_USER_GET_QUEUE_NUM] = vhost_user_get_queue_num,
+       [VHOST_USER_SET_VRING_ENABLE] = vhost_user_set_vring_enable,
+       [VHOST_USER_SEND_RARP] = vhost_user_send_rarp,
+       [VHOST_USER_NET_SET_MTU] = vhost_user_net_set_mtu,
+       [VHOST_USER_SET_SLAVE_REQ_FD] = vhost_user_set_req_fd,
+       [VHOST_USER_IOTLB_MSG] = vhost_user_iotlb_msg,
+};
+
+
 /* return bytes# of read on success or negative val on failure. */
 static int
 read_vhost_message(int sockfd, struct VhostUserMsg *msg)
@@ -1385,7 +1580,8 @@ send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg,
  * Allocate a queue pair if it hasn't been allocated yet
  */
 static int
-vhost_user_check_and_alloc_queue_pair(struct virtio_net *dev, VhostUserMsg *msg)
+vhost_user_check_and_alloc_queue_pair(struct virtio_net *dev,
+                       struct VhostUserMsg *msg)
 {
        uint16_t vring_idx;
 
@@ -1463,6 +1659,7 @@ vhost_user_msg_handler(int vid, int fd)
        int ret;
        int unlock_required = 0;
        uint32_t skip_master = 0;
+       int request;
 
        dev = get_device(vid);
        if (dev == NULL)
@@ -1555,110 +1752,38 @@ vhost_user_msg_handler(int vid, int fd)
                        goto skip_to_post_handle;
        }
 
-       switch (msg.request.master) {
-       case VHOST_USER_GET_FEATURES:
-               msg.payload.u64 = vhost_user_get_features(dev);
-               msg.size = sizeof(msg.payload.u64);
-               send_vhost_reply(fd, &msg);
-               break;
-       case VHOST_USER_SET_FEATURES:
-               ret = vhost_user_set_features(dev, msg.payload.u64);
-               if (ret)
-                       return -1;
-               break;
-
-       case VHOST_USER_GET_PROTOCOL_FEATURES:
-               vhost_user_get_protocol_features(dev, &msg);
-               send_vhost_reply(fd, &msg);
-               break;
-       case VHOST_USER_SET_PROTOCOL_FEATURES:
-               vhost_user_set_protocol_features(dev, msg.payload.u64);
-               break;
-
-       case VHOST_USER_SET_OWNER:
-               vhost_user_set_owner();
-               break;
-       case VHOST_USER_RESET_OWNER:
-               vhost_user_reset_owner(dev);
-               break;
-
-       case VHOST_USER_SET_MEM_TABLE:
-               ret = vhost_user_set_mem_table(&dev, &msg);
-               break;
-
-       case VHOST_USER_SET_LOG_BASE:
-               vhost_user_set_log_base(dev, &msg);
-
-               /* it needs a reply */
-               msg.size = sizeof(msg.payload.u64);
-               send_vhost_reply(fd, &msg);
-               break;
-       case VHOST_USER_SET_LOG_FD:
-               close(msg.fds[0]);
-               RTE_LOG(INFO, VHOST_CONFIG, "not implemented.\n");
-               break;
-
-       case VHOST_USER_SET_VRING_NUM:
-               vhost_user_set_vring_num(dev, &msg);
-               break;
-       case VHOST_USER_SET_VRING_ADDR:
-               vhost_user_set_vring_addr(&dev, &msg);
-               break;
-       case VHOST_USER_SET_VRING_BASE:
-               vhost_user_set_vring_base(dev, &msg);
-               break;
-
-       case VHOST_USER_GET_VRING_BASE:
-               vhost_user_get_vring_base(dev, &msg);
-               msg.size = sizeof(msg.payload.state);
-               send_vhost_reply(fd, &msg);
-               break;
-
-       case VHOST_USER_SET_VRING_KICK:
-               vhost_user_set_vring_kick(&dev, &msg);
-               break;
-       case VHOST_USER_SET_VRING_CALL:
-               vhost_user_set_vring_call(dev, &msg);
-               break;
-
-       case VHOST_USER_SET_VRING_ERR:
-               if (!(msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
-                       close(msg.fds[0]);
-               RTE_LOG(INFO, VHOST_CONFIG, "not implemented\n");
-               break;
-
-       case VHOST_USER_GET_QUEUE_NUM:
-               msg.payload.u64 = (uint64_t)vhost_user_get_queue_num(dev);
-               msg.size = sizeof(msg.payload.u64);
-               send_vhost_reply(fd, &msg);
-               break;
-
-       case VHOST_USER_SET_VRING_ENABLE:
-               vhost_user_set_vring_enable(dev, &msg);
-               break;
-       case VHOST_USER_SEND_RARP:
-               vhost_user_send_rarp(dev, &msg);
-               break;
-
-       case VHOST_USER_NET_SET_MTU:
-               ret = vhost_user_net_set_mtu(dev, &msg);
-               break;
-
-       case VHOST_USER_SET_SLAVE_REQ_FD:
-               ret = vhost_user_set_req_fd(dev, &msg);
-               break;
-
-       case VHOST_USER_IOTLB_MSG:
-               ret = vhost_user_iotlb_msg(&dev, &msg);
-               break;
+       request = msg.request.master;
+       if (request > VHOST_USER_NONE && request < VHOST_USER_MAX) {
+               if (!vhost_message_handlers[request])
+                       goto skip_to_post_handle;
+               ret = vhost_message_handlers[request](&dev, &msg);
 
-       default:
-               ret = -1;
-               break;
+               switch (ret) {
+               case VH_RESULT_ERR:
+                       RTE_LOG(ERR, VHOST_CONFIG,
+                               "Processing %s failed.\n",
+                               vhost_message_str[request]);
+                       break;
+               case VH_RESULT_OK:
+                       RTE_LOG(DEBUG, VHOST_CONFIG,
+                               "Processing %s succeeded.\n",
+                               vhost_message_str[request]);
+                       break;
+               case VH_RESULT_REPLY:
+                       RTE_LOG(DEBUG, VHOST_CONFIG,
+                               "Processing %s succeeded and needs reply.\n",
+                               vhost_message_str[request]);
+                       send_vhost_reply(fd, &msg);
+                       break;
+               }
+       } else {
+               RTE_LOG(ERR, VHOST_CONFIG,
+                       "Requested invalid message type %d.\n", request);
+               ret = VH_RESULT_ERR;
        }
 
 skip_to_post_handle:
-       if (dev->extern_ops.post_msg_handle) {
+       if (!ret && dev->extern_ops.post_msg_handle) {
                uint32_t need_reply;
 
                ret = (*dev->extern_ops.post_msg_handle)(
@@ -1678,6 +1803,10 @@ skip_to_reply:
                msg.payload.u64 = !!ret;
                msg.size = sizeof(msg.payload.u64);
                send_vhost_reply(fd, &msg);
+       } else if (ret) {
+               RTE_LOG(ERR, VHOST_CONFIG,
+                       "vhost message handling failed.\n");
+               return -1;
        }
 
        if (!(dev->flags & VIRTIO_DEV_RUNNING) && virtio_is_ready(dev)) {
@@ -1713,9 +1842,9 @@ skip_to_reply:
 }
 
 static int process_slave_message_reply(struct virtio_net *dev,
-                                      const VhostUserMsg *msg)
+                                      const struct VhostUserMsg *msg)
 {
-       VhostUserMsg msg_reply;
+       struct VhostUserMsg msg_reply;
        int ret;
 
        if ((msg->flags & VHOST_USER_NEED_REPLY) == 0)