replace zero-length arrays with flexible ones
[dpdk.git] / lib / vhost / vhost.c
index df0bb9d..b14521e 100644 (file)
 struct virtio_net *vhost_devices[RTE_MAX_VHOST_DEVICE];
 pthread_mutex_t vhost_dev_lock = PTHREAD_MUTEX_INITIALIZER;
 
+struct vhost_vq_stats_name_off {
+       char name[RTE_VHOST_STATS_NAME_SIZE];
+       unsigned int offset;
+};
+
+static const struct vhost_vq_stats_name_off vhost_vq_stat_strings[] = {
+       {"good_packets",           offsetof(struct vhost_virtqueue, stats.packets)},
+       {"good_bytes",             offsetof(struct vhost_virtqueue, stats.bytes)},
+       {"multicast_packets",      offsetof(struct vhost_virtqueue, stats.multicast)},
+       {"broadcast_packets",      offsetof(struct vhost_virtqueue, stats.broadcast)},
+       {"undersize_packets",      offsetof(struct vhost_virtqueue, stats.size_bins[0])},
+       {"size_64_packets",        offsetof(struct vhost_virtqueue, stats.size_bins[1])},
+       {"size_65_127_packets",    offsetof(struct vhost_virtqueue, stats.size_bins[2])},
+       {"size_128_255_packets",   offsetof(struct vhost_virtqueue, stats.size_bins[3])},
+       {"size_256_511_packets",   offsetof(struct vhost_virtqueue, stats.size_bins[4])},
+       {"size_512_1023_packets",  offsetof(struct vhost_virtqueue, stats.size_bins[5])},
+       {"size_1024_1518_packets", offsetof(struct vhost_virtqueue, stats.size_bins[6])},
+       {"size_1519_max_packets",  offsetof(struct vhost_virtqueue, stats.size_bins[7])},
+       {"guest_notifications",    offsetof(struct vhost_virtqueue, stats.guest_notifications)},
+       {"iotlb_hits",             offsetof(struct vhost_virtqueue, stats.iotlb_hits)},
+       {"iotlb_misses",           offsetof(struct vhost_virtqueue, stats.iotlb_misses)},
+       {"inflight_submitted",     offsetof(struct vhost_virtqueue, stats.inflight_submitted)},
+       {"inflight_completed",     offsetof(struct vhost_virtqueue, stats.inflight_completed)},
+};
+
+#define VHOST_NB_VQ_STATS RTE_DIM(vhost_vq_stat_strings)
+
 /* Called with iotlb_lock read-locked */
 uint64_t
 __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
@@ -37,8 +64,14 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
        tmp_size = *size;
 
        vva = vhost_user_iotlb_cache_find(vq, iova, &tmp_size, perm);
-       if (tmp_size == *size)
+       if (tmp_size == *size) {
+               if (dev->flags & VIRTIO_DEV_STATS_ENABLED)
+                       vq->stats.iotlb_hits++;
                return vva;
+       }
+
+       if (dev->flags & VIRTIO_DEV_STATS_ENABLED)
+               vq->stats.iotlb_misses++;
 
        iova += tmp_size;
 
@@ -755,7 +788,7 @@ vhost_set_ifname(int vid, const char *if_name, unsigned int if_len)
 }
 
 void
-vhost_setup_virtio_net(int vid, bool enable, bool compliant_ol_flags)
+vhost_setup_virtio_net(int vid, bool enable, bool compliant_ol_flags, bool stats_enabled)
 {
        struct virtio_net *dev = get_device(vid);
 
@@ -770,6 +803,10 @@ vhost_setup_virtio_net(int vid, bool enable, bool compliant_ol_flags)
                dev->flags |= VIRTIO_DEV_LEGACY_OL_FLAGS;
        else
                dev->flags &= ~VIRTIO_DEV_LEGACY_OL_FLAGS;
+       if (stats_enabled)
+               dev->flags |= VIRTIO_DEV_STATS_ENABLED;
+       else
+               dev->flags &= ~VIRTIO_DEV_STATS_ENABLED;
 }
 
 void
@@ -1732,6 +1769,12 @@ rte_vhost_async_channel_register_thread_unsafe(int vid, uint16_t queue_id)
        if (unlikely(vq == NULL || !dev->async_copy))
                return -1;
 
+       if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
+               VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock taken.\n",
+                               dev->ifname, __func__);
+               return -1;
+       }
+
        return async_channel_register(vid, queue_id);
 }
 
@@ -1753,27 +1796,23 @@ rte_vhost_async_channel_unregister(int vid, uint16_t queue_id)
        if (vq == NULL)
                return ret;
 
-       ret = 0;
-
-       if (!vq->async)
-               return ret;
-
        if (!rte_spinlock_trylock(&vq->access_lock)) {
                VHOST_LOG_CONFIG(ERR, "(%s) failed to unregister async channel, virtqueue busy.\n",
                                dev->ifname);
-               return -1;
+               return ret;
        }
 
-       if (vq->async->pkts_inflight_n) {
+       if (!vq->async) {
+               ret = 0;
+       } else if (vq->async->pkts_inflight_n) {
                VHOST_LOG_CONFIG(ERR, "(%s) failed to unregister async channel.\n", dev->ifname);
                VHOST_LOG_CONFIG(ERR, "(%s) inflight packets must be completed before unregistration.\n",
                        dev->ifname);
-               ret = -1;
-               goto out;
+       } else {
+               vhost_free_async_mem(vq);
+               ret = 0;
        }
 
-       vhost_free_async_mem(vq);
-out:
        rte_spinlock_unlock(&vq->access_lock);
 
        return ret;
@@ -1796,6 +1835,12 @@ rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t queue_id)
        if (vq == NULL)
                return -1;
 
+       if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
+               VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock taken.\n",
+                               dev->ifname, __func__);
+               return -1;
+       }
+
        if (!vq->async)
                return 0;
 
@@ -1891,9 +1936,6 @@ rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
        if (vq == NULL)
                return ret;
 
-       if (!vq->async)
-               return ret;
-
        if (!rte_spinlock_trylock(&vq->access_lock)) {
                VHOST_LOG_CONFIG(DEBUG,
                        "(%s) failed to check in-flight packets. virtqueue busy.\n",
@@ -1901,7 +1943,9 @@ rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
                return ret;
        }
 
-       ret = vq->async->pkts_inflight_n;
+       if (vq->async)
+               ret = vq->async->pkts_inflight_n;
+
        rte_spinlock_unlock(&vq->access_lock);
 
        return ret;
@@ -1925,6 +1969,12 @@ rte_vhost_async_get_inflight_thread_unsafe(int vid, uint16_t queue_id)
        if (vq == NULL)
                return ret;
 
+       if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
+               VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock taken.\n",
+                               dev->ifname, __func__);
+               return -1;
+       }
+
        if (!vq->async)
                return ret;
 
@@ -1971,5 +2021,89 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
        return 0;
 }
 
+
+int
+rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
+               struct rte_vhost_stat_name *name, unsigned int size)
+{
+       struct virtio_net *dev = get_device(vid);
+       unsigned int i;
+
+       if (dev == NULL)
+               return -1;
+
+       if (queue_id >= dev->nr_vring)
+               return -1;
+
+       if (!(dev->flags & VIRTIO_DEV_STATS_ENABLED))
+               return -1;
+
+       if (name == NULL || size < VHOST_NB_VQ_STATS)
+               return VHOST_NB_VQ_STATS;
+
+       for (i = 0; i < VHOST_NB_VQ_STATS; i++)
+               snprintf(name[i].name, sizeof(name[i].name), "%s_q%u_%s",
+                               (queue_id & 1) ? "rx" : "tx",
+                               queue_id / 2, vhost_vq_stat_strings[i].name);
+
+       return VHOST_NB_VQ_STATS;
+}
+
+int
+rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
+               struct rte_vhost_stat *stats, unsigned int n)
+{
+       struct virtio_net *dev = get_device(vid);
+       struct vhost_virtqueue *vq;
+       unsigned int i;
+
+       if (dev == NULL)
+               return -1;
+
+       if (queue_id >= dev->nr_vring)
+               return -1;
+
+       if (!(dev->flags & VIRTIO_DEV_STATS_ENABLED))
+               return -1;
+
+       if (stats == NULL || n < VHOST_NB_VQ_STATS)
+               return VHOST_NB_VQ_STATS;
+
+       vq = dev->virtqueue[queue_id];
+
+       rte_spinlock_lock(&vq->access_lock);
+       for (i = 0; i < VHOST_NB_VQ_STATS; i++) {
+               stats[i].value =
+                       *(uint64_t *)(((char *)vq) + vhost_vq_stat_strings[i].offset);
+               stats[i].id = i;
+       }
+       rte_spinlock_unlock(&vq->access_lock);
+
+       return VHOST_NB_VQ_STATS;
+}
+
+int rte_vhost_vring_stats_reset(int vid, uint16_t queue_id)
+{
+       struct virtio_net *dev = get_device(vid);
+       struct vhost_virtqueue *vq;
+
+       if (dev == NULL)
+               return -1;
+
+       if (queue_id >= dev->nr_vring)
+               return -1;
+
+       if (!(dev->flags & VIRTIO_DEV_STATS_ENABLED))
+               return -1;
+
+       vq = dev->virtqueue[queue_id];
+
+       rte_spinlock_lock(&vq->access_lock);
+       memset(&vq->stats, 0, sizeof(vq->stats));
+       rte_spinlock_unlock(&vq->access_lock);
+
+       return 0;
+}
+
 RTE_LOG_REGISTER_SUFFIX(vhost_config_log_level, config, INFO);
 RTE_LOG_REGISTER_SUFFIX(vhost_data_log_level, data, WARNING);