#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_log.h>
+#include <rte_vfio.h>
+#include <rte_errno.h>
#include "iotlb.h"
#include "vhost.h"
[VHOST_USER_GET_STATUS] = "VHOST_USER_GET_STATUS",
};
-static int send_vhost_reply(int sockfd, struct VhostUserMsg *msg);
-static int read_vhost_message(int sockfd, struct VhostUserMsg *msg);
+static int send_vhost_reply(struct virtio_net *dev, int sockfd, struct vhu_msg_context *ctx);
+static int read_vhost_message(struct virtio_net *dev, int sockfd, struct vhu_msg_context *ctx);
static void
-close_msg_fds(struct VhostUserMsg *msg)
+close_msg_fds(struct vhu_msg_context *ctx)
{
int i;
- for (i = 0; i < msg->fd_num; i++) {
- int fd = msg->fds[i];
+ for (i = 0; i < ctx->fd_num; i++) {
+ int fd = ctx->fds[i];
if (fd == -1)
continue;
- msg->fds[i] = -1;
+ ctx->fds[i] = -1;
close(fd);
}
}
* close all FDs and return an error if this is not the case.
*/
static int
-validate_msg_fds(struct VhostUserMsg *msg, int expected_fds)
+validate_msg_fds(struct virtio_net *dev, struct vhu_msg_context *ctx, int expected_fds)
{
- if (msg->fd_num == expected_fds)
+ if (ctx->fd_num == expected_fds)
return 0;
- VHOST_LOG_CONFIG(ERR,
- " Expect %d FDs for request %s, received %d\n",
- expected_fds,
- vhost_message_str[msg->request.master],
- msg->fd_num);
+ VHOST_LOG_CONFIG(ERR, "(%s) expect %d FDs for request %s, received %d\n",
+ dev->ifname, expected_fds,
+ vhost_message_str[ctx->msg.request.master],
+ ctx->fd_num);
- close_msg_fds(msg);
+ close_msg_fds(ctx);
return -1;
}
return ret == -1 ? (uint64_t)-1 : (uint64_t)stat.st_blksize;
}
+static int
+async_dma_map(struct virtio_net *dev, struct rte_vhost_mem_region *region, bool do_map)
+{
+ uint64_t host_iova;
+ int ret = 0;
+
+ host_iova = rte_mem_virt2iova((void *)(uintptr_t)region->host_user_addr);
+ if (do_map) {
+ /* Add mapped region into the default container of DPDK. */
+ ret = rte_vfio_container_dma_map(RTE_VFIO_DEFAULT_CONTAINER_FD,
+ region->host_user_addr,
+ host_iova,
+ region->size);
+ if (ret) {
+ /*
+ * DMA device may bind with kernel driver, in this case,
+ * we don't need to program IOMMU manually. However, if no
+ * device is bound with vfio/uio in DPDK, and vfio kernel
+ * module is loaded, the API will still be called and return
+ * with ENODEV/ENOSUP.
+ *
+ * DPDK vfio only returns ENODEV/ENOSUP in very similar
+ * situations(vfio either unsupported, or supported
+ * but no devices found). Either way, no mappings could be
+ * performed. We treat it as normal case in async path.
+ */
+ if (rte_errno == ENODEV || rte_errno == ENOTSUP)
+ return 0;
+
+ VHOST_LOG_CONFIG(ERR, "(%s) DMA engine map failed\n", dev->ifname);
+ /* DMA mapping errors won't stop VHST_USER_SET_MEM_TABLE. */
+ return 0;
+ }
+
+ } else {
+ /* Remove mapped region from the default container of DPDK. */
+ ret = rte_vfio_container_dma_unmap(RTE_VFIO_DEFAULT_CONTAINER_FD,
+ region->host_user_addr,
+ host_iova,
+ region->size);
+ if (ret) {
+ /* like DMA map, ignore the kernel driver case when unmap. */
+ if (rte_errno == EINVAL)
+ return 0;
+
+ VHOST_LOG_CONFIG(ERR, "(%s) DMA engine unmap failed\n", dev->ifname);
+ return ret;
+ }
+ }
+
+ return ret;
+}
+
static void
free_mem_region(struct virtio_net *dev)
{
for (i = 0; i < dev->mem->nregions; i++) {
reg = &dev->mem->regions[i];
if (reg->host_user_addr) {
+ if (dev->async_copy && rte_vfio_is_enabled("vfio"))
+ async_dma_map(dev, reg, false);
+
munmap(reg->mmap_addr, reg->mmap_size);
close(reg->fd);
}
dev->inflight_info->fd = -1;
}
- free(dev->inflight_info);
+ rte_free(dev->inflight_info);
dev->inflight_info = NULL;
}
* the device hasn't been initialised.
*/
static int
-vhost_user_set_owner(struct virtio_net **pdev __rte_unused,
- struct VhostUserMsg *msg,
+vhost_user_set_owner(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
- if (validate_msg_fds(msg, 0) != 0)
+ struct virtio_net *dev = *pdev;
+
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
return RTE_VHOST_MSG_RESULT_OK;
static int
vhost_user_reset_owner(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
vhost_destroy_device_notify(dev);
* The features that we support are requested.
*/
static int
-vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_get_features(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
uint64_t features = 0;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
rte_vhost_driver_get_features(dev->ifname, &features);
- msg->payload.u64 = features;
- msg->size = sizeof(msg->payload.u64);
- msg->fd_num = 0;
+ ctx->msg.payload.u64 = features;
+ ctx->msg.size = sizeof(ctx->msg.payload.u64);
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
}
* The queue number that we support are requested.
*/
static int
-vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_get_queue_num(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
uint32_t queue_num = 0;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
rte_vhost_driver_get_queue_num(dev->ifname, &queue_num);
- msg->payload.u64 = (uint64_t)queue_num;
- msg->size = sizeof(msg->payload.u64);
- msg->fd_num = 0;
+ ctx->msg.payload.u64 = (uint64_t)queue_num;
+ ctx->msg.size = sizeof(ctx->msg.payload.u64);
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
}
* We receive the negotiated features supported by us and the virtio device.
*/
static int
-vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_features(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- uint64_t features = msg->payload.u64;
+ uint64_t features = ctx->msg.payload.u64;
uint64_t vhost_features = 0;
struct rte_vdpa_device *vdpa_dev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
rte_vhost_driver_get_features(dev->ifname, &vhost_features);
if (features & ~vhost_features) {
- VHOST_LOG_CONFIG(ERR,
- "(%d) received invalid negotiated features.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(ERR, "(%s) received invalid negotiated features.\n",
+ dev->ifname);
dev->flags |= VIRTIO_DEV_FEATURES_FAILED;
dev->status &= ~VIRTIO_DEVICE_STATUS_FEATURES_OK;
* is enabled when the live-migration starts.
*/
if ((dev->features ^ features) & ~(1ULL << VHOST_F_LOG_ALL)) {
- VHOST_LOG_CONFIG(ERR,
- "(%d) features changed while device is running.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(ERR, "(%s) features changed while device is running.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
} else {
dev->vhost_hlen = sizeof(struct virtio_net_hdr);
}
- VHOST_LOG_CONFIG(INFO,
- "negotiated Virtio features: 0x%" PRIx64 "\n", dev->features);
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) mergeable RX buffers %s, virtio 1 %s\n",
- dev->vid,
+ VHOST_LOG_CONFIG(INFO, "(%s) negotiated Virtio features: 0x%" PRIx64 "\n",
+ dev->ifname, dev->features);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) mergeable RX buffers %s, virtio 1 %s\n",
+ dev->ifname,
(dev->features & (1 << VIRTIO_NET_F_MRG_RXBUF)) ? "on" : "off",
(dev->features & (1ULL << VIRTIO_F_VERSION_1)) ? "on" : "off");
*/
static int
vhost_user_set_vring_num(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];
+ struct vhost_virtqueue *vq = dev->virtqueue[ctx->msg.payload.state.index];
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- if (msg->payload.state.num > 32768) {
- VHOST_LOG_CONFIG(ERR, "invalid virtqueue size %u\n", msg->payload.state.num);
+ if (ctx->msg.payload.state.num > 32768) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid virtqueue size %u\n",
+ dev->ifname, ctx->msg.payload.state.num);
return RTE_VHOST_MSG_RESULT_ERR;
}
- vq->size = msg->payload.state.num;
+ vq->size = ctx->msg.payload.state.num;
/* VIRTIO 1.0, 2.4 Virtqueues says:
*
*/
if (!vq_is_packed(dev)) {
if (vq->size & (vq->size - 1)) {
- VHOST_LOG_CONFIG(ERR,
- "invalid virtqueue size %u\n", vq->size);
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid virtqueue size %u\n",
+ dev->ifname, vq->size);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
if (vq_is_packed(dev)) {
if (vq->shadow_used_packed)
rte_free(vq->shadow_used_packed);
- vq->shadow_used_packed = rte_malloc(NULL,
+ vq->shadow_used_packed = rte_malloc_socket(NULL,
vq->size *
sizeof(struct vring_used_elem_packed),
- RTE_CACHE_LINE_SIZE);
+ RTE_CACHE_LINE_SIZE, vq->numa_node);
if (!vq->shadow_used_packed) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for shadow used ring.\n");
+ "(%s) failed to allocate memory for shadow used ring.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
if (vq->shadow_used_split)
rte_free(vq->shadow_used_split);
- vq->shadow_used_split = rte_malloc(NULL,
+ vq->shadow_used_split = rte_malloc_socket(NULL,
vq->size * sizeof(struct vring_used_elem),
- RTE_CACHE_LINE_SIZE);
+ RTE_CACHE_LINE_SIZE, vq->numa_node);
if (!vq->shadow_used_split) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for vq internal data.\n");
+ "(%s) failed to allocate memory for vq internal data.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
if (vq->batch_copy_elems)
rte_free(vq->batch_copy_elems);
- vq->batch_copy_elems = rte_malloc(NULL,
+ vq->batch_copy_elems = rte_malloc_socket(NULL,
vq->size * sizeof(struct batch_copy_elem),
- RTE_CACHE_LINE_SIZE);
+ RTE_CACHE_LINE_SIZE, vq->numa_node);
if (!vq->batch_copy_elems) {
- VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for batching copy.\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to allocate memory for batching copy.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
- if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) {
- if (vhost_user_iotlb_init(dev, msg->payload.state.index))
- return RTE_VHOST_MSG_RESULT_ERR;
- }
return RTE_VHOST_MSG_RESULT_OK;
}
/*
- * Reallocate virtio_dev and vhost_virtqueue data structure to make them on the
- * same numa node as the memory of vring descriptor.
+ * Reallocate virtio_dev, vhost_virtqueue and related data structures to
+ * make them on the same numa node as the memory of vring descriptor.
*/
#ifdef RTE_LIBRTE_VHOST_NUMA
static struct virtio_net*
numa_realloc(struct virtio_net *dev, int index)
{
- int oldnode, newnode;
+ int node, dev_node;
struct virtio_net *old_dev;
- struct vhost_virtqueue *old_vq, *vq;
- struct vring_used_elem *new_shadow_used_split;
- struct vring_used_elem_packed *new_shadow_used_packed;
- struct batch_copy_elem *new_batch_copy_elems;
+ struct vhost_virtqueue *vq;
+ struct batch_copy_elem *bce;
+ struct guest_page *gp;
+ struct rte_vhost_memory *mem;
+ size_t mem_size;
int ret;
- if (dev->flags & VIRTIO_DEV_RUNNING)
- return dev;
-
old_dev = dev;
- vq = old_vq = dev->virtqueue[index];
+ vq = dev->virtqueue[index];
- ret = get_mempolicy(&newnode, NULL, 0, old_vq->desc,
- MPOL_F_NODE | MPOL_F_ADDR);
+ /*
+ * If VQ is ready, it is too late to reallocate, it certainly already
+ * happened anyway on VHOST_USER_SET_VRING_ADRR.
+ */
+ if (vq->ready)
+ return dev;
- /* check if we need to reallocate vq */
- ret |= get_mempolicy(&oldnode, NULL, 0, old_vq,
- MPOL_F_NODE | MPOL_F_ADDR);
+ ret = get_mempolicy(&node, NULL, 0, vq->desc, MPOL_F_NODE | MPOL_F_ADDR);
if (ret) {
- VHOST_LOG_CONFIG(ERR,
- "Unable to get vq numa information.\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) unable to get virtqueue %d numa information.\n",
+ dev->ifname, index);
return dev;
}
- if (oldnode != newnode) {
- VHOST_LOG_CONFIG(INFO,
- "reallocate vq from %d to %d node\n", oldnode, newnode);
- vq = rte_malloc_socket(NULL, sizeof(*vq), 0, newnode);
- if (!vq)
+
+ if (node == vq->numa_node)
+ goto out_dev_realloc;
+
+ vq = rte_realloc_socket(vq, sizeof(*vq), 0, node);
+ if (!vq) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc virtqueue %d on node %d\n",
+ dev->ifname, index, node);
+ return dev;
+ }
+
+ if (vq != dev->virtqueue[index]) {
+ VHOST_LOG_CONFIG(INFO, "(%s) reallocated virtqueue on node %d\n",
+ dev->ifname, node);
+ dev->virtqueue[index] = vq;
+ vhost_user_iotlb_init(dev, index);
+ }
+
+ if (vq_is_packed(dev)) {
+ struct vring_used_elem_packed *sup;
+
+ sup = rte_realloc_socket(vq->shadow_used_packed, vq->size * sizeof(*sup),
+ RTE_CACHE_LINE_SIZE, node);
+ if (!sup) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc shadow packed on node %d\n",
+ dev->ifname, node);
return dev;
+ }
+ vq->shadow_used_packed = sup;
+ } else {
+ struct vring_used_elem *sus;
- memcpy(vq, old_vq, sizeof(*vq));
+ sus = rte_realloc_socket(vq->shadow_used_split, vq->size * sizeof(*sus),
+ RTE_CACHE_LINE_SIZE, node);
+ if (!sus) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc shadow split on node %d\n",
+ dev->ifname, node);
+ return dev;
+ }
+ vq->shadow_used_split = sus;
+ }
- if (vq_is_packed(dev)) {
- new_shadow_used_packed = rte_malloc_socket(NULL,
- vq->size *
- sizeof(struct vring_used_elem_packed),
- RTE_CACHE_LINE_SIZE,
- newnode);
- if (new_shadow_used_packed) {
- rte_free(vq->shadow_used_packed);
- vq->shadow_used_packed = new_shadow_used_packed;
- }
- } else {
- new_shadow_used_split = rte_malloc_socket(NULL,
- vq->size *
- sizeof(struct vring_used_elem),
- RTE_CACHE_LINE_SIZE,
- newnode);
- if (new_shadow_used_split) {
- rte_free(vq->shadow_used_split);
- vq->shadow_used_split = new_shadow_used_split;
- }
+ bce = rte_realloc_socket(vq->batch_copy_elems, vq->size * sizeof(*bce),
+ RTE_CACHE_LINE_SIZE, node);
+ if (!bce) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc batch copy elem on node %d\n",
+ dev->ifname, node);
+ return dev;
+ }
+ vq->batch_copy_elems = bce;
+
+ if (vq->log_cache) {
+ struct log_cache_entry *lc;
+
+ lc = rte_realloc_socket(vq->log_cache, sizeof(*lc) * VHOST_LOG_CACHE_NR, 0, node);
+ if (!lc) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc log cache on node %d\n",
+ dev->ifname, node);
+ return dev;
}
+ vq->log_cache = lc;
+ }
+
+ if (vq->resubmit_inflight) {
+ struct rte_vhost_resubmit_info *ri;
- new_batch_copy_elems = rte_malloc_socket(NULL,
- vq->size * sizeof(struct batch_copy_elem),
- RTE_CACHE_LINE_SIZE,
- newnode);
- if (new_batch_copy_elems) {
- rte_free(vq->batch_copy_elems);
- vq->batch_copy_elems = new_batch_copy_elems;
+ ri = rte_realloc_socket(vq->resubmit_inflight, sizeof(*ri), 0, node);
+ if (!ri) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc resubmit inflight on node %d\n",
+ dev->ifname, node);
+ return dev;
}
+ vq->resubmit_inflight = ri;
+
+ if (ri->resubmit_list) {
+ struct rte_vhost_resubmit_desc *rd;
- rte_free(old_vq);
+ rd = rte_realloc_socket(ri->resubmit_list, sizeof(*rd) * ri->resubmit_num,
+ 0, node);
+ if (!rd) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc resubmit list on node %d\n",
+ dev->ifname, node);
+ return dev;
+ }
+ ri->resubmit_list = rd;
+ }
}
- /* check if we need to reallocate dev */
- ret = get_mempolicy(&oldnode, NULL, 0, old_dev,
- MPOL_F_NODE | MPOL_F_ADDR);
+ vq->numa_node = node;
+
+out_dev_realloc:
+
+ if (dev->flags & VIRTIO_DEV_RUNNING)
+ return dev;
+
+ ret = get_mempolicy(&dev_node, NULL, 0, dev, MPOL_F_NODE | MPOL_F_ADDR);
if (ret) {
- VHOST_LOG_CONFIG(ERR,
- "Unable to get dev numa information.\n");
- goto out;
+ VHOST_LOG_CONFIG(ERR, "(%s) unable to get numa information.\n", dev->ifname);
+ return dev;
}
- if (oldnode != newnode) {
- VHOST_LOG_CONFIG(INFO,
- "reallocate dev from %d to %d node\n",
- oldnode, newnode);
- dev = rte_malloc_socket(NULL, sizeof(*dev), 0, newnode);
- if (!dev) {
- dev = old_dev;
- goto out;
- }
- memcpy(dev, old_dev, sizeof(*dev));
- rte_free(old_dev);
+ if (dev_node == node)
+ return dev;
+
+ dev = rte_realloc_socket(old_dev, sizeof(*dev), 0, node);
+ if (!dev) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc dev on node %d\n",
+ dev->ifname, node);
+ return old_dev;
}
-out:
- dev->virtqueue[index] = vq;
+ VHOST_LOG_CONFIG(INFO, "(%s) reallocated device on node %d\n", dev->ifname, node);
vhost_devices[dev->vid] = dev;
- if (old_vq != vq && (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)))
- vhost_user_iotlb_init(dev, index);
+ mem_size = sizeof(struct rte_vhost_memory) +
+ sizeof(struct rte_vhost_mem_region) * dev->mem->nregions;
+ mem = rte_realloc_socket(dev->mem, mem_size, 0, node);
+ if (!mem) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc mem table on node %d\n",
+ dev->ifname, node);
+ return dev;
+ }
+ dev->mem = mem;
+
+ gp = rte_realloc_socket(dev->guest_pages, dev->max_guest_pages * sizeof(*gp),
+ RTE_CACHE_LINE_SIZE, node);
+ if (!gp) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc guest pages on node %d\n",
+ dev->ifname, node);
+ return dev;
+ }
+ dev->guest_pages = gp;
return dev;
}
vq->log_guest_addr =
log_addr_to_gpa(dev, vq);
if (vq->log_guest_addr == 0) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to map log_guest_addr.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to map log_guest_addr.\n",
+ dev->ifname);
return dev;
}
}
if (vq->desc_packed == NULL ||
len != sizeof(struct vring_packed_desc) *
vq->size) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to map desc_packed ring.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to map desc_packed ring.\n",
+ dev->ifname);
return dev;
}
vq, addr->avail_user_addr, &len);
if (vq->driver_event == NULL ||
len != sizeof(struct vring_packed_desc_event)) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to find driver area address.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to find driver area address.\n",
+ dev->ifname);
return dev;
}
vq, addr->used_user_addr, &len);
if (vq->device_event == NULL ||
len != sizeof(struct vring_packed_desc_event)) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to find device area address.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to find device area address.\n",
+ dev->ifname);
return dev;
}
vq->desc = (struct vring_desc *)(uintptr_t)ring_addr_to_vva(dev,
vq, addr->desc_user_addr, &len);
if (vq->desc == 0 || len != sizeof(struct vring_desc) * vq->size) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to map desc ring.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to map desc ring.\n", dev->ifname);
return dev;
}
vq->avail = (struct vring_avail *)(uintptr_t)ring_addr_to_vva(dev,
vq, addr->avail_user_addr, &len);
if (vq->avail == 0 || len != expected_len) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to map avail ring.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to map avail ring.\n", dev->ifname);
return dev;
}
vq->used = (struct vring_used *)(uintptr_t)ring_addr_to_vva(dev,
vq, addr->used_user_addr, &len);
if (vq->used == 0 || len != expected_len) {
- VHOST_LOG_CONFIG(DEBUG,
- "(%d) failed to map used ring.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) failed to map used ring.\n", dev->ifname);
return dev;
}
if (vq->last_used_idx != vq->used->idx) {
- VHOST_LOG_CONFIG(WARNING,
- "last_used_idx (%u) and vq->used->idx (%u) mismatches; "
- "some packets maybe resent for Tx and dropped for Rx\n",
+ VHOST_LOG_CONFIG(WARNING, "(%s) last_used_idx (%u) and vq->used->idx (%u) mismatches;\n",
+ dev->ifname,
vq->last_used_idx, vq->used->idx);
vq->last_used_idx = vq->used->idx;
vq->last_avail_idx = vq->used->idx;
+ VHOST_LOG_CONFIG(WARNING, "(%s) some packets maybe resent for Tx and dropped for Rx\n",
+ dev->ifname);
}
vq->access_ok = true;
- VHOST_LOG_CONFIG(DEBUG, "(%d) mapped address desc: %p\n",
- dev->vid, vq->desc);
- VHOST_LOG_CONFIG(DEBUG, "(%d) mapped address avail: %p\n",
- dev->vid, vq->avail);
- VHOST_LOG_CONFIG(DEBUG, "(%d) mapped address used: %p\n",
- dev->vid, vq->used);
- VHOST_LOG_CONFIG(DEBUG, "(%d) log_guest_addr: %" PRIx64 "\n",
- dev->vid, vq->log_guest_addr);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) mapped address desc: %p\n", dev->ifname, vq->desc);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) mapped address avail: %p\n", dev->ifname, vq->avail);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) mapped address used: %p\n", dev->ifname, vq->used);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) log_guest_addr: %" PRIx64 "\n",
+ dev->ifname, vq->log_guest_addr);
return dev;
}
* This function then converts these to our address space.
*/
static int
-vhost_user_set_vring_addr(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_vring_addr(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
struct vhost_virtqueue *vq;
- struct vhost_vring_addr *addr = &msg->payload.addr;
+ struct vhost_vring_addr *addr = &ctx->msg.payload.addr;
bool access_ok;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (dev->mem == NULL)
return RTE_VHOST_MSG_RESULT_ERR;
/* addr->index refers to the queue index. The txq 1, rxq is 0. */
- vq = dev->virtqueue[msg->payload.addr.index];
+ vq = dev->virtqueue[ctx->msg.payload.addr.index];
access_ok = vq->access_ok;
if ((vq->enabled && (dev->features &
(1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) ||
access_ok) {
- dev = translate_ring_addresses(dev, msg->payload.addr.index);
+ dev = translate_ring_addresses(dev, ctx->msg.payload.addr.index);
if (!dev)
return RTE_VHOST_MSG_RESULT_ERR;
*/
static int
vhost_user_set_vring_base(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];
- uint64_t val = msg->payload.state.num;
+ struct vhost_virtqueue *vq = dev->virtqueue[ctx->msg.payload.state.index];
+ uint64_t val = ctx->msg.payload.state.num;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (vq_is_packed(dev)) {
vq->last_used_idx = vq->last_avail_idx;
vq->used_wrap_counter = vq->avail_wrap_counter;
} else {
- vq->last_used_idx = msg->payload.state.num;
- vq->last_avail_idx = msg->payload.state.num;
+ vq->last_used_idx = ctx->msg.payload.state.num;
+ vq->last_avail_idx = ctx->msg.payload.state.num;
}
+ VHOST_LOG_CONFIG(INFO,
+ "(%s) vring base idx:%u last_used_idx:%u last_avail_idx:%u.\n",
+ dev->ifname, ctx->msg.payload.state.index, vq->last_used_idx,
+ vq->last_avail_idx);
+
return RTE_VHOST_MSG_RESULT_OK;
}
dev->max_guest_pages * sizeof(*page),
RTE_CACHE_LINE_SIZE);
if (dev->guest_pages == NULL) {
- VHOST_LOG_CONFIG(ERR, "cannot realloc guest_pages\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) cannot realloc guest_pages\n", dev->ifname);
rte_free(old_pages);
return -1;
}
for (i = 0; i < dev->nr_guest_pages; i++) {
page = &dev->guest_pages[i];
- VHOST_LOG_CONFIG(INFO,
- "guest physical page region %u\n"
- "\t guest_phys_addr: %" PRIx64 "\n"
- "\t host_phys_addr : %" PRIx64 "\n"
- "\t size : %" PRIx64 "\n",
- i,
- page->guest_phys_addr,
- page->host_phys_addr,
- page->size);
+ VHOST_LOG_CONFIG(INFO, "(%s) guest physical page region %u\n",
+ dev->ifname, i);
+ VHOST_LOG_CONFIG(INFO, "(%s)\tguest_phys_addr: %" PRIx64 "\n",
+ dev->ifname, page->guest_phys_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\thost_phys_addr : %" PRIx64 "\n",
+ dev->ifname, page->host_phys_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\tsize : %" PRIx64 "\n",
+ dev->ifname, page->size);
}
}
#else
struct uffdio_register reg_struct;
/*
- * Let's register all the mmap'ed area to ensure
+ * Let's register all the mmapped area to ensure
* alignment on page boundary.
*/
reg_struct.range.start = (uint64_t)(uintptr_t)reg->mmap_addr;
if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER,
®_struct)) {
- VHOST_LOG_CONFIG(ERR, "Failed to register ufd for region "
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region "
"%" PRIx64 " - %" PRIx64 " (ufd = %d) %s\n",
+ dev->ifname,
(uint64_t)reg_struct.range.start,
(uint64_t)reg_struct.range.start +
(uint64_t)reg_struct.range.len - 1,
return -1;
}
- VHOST_LOG_CONFIG(INFO, "\t userfaultfd registered for range : %" PRIx64 " - %" PRIx64 "\n",
+ VHOST_LOG_CONFIG(INFO,
+ "(%s)\t userfaultfd registered for range : %" PRIx64 " - %" PRIx64 "\n",
+ dev->ifname,
(uint64_t)reg_struct.range.start,
(uint64_t)reg_struct.range.start +
(uint64_t)reg_struct.range.len - 1);
static int
vhost_user_postcopy_register(struct virtio_net *dev, int main_fd,
- struct VhostUserMsg *msg)
+ struct vhu_msg_context *ctx)
{
struct VhostUserMemory *memory;
struct rte_vhost_mem_region *reg;
- VhostUserMsg ack_msg;
+ struct vhu_msg_context ack_ctx;
uint32_t i;
if (!dev->postcopy_listening)
* DPDK's virtual address with Qemu, so that Qemu can
* retrieve the region offset when handling userfaults.
*/
- memory = &msg->payload.memory;
+ memory = &ctx->msg.payload.memory;
for (i = 0; i < memory->nregions; i++) {
reg = &dev->mem->regions[i];
memory->regions[i].userspace_addr = reg->host_user_addr;
}
/* Send the addresses back to qemu */
- msg->fd_num = 0;
- send_vhost_reply(main_fd, msg);
+ ctx->fd_num = 0;
+ send_vhost_reply(dev, main_fd, ctx);
- /* Wait for qemu to acknolwedge it's got the addresses
+ /* Wait for qemu to acknowledge it got the addresses
* we've got to wait before we're allowed to generate faults.
*/
- if (read_vhost_message(main_fd, &ack_msg) <= 0) {
- VHOST_LOG_CONFIG(ERR,
- "Failed to read qemu ack on postcopy set-mem-table\n");
+ if (read_vhost_message(dev, main_fd, &ack_ctx) <= 0) {
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to read qemu ack on postcopy set-mem-table\n",
+ dev->ifname);
return -1;
}
- if (validate_msg_fds(&ack_msg, 0) != 0)
+ if (validate_msg_fds(dev, &ack_ctx, 0) != 0)
return -1;
- if (ack_msg.request.master != VHOST_USER_SET_MEM_TABLE) {
- VHOST_LOG_CONFIG(ERR,
- "Bad qemu ack on postcopy set-mem-table (%d)\n",
- ack_msg.request.master);
+ if (ack_ctx.msg.request.master != VHOST_USER_SET_MEM_TABLE) {
+ VHOST_LOG_CONFIG(ERR, "(%s) bad qemu ack on postcopy set-mem-table (%d)\n",
+ dev->ifname, ack_ctx.msg.request.master);
return -1;
}
uint64_t mmap_size;
uint64_t alignment;
int populate;
+ int ret;
/* Check for memory_size + mmap_offset overflow */
if (mmap_offset >= -region->size) {
- VHOST_LOG_CONFIG(ERR,
- "mmap_offset (%#"PRIx64") and memory_size "
- "(%#"PRIx64") overflow\n",
- mmap_offset, region->size);
+ VHOST_LOG_CONFIG(ERR, "(%s) mmap_offset (%#"PRIx64") and memory_size (%#"PRIx64") overflow\n",
+ dev->ifname, mmap_offset, region->size);
return -1;
}
*/
alignment = get_blk_size(region->fd);
if (alignment == (uint64_t)-1) {
- VHOST_LOG_CONFIG(ERR,
- "couldn't get hugepage size through fstat\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) couldn't get hugepage size through fstat\n",
+ dev->ifname);
return -1;
}
mmap_size = RTE_ALIGN_CEIL(mmap_size, alignment);
* mmap() kernel implementation would return an error, but
* better catch it before and provide useful info in the logs.
*/
- VHOST_LOG_CONFIG(ERR, "mmap size (0x%" PRIx64 ") "
- "or alignment (0x%" PRIx64 ") is invalid\n",
- region->size + mmap_offset, alignment);
+ VHOST_LOG_CONFIG(ERR, "(%s) mmap size (0x%" PRIx64 ") or alignment (0x%" PRIx64 ") is invalid\n",
+ dev->ifname, region->size + mmap_offset, alignment);
return -1;
}
MAP_SHARED | populate, region->fd, 0);
if (mmap_addr == MAP_FAILED) {
- VHOST_LOG_CONFIG(ERR, "mmap failed (%s).\n", strerror(errno));
+ VHOST_LOG_CONFIG(ERR, "(%s) mmap failed (%s).\n", dev->ifname, strerror(errno));
return -1;
}
region->mmap_size = mmap_size;
region->host_user_addr = (uint64_t)(uintptr_t)mmap_addr + mmap_offset;
- if (dev->async_copy)
+ if (dev->async_copy) {
if (add_guest_pages(dev, region, alignment) < 0) {
- VHOST_LOG_CONFIG(ERR,
- "adding guest pages to region failed.\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) adding guest pages to region failed.\n",
+ dev->ifname);
return -1;
}
- VHOST_LOG_CONFIG(INFO,
- "guest memory region size: 0x%" PRIx64 "\n"
- "\t guest physical addr: 0x%" PRIx64 "\n"
- "\t guest virtual addr: 0x%" PRIx64 "\n"
- "\t host virtual addr: 0x%" PRIx64 "\n"
- "\t mmap addr : 0x%" PRIx64 "\n"
- "\t mmap size : 0x%" PRIx64 "\n"
- "\t mmap align: 0x%" PRIx64 "\n"
- "\t mmap off : 0x%" PRIx64 "\n",
- region->size,
- region->guest_phys_addr,
- region->guest_user_addr,
- region->host_user_addr,
- (uint64_t)(uintptr_t)mmap_addr,
- mmap_size,
- alignment,
- mmap_offset);
+ if (rte_vfio_is_enabled("vfio")) {
+ ret = async_dma_map(dev, region, true);
+ if (ret) {
+ VHOST_LOG_CONFIG(ERR,
+ "(%s) configure IOMMU for DMA engine failed\n",
+ dev->ifname);
+ return -1;
+ }
+ }
+ }
+
+ VHOST_LOG_CONFIG(INFO, "(%s) guest memory region size: 0x%" PRIx64 "\n",
+ dev->ifname, region->size);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t guest physical addr: 0x%" PRIx64 "\n",
+ dev->ifname, region->guest_phys_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t guest virtual addr: 0x%" PRIx64 "\n",
+ dev->ifname, region->guest_user_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t host virtual addr: 0x%" PRIx64 "\n",
+ dev->ifname, region->host_user_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t mmap addr : 0x%" PRIx64 "\n",
+ dev->ifname, (uint64_t)(uintptr_t)mmap_addr);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t mmap size : 0x%" PRIx64 "\n",
+ dev->ifname, mmap_size);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t mmap align: 0x%" PRIx64 "\n",
+ dev->ifname, alignment);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t mmap off : 0x%" PRIx64 "\n",
+ dev->ifname, mmap_offset);
return 0;
}
static int
-vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_mem_table(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd)
{
struct virtio_net *dev = *pdev;
- struct VhostUserMemory *memory = &msg->payload.memory;
+ struct VhostUserMemory *memory = &ctx->msg.payload.memory;
struct rte_vhost_mem_region *reg;
-
+ int numa_node = SOCKET_ID_ANY;
uint64_t mmap_offset;
uint32_t i;
+ bool async_notify = false;
- if (validate_msg_fds(msg, memory->nregions) != 0)
+ if (validate_msg_fds(dev, ctx, memory->nregions) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (memory->nregions > VHOST_MEMORY_MAX_NREGIONS) {
- VHOST_LOG_CONFIG(ERR,
- "too many memory regions (%u)\n", memory->nregions);
+ VHOST_LOG_CONFIG(ERR, "(%s) too many memory regions (%u)\n",
+ dev->ifname, memory->nregions);
goto close_msg_fds;
}
if (dev->mem && !vhost_memory_changed(memory, dev->mem)) {
- VHOST_LOG_CONFIG(INFO,
- "(%d) memory regions not changed\n", dev->vid);
+ VHOST_LOG_CONFIG(INFO, "(%s) memory regions not changed\n", dev->ifname);
- close_msg_fds(msg);
+ close_msg_fds(ctx);
return RTE_VHOST_MSG_RESULT_OK;
}
vdpa_dev->ops->dev_close(dev->vid);
dev->flags &= ~VIRTIO_DEV_VDPA_CONFIGURED;
}
+
+ /* notify the vhost application to stop DMA transfers */
+ if (dev->async_copy && dev->notify_ops->vring_state_changed) {
+ for (i = 0; i < dev->nr_vring; i++) {
+ dev->notify_ops->vring_state_changed(dev->vid,
+ i, 0);
+ }
+ async_notify = true;
+ }
+
free_mem_region(dev);
rte_free(dev->mem);
dev->mem = NULL;
for (i = 0; i < dev->nr_vring; i++)
vhost_user_iotlb_flush_all(dev->virtqueue[i]);
+ /*
+ * If VQ 0 has already been allocated, try to allocate on the same
+ * NUMA node. It can be reallocated later in numa_realloc().
+ */
+ if (dev->nr_vring > 0)
+ numa_node = dev->virtqueue[0]->numa_node;
+
dev->nr_guest_pages = 0;
if (dev->guest_pages == NULL) {
dev->max_guest_pages = 8;
- dev->guest_pages = rte_zmalloc(NULL,
+ dev->guest_pages = rte_zmalloc_socket(NULL,
dev->max_guest_pages *
sizeof(struct guest_page),
- RTE_CACHE_LINE_SIZE);
+ RTE_CACHE_LINE_SIZE,
+ numa_node);
if (dev->guest_pages == NULL) {
VHOST_LOG_CONFIG(ERR,
- "(%d) failed to allocate memory "
- "for dev->guest_pages\n",
- dev->vid);
+ "(%s) failed to allocate memory for dev->guest_pages\n",
+ dev->ifname);
goto close_msg_fds;
}
}
- dev->mem = rte_zmalloc("vhost-mem-table", sizeof(struct rte_vhost_memory) +
- sizeof(struct rte_vhost_mem_region) * memory->nregions, 0);
+ dev->mem = rte_zmalloc_socket("vhost-mem-table", sizeof(struct rte_vhost_memory) +
+ sizeof(struct rte_vhost_mem_region) * memory->nregions, 0, numa_node);
if (dev->mem == NULL) {
VHOST_LOG_CONFIG(ERR,
- "(%d) failed to allocate memory for dev->mem\n",
- dev->vid);
+ "(%s) failed to allocate memory for dev->mem\n",
+ dev->ifname);
goto free_guest_pages;
}
reg->guest_phys_addr = memory->regions[i].guest_phys_addr;
reg->guest_user_addr = memory->regions[i].userspace_addr;
reg->size = memory->regions[i].memory_size;
- reg->fd = msg->fds[i];
+ reg->fd = ctx->fds[i];
/*
* Assign invalid file descriptor value to avoid double
* closing on error path.
*/
- msg->fds[i] = -1;
+ ctx->fds[i] = -1;
mmap_offset = memory->regions[i].mmap_offset;
if (vhost_user_mmap_region(dev, reg, mmap_offset) < 0) {
- VHOST_LOG_CONFIG(ERR, "Failed to mmap region %u\n", i);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to mmap region %u\n", dev->ifname, i);
goto free_mem_table;
}
dev->mem->nregions++;
}
- if (vhost_user_postcopy_register(dev, main_fd, msg) < 0)
+ if (vhost_user_postcopy_register(dev, main_fd, ctx) < 0)
goto free_mem_table;
for (i = 0; i < dev->nr_vring; i++) {
dump_guest_pages(dev);
+ if (async_notify) {
+ for (i = 0; i < dev->nr_vring; i++)
+ dev->notify_ops->vring_state_changed(dev->vid, i, 1);
+ }
+
return RTE_VHOST_MSG_RESULT_OK;
free_mem_table:
free_mem_region(dev);
rte_free(dev->mem);
dev->mem = NULL;
+
free_guest_pages:
rte_free(dev->guest_pages);
dev->guest_pages = NULL;
close_msg_fds:
- close_msg_fds(msg);
+ close_msg_fds(ctx);
return RTE_VHOST_MSG_RESULT_ERR;
}
dev->flags |= VIRTIO_DEV_READY;
if (!(dev->flags & VIRTIO_DEV_RUNNING))
- VHOST_LOG_CONFIG(INFO,
- "virtio is now ready for processing.\n");
+ VHOST_LOG_CONFIG(INFO, "(%s) virtio is now ready for processing.\n", dev->ifname);
return 1;
}
static void *
-inflight_mem_alloc(const char *name, size_t size, int *fd)
+inflight_mem_alloc(struct virtio_net *dev, const char *name, size_t size, int *fd)
{
void *ptr;
int mfd = -1;
if (mfd == -1) {
mfd = mkstemp(fname);
if (mfd == -1) {
- VHOST_LOG_CONFIG(ERR,
- "failed to get inflight buffer fd\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to get inflight buffer fd\n",
+ dev->ifname);
return NULL;
}
}
if (ftruncate(mfd, size) == -1) {
- VHOST_LOG_CONFIG(ERR,
- "failed to alloc inflight buffer\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to alloc inflight buffer\n", dev->ifname);
close(mfd);
return NULL;
}
ptr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, mfd, 0);
if (ptr == MAP_FAILED) {
- VHOST_LOG_CONFIG(ERR,
- "failed to mmap inflight buffer\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to mmap inflight buffer\n", dev->ifname);
close(mfd);
return NULL;
}
static int
vhost_user_get_inflight_fd(struct virtio_net **pdev,
- VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct rte_vhost_inflight_info_packed *inflight_packed;
uint16_t num_queues, queue_size;
struct virtio_net *dev = *pdev;
int fd, i, j;
+ int numa_node = SOCKET_ID_ANY;
void *addr;
- if (msg->size != sizeof(msg->payload.inflight)) {
- VHOST_LOG_CONFIG(ERR,
- "invalid get_inflight_fd message size is %d\n",
- msg->size);
+ if (ctx->msg.size != sizeof(ctx->msg.payload.inflight)) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid get_inflight_fd message size is %d\n",
+ dev->ifname, ctx->msg.size);
return RTE_VHOST_MSG_RESULT_ERR;
}
+ /*
+ * If VQ 0 has already been allocated, try to allocate on the same
+ * NUMA node. It can be reallocated later in numa_realloc().
+ */
+ if (dev->nr_vring > 0)
+ numa_node = dev->virtqueue[0]->numa_node;
+
if (dev->inflight_info == NULL) {
- dev->inflight_info = calloc(1,
- sizeof(struct inflight_mem_info));
+ dev->inflight_info = rte_zmalloc_socket("inflight_info",
+ sizeof(struct inflight_mem_info), 0, numa_node);
if (!dev->inflight_info) {
- VHOST_LOG_CONFIG(ERR,
- "failed to alloc dev inflight area\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to alloc dev inflight area\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
dev->inflight_info->fd = -1;
}
- num_queues = msg->payload.inflight.num_queues;
- queue_size = msg->payload.inflight.queue_size;
+ num_queues = ctx->msg.payload.inflight.num_queues;
+ queue_size = ctx->msg.payload.inflight.queue_size;
- VHOST_LOG_CONFIG(INFO, "get_inflight_fd num_queues: %u\n",
- msg->payload.inflight.num_queues);
- VHOST_LOG_CONFIG(INFO, "get_inflight_fd queue_size: %u\n",
- msg->payload.inflight.queue_size);
+ VHOST_LOG_CONFIG(INFO, "(%s) get_inflight_fd num_queues: %u\n",
+ dev->ifname, ctx->msg.payload.inflight.num_queues);
+ VHOST_LOG_CONFIG(INFO, "(%s) get_inflight_fd queue_size: %u\n",
+ dev->ifname, ctx->msg.payload.inflight.queue_size);
if (vq_is_packed(dev))
pervq_inflight_size = get_pervq_shm_size_packed(queue_size);
pervq_inflight_size = get_pervq_shm_size_split(queue_size);
mmap_size = num_queues * pervq_inflight_size;
- addr = inflight_mem_alloc("vhost-inflight", mmap_size, &fd);
+ addr = inflight_mem_alloc(dev, "vhost-inflight", mmap_size, &fd);
if (!addr) {
- VHOST_LOG_CONFIG(ERR,
- "failed to alloc vhost inflight area\n");
- msg->payload.inflight.mmap_size = 0;
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to alloc vhost inflight area\n", dev->ifname);
+ ctx->msg.payload.inflight.mmap_size = 0;
return RTE_VHOST_MSG_RESULT_ERR;
}
memset(addr, 0, mmap_size);
}
dev->inflight_info->addr = addr;
- dev->inflight_info->size = msg->payload.inflight.mmap_size = mmap_size;
- dev->inflight_info->fd = msg->fds[0] = fd;
- msg->payload.inflight.mmap_offset = 0;
- msg->fd_num = 1;
+ dev->inflight_info->size = ctx->msg.payload.inflight.mmap_size = mmap_size;
+ dev->inflight_info->fd = ctx->fds[0] = fd;
+ ctx->msg.payload.inflight.mmap_offset = 0;
+ ctx->fd_num = 1;
if (vq_is_packed(dev)) {
for (i = 0; i < num_queues; i++) {
}
}
- VHOST_LOG_CONFIG(INFO,
- "send inflight mmap_size: %"PRIu64"\n",
- msg->payload.inflight.mmap_size);
- VHOST_LOG_CONFIG(INFO,
- "send inflight mmap_offset: %"PRIu64"\n",
- msg->payload.inflight.mmap_offset);
- VHOST_LOG_CONFIG(INFO,
- "send inflight fd: %d\n", msg->fds[0]);
+ VHOST_LOG_CONFIG(INFO, "(%s) send inflight mmap_size: %"PRIu64"\n",
+ dev->ifname, ctx->msg.payload.inflight.mmap_size);
+ VHOST_LOG_CONFIG(INFO, "(%s) send inflight mmap_offset: %"PRIu64"\n",
+ dev->ifname, ctx->msg.payload.inflight.mmap_offset);
+ VHOST_LOG_CONFIG(INFO, "(%s) send inflight fd: %d\n", dev->ifname, ctx->fds[0]);
return RTE_VHOST_MSG_RESULT_REPLY;
}
static int
-vhost_user_set_inflight_fd(struct virtio_net **pdev, VhostUserMsg *msg,
+vhost_user_set_inflight_fd(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
uint64_t mmap_size, mmap_offset;
struct vhost_virtqueue *vq;
void *addr;
int fd, i;
+ int numa_node = SOCKET_ID_ANY;
- fd = msg->fds[0];
- if (msg->size != sizeof(msg->payload.inflight) || fd < 0) {
- VHOST_LOG_CONFIG(ERR,
- "invalid set_inflight_fd message size is %d,fd is %d\n",
- msg->size, fd);
+ fd = ctx->fds[0];
+ if (ctx->msg.size != sizeof(ctx->msg.payload.inflight) || fd < 0) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid set_inflight_fd message size is %d,fd is %d\n",
+ dev->ifname, ctx->msg.size, fd);
return RTE_VHOST_MSG_RESULT_ERR;
}
- mmap_size = msg->payload.inflight.mmap_size;
- mmap_offset = msg->payload.inflight.mmap_offset;
- num_queues = msg->payload.inflight.num_queues;
- queue_size = msg->payload.inflight.queue_size;
+ mmap_size = ctx->msg.payload.inflight.mmap_size;
+ mmap_offset = ctx->msg.payload.inflight.mmap_offset;
+ num_queues = ctx->msg.payload.inflight.num_queues;
+ queue_size = ctx->msg.payload.inflight.queue_size;
if (vq_is_packed(dev))
pervq_inflight_size = get_pervq_shm_size_packed(queue_size);
else
pervq_inflight_size = get_pervq_shm_size_split(queue_size);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd mmap_size: %"PRIu64"\n", mmap_size);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd mmap_offset: %"PRIu64"\n", mmap_offset);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd num_queues: %u\n", num_queues);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd queue_size: %u\n", queue_size);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd fd: %d\n", fd);
- VHOST_LOG_CONFIG(INFO,
- "set_inflight_fd pervq_inflight_size: %d\n",
- pervq_inflight_size);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd mmap_size: %"PRIu64"\n",
+ dev->ifname, mmap_size);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd mmap_offset: %"PRIu64"\n",
+ dev->ifname, mmap_offset);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd num_queues: %u\n", dev->ifname, num_queues);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd queue_size: %u\n", dev->ifname, queue_size);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd fd: %d\n", dev->ifname, fd);
+ VHOST_LOG_CONFIG(INFO, "(%s) set_inflight_fd pervq_inflight_size: %d\n",
+ dev->ifname, pervq_inflight_size);
+
+ /*
+ * If VQ 0 has already been allocated, try to allocate on the same
+ * NUMA node. It can be reallocated later in numa_realloc().
+ */
+ if (dev->nr_vring > 0)
+ numa_node = dev->virtqueue[0]->numa_node;
if (!dev->inflight_info) {
- dev->inflight_info = calloc(1,
- sizeof(struct inflight_mem_info));
+ dev->inflight_info = rte_zmalloc_socket("inflight_info",
+ sizeof(struct inflight_mem_info), 0, numa_node);
if (dev->inflight_info == NULL) {
- VHOST_LOG_CONFIG(ERR,
- "failed to alloc dev inflight area\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to alloc dev inflight area\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
dev->inflight_info->fd = -1;
addr = mmap(0, mmap_size, PROT_READ | PROT_WRITE, MAP_SHARED,
fd, mmap_offset);
if (addr == MAP_FAILED) {
- VHOST_LOG_CONFIG(ERR, "failed to mmap share memory.\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to mmap share memory.\n", dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
static int
-vhost_user_set_vring_call(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_vring_call(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
struct vhost_virtqueue *vq;
int expected_fds;
- expected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
- if (validate_msg_fds(msg, expected_fds) != 0)
+ expected_fds = (ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
+ if (validate_msg_fds(dev, ctx, expected_fds) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- file.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
- if (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
+ file.index = ctx->msg.payload.u64 & VHOST_USER_VRING_IDX_MASK;
+ if (ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)
file.fd = VIRTIO_INVALID_EVENTFD;
else
- file.fd = msg->fds[0];
- VHOST_LOG_CONFIG(INFO,
- "vring call idx:%d file:%d\n", file.index, file.fd);
+ file.fd = ctx->fds[0];
+ VHOST_LOG_CONFIG(INFO, "(%s) vring call idx:%d file:%d\n",
+ dev->ifname, file.index, file.fd);
vq = dev->virtqueue[file.index];
return RTE_VHOST_MSG_RESULT_OK;
}
-static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
- struct VhostUserMsg *msg,
+static int vhost_user_set_vring_err(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
+ struct virtio_net *dev = *pdev;
int expected_fds;
- expected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
- if (validate_msg_fds(msg, expected_fds) != 0)
+ expected_fds = (ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
+ if (validate_msg_fds(dev, ctx, expected_fds) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
- close(msg->fds[0]);
- VHOST_LOG_CONFIG(INFO, "not implemented\n");
+ if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
+ close(ctx->fds[0]);
+ VHOST_LOG_CONFIG(INFO, "(%s) not implemented\n", dev->ifname);
return RTE_VHOST_MSG_RESULT_OK;
}
vq->last_avail_idx += resubmit_num;
if (resubmit_num) {
- resubmit = calloc(1, sizeof(struct rte_vhost_resubmit_info));
+ resubmit = rte_zmalloc_socket("resubmit", sizeof(struct rte_vhost_resubmit_info),
+ 0, vq->numa_node);
if (!resubmit) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for resubmit info.\n");
+ "(%s) failed to allocate memory for resubmit info.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
- resubmit->resubmit_list = calloc(resubmit_num,
- sizeof(struct rte_vhost_resubmit_desc));
+ resubmit->resubmit_list = rte_zmalloc_socket("resubmit_list",
+ resubmit_num * sizeof(struct rte_vhost_resubmit_desc),
+ 0, vq->numa_node);
if (!resubmit->resubmit_list) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for inflight desc.\n");
- free(resubmit);
+ "(%s) failed to allocate memory for inflight desc.\n",
+ dev->ifname);
+ rte_free(resubmit);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
if (resubmit_num) {
- resubmit = calloc(1, sizeof(struct rte_vhost_resubmit_info));
+ resubmit = rte_zmalloc_socket("resubmit", sizeof(struct rte_vhost_resubmit_info),
+ 0, vq->numa_node);
if (resubmit == NULL) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for resubmit info.\n");
+ "(%s) failed to allocate memory for resubmit info.\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
- resubmit->resubmit_list = calloc(resubmit_num,
- sizeof(struct rte_vhost_resubmit_desc));
+ resubmit->resubmit_list = rte_zmalloc_socket("resubmit_list",
+ resubmit_num * sizeof(struct rte_vhost_resubmit_desc),
+ 0, vq->numa_node);
if (resubmit->resubmit_list == NULL) {
VHOST_LOG_CONFIG(ERR,
- "failed to allocate memory for resubmit desc.\n");
- free(resubmit);
+ "(%s) failed to allocate memory for resubmit desc.\n",
+ dev->ifname);
+ rte_free(resubmit);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
static int
-vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_vring_kick(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
struct vhost_virtqueue *vq;
int expected_fds;
- expected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
- if (validate_msg_fds(msg, expected_fds) != 0)
+ expected_fds = (ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;
+ if (validate_msg_fds(dev, ctx, expected_fds) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- file.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
- if (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)
+ file.index = ctx->msg.payload.u64 & VHOST_USER_VRING_IDX_MASK;
+ if (ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)
file.fd = VIRTIO_INVALID_EVENTFD;
else
- file.fd = msg->fds[0];
- VHOST_LOG_CONFIG(INFO,
- "vring kick idx:%d file:%d\n", file.index, file.fd);
+ file.fd = ctx->fds[0];
+ VHOST_LOG_CONFIG(INFO, "(%s) vring kick idx:%d file:%d\n",
+ dev->ifname, file.index, file.fd);
/* Interpret ring addresses only when ring is started. */
dev = translate_ring_addresses(dev, file.index);
if (vq_is_packed(dev)) {
if (vhost_check_queue_inflights_packed(dev, vq)) {
- VHOST_LOG_CONFIG(ERR,
- "failed to inflights for vq: %d\n", file.index);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to inflights for vq: %d\n",
+ dev->ifname, file.index);
return RTE_VHOST_MSG_RESULT_ERR;
}
} else {
if (vhost_check_queue_inflights_split(dev, vq)) {
- VHOST_LOG_CONFIG(ERR,
- "failed to inflights for vq: %d\n", file.index);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to inflights for vq: %d\n",
+ dev->ifname, file.index);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
*/
static int
vhost_user_get_vring_base(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];
+ struct vhost_virtqueue *vq = dev->virtqueue[ctx->msg.payload.state.index];
uint64_t val;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
/* We have to stop the queue (virtio) if it is running. */
*/
val = vq->last_avail_idx & 0x7fff;
val |= vq->avail_wrap_counter << 15;
- msg->payload.state.num = val;
+ ctx->msg.payload.state.num = val;
} else {
- msg->payload.state.num = vq->last_avail_idx;
+ ctx->msg.payload.state.num = vq->last_avail_idx;
}
- VHOST_LOG_CONFIG(INFO,
- "vring base idx:%d file:%d\n", msg->payload.state.index,
- msg->payload.state.num);
+ VHOST_LOG_CONFIG(INFO, "(%s) vring base idx:%d file:%d\n",
+ dev->ifname, ctx->msg.payload.state.index,
+ ctx->msg.payload.state.num);
/*
* Based on current qemu vhost-user implementation, this message is
* sent and only sent in vhost_vring_stop.
rte_free(vq->log_cache);
vq->log_cache = NULL;
- msg->size = sizeof(msg->payload.state);
- msg->fd_num = 0;
+ ctx->msg.size = sizeof(ctx->msg.payload.state);
+ ctx->fd_num = 0;
+
+ vhost_user_iotlb_flush_all(vq);
vring_invalidate(dev, vq);
*/
static int
vhost_user_set_vring_enable(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- bool enable = !!msg->payload.state.num;
- int index = (int)msg->payload.state.index;
+ bool enable = !!ctx->msg.payload.state.num;
+ int index = (int)ctx->msg.payload.state.index;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- VHOST_LOG_CONFIG(INFO,
- "set queue enable: %d to qp idx: %d\n",
- enable, index);
+ VHOST_LOG_CONFIG(INFO, "(%s) set queue enable: %d to qp idx: %d\n",
+ dev->ifname, enable, index);
- if (enable && dev->virtqueue[index]->async_registered) {
- if (dev->virtqueue[index]->async_pkts_inflight_n) {
- VHOST_LOG_CONFIG(ERR, "failed to enable vring. "
- "async inflight packets must be completed first\n");
+ if (enable && dev->virtqueue[index]->async) {
+ if (dev->virtqueue[index]->async->pkts_inflight_n) {
+ VHOST_LOG_CONFIG(ERR,
+ "(%s) failed to enable vring. Inflight packets must be completed first\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
static int
vhost_user_get_protocol_features(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
uint64_t features, protocol_features;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
rte_vhost_driver_get_features(dev->ifname, &features);
rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
- msg->payload.u64 = protocol_features;
- msg->size = sizeof(msg->payload.u64);
- msg->fd_num = 0;
+ ctx->msg.payload.u64 = protocol_features;
+ ctx->msg.size = sizeof(ctx->msg.payload.u64);
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
}
static int
vhost_user_set_protocol_features(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- uint64_t protocol_features = msg->payload.u64;
+ uint64_t protocol_features = ctx->msg.payload.u64;
uint64_t slave_protocol_features = 0;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
rte_vhost_driver_get_protocol_features(dev->ifname,
&slave_protocol_features);
if (protocol_features & ~slave_protocol_features) {
- VHOST_LOG_CONFIG(ERR,
- "(%d) received invalid protocol features.\n",
- dev->vid);
+ VHOST_LOG_CONFIG(ERR, "(%s) received invalid protocol features.\n", dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
dev->protocol_features = protocol_features;
- VHOST_LOG_CONFIG(INFO,
- "negotiated Vhost-user protocol features: 0x%" PRIx64 "\n",
- dev->protocol_features);
+ VHOST_LOG_CONFIG(INFO, "(%s) negotiated Vhost-user protocol features: 0x%" PRIx64 "\n",
+ dev->ifname, dev->protocol_features);
return RTE_VHOST_MSG_RESULT_OK;
}
static int
-vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_log_base(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- int fd = msg->fds[0];
+ int fd = ctx->fds[0];
uint64_t size, off;
void *addr;
uint32_t i;
- if (validate_msg_fds(msg, 1) != 0)
+ if (validate_msg_fds(dev, ctx, 1) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (fd < 0) {
- VHOST_LOG_CONFIG(ERR, "invalid log fd: %d\n", fd);
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid log fd: %d\n", dev->ifname, fd);
return RTE_VHOST_MSG_RESULT_ERR;
}
- if (msg->size != sizeof(VhostUserLog)) {
- VHOST_LOG_CONFIG(ERR,
- "invalid log base msg size: %"PRId32" != %d\n",
- msg->size, (int)sizeof(VhostUserLog));
+ if (ctx->msg.size != sizeof(VhostUserLog)) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid log base msg size: %"PRId32" != %d\n",
+ dev->ifname, ctx->msg.size, (int)sizeof(VhostUserLog));
goto close_msg_fds;
}
- size = msg->payload.log.mmap_size;
- off = msg->payload.log.mmap_offset;
+ size = ctx->msg.payload.log.mmap_size;
+ off = ctx->msg.payload.log.mmap_offset;
/* Check for mmap size and offset overflow. */
if (off >= -size) {
VHOST_LOG_CONFIG(ERR,
- "log offset %#"PRIx64" and log size %#"PRIx64" overflow\n",
- off, size);
+ "(%s) log offset %#"PRIx64" and log size %#"PRIx64" overflow\n",
+ dev->ifname, off, size);
goto close_msg_fds;
}
- VHOST_LOG_CONFIG(INFO,
- "log mmap size: %"PRId64", offset: %"PRId64"\n",
- size, off);
+ VHOST_LOG_CONFIG(INFO, "(%s) log mmap size: %"PRId64", offset: %"PRId64"\n",
+ dev->ifname, size, off);
/*
* mmap from 0 to workaround a hugepage mmap bug: mmap will
addr = mmap(0, size + off, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
close(fd);
if (addr == MAP_FAILED) {
- VHOST_LOG_CONFIG(ERR, "mmap log base failed!\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) mmap log base failed!\n", dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
rte_free(vq->log_cache);
vq->log_cache = NULL;
vq->log_cache_nb_elem = 0;
- vq->log_cache = rte_zmalloc("vq log cache",
+ vq->log_cache = rte_malloc_socket("vq log cache",
sizeof(struct log_cache_entry) * VHOST_LOG_CACHE_NR,
- 0);
+ 0, vq->numa_node);
/*
* If log cache alloc fail, don't fail migration, but no
* caching will be done, which will impact performance
*/
if (!vq->log_cache)
- VHOST_LOG_CONFIG(ERR, "Failed to allocate VQ logging cache\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to allocate VQ logging cache\n",
+ dev->ifname);
}
/*
* The spec is not clear about it (yet), but QEMU doesn't expect
* any payload in the reply.
*/
- msg->size = 0;
- msg->fd_num = 0;
+ ctx->msg.size = 0;
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
close_msg_fds:
- close_msg_fds(msg);
+ close_msg_fds(ctx);
return RTE_VHOST_MSG_RESULT_ERR;
}
-static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
- struct VhostUserMsg *msg,
+static int vhost_user_set_log_fd(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
- if (validate_msg_fds(msg, 1) != 0)
+ struct virtio_net *dev = *pdev;
+
+ if (validate_msg_fds(dev, ctx, 1) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- close(msg->fds[0]);
- VHOST_LOG_CONFIG(INFO, "not implemented.\n");
+ close(ctx->fds[0]);
+ VHOST_LOG_CONFIG(INFO, "(%s) not implemented.\n", dev->ifname);
return RTE_VHOST_MSG_RESULT_OK;
}
* a flag 'broadcast_rarp' to let rte_vhost_dequeue_burst() inject it.
*/
static int
-vhost_user_send_rarp(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_send_rarp(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- uint8_t *mac = (uint8_t *)&msg->payload.u64;
+ uint8_t *mac = (uint8_t *)&ctx->msg.payload.u64;
struct rte_vdpa_device *vdpa_dev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- VHOST_LOG_CONFIG(DEBUG,
- ":: mac: %02x:%02x:%02x:%02x:%02x:%02x\n",
- mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) MAC: " RTE_ETHER_ADDR_PRT_FMT "\n",
+ dev->ifname, mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]);
memcpy(dev->mac.addr_bytes, mac, 6);
/*
}
static int
-vhost_user_net_set_mtu(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_net_set_mtu(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- if (msg->payload.u64 < VIRTIO_MIN_MTU ||
- msg->payload.u64 > VIRTIO_MAX_MTU) {
- VHOST_LOG_CONFIG(ERR, "Invalid MTU size (%"PRIu64")\n",
- msg->payload.u64);
+ if (ctx->msg.payload.u64 < VIRTIO_MIN_MTU ||
+ ctx->msg.payload.u64 > VIRTIO_MAX_MTU) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid MTU size (%"PRIu64")\n",
+ dev->ifname, ctx->msg.payload.u64);
return RTE_VHOST_MSG_RESULT_ERR;
}
- dev->mtu = msg->payload.u64;
+ dev->mtu = ctx->msg.payload.u64;
return RTE_VHOST_MSG_RESULT_OK;
}
static int
-vhost_user_set_req_fd(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_req_fd(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- int fd = msg->fds[0];
+ int fd = ctx->fds[0];
- if (validate_msg_fds(msg, 1) != 0)
+ if (validate_msg_fds(dev, ctx, 1) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (fd < 0) {
- VHOST_LOG_CONFIG(ERR,
- "Invalid file descriptor for slave channel (%d)\n",
- fd);
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid file descriptor for slave channel (%d)\n",
+ dev->ifname, fd);
return RTE_VHOST_MSG_RESULT_ERR;
}
}
static int
-vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_iotlb_msg(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- struct vhost_iotlb_msg *imsg = &msg->payload.iotlb;
+ struct vhost_iotlb_msg *imsg = &ctx->msg.payload.iotlb;
uint16_t i;
uint64_t vva, len;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
switch (imsg->type) {
if (!vq)
continue;
- vhost_user_iotlb_cache_insert(vq, imsg->iova, vva,
+ vhost_user_iotlb_cache_insert(dev, vq, imsg->iova, vva,
len, imsg->perm);
if (is_vring_iotlb(dev, vq, imsg))
}
break;
default:
- VHOST_LOG_CONFIG(ERR, "Invalid IOTLB message type (%d)\n",
- imsg->type);
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid IOTLB message type (%d)\n",
+ dev->ifname, imsg->type);
return RTE_VHOST_MSG_RESULT_ERR;
}
static int
vhost_user_set_postcopy_advise(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
#ifdef RTE_LIBRTE_VHOST_POSTCOPY
struct uffdio_api api_struct;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
dev->postcopy_ufd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
if (dev->postcopy_ufd == -1) {
- VHOST_LOG_CONFIG(ERR, "Userfaultfd not available: %s\n",
- strerror(errno));
+ VHOST_LOG_CONFIG(ERR, "(%s) userfaultfd not available: %s\n",
+ dev->ifname, strerror(errno));
return RTE_VHOST_MSG_RESULT_ERR;
}
api_struct.api = UFFD_API;
api_struct.features = 0;
if (ioctl(dev->postcopy_ufd, UFFDIO_API, &api_struct)) {
- VHOST_LOG_CONFIG(ERR, "UFFDIO_API ioctl failure: %s\n",
- strerror(errno));
+ VHOST_LOG_CONFIG(ERR, "(%s) UFFDIO_API ioctl failure: %s\n",
+ dev->ifname, strerror(errno));
close(dev->postcopy_ufd);
dev->postcopy_ufd = -1;
return RTE_VHOST_MSG_RESULT_ERR;
}
- msg->fds[0] = dev->postcopy_ufd;
- msg->fd_num = 1;
+ ctx->fds[0] = dev->postcopy_ufd;
+ ctx->fd_num = 1;
return RTE_VHOST_MSG_RESULT_REPLY;
#else
dev->postcopy_ufd = -1;
- msg->fd_num = 0;
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_ERR;
#endif
static int
vhost_user_set_postcopy_listen(struct virtio_net **pdev,
- struct VhostUserMsg *msg __rte_unused,
+ struct vhu_msg_context *ctx __rte_unused,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
if (dev->mem && dev->mem->nregions) {
- VHOST_LOG_CONFIG(ERR,
- "Regions already registered at postcopy-listen\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) regions already registered at postcopy-listen\n",
+ dev->ifname);
return RTE_VHOST_MSG_RESULT_ERR;
}
dev->postcopy_listening = 1;
}
static int
-vhost_user_postcopy_end(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_postcopy_end(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
dev->postcopy_listening = 0;
dev->postcopy_ufd = -1;
}
- msg->payload.u64 = 0;
- msg->size = sizeof(msg->payload.u64);
- msg->fd_num = 0;
+ ctx->msg.payload.u64 = 0;
+ ctx->msg.size = sizeof(ctx->msg.payload.u64);
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
}
static int
-vhost_user_get_status(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_get_status(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
- msg->payload.u64 = dev->status;
- msg->size = sizeof(msg->payload.u64);
- msg->fd_num = 0;
+ ctx->msg.payload.u64 = dev->status;
+ ctx->msg.size = sizeof(ctx->msg.payload.u64);
+ ctx->fd_num = 0;
return RTE_VHOST_MSG_RESULT_REPLY;
}
static int
-vhost_user_set_status(struct virtio_net **pdev, struct VhostUserMsg *msg,
+vhost_user_set_status(struct virtio_net **pdev,
+ struct vhu_msg_context *ctx,
int main_fd __rte_unused)
{
struct virtio_net *dev = *pdev;
- if (validate_msg_fds(msg, 0) != 0)
+ if (validate_msg_fds(dev, ctx, 0) != 0)
return RTE_VHOST_MSG_RESULT_ERR;
/* As per Virtio specification, the device status is 8bits long */
- if (msg->payload.u64 > UINT8_MAX) {
- VHOST_LOG_CONFIG(ERR, "Invalid VHOST_USER_SET_STATUS payload 0x%" PRIx64 "\n",
- msg->payload.u64);
+ if (ctx->msg.payload.u64 > UINT8_MAX) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid VHOST_USER_SET_STATUS payload 0x%" PRIx64 "\n",
+ dev->ifname, ctx->msg.payload.u64);
return RTE_VHOST_MSG_RESULT_ERR;
}
- dev->status = msg->payload.u64;
+ dev->status = ctx->msg.payload.u64;
if ((dev->status & VIRTIO_DEVICE_STATUS_FEATURES_OK) &&
(dev->flags & VIRTIO_DEV_FEATURES_FAILED)) {
- VHOST_LOG_CONFIG(ERR, "FEATURES_OK bit is set but feature negotiation failed\n");
+ VHOST_LOG_CONFIG(ERR,
+ "(%s) FEATURES_OK bit is set but feature negotiation failed\n",
+ dev->ifname);
/*
* Clear the bit to let the driver know about the feature
* negotiation failure
dev->status &= ~VIRTIO_DEVICE_STATUS_FEATURES_OK;
}
- VHOST_LOG_CONFIG(INFO, "New device status(0x%08x):\n"
- "\t-RESET: %u\n"
- "\t-ACKNOWLEDGE: %u\n"
- "\t-DRIVER: %u\n"
- "\t-FEATURES_OK: %u\n"
- "\t-DRIVER_OK: %u\n"
- "\t-DEVICE_NEED_RESET: %u\n"
- "\t-FAILED: %u\n",
- dev->status,
- (dev->status == VIRTIO_DEVICE_STATUS_RESET),
- !!(dev->status & VIRTIO_DEVICE_STATUS_ACK),
- !!(dev->status & VIRTIO_DEVICE_STATUS_DRIVER),
- !!(dev->status & VIRTIO_DEVICE_STATUS_FEATURES_OK),
- !!(dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK),
- !!(dev->status & VIRTIO_DEVICE_STATUS_DEV_NEED_RESET),
+ VHOST_LOG_CONFIG(INFO, "(%s) new device status(0x%08x):\n", dev->ifname,
+ dev->status);
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-RESET: %u\n", dev->ifname,
+ (dev->status == VIRTIO_DEVICE_STATUS_RESET));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-ACKNOWLEDGE: %u\n", dev->ifname,
+ !!(dev->status & VIRTIO_DEVICE_STATUS_ACK));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-DRIVER: %u\n", dev->ifname,
+ !!(dev->status & VIRTIO_DEVICE_STATUS_DRIVER));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-FEATURES_OK: %u\n", dev->ifname,
+ !!(dev->status & VIRTIO_DEVICE_STATUS_FEATURES_OK));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-DRIVER_OK: %u\n", dev->ifname,
+ !!(dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-DEVICE_NEED_RESET: %u\n", dev->ifname,
+ !!(dev->status & VIRTIO_DEVICE_STATUS_DEV_NEED_RESET));
+ VHOST_LOG_CONFIG(INFO, "(%s)\t-FAILED: %u\n", dev->ifname,
!!(dev->status & VIRTIO_DEVICE_STATUS_FAILED));
return RTE_VHOST_MSG_RESULT_OK;
}
typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,
- struct VhostUserMsg *msg,
+ struct vhu_msg_context *ctx,
int main_fd);
+
static vhost_message_handler_t vhost_message_handlers[VHOST_USER_MAX] = {
[VHOST_USER_NONE] = NULL,
[VHOST_USER_GET_FEATURES] = vhost_user_get_features,
/* return bytes# of read on success or negative val on failure. */
static int
-read_vhost_message(int sockfd, struct VhostUserMsg *msg)
+read_vhost_message(struct virtio_net *dev, int sockfd, struct vhu_msg_context *ctx)
{
int ret;
- ret = read_fd_message(sockfd, (char *)msg, VHOST_USER_HDR_SIZE,
- msg->fds, VHOST_MEMORY_MAX_NREGIONS, &msg->fd_num);
+ ret = read_fd_message(dev->ifname, sockfd, (char *)&ctx->msg, VHOST_USER_HDR_SIZE,
+ ctx->fds, VHOST_MEMORY_MAX_NREGIONS, &ctx->fd_num);
if (ret <= 0) {
return ret;
} else if (ret != VHOST_USER_HDR_SIZE) {
- VHOST_LOG_CONFIG(ERR, "Unexpected header size read\n");
- close_msg_fds(msg);
+ VHOST_LOG_CONFIG(ERR, "(%s) Unexpected header size read\n", dev->ifname);
+ close_msg_fds(ctx);
return -1;
}
- if (msg->size) {
- if (msg->size > sizeof(msg->payload)) {
- VHOST_LOG_CONFIG(ERR,
- "invalid msg size: %d\n", msg->size);
+ if (ctx->msg.size) {
+ if (ctx->msg.size > sizeof(ctx->msg.payload)) {
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid msg size: %d\n",
+ dev->ifname, ctx->msg.size);
return -1;
}
- ret = read(sockfd, &msg->payload, msg->size);
+ ret = read(sockfd, &ctx->msg.payload, ctx->msg.size);
if (ret <= 0)
return ret;
- if (ret != (int)msg->size) {
- VHOST_LOG_CONFIG(ERR,
- "read control message failed\n");
+ if (ret != (int)ctx->msg.size) {
+ VHOST_LOG_CONFIG(ERR, "(%s) read control message failed\n", dev->ifname);
return -1;
}
}
}
static int
-send_vhost_message(int sockfd, struct VhostUserMsg *msg)
+send_vhost_message(struct virtio_net *dev, int sockfd, struct vhu_msg_context *ctx)
{
- if (!msg)
+ if (!ctx)
return 0;
- return send_fd_message(sockfd, (char *)msg,
- VHOST_USER_HDR_SIZE + msg->size, msg->fds, msg->fd_num);
+ return send_fd_message(dev->ifname, sockfd, (char *)&ctx->msg,
+ VHOST_USER_HDR_SIZE + ctx->msg.size, ctx->fds, ctx->fd_num);
}
static int
-send_vhost_reply(int sockfd, struct VhostUserMsg *msg)
+send_vhost_reply(struct virtio_net *dev, int sockfd, struct vhu_msg_context *ctx)
{
- if (!msg)
+ if (!ctx)
return 0;
- msg->flags &= ~VHOST_USER_VERSION_MASK;
- msg->flags &= ~VHOST_USER_NEED_REPLY;
- msg->flags |= VHOST_USER_VERSION;
- msg->flags |= VHOST_USER_REPLY_MASK;
+ ctx->msg.flags &= ~VHOST_USER_VERSION_MASK;
+ ctx->msg.flags &= ~VHOST_USER_NEED_REPLY;
+ ctx->msg.flags |= VHOST_USER_VERSION;
+ ctx->msg.flags |= VHOST_USER_REPLY_MASK;
- return send_vhost_message(sockfd, msg);
+ return send_vhost_message(dev, sockfd, ctx);
}
static int
-send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg)
+send_vhost_slave_message(struct virtio_net *dev,
+ struct vhu_msg_context *ctx)
{
int ret;
- if (msg->flags & VHOST_USER_NEED_REPLY)
+ if (ctx->msg.flags & VHOST_USER_NEED_REPLY)
rte_spinlock_lock(&dev->slave_req_lock);
- ret = send_vhost_message(dev->slave_req_fd, msg);
- if (ret < 0 && (msg->flags & VHOST_USER_NEED_REPLY))
+ ret = send_vhost_message(dev, dev->slave_req_fd, ctx);
+ if (ret < 0 && (ctx->msg.flags & VHOST_USER_NEED_REPLY))
rte_spinlock_unlock(&dev->slave_req_lock);
return ret;
*/
static int
vhost_user_check_and_alloc_queue_pair(struct virtio_net *dev,
- struct VhostUserMsg *msg)
+ struct vhu_msg_context *ctx)
{
uint32_t vring_idx;
- switch (msg->request.master) {
+ switch (ctx->msg.request.master) {
case VHOST_USER_SET_VRING_KICK:
case VHOST_USER_SET_VRING_CALL:
case VHOST_USER_SET_VRING_ERR:
- vring_idx = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;
+ vring_idx = ctx->msg.payload.u64 & VHOST_USER_VRING_IDX_MASK;
break;
case VHOST_USER_SET_VRING_NUM:
case VHOST_USER_SET_VRING_BASE:
+ case VHOST_USER_GET_VRING_BASE:
case VHOST_USER_SET_VRING_ENABLE:
- vring_idx = msg->payload.state.index;
+ vring_idx = ctx->msg.payload.state.index;
break;
case VHOST_USER_SET_VRING_ADDR:
- vring_idx = msg->payload.addr.index;
+ vring_idx = ctx->msg.payload.addr.index;
break;
default:
return 0;
}
if (vring_idx >= VHOST_MAX_VRING) {
- VHOST_LOG_CONFIG(ERR,
- "invalid vring index: %u\n", vring_idx);
+ VHOST_LOG_CONFIG(ERR, "(%s) invalid vring index: %u\n", dev->ifname, vring_idx);
return -1;
}
vhost_user_msg_handler(int vid, int fd)
{
struct virtio_net *dev;
- struct VhostUserMsg msg;
+ struct vhu_msg_context ctx;
struct rte_vdpa_device *vdpa_dev;
int ret;
int unlock_required = 0;
if (!dev->notify_ops) {
dev->notify_ops = vhost_driver_callback_get(dev->ifname);
if (!dev->notify_ops) {
- VHOST_LOG_CONFIG(ERR,
- "failed to get callback ops for driver %s\n",
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to get callback ops for driver\n",
dev->ifname);
return -1;
}
}
- ret = read_vhost_message(fd, &msg);
+ ret = read_vhost_message(dev, fd, &ctx);
if (ret <= 0) {
if (ret < 0)
- VHOST_LOG_CONFIG(ERR,
- "vhost read message failed\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) vhost read message failed\n", dev->ifname);
else
- VHOST_LOG_CONFIG(INFO,
- "vhost peer closed\n");
+ VHOST_LOG_CONFIG(INFO, "(%s) vhost peer closed\n", dev->ifname);
return -1;
}
ret = 0;
- request = msg.request.master;
+ request = ctx.msg.request.master;
if (request > VHOST_USER_NONE && request < VHOST_USER_MAX &&
vhost_message_str[request]) {
if (request != VHOST_USER_IOTLB_MSG)
- VHOST_LOG_CONFIG(INFO, "read message %s\n",
- vhost_message_str[request]);
+ VHOST_LOG_CONFIG(INFO, "(%s) read message %s\n",
+ dev->ifname, vhost_message_str[request]);
else
- VHOST_LOG_CONFIG(DEBUG, "read message %s\n",
- vhost_message_str[request]);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) read message %s\n",
+ dev->ifname, vhost_message_str[request]);
} else {
- VHOST_LOG_CONFIG(DEBUG, "External request %d\n", request);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) external request %d\n", dev->ifname, request);
}
- ret = vhost_user_check_and_alloc_queue_pair(dev, &msg);
+ ret = vhost_user_check_and_alloc_queue_pair(dev, &ctx);
if (ret < 0) {
- VHOST_LOG_CONFIG(ERR,
- "failed to alloc queue\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to alloc queue\n", dev->ifname);
return -1;
}
handled = false;
if (dev->extern_ops.pre_msg_handle) {
ret = (*dev->extern_ops.pre_msg_handle)(dev->vid,
- (void *)&msg);
+ (void *)&ctx.msg);
switch (ret) {
case RTE_VHOST_MSG_RESULT_REPLY:
- send_vhost_reply(fd, &msg);
+ send_vhost_reply(dev, fd, &ctx);
/* Fall-through */
case RTE_VHOST_MSG_RESULT_ERR:
case RTE_VHOST_MSG_RESULT_OK:
if (request > VHOST_USER_NONE && request < VHOST_USER_MAX) {
if (!vhost_message_handlers[request])
goto skip_to_post_handle;
- ret = vhost_message_handlers[request](&dev, &msg, fd);
+ ret = vhost_message_handlers[request](&dev, &ctx, fd);
switch (ret) {
case RTE_VHOST_MSG_RESULT_ERR:
- VHOST_LOG_CONFIG(ERR,
- "Processing %s failed.\n",
- vhost_message_str[request]);
+ VHOST_LOG_CONFIG(ERR, "(%s) processing %s failed.\n",
+ dev->ifname, vhost_message_str[request]);
handled = true;
break;
case RTE_VHOST_MSG_RESULT_OK:
- VHOST_LOG_CONFIG(DEBUG,
- "Processing %s succeeded.\n",
- vhost_message_str[request]);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) processing %s succeeded.\n",
+ dev->ifname, vhost_message_str[request]);
handled = true;
break;
case RTE_VHOST_MSG_RESULT_REPLY:
- VHOST_LOG_CONFIG(DEBUG,
- "Processing %s succeeded and needs reply.\n",
- vhost_message_str[request]);
- send_vhost_reply(fd, &msg);
+ VHOST_LOG_CONFIG(DEBUG, "(%s) processing %s succeeded and needs reply.\n",
+ dev->ifname, vhost_message_str[request]);
+ send_vhost_reply(dev, fd, &ctx);
handled = true;
break;
default:
if (ret != RTE_VHOST_MSG_RESULT_ERR &&
dev->extern_ops.post_msg_handle) {
ret = (*dev->extern_ops.post_msg_handle)(dev->vid,
- (void *)&msg);
+ (void *)&ctx.msg);
switch (ret) {
case RTE_VHOST_MSG_RESULT_REPLY:
- send_vhost_reply(fd, &msg);
+ send_vhost_reply(dev, fd, &ctx);
/* Fall-through */
case RTE_VHOST_MSG_RESULT_ERR:
case RTE_VHOST_MSG_RESULT_OK:
}
}
- if (unlock_required)
- vhost_user_unlock_all_queue_pairs(dev);
-
/* If message was not handled at this stage, treat it as an error */
if (!handled) {
- VHOST_LOG_CONFIG(ERR,
- "vhost message (req: %d) was not handled.\n", request);
- close_msg_fds(&msg);
+ VHOST_LOG_CONFIG(ERR, "(%s) vhost message (req: %d) was not handled.\n",
+ dev->ifname, request);
+ close_msg_fds(&ctx);
ret = RTE_VHOST_MSG_RESULT_ERR;
}
* this optional reply-ack won't be sent as the
* VHOST_USER_NEED_REPLY was cleared in send_vhost_reply().
*/
- if (msg.flags & VHOST_USER_NEED_REPLY) {
- msg.payload.u64 = ret == RTE_VHOST_MSG_RESULT_ERR;
- msg.size = sizeof(msg.payload.u64);
- msg.fd_num = 0;
- send_vhost_reply(fd, &msg);
+ if (ctx.msg.flags & VHOST_USER_NEED_REPLY) {
+ ctx.msg.payload.u64 = ret == RTE_VHOST_MSG_RESULT_ERR;
+ ctx.msg.size = sizeof(ctx.msg.payload.u64);
+ ctx.fd_num = 0;
+ send_vhost_reply(dev, fd, &ctx);
} else if (ret == RTE_VHOST_MSG_RESULT_ERR) {
- VHOST_LOG_CONFIG(ERR,
- "vhost message handling failed.\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) vhost message handling failed.\n", dev->ifname);
return -1;
}
}
}
+ if (unlock_required)
+ vhost_user_unlock_all_queue_pairs(dev);
if (!virtio_is_ready(dev))
goto out;
if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {
if (vdpa_dev->ops->dev_conf(dev->vid))
- VHOST_LOG_CONFIG(ERR,
- "Failed to configure vDPA device\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to configure vDPA device\n",
+ dev->ifname);
else
dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;
}
}
static int process_slave_message_reply(struct virtio_net *dev,
- const struct VhostUserMsg *msg)
+ const struct vhu_msg_context *ctx)
{
- struct VhostUserMsg msg_reply;
+ struct vhu_msg_context msg_reply;
int ret;
- if ((msg->flags & VHOST_USER_NEED_REPLY) == 0)
+ if ((ctx->msg.flags & VHOST_USER_NEED_REPLY) == 0)
return 0;
- ret = read_vhost_message(dev->slave_req_fd, &msg_reply);
+ ret = read_vhost_message(dev, dev->slave_req_fd, &msg_reply);
if (ret <= 0) {
if (ret < 0)
- VHOST_LOG_CONFIG(ERR,
- "vhost read slave message reply failed\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) vhost read slave message reply failed\n",
+ dev->ifname);
else
- VHOST_LOG_CONFIG(INFO,
- "vhost peer closed\n");
+ VHOST_LOG_CONFIG(INFO, "(%s) vhost peer closed\n", dev->ifname);
ret = -1;
goto out;
}
ret = 0;
- if (msg_reply.request.slave != msg->request.slave) {
- VHOST_LOG_CONFIG(ERR,
- "Received unexpected msg type (%u), expected %u\n",
- msg_reply.request.slave, msg->request.slave);
+ if (msg_reply.msg.request.slave != ctx->msg.request.slave) {
+ VHOST_LOG_CONFIG(ERR, "(%s) received unexpected msg type (%u), expected %u\n",
+ dev->ifname, msg_reply.msg.request.slave, ctx->msg.request.slave);
ret = -1;
goto out;
}
- ret = msg_reply.payload.u64 ? -1 : 0;
+ ret = msg_reply.msg.payload.u64 ? -1 : 0;
out:
rte_spinlock_unlock(&dev->slave_req_lock);
vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)
{
int ret;
- struct VhostUserMsg msg = {
- .request.slave = VHOST_USER_SLAVE_IOTLB_MSG,
- .flags = VHOST_USER_VERSION,
- .size = sizeof(msg.payload.iotlb),
- .payload.iotlb = {
- .iova = iova,
- .perm = perm,
- .type = VHOST_IOTLB_MISS,
+ struct vhu_msg_context ctx = {
+ .msg = {
+ .request.slave = VHOST_USER_SLAVE_IOTLB_MSG,
+ .flags = VHOST_USER_VERSION,
+ .size = sizeof(ctx.msg.payload.iotlb),
+ .payload.iotlb = {
+ .iova = iova,
+ .perm = perm,
+ .type = VHOST_IOTLB_MISS,
+ },
},
};
- ret = send_vhost_message(dev->slave_req_fd, &msg);
+ ret = send_vhost_message(dev, dev->slave_req_fd, &ctx);
if (ret < 0) {
- VHOST_LOG_CONFIG(ERR,
- "Failed to send IOTLB miss message (%d)\n",
- ret);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to send IOTLB miss message (%d)\n",
+ dev->ifname, ret);
return ret;
}
vhost_user_slave_config_change(struct virtio_net *dev, bool need_reply)
{
int ret;
- struct VhostUserMsg msg = {
- .request.slave = VHOST_USER_SLAVE_CONFIG_CHANGE_MSG,
- .flags = VHOST_USER_VERSION,
- .size = 0,
+ struct vhu_msg_context ctx = {
+ .msg = {
+ .request.slave = VHOST_USER_SLAVE_CONFIG_CHANGE_MSG,
+ .flags = VHOST_USER_VERSION,
+ .size = 0,
+ }
};
if (need_reply)
- msg.flags |= VHOST_USER_NEED_REPLY;
+ ctx.msg.flags |= VHOST_USER_NEED_REPLY;
- ret = send_vhost_slave_message(dev, &msg);
+ ret = send_vhost_slave_message(dev, &ctx);
if (ret < 0) {
- VHOST_LOG_CONFIG(ERR,
- "Failed to send config change (%d)\n",
- ret);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to send config change (%d)\n",
+ dev->ifname, ret);
return ret;
}
- return process_slave_message_reply(dev, &msg);
+ return process_slave_message_reply(dev, &ctx);
}
int
uint64_t size)
{
int ret;
- struct VhostUserMsg msg = {
- .request.slave = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG,
- .flags = VHOST_USER_VERSION | VHOST_USER_NEED_REPLY,
- .size = sizeof(msg.payload.area),
- .payload.area = {
- .u64 = index & VHOST_USER_VRING_IDX_MASK,
- .size = size,
- .offset = offset,
+ struct vhu_msg_context ctx = {
+ .msg = {
+ .request.slave = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG,
+ .flags = VHOST_USER_VERSION | VHOST_USER_NEED_REPLY,
+ .size = sizeof(ctx.msg.payload.area),
+ .payload.area = {
+ .u64 = index & VHOST_USER_VRING_IDX_MASK,
+ .size = size,
+ .offset = offset,
+ },
},
};
if (fd < 0)
- msg.payload.area.u64 |= VHOST_USER_VRING_NOFD_MASK;
+ ctx.msg.payload.area.u64 |= VHOST_USER_VRING_NOFD_MASK;
else {
- msg.fds[0] = fd;
- msg.fd_num = 1;
+ ctx.fds[0] = fd;
+ ctx.fd_num = 1;
}
- ret = send_vhost_slave_message(dev, &msg);
+ ret = send_vhost_slave_message(dev, &ctx);
if (ret < 0) {
- VHOST_LOG_CONFIG(ERR,
- "Failed to set host notifier (%d)\n", ret);
+ VHOST_LOG_CONFIG(ERR, "(%s) failed to set host notifier (%d)\n",
+ dev->ifname, ret);
return ret;
}
- return process_slave_message_reply(dev, &msg);
+ return process_slave_message_reply(dev, &ctx);
}
int rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable)
git.droids-corp.org / dpdk.git / blobdiff