vhost: add note about sockets in server mode
authorIlya Maximets <i.maximets@samsung.com>
Mon, 26 Feb 2018 08:39:00 +0000 (09:39 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 30 Mar 2018 12:08:43 +0000 (14:08 +0200)
commit1cf62d96850b54a96d20ac173229814292fedb9f
tree58c049a8abee7ff93f9cbd75e300c6eeb50d6254
parente14dca8dc1121efbff29e0928d5de703f924c3f0
vhost: add note about sockets in server mode

From time to time, someone sends patches about unlinking existing
sockets when registering a vhost user in server mode.

A recent example:
http://dpdk.org/ml/archives/dev/2018-February/090025.html

This problem has been discussed many times, and it was made clear that
the library should not unlink files given by the application in order
to avoid possible security problems, such as removing random files
used by other programs.

One of the first discussions:
http://dpdk.org/ml/archives/dev/2015-December/030326.html

To avoid such patches in the future, it was decided to add a comment
that explains what is happening and tries to describe the reasoning.

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
lib/librte_vhost/socket.c