git.droids-corp.org / dpdk.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b69259c) | patch
net/sfc/base: fix shift by more bits than field width
authorMark Spender <mspender@solarflare.com>
Mon, 10 Jun 2019 07:38:18 +0000 (08:38 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 20 Jun 2019 21:42:04 +0000 (23:42 +0200)
commit1dcd3a98954075f3218d9bf1d00eaad250f92833
tree4186bca8bd1a58b2556247b960e532127279ec96tree | snapshot
parentb69259cd152055bc5ace20929a3719183941f695commit | diff
net/sfc/base: fix shift by more bits than field width

This was probably an oversight when support for multiple sensor pages
was added.

Despite being undefined behaviour in C, it probably worked on Intel
x32/x64 as on them bit shift operations wrap round.

Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI")
Cc: stable@dpdk.org
Signed-off-by: Mark Spender <mspender@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
drivers/net/sfc/base/mcdi_mon.c diff | blob | history
DPDK repo used for reviews