]> git.droids-corp.org - dpdk.git/commit
net/bnxt: fix firmware version query
authorStephen Hemminger <stephen@networkplumber.org>
Tue, 2 Nov 2021 21:27:44 +0000 (14:27 -0700)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Wed, 3 Nov 2021 04:12:29 +0000 (05:12 +0100)
commit211262d925268a3f5ac1c6a5a6610762b5ca5f5a
tree10a2d0ee7660eaf69f4556984eb2ab8d712767f4
parent69fbb4e9b5bae73edc91271279a30bdfaa4ca08d
net/bnxt: fix firmware version query

UBSan testing revealed undefined shift here.

The firmware returns the version in bytes; and shifting a 8 bit
quantity here can lead to undefined behaviour or truncation.
The fix is to promote the bytes to 32 bit before shifting.

Bugzilla ID: 838
Fixes: 9a891c1764ea ("net/bnxt: update HWRM to version 1.9.2")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
drivers/net/bnxt/bnxt_hwrm.c