cmdline: make implementation logically opaque
authorDmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Mon, 28 Sep 2020 21:50:46 +0000 (00:50 +0300)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 14 Oct 2020 22:39:10 +0000 (00:39 +0200)
commit51fcb6a1fe1c92176ea19f20ccadaad9a5e0fcb4
tree97416378fb5d7959fea608dab4cb04744a27daec
parentf4cbdbc7fbd2cf352d50f5ce7018a63dc5392b1b
cmdline: make implementation logically opaque

struct cmdline exposes platform-specific members it contains, most
notably struct termios that is only available on Unix. While ABI
considerations prevent from hinding the definition on already supported
platforms, struct cmdline is considered logically opaque from now on.
Add a deprecation notice targeted at 20.11.

* Remove tests checking struct cmdline content as meaningless.

* Fix missing cmdline_free() in unit test.

* Add cmdline_get_rdline() to access history buffer indirectly.
  The new function is currently used only in tests.

Suggested-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
app/test-cmdline/commands.c
app/test/test_cmdline_lib.c
doc/guides/rel_notes/deprecation.rst
lib/librte_cmdline/cmdline.c
lib/librte_cmdline/cmdline.h
lib/librte_cmdline/cmdline_parse.c
lib/librte_cmdline/cmdline_socket.c
lib/librte_cmdline/rte_cmdline_version.map