examples/fips_validation: fix null dereferences
authorChaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
Wed, 25 Sep 2019 06:31:34 +0000 (07:31 +0100)
committerAkhil Goyal <akhil.goyal@nxp.com>
Wed, 9 Oct 2019 09:50:12 +0000 (11:50 +0200)
commit75b3dddf95ea0d5a1356115f748e1cc43de67886
tree77cc6eee582c36af3964dc1836464f61efc11825
parente671f2041f5c13e6fecda7dbe421ae0940a8088b
examples/fips_validation: fix null dereferences

One issue caught by Coverity 343408
*deref_parm: Directly dereferencing parameter val->val.

In writeback_tdes_hex_str(), tmp_val is initialised to null.
tmp_val.val is updated only if keys are found.
If keys are not found,it doesn't fails but continues
to invoke writeback_hex_str(),where val->val is accessed
without null check.

The fix is to return the error,
if keys are not found in writeback_tdes_hex_str().

Coverity issue: 343408
Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing")
Cc: stable@dpdk.org
Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
examples/fips_validation/fips_validation_tdes.c