kni: fix build with gcc 8.1
authorFerruh Yigit <ferruh.yigit@intel.com>
Tue, 26 Jun 2018 11:38:07 +0000 (12:38 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 27 Jun 2018 13:13:17 +0000 (15:13 +0200)
commita36b40dd8ecfb61648045e418551f75055ca77f9
tree7d1530f601c71c5bfe6c6bb81554c56137440f84
parent80ec1b21d9bcfd34baa86e4fab70c79fcc8b7f05
kni: fix build with gcc 8.1

Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
enabled.

build error:
In function ‘strncpy’,
    inlined from ‘igb_get_drvinfo’ at
    kernel/linux/kni/igb_ethtool.c:814:2:
    include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output
    may be truncated copying 31 bytes from a string of length 42
    [-Werror=stringop-truncation]
      return __builtin_strncpy(p, q, size);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixed by using strlcpy instead of strncpy.

adapter->fw_version size kept same because of
c3698192940c ("kni: fix build with gcc 7.1")

Also next line strncpy usage replaced with strlcpy while arround.

Fixes: c3698192940c ("kni: fix build with gcc 7.1")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
kernel/linux/kni/ethtool/igb/igb_ethtool.c