cmdline: fix overflow on bsd
authorAlan Carew <alan.carew@intel.com>
Fri, 5 Dec 2014 14:19:07 +0000 (15:19 +0100)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Fri, 5 Dec 2014 15:54:53 +0000 (16:54 +0100)
commitaaa662e75c23c61a1d79bd4d1f9f35b4967c39db
treebb3195d876d3dc798b4576ec26aadf9f225389de
parent29d03f7aa33edc3292bf75730ec684dd4cbe5054
cmdline: fix overflow on bsd

When using test-pmd with flow director in FreeBSD, the application will
segfault/Bus error while parsing the command-line. This is due to how
each commands result structure is represented during parsing, where the offsets
for each tokens value is stored in a character array(char result_buf[BUFSIZ])
in cmdline_parse()(./lib/librte_cmdline/cmdline_parse.c).

The overflow occurs where BUFSIZ is less than the size of a commands result
structure, in this case "struct cmd_pkt_filter_result"
(app/test-pmd/cmdline.c) is 1088 bytes and BUFSIZ on FreeBSD is 1024 bytes as
opposed to 8192 bytes on Linux.

The problem can be reproduced by running test-pmd on FreeBSD:
./testpmd -c 0x3 -n 4 -- -i --portmask=0x3 --pkt-filter-mode=perfect
And adding a filter:
add_perfect_filter 0 udp src 192.168.0.0 1024 dst 192.168.0.0 1024 flexbytes
0x800 vlan 0 queue 0 soft 0x17

This patch removes the OS dependency on BUFSIZ and defines and uses a
library #define CMDLINE_PARSE_RESULT_BUFSIZE 8192

Added boundary checking to ensure this buffer size cannot overflow, with
an error message being produced.

Suggested-by: Olivier Matz <olivier.matz@6wind.com>
http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=b1d5b169352e57df3fc14c51ffad4b83f3e5613f

Signed-off-by: Alan Carew <alan.carew@intel.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
22 files changed:
app/test-pmd/parameters.c
app/test/test_cmdline_etheraddr.c
app/test/test_cmdline_ipaddr.c
app/test/test_cmdline_num.c
app/test/test_cmdline_portlist.c
app/test/test_cmdline_string.c
examples/cmdline/parse_obj_list.c
examples/cmdline/parse_obj_list.h
examples/vhost_xen/xenstore_parse.c
lib/librte_cmdline/cmdline_parse.c
lib/librte_cmdline/cmdline_parse.h
lib/librte_cmdline/cmdline_parse_etheraddr.c
lib/librte_cmdline/cmdline_parse_etheraddr.h
lib/librte_cmdline/cmdline_parse_ipaddr.c
lib/librte_cmdline/cmdline_parse_ipaddr.h
lib/librte_cmdline/cmdline_parse_num.c
lib/librte_cmdline/cmdline_parse_num.h
lib/librte_cmdline/cmdline_parse_portlist.c
lib/librte_cmdline/cmdline_parse_portlist.h
lib/librte_cmdline/cmdline_parse_string.c
lib/librte_cmdline/cmdline_parse_string.h
lib/librte_pmd_bond/rte_eth_bond_args.c