]> git.droids-corp.org - dpdk.git/commit
trace: fix init with long file prefix
authorChengwen Feng <fengchengwen@huawei.com>
Fri, 17 Jun 2022 02:29:11 +0000 (10:29 +0800)
committerDavid Marchand <david.marchand@redhat.com>
Tue, 21 Jun 2022 09:11:00 +0000 (11:11 +0200)
commitd59a940667989461e2916207e7fbb8148504c44f
tree90bad4aa07d84e5ad41d22bcc90f2abb84cd2c59
parenta8f23b444dc3ff32ff27ceeba267fe996c0fbabd
trace: fix init with long file prefix

Bug scenario:
1. start testpmd:
  $ dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* \
    --file-prefix=trace_autotest -- -i
2. then observed:
  EAL: eal_trace_init():93 failed to initialize trace [File exists]
  EAL: FATAL: Cannot init trace
  EAL: Cannot init trace
  EAL: Error - exiting with code: 1

The root cause it that the offset set wrong with long file-prefix and
then lead the strftime return failed.

At the same time, trace_session_name_generate() uses errno as the return
value, but the errno was not set if strftime returned zero.
A previously set errno (EEXIST or ENOENT from call to mkdir for creating
the runtime configuration directory) was returned in this case.
This is fragile and may lead to incorrect logic if errno was set
to 0 previously.
This also resulted in inaccurate prompting.
Set errno to ENOSPC if strftime return zero.

Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
lib/eal/common/eal_common_trace_utils.c