summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
0215a4c)
As far as I know, there is no reason why we should have a limit on the length of
parameters that can be given for a device.
Remove this limit by using dynamic allocations.
Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
{
struct rte_devargs *devargs = NULL;
rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
{
struct rte_devargs *devargs = NULL;
- char buf[RTE_DEVARGS_LEN];
- ret = snprintf(buf, sizeof(buf), "%s", devargs_str);
- if (ret < 0 || ret >= (int)sizeof(buf)) {
- RTE_LOG(ERR, EAL, "user device args too large: <%s>\n",
- devargs_str);
- goto fail;
- }
-
/* use malloc instead of rte_malloc as it's called early at init */
devargs = malloc(sizeof(*devargs));
if (devargs == NULL) {
/* use malloc instead of rte_malloc as it's called early at init */
devargs = malloc(sizeof(*devargs));
if (devargs == NULL) {
memset(devargs, 0, sizeof(*devargs));
devargs->type = devtype;
memset(devargs, 0, sizeof(*devargs));
devargs->type = devtype;
+ buf = strdup(devargs_str);
+ if (buf == NULL) {
+ RTE_LOG(ERR, EAL, "cannot allocate temp memory for devargs\n");
+ goto fail;
+ }
+
/* set the first ',' to '\0' to split name and arguments */
sep = strchr(buf, ',');
if (sep != NULL) {
sep[0] = '\0';
/* set the first ',' to '\0' to split name and arguments */
sep = strchr(buf, ',');
if (sep != NULL) {
sep[0] = '\0';
- snprintf(devargs->args, sizeof(devargs->args), "%s", sep + 1);
+ devargs->args = strdup(sep + 1);
+ if (devargs->args == NULL) {
+ RTE_LOG(ERR, EAL, "cannot allocate for devargs args\n");
+ goto fail;
+ }
}
switch (devargs->type) {
}
switch (devargs->type) {
TAILQ_INSERT_TAIL(&devargs_list, devargs, next);
return 0;
fail:
TAILQ_INSERT_TAIL(&devargs_list, devargs, next);
return 0;
fail:
+ if (devargs->args)
+ free(devargs->args);
+ if (buf)
+ free(buf);
if (devargs)
free(devargs);
return -1;
if (devargs)
free(devargs);
return -1;
char drv_name[32];
} virtual;
};
char drv_name[32];
} virtual;
};
-#define RTE_DEVARGS_LEN 256
- char args[RTE_DEVARGS_LEN]; /**< Arguments string as given by user. */
+ /** Arguments string as given by user. */
+ char *args;
};
/** user device double-linked queue type definition */
};
/** user device double-linked queue type definition */