net/mrvl: do not enable port after setting MAC address
authorTomasz Duszynski <tdu@semihalf.com>
Tue, 5 Dec 2017 09:39:18 +0000 (10:39 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 16 Jan 2018 17:47:49 +0000 (18:47 +0100)
Setting enabled port's mac address caused it to stop receiving
packets. Now as that issue is fixed in library reenabling port
is no longer necessary.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
drivers/net/mrvl/mrvl_ethdev.c

index 47f12b8..c44a2bc 100644 (file)
@@ -822,15 +822,14 @@ static void
 mrvl_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
 {
        struct mrvl_priv *priv = dev->data->dev_private;
+       int ret;
 
-       pp2_ppio_set_mac_addr(priv->ppio, mac_addr->addr_bytes);
-       /*
-        * TODO
-        * Port stops sending packets if pp2_ppio_set_mac_addr()
-        * was called after pp2_ppio_enable(). As a quick fix issue
-        * enable port once again.
-        */
-       pp2_ppio_enable(priv->ppio);
+       ret = pp2_ppio_set_mac_addr(priv->ppio, mac_addr->addr_bytes);
+       if (ret) {
+               char buf[ETHER_ADDR_FMT_SIZE];
+               ether_format_addr(buf, sizeof(buf), mac_addr);
+               RTE_LOG(ERR, PMD, "Failed to set mac to %s\n", buf);
+       }
 }
 
 /**