eal: fix IPC memory leak on device hotplug
authorDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Mon, 29 Oct 2018 11:47:18 +0000 (12:47 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 31 Oct 2018 18:16:42 +0000 (19:16 +0100)
rte_mp_request_sync() says that the caller is responsible
for freeing one of its parameters afterwards. EAL didn't
do that, causing a memory leak.

Fixes: 244d5130719c ("eal: enable hotplug on multi-process")

Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/hotplug_mp.c

index 84f59d9..b68e4ca 100644 (file)
@@ -355,6 +355,7 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
        resp = (struct eal_dev_mp_req *)mp_reply.msgs[0].param;
        req->result = resp->result;
 
+       free(mp_reply.msgs);
        return ret;
 }
 
@@ -379,6 +380,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
 
        if (mp_reply.nb_sent != mp_reply.nb_received) {
                RTE_LOG(ERR, EAL, "not all secondary reply\n");
+               free(mp_reply.msgs);
                return -1;
        }
 
@@ -397,6 +399,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
                }
        }
 
+       free(mp_reply.msgs);
        return 0;
 }