]> git.droids-corp.org - dpdk.git/commitdiff
net/sfc: avoid Tx queue setup failure if thresholds are set
authorAndrew Rybchenko <arybchenko@solarflare.com>
Tue, 14 Nov 2017 11:32:35 +0000 (11:32 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 14 Nov 2017 17:57:22 +0000 (18:57 +0100)
Tx queue prefetch, host and writeback thresholds are used for
performance fine-tuning and not applicable to Solarflare NICs.
It is safe to just log warning and do not fail Tx queue setup
to be more friendly to DPDK applications which hardcode it.

Fixes: b1b7ad933b39 ("net/sfc: set up and release Tx queues")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
drivers/net/sfc/sfc_tx.c

index 127d59e60d657c2f5e888d3b83edaec1ed43e0d6..d1320f462dda918cdb2b18580c117083c4f57c13 100644 (file)
@@ -79,9 +79,8 @@ sfc_tx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_tx_desc,
        if (tx_conf->tx_thresh.pthresh != 0 ||
            tx_conf->tx_thresh.hthresh != 0 ||
            tx_conf->tx_thresh.wthresh != 0) {
-               sfc_err(sa,
+               sfc_warn(sa,
                        "prefetch/host/writeback thresholds are not supported");
-               rc = EINVAL;
        }
 
        if (((flags & ETH_TXQ_FLAGS_NOMULTSEGS) == 0) &&