port: fix crash for ethdev writer nodrop
authorJasvinder Singh <jasvinder.singh@intel.com>
Wed, 2 Mar 2016 21:19:29 +0000 (21:19 +0000)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Mon, 7 Mar 2016 10:52:14 +0000 (11:52 +0100)
Error log:
 [APP] Initializing PIPELINE0 ...
 pipeline> [APP] Initializing PIPELINE1 ...
 [PIPELINE1] Pass-through
 Segmentation fault (core dumped)

Fixes: 304c8091e90a ("port: add ethdev writer nodrop")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
lib/librte_port/rte_port_ethdev.c

index 1f0c81c..1c34602 100644 (file)
@@ -390,16 +390,20 @@ send_burst_nodrop(struct rte_port_ethdev_writer_nodrop *p)
                        p->tx_buf_count);
 
        /* We sent all the packets in a first try */
-       if (nb_tx >= p->tx_buf_count)
+       if (nb_tx >= p->tx_buf_count) {
+               p->tx_buf_count = 0;
                return;
+       }
 
        for (i = 0; i < p->n_retries; i++) {
                nb_tx += rte_eth_tx_burst(p->port_id, p->queue_id,
                                                         p->tx_buf + nb_tx, p->tx_buf_count - nb_tx);
 
                /* We sent all the packets in more than one try */
-               if (nb_tx >= p->tx_buf_count)
+               if (nb_tx >= p->tx_buf_count) {
+                       p->tx_buf_count = 0;
                        return;
+               }
        }
 
        /* We didn't send the packets in maximum allowed attempts */