]> git.droids-corp.org - dpdk.git/commitdiff
net/ixgbe: fix FSP check for X550EM devices
authorStephen Douthit <stephend@silicom-usa.com>
Mon, 28 Feb 2022 15:29:35 +0000 (10:29 -0500)
committerQi Zhang <qi.z.zhang@intel.com>
Tue, 1 Mar 2022 19:19:57 +0000 (20:19 +0100)
Currently all X500EM* MAC types fall through to the default case and get
reported as non-SFP regardless of media type, which isn't correct.

Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device")
Cc: stable@dpdk.org
Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
drivers/net/ixgbe/ixgbe_ethdev.c

index 7643842560d33c0a1e9e535b9a54ffca6d5f9c12..2da3f67bbc786263cb7c6a184b04ba646320a5cc 100644 (file)
@@ -781,6 +781,20 @@ ixgbe_is_sfp(struct ixgbe_hw *hw)
        case ixgbe_phy_sfp_passive_unknown:
                return 1;
        default:
+               /* x550em devices may be SFP, check media type */
+               switch (hw->mac.type) {
+               case ixgbe_mac_X550EM_x:
+               case ixgbe_mac_X550EM_a:
+                       switch (ixgbe_get_media_type(hw)) {
+                       case ixgbe_media_type_fiber:
+                       case ixgbe_media_type_fiber_qsfp:
+                               return 1;
+                       default:
+                               break;
+                       }
+               default:
+                       break;
+               }
                return 0;
        }
 }